pyglaze 0.4.1__tar.gz → 0.4.5__tar.gz

{pyglaze-0.4.1/src/pyglaze.egg-info → pyglaze-0.4.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pyglaze
-Version: 0.4.1
+Version: 0.4.5
 Summary: Pyglaze is a library used to operate the devices of Glaze Technologies
 Author: GLAZE Technologies ApS
 License: BSD 3-Clause License

{pyglaze-0.4.1 → pyglaze-0.4.5}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pyglaze"
-version = "0.4.1"
+version = "0.4.5"
 description = "Pyglaze is a library used to operate the devices of Glaze Technologies"
 readme = "README.md"
 license = { file = "LICENSE" }
@@ -74,7 +74,7 @@ convention = "google"
 ]
 
 [tool.bumpver]
-current_version = "0.4.1"
+current_version = "0.4.5"
 version_pattern = "MAJOR.MINOR.PATCH[-TAG]"
 commit_message = "BUMP VERSION {old_version} -> {new_version}"
 tag_message = "v{new_version}"

pyglaze-0.4.5/src/pyglaze/__init__.py

@@ -0,0 +1 @@
+__version__ = "0.4.5"

{pyglaze-0.4.1 → pyglaze-0.4.5}/src/pyglaze/datamodels/pulse.py

@@ -174,7 +174,7 @@ class Pulse:
         """
         extrema = [scan._get_min_or_max_idx(wrt_max=wrt_max) for scan in scans]  # noqa: SLF001
         n_before = min(extrema)
-        n_after = min(len(scan) - index - 1 for scan, index in zip(scans, extrema))
+        n_after = min(len(scan) - index for scan, index in zip(scans, extrema))
         roughly_aligned = [
             cls._from_slice(scan, slice(index - n_before, index + n_after))
             for index, scan in zip(extrema, scans)

{pyglaze-0.4.1 → pyglaze-0.4.5}/src/pyglaze/device/ampcom.py

@@ -15,6 +15,8 @@ from bitstring import BitArray
 from serial import serialutil
 
 from pyglaze.device.configuration import (
+    BYTES_PER_CHANNEL,
+    N_CHANNELS,
     DeviceConfiguration,
     Interval,
     LeDeviceConfiguration,
@@ -78,7 +80,7 @@ class _LeAmpCom:
 
         We expect to receive 3 arrays of floats (delays, X and Y), each with self.scanning_points elements.
         """
-        return self.scanning_points * 12
+        return self.scanning_points * N_CHANNELS * BYTES_PER_CHANNEL
 
     @property
     def serial_number_bytes(self: _LeAmpCom) -> int:
@@ -150,9 +152,11 @@ class _LeAmpCom:
         angle = np.arctan2(np.array(Ys), np.array(Xs))
         return r, np.rad2deg(angle)
 
-    def _encode_send_response(self: _LeAmpCom, command: str) -> str:
+    def _encode_send_response(
+        self: _LeAmpCom, command: str, *, check_ack: bool = True
+    ) -> str:
         self._encode_and_send(command)
-        return self._get_response(command)
+        return self._get_response(command, check_ack=check_ack)
 
     def _encode_and_send(self: _LeAmpCom, command: str) -> None:
         self.__ser.write(command.encode(self.ENCODING))
@@ -180,13 +184,13 @@ class _LeAmpCom:
     @_BackoffRetry(
         backoff_base=1e-2, max_tries=3, logger=logging.getLogger(LOGGER_NAME)
     )
-    def _get_response(self: _LeAmpCom, command: str) -> str:
+    def _get_response(self: _LeAmpCom, command: str, *, check_ack: bool = True) -> str:
         response = self.__ser.read_until().decode(self.ENCODING).strip()
 
         if len(response) == 0:
             msg = f"Command: '{command}'. Empty response received"
             raise serialutil.SerialException(msg)
-        if response[: len(self.OK_RESPONSE)] != self.OK_RESPONSE:
+        if check_ack and response[: len(self.OK_RESPONSE)] != self.OK_RESPONSE:
             msg = f"Command: '{command}'. Expected response '{self.OK_RESPONSE}', received: '{response}'"
             raise DeviceComError(msg)
         return response
@@ -220,13 +224,14 @@ class _LeAmpCom:
         ]
 
     def _get_status(self: _LeAmpCom) -> _LeStatus:
-        msg = self._encode_send_response(self.STATUS_COMMAND)
-        if msg == _LeStatus.SCANNING.value:
+        response = self._encode_send_response(self.STATUS_COMMAND, check_ack=False)
+
+        if response == _LeStatus.SCANNING.value:
             return _LeStatus.SCANNING
-        if msg == _LeStatus.IDLE.value:
+        if response == _LeStatus.IDLE.value:
             return _LeStatus.IDLE
-        msg = f"Unknown status: {msg}"
-        raise ValueError(msg)
+        msg = f"Unknown status: {response}"
+        raise DeviceComError(msg)
 
 
 class _LeStatus(Enum):
@@ -238,8 +243,8 @@ def _serial_factory(config: DeviceConfiguration) -> serial.Serial | LeMockDevice
     if "mock_device" in config.amp_port:
         return _mock_device_factory(config)
 
-    return serial.Serial(
-        port=config.amp_port,
+    return serial.serial_for_url(
+        url=config.amp_port,
         baudrate=config.amp_baudrate,
         timeout=config.amp_timeout_seconds,
     )

{pyglaze-0.4.1 → pyglaze-0.4.5}/src/pyglaze/device/configuration.py

@@ -11,6 +11,14 @@ if TYPE_CHECKING:
 T = TypeVar("T", bound="DeviceConfiguration")
 
 
+# Serial protocol constants for timeout calculation
+SERIAL_BITS_PER_BYTE = 10  # 8 data bits + start + stop bits
+N_CHANNELS = 3  # delays, X, Y arrays transmitted
+BYTES_PER_CHANNEL = 4  # 32-bit float = 4 bytes
+TIMEOUT_SAFETY_FACTOR = 2.5  # Safety multiplier for network/processing delays
+TIMEOUT_BASELINE_S = 0.05  # Fixed additive latency
+
+
 @dataclass
 class Interval:
     """An interval with a lower and upper bounds between 0 and 1 to scan."""
@@ -50,9 +58,10 @@ class Interval:
 class DeviceConfiguration(ABC):
     """Base class for device configurations."""
 
-    amp_timeout_seconds: float
+    amp_timeout_seconds: float | None
     amp_port: str
     amp_baudrate: ClassVar[int]
+    n_points: int
 
     @property
     @abstractmethod
@@ -92,11 +101,22 @@ class LeDeviceConfiguration(DeviceConfiguration):
     n_points: int = 1000
     scan_intervals: list[Interval] = field(default_factory=lambda: [Interval(0.0, 1.0)])
     integration_periods: int = 10
-    amp_timeout_seconds: float = 0.2
+    amp_timeout_seconds: float | None = None
     modulation_frequency: int = 10000  # Hz
 
     amp_baudrate: ClassVar[int] = 1000000  # bit/s
 
+    def __post_init__(self: LeDeviceConfiguration) -> None:
+        """Calculate dynamic timeout if not explicitly set."""
+        if self.amp_timeout_seconds is None:
+            # Calculate timeout based on data transfer requirements
+            bytes_to_receive = self.n_points * N_CHANNELS * BYTES_PER_CHANNEL
+            bits_to_transfer = bytes_to_receive * SERIAL_BITS_PER_BYTE
+            transfer_time = bits_to_transfer / self.amp_baudrate
+            self.amp_timeout_seconds = (
+                transfer_time + TIMEOUT_BASELINE_S
+            ) * TIMEOUT_SAFETY_FACTOR
+
     @property
     def _sweep_length_ms(self: LeDeviceConfiguration) -> float:
         return self.n_points * self._time_constant_ms

{pyglaze-0.4.1 → pyglaze-0.4.5}/src/pyglaze/devtools/mock_device.py

@@ -154,6 +154,8 @@ class LeMockDevice(MockDevice):
             self._scan_start_time = time.time()
         elif msg == "R":
             self._scan_has_finished()
+        elif msg == "H":
+            self.state = _LeMockState.RECEIVED_STATUS_REQUEST
         elif msg == "s":
             self.state = _LeMockState.RECEIVED_SERIAL_NUMBER_REQUEST
         elif msg == "v":

{pyglaze-0.4.1 → pyglaze-0.4.5/src/pyglaze.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pyglaze
-Version: 0.4.1
+Version: 0.4.5
 Summary: Pyglaze is a library used to operate the devices of Glaze Technologies
 Author: GLAZE Technologies ApS
 License: BSD 3-Clause License

pyglaze-0.4.1/src/pyglaze/__init__.py

@@ -1 +0,0 @@
-__version__ = "0.4.1"