pyghmi 1.5.59__tar.gz → 1.5.61__tar.gz

{pyghmi-1.5.59 → pyghmi-1.5.61}/ChangeLog

@@ -1,6 +1,20 @@
 CHANGES
 =======
 
+1.5.61
+------
+
+* Follow state of validate job when updating firmware
+* Handle FRU with blank mac area
+* Stage alternate power meter support
+
+1.5.60
+------
+
+* Avoid doing extra AddNewVolWithNaAsync calls
+* Update storage code to handle 2023 XCC FW
+* Fix for newer SMMv2 firmware
+
 1.5.59
 ------
 

{pyghmi-1.5.59 → pyghmi-1.5.61}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 1.1
 Name: pyghmi
-Version: 1.5.59
+Version: 1.5.61
 Summary: Python General Hardware Management Initiative (IPMI and others)
 Home-page: http://github.com/openstack/pyghmi/
 Author: Jarrod Johnson

{pyghmi-1.5.59 → pyghmi-1.5.61}/pyghmi/ipmi/oem/lenovo/energy.py

@@ -31,7 +31,9 @@ class EnergyManager(object):
         try:
             rsp = ipmicmd.xraw_command(netfn=0x3a, command=0x32, data=[4, 2, 0, 0, 0])
             if len(rsp['data']) >= 8:
-                self.supportedmeters = ('DC Energy',)
+                self.supportedmeters = ('DC Energy',)  # 'GPU Power',
+                                        # 'Node Power', 'Total Power')
+                self._mypowermeters = ('node power', 'total power', 'gpu power', 'riser 1 power', 'riser 2 power')
                 self._usefapm = True
                 return
         except pygexc.IpmiException:
@@ -57,6 +59,23 @@ class EnergyManager(object):
         else:
             self.supportedmeters = ('DC Energy',)
 
+    def supports(self, name):
+        if name.lower() in self._mypowermeters:
+            return True
+        return False
+
+    def get_sensor(self, name, ipmicmd):
+        if name.lower() not in self._mypowermeters:
+            raise pygexc.UnsupportedFunctionality('Unrecogcized sensor')
+        rsp = ipmicmd.xraw_command(netfn=0x3a, command=0x32, data=[4, 8, 0, 0, 0])
+        npow, gpupow, r1pow, r2pow = struct.unpack('<HHHH', rsp['data'][6:10])
+        if name.lower().startswith('node'):
+            return npow, 'W'
+        elif name.lower().startswith('gpu'):
+            return gpupow, 'W'
+        elif name.lower().startswith('total'):
+            return npow + gpupow, 'W'
+
     def get_fapm_energy(self, ipmicmd):
         rsp = ipmicmd.xraw_command(netfn=0x3a, command=0x32, data=[4, 2, 0, 0, 0])
         j, mj = struct.unpack('<IH', rsp['data'][2:8])

{pyghmi-1.5.59 → pyghmi-1.5.61}/pyghmi/ipmi/oem/lenovo/handler.py

@@ -718,27 +718,28 @@ class OEMHandler(generic.OEMHandler):
                 fru['FRU Number'] = bextra[0]
                 fru['Revision'] = bextra[4]
                 macs = bextra[6]
-                macprefix = None
-                idx = 0
-                endidx = len(macs) - 5
-                macprefix = None
-                while idx < endidx:
-                    currmac = macs[idx:idx + 6]
-                    if not isinstance(currmac, bytearray):
-                        # invalid vpd format, abort attempts to extract
-                        # mac in this way
-                        break
-                    if currmac == b'\x00\x00\x00\x00\x00\x00':
-                        break
-                    # VPD may veer off, detect and break off
-                    if macprefix is None:
-                        macprefix = currmac[:3]
-                    elif currmac[:3] != macprefix:
-                        break
-                    ms = mac_format.format(*currmac)
-                    ifidx = idx / 6 + 1
-                    fru['MAC Address {0}'.format(ifidx)] = ms
-                    idx = idx + 6
+                if macs:
+                    macprefix = None
+                    idx = 0
+                    endidx = len(macs) - 5
+                    macprefix = None
+                    while idx < endidx:
+                        currmac = macs[idx:idx + 6]
+                        if not isinstance(currmac, bytearray):
+                            # invalid vpd format, abort attempts to extract
+                            # mac in this way
+                            break
+                        if currmac == b'\x00\x00\x00\x00\x00\x00':
+                            break
+                        # VPD may veer off, detect and break off
+                        if macprefix is None:
+                            macprefix = currmac[:3]
+                        elif currmac[:3] != macprefix:
+                            break
+                        ms = mac_format.format(*currmac)
+                        ifidx = idx / 6 + 1
+                        fru['MAC Address {0}'.format(ifidx)] = ms
+                        idx = idx + 6
             except (AttributeError, KeyError, IndexError):
                 pass
             if self.has_xcc and name and name.startswith('PSU '):
@@ -1202,7 +1203,7 @@ class OEMHandler(generic.OEMHandler):
         if self.has_xcc:
             return self.immhandler.get_bmc_configuration()
         if self.is_fpc:
-            return self.smmhandler.get_bmc_configuration()
+            return self.smmhandler.get_bmc_configuration(self._fpc_variant)
         if self.has_tsma:
             return self.tsmahandler.get_bmc_configuration()
         return super(OEMHandler, self).get_bmc_configuration()

{pyghmi-1.5.59 → pyghmi-1.5.61}/pyghmi/ipmi/oem/lenovo/imm.py

@@ -684,8 +684,13 @@ class IMMClient(object):
             return ()
 
     def get_oem_sensor_descriptions(self, ipmicmd):
-        return [{'name': x, 'type': 'Energy'
-                 } for x in self.get_oem_sensor_names(ipmicmd)]
+        desc = []
+        for x in self.get_oem_sensor_names(ipmicmd):
+            desc.append({
+                'name': x,
+                'type': 'Power' if 'Power' in x else 'Energy'
+            })
+        return desc
 
     def get_oem_sensor_reading(self, name, ipmicmd):
         if self._energymanager is None:
@@ -694,8 +699,15 @@ class IMMClient(object):
             kwh = self._energymanager.get_ac_energy(ipmicmd)
         elif name == 'DC Energy':
             kwh = self._energymanager.get_dc_energy(ipmicmd)
+        elif self._energymanager.supports(name):
+            value, units = self._energymanager.get_sensor(name, ipmicmd)
+            return sdr.SensorReading({
+                'name': name, 'imprecision': None,
+                'value': value,
+                'states': [], 'state_ids': [], 'health': pygconst.Health.Ok,
+                'type': 'Power'}, units)
         else:
-            raise pygexc.UnsupportedFunctionality('No sunch sensor ' + name)
+            raise pygexc.UnsupportedFunctionality('No such sensor ' + name)
         return sdr.SensorReading({'name': name, 'imprecision': None,
                                   'value': kwh, 'states': [],
                                   'state_ids': [],
@@ -1489,12 +1501,23 @@ class XCCClient(IMMClient):
     def _create_array(self, pool):
         params = self._parse_array_spec(pool)
         cid = params['controller'].split(',')[0]
+        cslotno = params['controller'].split(',')[1]
         url = '/api/function/raid_conf?params=raidlink_GetDefaultVolProp'
         args = (url, cid, 0, params['drives'])
         props = self.wc.grab_json_response(','.join([str(x) for x in args]))
+        usesctrlslot = False
         if not props:  # newer firmware requires raidlevel too
             args = (url, cid, params['raidlevel'], 0, params['drives'])
             props = self.wc.grab_json_response(','.join([str(x) for x in args]))
+        elif 'return' in props and props['return'] == 22:
+            # Jan 2023 XCC FW - without controller slot number
+            args = (url, cid, params['raidlevel'], 0, params['drives'])
+            props = self.wc.grab_json_response(','.join([str(x) for x in args]))
+            if 'return' in props and props['return'] == 22:
+                usesctrlslot = True
+                # Jan 2023 XCC FW - with controller slot number
+                args = (url, cid, params['raidlevel'], 0, params['drives'], cslotno)
+                props = self.wc.grab_json_response(','.join([str(x) for x in args]))
         props = props['items'][0]
         volumes = pool.volumes
         remainingcap = params['capacity']
@@ -1565,14 +1588,14 @@ class XCCClient(IMMClient):
         parms = {'raidlink_AddNewVolWithNaAsync': arglist}
         rsp = self.wc.grab_json_response(url, parms)
         if rsp['return'] == 14:  # newer firmware
-            if 'supported_cpwb' in props: # Whitley
+            if 'supported_cpwb' in props and not usesctrlslot: # no ctrl_type
                 arglist = '{0},{1},{2},{3},{4},{5},{6},'.format(
                     cnum, params['raidlevel'], params['spans'],
                     params['perspan'], 0, params['drives'], params['hotspares'])
                 arglist += ''.join(vols)
                 parms = {'raidlink_AddNewVolWithNaAsync': arglist}
                 rsp = self.wc.grab_json_response(url, parms)
-            else: # Purley
+            else: # with ctrl_type
                 if cid[2] == 2:
                     cnum = cid[1]
                 arglist = '{0},{1},{2},{3},{4},{5},'.format(
@@ -1615,32 +1638,6 @@ class XCCClient(IMMClient):
         #             oemsensornames = oemsensornames + (name,)
         # return oemsensornames
 
-    def get_oem_sensor_descriptions(self, ipmicmd):
-        oemdesc = [{'name': x, 'type': 'Energy'} for x in super(
-            XCCClient, self).get_oem_sensor_names(ipmicmd)]
-        return oemdesc
-        # therminfo = self.grab_cacheable_json(
-        #     '/api/dataset/pwrmgmt?params=GetThermalRealTimeData', 1)
-        # if therminfo:
-        #     for name in sorted(therminfo['items'][0]):
-        #         if 'DIMM' in name and 'Temp' in name:
-        #             oemdesc.append({'name': name, 'type': 'Temperature'})
-        # return oemdesc
-
-    def get_oem_sensor_reading(self, name, ipmicmd):
-        if 'Energy' in name:
-            return super(XCCClient, self).get_oem_sensor_reading(name, ipmicmd)
-        therminfo = self.grab_cacheable_json(
-            '/api/dataset/pwrmgmt?params=GetThermalRealTimeData', 1)
-        temp = therminfo.get('items', [{}])[0].get(name, None)
-        if temp is None:
-            raise pygexc.UnsupportedFunctionality('No sunch sensor ' + name)
-        return sdr.SensorReading({'name': name, 'imprecision': None,
-                                  'value': temp, 'states': [],
-                                  'state_ids': [],
-                                  'health': pygconst.Health.Ok,
-                                  'type': 'Temperature'}, '°C')
-
     def get_storage_configuration(self, logout=True):
         rsp = self.wc.grab_json_response(
             '/api/function/raid_alldevices?params=storage_GetAllDevices,0')
@@ -2021,8 +2018,10 @@ class XCCClient(IMMClient):
                     raise Exception(uploadthread.rsp)
                 raise Exception(errmsg)
             rsp = json.loads(uploadthread.rsp)
-            monitorurl = rsp['TaskMonitor']
+            monitorurl = rsp['@odata.id']
             complete = False
+            phase = "apply"
+            statetype = 'TaskState'
             while not complete:
                 pgress, status = self.grab_redfish_response_with_status(
                     monitorurl)
@@ -2033,14 +2032,21 @@ class XCCClient(IMMClient):
                 for msg in pgress.get('Messages', []):
                     if 'Verify failed' in msg.get('Message', ''):
                         raise Exception(msg['Message'])
-                state = pgress['TaskState']
+                state = pgress[statetype]
                 if state in ('Cancelled', 'Exception',
                              'Interrupted', 'Suspended'):
                     raise Exception(json.dumps(pgress['Messages']))
                 pct = float(pgress['PercentComplete'])
                 complete = state == 'Completed'
-                progress({'phase': 'apply', 'progress': pct})
-                if not complete:
+                progress({'phase': phase, 'progress': pct})
+                if complete:
+                    if 'OperationTransitionedToJob' in pgress['Messages'][0]['MessageId']:
+                        monitorurl = pgress['Messages'][0]['MessageArgs'][0]
+                        phase = 'validating'
+                        statetype = 'JobState'
+                        complete = False
+                        ipmisession.Session.pause(3)
+                else:
                     ipmisession.Session.pause(3)
             if bank == 'backup':
                 return 'complete'

{pyghmi-1.5.59 → pyghmi-1.5.61}/pyghmi/ipmi/oem/lenovo/nextscale.py

@@ -415,7 +415,7 @@ class SMMClient(object):
         5: 'Boosted',
     }
 
-    def get_bmc_configuration(self):
+    def get_bmc_configuration(self, variant):
         settings = {}
         wc = self.wc
         wc.request(
@@ -453,7 +453,10 @@ class SMMClient(object):
         powercfg = self.ipmicmd.xraw_command(0x32, 0xa2)
         powercfg = bytearray(powercfg['data'])
         if len(powercfg) == 5:
-            powercfg = powercfg[1:]
+            if variant and variant >> 5:
+                powercfg = powercfg[-2:]
+            else:
+                powercfg = powercfg[1:]
         val = powercfg[0]
         if val == 2:
             val = 'N+N'
@@ -700,6 +703,8 @@ class SMMClient(object):
                 if None in powercfg:
                     currcfg = self.ipmicmd.xraw_command(0x32, 0xa2)
                     currcfg = bytearray(currcfg['data'])
+                    if variant and variant >> 5 and len(currcfg) == 5:
+                        currcfg = currcfg[-2:]
                     if powercfg[0] is None:
                         powercfg[0] = currcfg[0]
                     if powercfg[1] is None:

{pyghmi-1.5.59 → pyghmi-1.5.61}/pyghmi/redfish/oem/lenovo/xcc.py

@@ -811,12 +811,23 @@ class OEMHandler(generic.OEMHandler):
     def _create_array(self, pool):
         params = self._parse_array_spec(pool)
         cid = params['controller'].split(',')[0]
+        cslotno = params['controller'].split(',')[1]
         url = '/api/function/raid_conf?params=raidlink_GetDefaultVolProp'
         args = (url, cid, 0, params['drives'])
         props = self.wc.grab_json_response(','.join([str(x) for x in args]))
-        if not props:  # newer firmwarerequires raidlevel too
+        usesctrlslot = False
+        if not props:  # newer firmware requires raidlevel too
             args = (url, cid, params['raidlevel'], 0, params['drives'])
             props = self.wc.grab_json_response(','.join([str(x) for x in args]))
+        elif 'return' in props and props['return'] == 22:
+            # Jan 2023 XCC FW - without controller slot number
+            args = (url, cid, params['raidlevel'], 0, params['drives'])
+            props = self.wc.grab_json_response(','.join([str(x) for x in args]))
+            if 'return' in props and props['return'] == 22:
+                usesctrlslot = True
+                # Jan 2023 XCC FW - with controller slot number
+                args = (url, cid, params['raidlevel'], 0, params['drives'], cslotno)
+                props = self.wc.grab_json_response(','.join([str(x) for x in args]))
         props = props['items'][0]
         volumes = pool.volumes
         remainingcap = params['capacity']
@@ -888,14 +899,14 @@ class OEMHandler(generic.OEMHandler):
         parms = {'raidlink_AddNewVolWithNaAsync': arglist}
         rsp = self.wc.grab_json_response(url, parms)
         if rsp['return'] == 14:  # newer firmware
-            if 'supported_cpwb' in props: # Whitley
+            if 'supported_cpwb' in props and not usesctrlslot: # no ctrl_type
                 arglist = '{0},{1},{2},{3},{4},{5},{6},'.format(
                     cnum, params['raidlevel'], params['spans'],
                     params['perspan'], 0, params['drives'], params['hotspares'])
                 arglist += ''.join(vols)
                 parms = {'raidlink_AddNewVolWithNaAsync': arglist}
                 rsp = self.wc.grab_json_response(url, parms)
-            else: # Purley
+            else: # with ctrl_type
                 if cid[2] == 2:
                     cnum = cid[1]
                 arglist = '{0},{1},{2},{3},{4},{5},'.format(
@@ -1145,8 +1156,10 @@ class OEMHandler(generic.OEMHandler):
                     raise Exception(uploadthread.rsp)
                 raise Exception(errmsg)
             rsp = json.loads(uploadthread.rsp)
-            monitorurl = rsp['TaskMonitor']
+            monitorurl = rsp['@odata.id']
             complete = False
+            phase = "apply"
+            statetype = 'TaskState'
             while not complete:
                 pgress = self._do_web_request(monitorurl, cache=False)
                 if not pgress:
@@ -1154,15 +1167,22 @@ class OEMHandler(generic.OEMHandler):
                 for msg in pgress.get('Messages', []):
                     if 'Verify failed' in msg.get('Message', ''):
                         raise Exception(msg['Message'])
-                state = pgress['TaskState']
+                state = pgress[statetype]
                 if state in ('Cancelled', 'Exception', 'Interrupted',
                              'Suspended'):
                     raise Exception(
                         json.dumps(json.dumps(pgress['Messages'])))
                 pct = float(pgress['PercentComplete'])
                 complete = state == 'Completed'
-                progress({'phase': 'apply', 'progress': pct})
-                if not complete:
+                progress({'phase': phase, 'progress': pct})
+                if complete:
+                    if 'OperationTransitionedToJob' in pgress['Messages'][0]['MessageId']:
+                        monitorurl = pgress['Messages'][0]['MessageArgs'][0]
+                        phase = 'validating'
+                        statetype = 'JobState'
+                        complete = False
+                        time.sleep(3)
+                else:
                     time.sleep(3)
             if bank == 'backup':
                 return 'complete'

{pyghmi-1.5.59 → pyghmi-1.5.61}/pyghmi.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 1.1
 Name: pyghmi
-Version: 1.5.59
+Version: 1.5.61
 Summary: Python General Hardware Management Initiative (IPMI and others)
 Home-page: http://github.com/openstack/pyghmi/
 Author: Jarrod Johnson

pyghmi-1.5.61/pyghmi.egg-info/pbr.json

@@ -0,0 +1 @@
+{"git_version": "537fccb", "is_release": true}

pyghmi-1.5.59/pyghmi.egg-info/pbr.json

@@ -1 +0,0 @@
-{"git_version": "bb46b94", "is_release": true}