pyfunda 3.1.1__tar.gz → 3.1.3__tar.gz

{pyfunda-3.1.1 → pyfunda-3.1.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pyfunda
-Version: 3.1.1
+Version: 3.1.3
 Summary: Python API wrapper for Funda.nl, the Dutch real estate platform. Reverse-engineered mobile API client, no scraping, no Selenium, no CAPTCHA.
 Project-URL: Homepage, https://github.com/0xMH/pyfunda
 Project-URL: Repository, https://github.com/0xMH/pyfunda
@@ -33,10 +33,6 @@ Description-Content-Type: text/markdown
 
 Funda has no public developer API. pyfunda is the only working opensource Python client that hits Funda's app facing `*.funda.io` endpoints directly, the same ones the official Android app uses.
 
-```bash
-pip install pyfunda
-```
-
 Use pyfunda as a Funda API client or Funda Python SDK to fetch Dutch property listings, run search queries by city and price, pull listing detail and media, get broker info and reviews, read price history, and stream new listings. If you have been looking for a working fundascraper alternative or a Netherlands housing API, this is the only Python wrapper hitting the same `*.funda.io` endpoints the Funda Android app uses.
 
 > If you find this useful, consider giving it a star, it helps others discover the project.

{pyfunda-3.1.1 → pyfunda-3.1.3}/README.md

@@ -8,10 +8,6 @@
 
 Funda has no public developer API. pyfunda is the only working opensource Python client that hits Funda's app facing `*.funda.io` endpoints directly, the same ones the official Android app uses.
 
-```bash
-pip install pyfunda
-```
-
 Use pyfunda as a Funda API client or Funda Python SDK to fetch Dutch property listings, run search queries by city and price, pull listing detail and media, get broker info and reviews, read price history, and stream new listings. If you have been looking for a working fundascraper alternative or a Netherlands housing API, this is the only Python wrapper hitting the same `*.funda.io` endpoints the Funda Android app uses.
 
 > If you find this useful, consider giving it a star, it helps others discover the project.

{pyfunda-3.1.1 → pyfunda-3.1.3}/funda/constants.py

@@ -36,7 +36,7 @@ API_BROKER_REVIEWS = (
 )
 
 SEARCH_INDEX = "listings-wonen-searcher-alias-prod"
-SEARCH_TEMPLATE_ID = "search_result_20250805"
+SEARCH_TEMPLATE_ID = "search_result_20260227"
 LOCATION_AUTOCOMPLETE_TEMPLATE_ID = "searchbox_20250805"
 LOCATION_AUTOCOMPLETE_AREA_TYPES = (
     "country",

{pyfunda-3.1.1 → pyfunda-3.1.3}/funda/funda.py

@@ -423,7 +423,9 @@ class Funda:
         for attempt in range(3):
             response = self._transport.post(API_SEARCH, profile="search", data=payload)
             if response.status_code == 200:
-                return response.json()
+                data = response.json()
+                self._raise_for_msearch_error(data)
+                return data
             if response.status_code == 400 and attempt < 2:
                 time.sleep(0.1 * (attempt + 1))
                 continue
@@ -434,6 +436,23 @@ class Funda:
 
         raise SearchError("Search failed without a response")
 
+    @staticmethod
+    def _raise_for_msearch_error(data: JsonDict) -> None:
+        """Surface per-query errors that _msearch reports inside an HTTP 200 body.
+
+        The _msearch/template endpoint answers with HTTP 200 even when the
+        individual query fails (for example a rotated/stale search template),
+        embedding the failure as ``responses[].error``. Without this check such
+        breakage is silently parsed as zero results.
+        """
+        responses = data.get("responses") if isinstance(data, dict) else None
+        for entry in responses or []:
+            if isinstance(entry, dict) and entry.get("error"):
+                error = entry["error"]
+                reason = error.get("reason") if isinstance(error, dict) else str(error)
+                status = entry.get("status", "unknown")
+                raise SearchError(f"Search failed (status {status}): {reason}")
+
     def _autocomplete(self, autocomplete: LocationAutocomplete) -> JsonDict:
         payload = autocomplete.to_payload()
         for attempt in range(3):

{pyfunda-3.1.1 → pyfunda-3.1.3}/funda/headers.py

@@ -19,7 +19,7 @@ def make_headers(profile: RequestProfile = "listing") -> HeaderList:
     tid = hex(int(time.time()))[2:] + "00000000"
 
     headers = [
-        ("user-agent", "Dart/3.9 (dart:io)"),
+        ("user-agent", "Dart/3.11 (dart:io)"),
         ("x-datadog-sampling-priority", "0"),
         ("x-datadog-origin", "rum"),
         ("tracestate", f"dd=s:0;o:rum;p:{parent_id}"),
@@ -39,6 +39,7 @@ def make_headers(profile: RequestProfile = "listing") -> HeaderList:
         headers.extend(
             [
                 ("x-funda-app-platform", "android"),
+                ("x-funda-app-version", "7.14.11"),
                 ("content-type", "application/json"),
             ]
         )

{pyfunda-3.1.1 → pyfunda-3.1.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "pyfunda"
-version = "3.1.1"
+version = "3.1.3"
 description = "Python API wrapper for Funda.nl, the Dutch real estate platform. Reverse-engineered mobile API client, no scraping, no Selenium, no CAPTCHA."
 readme = "README.md"
 license = "AGPL-3.0-or-later"

{pyfunda-3.1.1 → pyfunda-3.1.3}/tests/test_client.py

@@ -2,6 +2,8 @@ import unittest
 from unittest.mock import patch
 
 from funda import Funda, FundaRequestError, Listing, LocationSuggestion
+from funda.constants import LOCATION_AUTOCOMPLETE_TEMPLATE_ID, SEARCH_TEMPLATE_ID
+from funda.exceptions import SearchError
 
 
 class FakeResponse:
@@ -83,7 +85,27 @@ class FundaClientTests(unittest.TestCase):
         url, payload, json_data = client._transport.posts[0]
         self.assertIn("_msearch/template", url)
         self.assertIsNone(json_data)
-        self.assertIn("search_result_", payload)
+        self.assertIn(SEARCH_TEMPLATE_ID, payload)
+
+    def test_search_raises_on_embedded_msearch_error(self) -> None:
+        # _msearch/template answers 200 even when the query fails (e.g. a
+        # stale search template), embedding the error inside the body. This
+        # must surface as an error rather than being parsed as zero results.
+        error_body = {
+            "responses": [
+                {
+                    "error": {
+                        "reason": "No mapping found for [placement_type] in order to sort on",
+                    },
+                    "status": 400,
+                }
+            ]
+        }
+        client = self.client(FakeResponse(200, error_body))
+
+        with self.assertRaises(SearchError) as ctx:
+            client.search("amsterdam")
+        self.assertIn("placement_type", str(ctx.exception))
 
     def test_autocomplete_posts_json_payload_and_parses_results(self) -> None:
         client = self.client(FakeResponse(200, {"hits": {"hits": []}}))
@@ -100,7 +122,7 @@ class FundaClientTests(unittest.TestCase):
         url, payload, json_data = client._transport.posts[0]
         self.assertIn("geo-wonen-alias-prod/_search/template", url)
         self.assertIsNone(payload)
-        self.assertEqual(json_data["id"], "searchbox_20250805")
+        self.assertEqual(json_data["id"], LOCATION_AUTOCOMPLETE_TEMPLATE_ID)
         self.assertEqual(json_data["params"]["value"], "amsterdam west")
         self.assertEqual(json_data["params"]["size"], 5)
         self.assertEqual(

{pyfunda-3.1.1 → pyfunda-3.1.3}/tests/test_live.py

@@ -2,10 +2,30 @@ import os
 import unittest
 
 from funda import Funda
+from funda.constants import SEARCH_TEMPLATE_ID
+from funda.exceptions import SearchError
 
 
 @unittest.skipUnless(os.environ.get("PYFUNDA_LIVE") == "1", "set PYFUNDA_LIVE=1")
 class LiveFundaSmokeTests(unittest.TestCase):
+    def test_search_template_id_is_accepted_by_funda(self) -> None:
+        """Guard against Funda rotating the stored search template ID.
+
+        A stale SEARCH_TEMPLATE_ID makes every search fail server-side with an
+        HTTP 400, while the mocked unit tests keep passing. This isolates that
+        failure mode with a clear pointer to the constant that needs updating.
+        """
+        with Funda(timeout=30) as client:
+            try:
+                results = client.search("amsterdam")
+            except SearchError as exc:
+                self.fail(
+                    f"Funda rejected search template {SEARCH_TEMPLATE_ID!r}: {exc}. "
+                    "Update SEARCH_TEMPLATE_ID in funda/constants.py to the value "
+                    "used by the current Funda app."
+                )
+        self.assertTrue(results, "search returned no listings for 'amsterdam'")
+
     def test_core_listing_search_and_parallel_paths(self) -> None:
         with Funda(timeout=30) as client:
             listing = client.listing(43117443)

{pyfunda-3.1.1 → pyfunda-3.1.3}/tests/test_search.py

@@ -1,6 +1,7 @@
 import json
 import unittest
 
+from funda.constants import SEARCH_INDEX, SEARCH_TEMPLATE_ID
 from funda.search import _Search
 
 
@@ -65,8 +66,8 @@ class SearchTests(unittest.TestCase):
         lines = payload.splitlines()
 
         self.assertEqual(len(lines), 2)
-        self.assertIn("listings-wonen-searcher", json.loads(lines[0])["index"])
-        self.assertIn("search_result_", json.loads(lines[1])["id"])
+        self.assertEqual(json.loads(lines[0])["index"], SEARCH_INDEX)
+        self.assertEqual(json.loads(lines[1])["id"], SEARCH_TEMPLATE_ID)
 
 
 if __name__ == "__main__":