pyflakes 3.3.0__tar.gz → 3.3.2__tar.gz

{pyflakes-3.3.0 → pyflakes-3.3.2}/NEWS.rst

@@ -1,3 +1,11 @@
+3.3.2 (2025-03-31)
+
+- Fix crash with ``global`` / ``nonlocal`` in class bodies (regressed in 3.3.0)
+
+3.3.1 (2025-03-30)
+
+- Allow assignment expressions to redefine annotations (regressed in 3.3.0)
+
 3.3.0 (2025-03-29)
 
 - Add ``__debuggerskip__`` as a special local

{pyflakes-3.3.0 → pyflakes-3.3.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: pyflakes
-Version: 3.3.0
+Version: 3.3.2
 Summary: passive checker of Python programs
 Home-page: https://github.com/PyCQA/pyflakes
 Author: A lot of people

pyflakes-3.3.2/pyflakes/__init__.py

@@ -0,0 +1 @@
+__version__ = '3.3.2'

{pyflakes-3.3.0 → pyflakes-3.3.2}/pyflakes/checker.py

@@ -526,7 +526,10 @@ class Scope(dict):
 
 
 class ClassScope(Scope):
-    pass
+    def __init__(self):
+        super().__init__()
+        # {name: node}
+        self.indirect_assignments = {}
 
 
 class FunctionScope(Scope):
@@ -566,9 +569,6 @@ class FunctionScope(Scope):
             if not binding.used and isinstance(binding, Annotation):
                 yield name, binding
 
-    def unused_indirect_assignments(self):
-        return self.indirect_assignments.items()
-
 
 class TypeScope(Scope):
     pass
@@ -835,6 +835,10 @@ class Checker:
         which were imported but unused.
         """
         for scope in self.deadScopes:
+            if isinstance(scope, (ClassScope, FunctionScope)):
+                for name, node in scope.indirect_assignments.items():
+                    self.report(messages.UnusedIndirectAssignment, node, name)
+
             # imports in classes are public members
             if isinstance(scope, ClassScope):
                 continue
@@ -844,8 +848,6 @@ class Checker:
                     self.report(messages.UnusedVariable, binding.source, name)
                 for name, binding in scope.unused_annotations():
                     self.report(messages.UnusedAnnotation, binding.source, name)
-                for name, node in scope.unused_indirect_assignments():
-                    self.report(messages.UnusedIndirectAssignment, node, name)
 
             all_binding = scope.get('__all__')
             if all_binding and not isinstance(all_binding, ExportBinding):
@@ -988,7 +990,7 @@ class Checker:
                     self.report(messages.RedefinedWhileUnused,
                                 node, value.name, existing.source)
 
-                if isinstance(scope, FunctionScope):
+                if isinstance(scope, (ClassScope, FunctionScope)):
                     scope.indirect_assignments.pop(value.name, None)
 
             elif isinstance(existing, Importation) and value.redefines(existing):
@@ -1008,8 +1010,12 @@ class Checker:
                     for scope in reversed(self.scopeStack)
                     if not isinstance(scope, GeneratorScope)
                 )
-                # it may be a re-assignment to an already existing name
-                scope.setdefault(value.name, value)
+                if value.name in scope and isinstance(scope[value.name], Annotation):
+                    # re-assignment to name that was previously only an annotation
+                    scope[value.name] = value
+                else:
+                    # it may be a re-assignment to an already existing name
+                    scope.setdefault(value.name, value)
             else:
                 self.scope[value.name] = value
 
@@ -1187,7 +1193,7 @@ class Checker:
             # be executed.
             return
 
-        if isinstance(self.scope, FunctionScope):
+        if isinstance(self.scope, (ClassScope, FunctionScope)):
             self.scope.indirect_assignments.pop(name, None)
 
         if isinstance(self.scope, FunctionScope) and name in self.scope.globals:

{pyflakes-3.3.0 → pyflakes-3.3.2}/pyflakes/test/test_other.py

@@ -1121,6 +1121,36 @@ class Test(TestCase):
                 g = 2
         ''', m.UnusedIndirectAssignment, m.UnusedVariable)
 
+    def test_global_nonlocal_in_class_bodies(self):
+        self.flakes('''
+        g = 0
+        class C:
+            global g
+            g = 1
+        def f():
+            nl = 0
+            class C:
+                nonlocal nl
+                nl = 1
+        ''')
+
+    def test_unused_global_in_class(self):
+        self.flakes('''
+        g = 0
+        class C:
+            global g
+            u = g
+        ''', m.UnusedIndirectAssignment)
+
+    def test_unused_nonlocal_in_clas(self):
+        self.flakes('''
+        def f():
+            nl = 1
+            class C:
+                nonlocal nl
+                u = nl
+        ''', m.UnusedIndirectAssignment)
+
     def test_function_arguments(self):
         """
         Test to traverse ARG and ARGUMENT handler
@@ -1744,6 +1774,13 @@ class TestUnusedAssignment(TestCase):
         print(x)
         ''')
 
+    def test_assign_expr_after_annotation(self):
+        self.flakes("""
+        a: int
+        print(a := 3)
+        print(a)
+        """)
+
     def test_assign_expr_generator_scope(self):
         """Test assignment expressions in generator expressions."""
         self.flakes('''

{pyflakes-3.3.0 → pyflakes-3.3.2}/pyflakes.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: pyflakes
-Version: 3.3.0
+Version: 3.3.2
 Summary: passive checker of Python programs
 Home-page: https://github.com/PyCQA/pyflakes
 Author: A lot of people

pyflakes-3.3.0/pyflakes/__init__.py

@@ -1 +0,0 @@
-__version__ = '3.3.0'