pyfirstaid 0.2.2__tar.gz → 0.3.0__tar.gz

{pyfirstaid-0.2.2 → pyfirstaid-0.3.0}/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## Unreleased
+
+- **New `conda` check** for problems from mixing conda and pip (something `conda doctor`
+  doesn't look at):
+  - a package conda installed that pip later replaced, so both tools think they own it,
+  - pip packages installed into the conda *base* environment,
+  - a conda environment that is activated, but isn't the Python actually running.
+  It only reads files on disk, runs no conda or pip commands, and stays quiet when unsure.
+- README: up-to-date example output and downloads badge; author link on PyPI.
+
+## 0.2.3
+
+- Clearer PEP 668 message: it now says the block can come from your OS *or* a package
+  manager such as Homebrew.
+- PyPI page: version, Python-versions, downloads and license badges; Source and Changelog
+  links; per-version Python classifiers (3.9–3.14).
+
 ## 0.2.2
 
 Fixes found by testing on a real Mac with Homebrew Python:

{pyfirstaid-0.2.2 → pyfirstaid-0.3.0}/PKG-INFO

@@ -1,9 +1,12 @@
 Metadata-Version: 2.5
 Name: pyfirstaid
-Version: 0.2.2
+Version: 0.3.0
 Summary: First aid for broken Python environments: finds what's wrong and tells you how to fix it.
 Project-URL: Homepage, https://github.com/sai-sakalam/pyfirstaid
+Project-URL: Source, https://github.com/sai-sakalam/pyfirstaid
 Project-URL: Issues, https://github.com/sai-sakalam/pyfirstaid/issues
+Project-URL: Changelog, https://github.com/sai-sakalam/pyfirstaid/blob/main/CHANGELOG.md
+Project-URL: Author, https://sai-sakalam.github.io/
 Author: Sai Gavaskar Sakalam
 License-Expression: MIT
 License-File: LICENSE
@@ -13,6 +16,13 @@ Classifier: Environment :: Console
 Classifier: Intended Audience :: Developers
 Classifier: Operating System :: OS Independent
 Classifier: Programming Language :: Python :: 3
+Classifier: Programming Language :: Python :: 3 :: Only
+Classifier: Programming Language :: Python :: 3.9
+Classifier: Programming Language :: Python :: 3.10
+Classifier: Programming Language :: Python :: 3.11
+Classifier: Programming Language :: Python :: 3.12
+Classifier: Programming Language :: Python :: 3.13
+Classifier: Programming Language :: Python :: 3.14
 Classifier: Topic :: Software Development :: Debuggers
 Classifier: Topic :: System :: Installation/Setup
 Requires-Python: >=3.9
@@ -22,11 +32,15 @@ Requires-Dist: ruff>=0.5; extra == 'dev'
 Description-Content-Type: text/markdown
 
 # pyfirstaid 🩹
+[![PyPI](https://img.shields.io/pypi/v/pyfirstaid)](https://pypi.org/project/pyfirstaid/)
+[![Python versions](https://img.shields.io/pypi/pyversions/pyfirstaid)](https://pypi.org/project/pyfirstaid/)
+[![Downloads](https://img.shields.io/pypi/dm/pyfirstaid)](https://pypistats.org/packages/pyfirstaid)
 [![CI](https://github.com/sai-sakalam/pyfirstaid/actions/workflows/ci.yml/badge.svg)](https://github.com/sai-sakalam/pyfirstaid/actions/workflows/ci.yml)
+[![License: MIT](https://img.shields.io/badge/license-MIT-blue)](https://github.com/sai-sakalam/pyfirstaid/blob/main/LICENSE)
 
 **First aid for broken Python environments.** One command tells you *what's broken* and *exactly how to fix it*.
 
-> **Status: v0.2.2.** 12 checks, tested on Windows, macOS and Linux (Python 3.9–3.14).
+> **Status: early, actively developed.** 13 checks, tested on Windows, macOS and Linux (Python 3.9–3.14).
 > Feedback is very welcome in [Issues](https://github.com/sai-sakalam/pyfirstaid/issues). *Which problems do you hit most?*
 
 ---
@@ -47,7 +61,7 @@ system Python, and a file called `random.py` is hiding the real `random` module:
 ```console
 $ python -m pyfirstaid --share
 
-pyfirstaid 0.2.0: checking your Python environment
+pyfirstaid 0.2.3: checking your Python environment
 Python 3.13.1 (~/project/.venv/bin/python)
 
 ✔ Python 3.13.1 (supported until October 2029)
@@ -191,6 +205,7 @@ Download `pyfirstaid.pyz` from the [latest release](https://github.com/sai-sakal
 |---|---|
 | `python-version` | Python past (or close to) end of life, pre-release Pythons, Apple's built-in Command Line Tools Python |
 | `venv` | No venv active, an unused `.venv` in the folder, a *different* venv activated in your shell, a system Python that blocks pip (PEP 668) |
+| `conda` | A package conda installed that pip later replaced, pip packages in the conda *base* environment, a conda environment that is activated but isn't the Python running |
 | `pip-mismatch` | `pip` installs into a different Python than the one you run, pip missing, a broken `pip` command |
 | `path` | Typing `python` / `python3` runs a *different* Python, or the Windows Microsoft Store shortcut |
 | `leaks` | `PYTHONPATH` / `PYTHONHOME` set, venvs that can see system packages |
@@ -209,7 +224,7 @@ Run one or a few: `python -m pyfirstaid --only shadowing,path`. List them all: `
 | Tool | What it does | Gap pyfirstaid fills |
 |---|---|---|
 | `pip check` | Finds dependency conflicts | Only covers one kind of problem |
-| `conda doctor` | Health checks for conda environments | Doesn't cover pip, venv or uv |
+| `conda doctor` | Health checks for conda environments | Doesn't check what pip did inside conda, or venv / uv |
 | pymedic | Lists environment info (versions, packages) | Reports, but doesn't diagnose or suggest fixes |
 | pyenv-doctor | Early-stage environment checks | Single release so far |
 | env-repair | Repairs conda and pip environments | Changes your environment; pyfirstaid only diagnoses, safely |
@@ -227,8 +242,8 @@ Run one or a few: `python -m pyfirstaid --only shadowing,path`. List them all: `
 
 ## Scope
 
-**In:** pip, venv and uv on Windows, macOS and Linux.
-**Out (for now):** conda (use `conda doctor`), Poetry and pyenv specifics, automatic repair.
+**In:** pip, venv and uv on Windows, macOS and Linux, plus conda / pip mixing problems.
+**Out (for now):** conda's own internals (use `conda doctor`), Poetry and pyenv specifics, automatic repair.
 
 ## Contributing
 
@@ -236,6 +251,10 @@ Run one or a few: `python -m pyfirstaid --only shadowing,path`. List them all: `
 - Development: `python -m pip install -e ".[dev]"`, then `python -m pytest` and `ruff check src tests`.
 - A new check is one file in `src/pyfirstaid/checks/` that returns a list of `Finding`s, registered in `checks/__init__.py`.
 
+## Author
+
+Made by [Sai Sakalam](https://sai-sakalam.github.io/), a data engineer who kept fixing the same broken Python environments for colleagues and decided to automate it. Feedback and ideas are always welcome.
+
 ## License
 
 MIT

{pyfirstaid-0.2.2 → pyfirstaid-0.3.0}/README.md

@@ -1,9 +1,13 @@
 # pyfirstaid 🩹
+[![PyPI](https://img.shields.io/pypi/v/pyfirstaid)](https://pypi.org/project/pyfirstaid/)
+[![Python versions](https://img.shields.io/pypi/pyversions/pyfirstaid)](https://pypi.org/project/pyfirstaid/)
+[![Downloads](https://img.shields.io/pypi/dm/pyfirstaid)](https://pypistats.org/packages/pyfirstaid)
 [![CI](https://github.com/sai-sakalam/pyfirstaid/actions/workflows/ci.yml/badge.svg)](https://github.com/sai-sakalam/pyfirstaid/actions/workflows/ci.yml)
+[![License: MIT](https://img.shields.io/badge/license-MIT-blue)](https://github.com/sai-sakalam/pyfirstaid/blob/main/LICENSE)
 
 **First aid for broken Python environments.** One command tells you *what's broken* and *exactly how to fix it*.
 
-> **Status: v0.2.2.** 12 checks, tested on Windows, macOS and Linux (Python 3.9–3.14).
+> **Status: early, actively developed.** 13 checks, tested on Windows, macOS and Linux (Python 3.9–3.14).
 > Feedback is very welcome in [Issues](https://github.com/sai-sakalam/pyfirstaid/issues). *Which problems do you hit most?*
 
 ---
@@ -24,7 +28,7 @@ system Python, and a file called `random.py` is hiding the real `random` module:
 ```console
 $ python -m pyfirstaid --share
 
-pyfirstaid 0.2.0: checking your Python environment
+pyfirstaid 0.2.3: checking your Python environment
 Python 3.13.1 (~/project/.venv/bin/python)
 
 ✔ Python 3.13.1 (supported until October 2029)
@@ -168,6 +172,7 @@ Download `pyfirstaid.pyz` from the [latest release](https://github.com/sai-sakal
 |---|---|
 | `python-version` | Python past (or close to) end of life, pre-release Pythons, Apple's built-in Command Line Tools Python |
 | `venv` | No venv active, an unused `.venv` in the folder, a *different* venv activated in your shell, a system Python that blocks pip (PEP 668) |
+| `conda` | A package conda installed that pip later replaced, pip packages in the conda *base* environment, a conda environment that is activated but isn't the Python running |
 | `pip-mismatch` | `pip` installs into a different Python than the one you run, pip missing, a broken `pip` command |
 | `path` | Typing `python` / `python3` runs a *different* Python, or the Windows Microsoft Store shortcut |
 | `leaks` | `PYTHONPATH` / `PYTHONHOME` set, venvs that can see system packages |
@@ -186,7 +191,7 @@ Run one or a few: `python -m pyfirstaid --only shadowing,path`. List them all: `
 | Tool | What it does | Gap pyfirstaid fills |
 |---|---|---|
 | `pip check` | Finds dependency conflicts | Only covers one kind of problem |
-| `conda doctor` | Health checks for conda environments | Doesn't cover pip, venv or uv |
+| `conda doctor` | Health checks for conda environments | Doesn't check what pip did inside conda, or venv / uv |
 | pymedic | Lists environment info (versions, packages) | Reports, but doesn't diagnose or suggest fixes |
 | pyenv-doctor | Early-stage environment checks | Single release so far |
 | env-repair | Repairs conda and pip environments | Changes your environment; pyfirstaid only diagnoses, safely |
@@ -204,8 +209,8 @@ Run one or a few: `python -m pyfirstaid --only shadowing,path`. List them all: `
 
 ## Scope
 
-**In:** pip, venv and uv on Windows, macOS and Linux.
-**Out (for now):** conda (use `conda doctor`), Poetry and pyenv specifics, automatic repair.
+**In:** pip, venv and uv on Windows, macOS and Linux, plus conda / pip mixing problems.
+**Out (for now):** conda's own internals (use `conda doctor`), Poetry and pyenv specifics, automatic repair.
 
 ## Contributing
 
@@ -213,6 +218,10 @@ Run one or a few: `python -m pyfirstaid --only shadowing,path`. List them all: `
 - Development: `python -m pip install -e ".[dev]"`, then `python -m pytest` and `ruff check src tests`.
 - A new check is one file in `src/pyfirstaid/checks/` that returns a list of `Finding`s, registered in `checks/__init__.py`.
 
+## Author
+
+Made by [Sai Sakalam](https://sai-sakalam.github.io/), a data engineer who kept fixing the same broken Python environments for colleagues and decided to automate it. Feedback and ideas are always welcome.
+
 ## License
 
 MIT

{pyfirstaid-0.2.2 → pyfirstaid-0.3.0}/pyproject.toml

@@ -18,6 +18,13 @@ classifiers = [
     "Intended Audience :: Developers",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
+    "Programming Language :: Python :: 3.9",
+    "Programming Language :: Python :: 3.10",
+    "Programming Language :: Python :: 3.11",
+    "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
+    "Programming Language :: Python :: 3.14",
+    "Programming Language :: Python :: 3 :: Only",
     "Topic :: Software Development :: Debuggers",
     "Topic :: System :: Installation/Setup",
 ]
@@ -31,7 +38,10 @@ pyfirstaid = "pyfirstaid.cli:main"
 
 [project.urls]
 Homepage = "https://github.com/sai-sakalam/pyfirstaid"
+Source = "https://github.com/sai-sakalam/pyfirstaid"
 Issues = "https://github.com/sai-sakalam/pyfirstaid/issues"
+Changelog = "https://github.com/sai-sakalam/pyfirstaid/blob/main/CHANGELOG.md"
+Author = "https://sai-sakalam.github.io/"
 
 [tool.hatch.version]
 path = "src/pyfirstaid/__init__.py"

{pyfirstaid-0.2.2 → pyfirstaid-0.3.0}/src/pyfirstaid/__init__.py

@@ -1,3 +1,3 @@
 """pyfirstaid: first aid for broken Python environments."""
 
-__version__ = "0.2.2"
+__version__ = "0.3.0"

{pyfirstaid-0.2.2 → pyfirstaid-0.3.0}/src/pyfirstaid/checks/__init__.py

@@ -7,6 +7,7 @@ from typing import List
 from pyfirstaid.checks import (
     broken_installs,
     compiled,
+    conda,
     dependencies,
     encoding,
     leaks,
@@ -23,6 +24,7 @@ from pyfirstaid.model import Check
 ALL_CHECKS: List[Check] = [
     Check(python_version.CHECK_ID, "Python version", python_version.run_check),
     Check(venv.CHECK_ID, "Virtual environment", venv.run_check),
+    Check(conda.CHECK_ID, "conda / pip mixing", conda.run_check),
     Check(pip_mismatch.CHECK_ID, "pip / python match", pip_mismatch.run_check),
     Check(path_check.CHECK_ID, "python on PATH", path_check.run_check),
     Check(leaks.CHECK_ID, "PYTHONPATH / PYTHONHOME", leaks.run_check),

pyfirstaid-0.3.0/src/pyfirstaid/checks/conda.py

@@ -0,0 +1,166 @@
+"""Check: problems from mixing conda and pip in a conda environment.
+
+`conda doctor` checks conda's own files but not what pip did to the environment.
+This check looks only at files on disk (no conda or pip commands are run):
+
+- a package that conda installed and pip later replaced (two tools fighting over it),
+- packages pip-installed into the conda *base* environment,
+- a conda environment that is activated but is not the Python actually running.
+"""
+
+from __future__ import annotations
+
+import glob
+import json
+import os
+import re
+import sys
+from typing import Dict, List, Optional, Set
+
+from pyfirstaid.model import Finding, Options, Status
+from pyfirstaid.util import norm, site_package_dirs
+
+CHECK_ID = "conda"
+
+_META_RE = re.compile(r"^(?P<name>.+?)-(?P<ver>[^-]+)\.(?:dist-info|egg-info)$")
+
+
+def normalize(name: str) -> str:
+    return re.sub(r"[-_.]+", "-", name).lower()
+
+
+def is_conda_env(prefix: str) -> bool:
+    """Every conda environment (base included) has a conda-meta folder."""
+    return os.path.isdir(os.path.join(prefix, "conda-meta"))
+
+
+def is_base_env(prefix: str) -> bool:
+    """The base environment holds conda itself: it has condabin/ or an envs/ folder."""
+    return (os.path.isdir(os.path.join(prefix, "condabin"))
+            or os.path.isdir(os.path.join(prefix, "envs")))
+
+
+def conda_records(prefix: str) -> Dict[str, Set[str]]:
+    """Map normalized conda package name -> metadata folder names conda installed for it.
+
+    Reads conda-meta/*.json. The set is empty for packages that ship no Python metadata.
+    """
+    records: Dict[str, Set[str]] = {}
+    for path in glob.glob(os.path.join(prefix, "conda-meta", "*.json")):
+        try:
+            with open(path, encoding="utf-8") as fh:
+                data = json.load(fh)
+        except (OSError, ValueError):
+            continue
+        name = data.get("name")
+        if not isinstance(name, str):
+            continue
+        metas: Set[str] = set()
+        for f in data.get("files") or []:
+            if not isinstance(f, str):
+                continue
+            for part in f.replace("\\", "/").split("/"):
+                if part.endswith((".dist-info", ".egg-info")):
+                    metas.add(part)
+                    break
+        records.setdefault(normalize(name), set()).update(metas)
+    return records
+
+
+def installer_of(meta_dir: str) -> str:
+    try:
+        with open(os.path.join(meta_dir, "INSTALLER"), encoding="utf-8") as fh:
+            return fh.read().strip().lower()
+    except OSError:
+        return ""
+
+
+def find_problems(site_dirs: List[str], records: Dict[str, Set[str]]):
+    """Return (replaced, pip_only): package names pip replaced over conda, and pip-only ones."""
+    owned_by_conda: Set[str] = set()
+    for metas in records.values():
+        owned_by_conda.update(metas)
+
+    replaced: List[str] = []
+    pip_only: List[str] = []
+    for d in site_dirs:
+        try:
+            entries = os.listdir(d)
+        except OSError:
+            continue
+        for entry in entries:
+            m = _META_RE.match(entry)
+            if not m or entry in owned_by_conda:
+                continue
+            if installer_of(os.path.join(d, entry)) != "pip":
+                continue  # conservative: only packages pip clearly says it installed
+            name = normalize(m.group("name"))
+            if name in records:
+                replaced.append("%s %s" % (name, m.group("ver")))
+            else:
+                pip_only.append(name)
+    return sorted(set(replaced)), sorted(set(pip_only))
+
+
+def run_check(opts: Options, prefix: Optional[str] = None,
+              site_dirs: Optional[List[str]] = None) -> List[Finding]:
+    prefix = prefix or sys.prefix
+    findings: List[Finding] = []
+    active = os.environ.get("CONDA_PREFIX")
+
+    if not is_conda_env(prefix):
+        if active and is_conda_env(active):
+            findings.append(Finding(
+                CHECK_ID, Status.WARN,
+                "A conda environment is activated, but this Python is not from it",
+                detail="activated: %s\nrunning:   %s" % (active, sys.executable),
+                fix="Use the environment's own Python: python -m pyfirstaid after "
+                    "`conda activate <env>`, or check which python with `which python` "
+                    "(Windows: `where python`).",
+            ))
+            return findings
+        return [Finding(CHECK_ID, Status.SKIP, "Not a conda environment")]
+
+    records = conda_records(prefix)
+    replaced, pip_only = find_problems(
+        site_dirs if site_dirs is not None else site_package_dirs(), records)
+    base = is_base_env(prefix)
+    env_hint = "the base environment" if base else "this conda environment"
+
+    if replaced:
+        findings.append(Finding(
+            CHECK_ID, Status.WARN,
+            "%d package(s) installed by conda were later replaced by pip" % len(replaced),
+            detail="conda and pip now both think they own these, which can cause "
+                   "import errors and broken updates:\n" + "\n".join(replaced[:8])
+                   + ("\n...and %d more" % (len(replaced) - 8) if len(replaced) > 8 else ""),
+            fix="Pick one tool per package. Usually: conda install --force-reinstall <name>. "
+                "Rule of thumb: install with conda first, and use pip only for packages "
+                "conda doesn't have.",
+        ))
+
+    if base and pip_only:
+        findings.append(Finding(
+            CHECK_ID, Status.WARN,
+            "%d package(s) pip-installed into the conda base environment" % len(pip_only),
+            detail="The base environment runs conda itself; extra pip packages there can "
+                   "break conda updates:\n" + ", ".join(pip_only[:10])
+                   + (" ..." if len(pip_only) > 10 else ""),
+            fix="Create a separate environment for your work: conda create -n myenv python, "
+                "then conda activate myenv",
+        ))
+
+    if active and norm(active) != norm(prefix):
+        findings.append(Finding(
+            CHECK_ID, Status.WARN,
+            "Your shell activated a DIFFERENT conda environment",
+            detail="activated: %s\nrunning:   %s" % (active, prefix),
+            fix="Run `conda activate <the env you meant>`, then run pyfirstaid again.",
+        ))
+
+    if not findings:
+        findings.append(Finding(
+            CHECK_ID, Status.OK,
+            "No conda / pip conflicts in %s" % env_hint,
+        ))
+    return findings

{pyfirstaid-0.2.2 → pyfirstaid-0.3.0}/src/pyfirstaid/checks/venv.py

@@ -62,7 +62,8 @@ def run_check(opts: Options) -> List[Finding]:
             findings.append(Finding(
                 CHECK_ID, Status.WARN,
                 "No virtual environment, and this system Python blocks pip installs",
-                detail="Your OS marks this Python as externally managed (PEP 668), "
+                detail="Your OS or package manager (e.g. Homebrew) marks this Python as "
+                       "externally managed (PEP 668), "
                        "so `pip install` will fail with 'externally-managed-environment'.",
                 fix="python -m venv .venv  &&  " + activate_command(".venv"),
             ))

pyfirstaid-0.3.0/tests/test_conda.py

@@ -0,0 +1,139 @@
+import json
+
+from pyfirstaid.checks import conda
+from pyfirstaid.model import Options, Status
+
+
+def make_env(tmp_path, base=False, conda_pkgs=(), dists=()):
+    """Build a fake conda environment.
+
+    conda_pkgs: (name, version) pairs that conda installed, with their dist-info.
+    dists: (dist-info folder name, INSTALLER contents) actually present in site-packages.
+    """
+    prefix = tmp_path / "env"
+    meta = prefix / "conda-meta"
+    meta.mkdir(parents=True)
+    if base:
+        (prefix / "condabin").mkdir()
+    site = prefix / "lib" / "site-packages"
+    site.mkdir(parents=True)
+    for name, ver in conda_pkgs:
+        record = {
+            "name": name,
+            "version": ver,
+            "files": ["lib/site-packages/%s/__init__.py" % name,
+                      "lib/site-packages/%s-%s.dist-info/METADATA" % (name, ver)],
+        }
+        (meta / ("%s-%s-0.json" % (name, ver))).write_text(json.dumps(record))
+    for folder, installer in dists:
+        d = site / folder
+        d.mkdir()
+        (d / "METADATA").write_text("Name: x\n")
+        if installer is not None:
+            (d / "INSTALLER").write_text(installer + "\n")
+    return str(prefix), [str(site)]
+
+
+def run(prefix, site_dirs, monkeypatch, active=None):
+    if active is None:
+        monkeypatch.setenv("CONDA_PREFIX", prefix)
+    else:
+        monkeypatch.setenv("CONDA_PREFIX", active)
+    return conda.run_check(Options(), prefix=prefix, site_dirs=site_dirs)
+
+
+def test_not_conda_is_skipped(tmp_path, monkeypatch):
+    monkeypatch.delenv("CONDA_PREFIX", raising=False)
+    findings = conda.run_check(Options(), prefix=str(tmp_path), site_dirs=[])
+    assert [f.status for f in findings] == [Status.SKIP]
+
+
+def test_clean_env_is_ok(tmp_path, monkeypatch):
+    prefix, sites = make_env(
+        tmp_path,
+        conda_pkgs=[("numpy", "2.1.0")],
+        dists=[("numpy-2.1.0.dist-info", "conda"), ("requests-2.32.0.dist-info", "pip")],
+    )
+    findings = run(prefix, sites, monkeypatch)
+    assert [f.status for f in findings] == [Status.OK]
+
+
+def test_pip_replaced_conda_package(tmp_path, monkeypatch):
+    prefix, sites = make_env(
+        tmp_path,
+        conda_pkgs=[("numpy", "2.1.0")],
+        dists=[("numpy-2.2.0.dist-info", "pip")],  # pip upgraded over conda's numpy
+    )
+    findings = run(prefix, sites, monkeypatch)
+    assert findings[0].status == Status.WARN
+    assert "replaced by pip" in findings[0].title
+    assert "numpy 2.2.0" in findings[0].detail
+
+
+def test_conda_owned_dist_is_not_flagged_even_if_installer_says_pip(tmp_path, monkeypatch):
+    # some conda packages are built with pip; conda-meta lists the dist-info, so it's conda's
+    prefix, sites = make_env(
+        tmp_path,
+        conda_pkgs=[("numpy", "2.1.0")],
+        dists=[("numpy-2.1.0.dist-info", "pip")],
+    )
+    findings = run(prefix, sites, monkeypatch)
+    assert [f.status for f in findings] == [Status.OK]
+
+
+def test_unknown_installer_is_not_flagged(tmp_path, monkeypatch):
+    prefix, sites = make_env(
+        tmp_path,
+        conda_pkgs=[("numpy", "2.1.0")],
+        dists=[("numpy-2.2.0.dist-info", None)],  # no INSTALLER file: stay conservative
+    )
+    findings = run(prefix, sites, monkeypatch)
+    assert [f.status for f in findings] == [Status.OK]
+
+
+def test_pip_packages_in_base_env(tmp_path, monkeypatch):
+    prefix, sites = make_env(
+        tmp_path, base=True,
+        dists=[("requests-2.32.0.dist-info", "pip")],
+    )
+    findings = run(prefix, sites, monkeypatch)
+    assert findings[0].status == Status.WARN
+    assert "base environment" in findings[0].title
+    assert "requests" in findings[0].detail
+
+
+def test_pip_packages_in_normal_env_are_fine(tmp_path, monkeypatch):
+    prefix, sites = make_env(tmp_path, dists=[("requests-2.32.0.dist-info", "pip")])
+    findings = run(prefix, sites, monkeypatch)
+    assert [f.status for f in findings] == [Status.OK]
+
+
+def test_different_conda_env_activated(tmp_path, monkeypatch):
+    prefix, sites = make_env(tmp_path)
+    other = tmp_path / "other"
+    (other / "conda-meta").mkdir(parents=True)
+    findings = run(prefix, sites, monkeypatch, active=str(other))
+    assert findings[0].status == Status.WARN
+    assert "DIFFERENT conda environment" in findings[0].title
+
+
+def test_conda_activated_but_python_is_elsewhere(tmp_path, monkeypatch):
+    active = tmp_path / "myenv"
+    (active / "conda-meta").mkdir(parents=True)
+    monkeypatch.setenv("CONDA_PREFIX", str(active))
+    findings = conda.run_check(Options(), prefix=str(tmp_path / "not-conda"), site_dirs=[])
+    assert findings[0].status == Status.WARN
+    assert "not from it" in findings[0].title
+
+
+def test_conda_records_ignores_bad_json(tmp_path):
+    meta = tmp_path / "conda-meta"
+    meta.mkdir()
+    (meta / "broken.json").write_text("{not json")
+    (meta / "ok-1.0-0.json").write_text(json.dumps({"name": "Some_Pkg", "files": []}))
+    assert conda.conda_records(str(tmp_path)) == {"some-pkg": set()}
+
+
+def test_real_environment_does_not_crash():
+    findings = conda.run_check(Options())
+    assert findings and all(f.check == "conda" for f in findings)

{pyfirstaid-0.2.2 → pyfirstaid-0.3.0}/tests/test_more_checks.py

@@ -144,7 +144,7 @@ def test_all_checks_registered():
     from pyfirstaid.checks import ALL_CHECKS
 
     ids = [c.id for c in ALL_CHECKS]
-    assert len(ids) == len(set(ids)) == 12
+    assert len(ids) == len(set(ids)) == 13
     assert os.path.basename(__file__)  # keeps `os` used