pycontrol-gui 3.0.0b2__tar.gz → 3.0.0b3__tar.gz

{pycontrol_gui-3.0.0b2 → pycontrol_gui-3.0.0b3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: pycontrol-gui
-Version: 3.0.0b2
+Version: 3.0.0b3
 Summary: Qt desktop frontend for pycontrol-core.
 Author: Karpova Lab contributors
 License: GPL-3.0-or-later
@@ -13,7 +13,7 @@ Classifier: Programming Language :: Python :: 3.12
 Classifier: Topic :: Scientific/Engineering
 Requires-Python: >=3.12
 Requires-Dist: packaging>=24
-Requires-Dist: pycontrol-core<3.1,>=3.0.0b1
+Requires-Dist: pycontrol-core<3.1,>=3.0.0b2
 Requires-Dist: pyqtgraph>=0.13.7
 Requires-Dist: pyside6>=6.8
 Provides-Extra: test

{pycontrol_gui-3.0.0b2 → pycontrol_gui-3.0.0b3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "pycontrol-gui"
-version = "3.0.0b2"
+version = "3.0.0b3"
 description = "Qt desktop frontend for pycontrol-core."
 readme = "README.md"
 requires-python = ">=3.12"
@@ -20,7 +20,7 @@ classifiers = [
 ]
 dependencies = [
   "packaging>=24",
-  "pycontrol-core>=3.0.0b1,<3.1",
+  "pycontrol-core>=3.0.0b2,<3.1",
   "PySide6>=6.8",
   "pyqtgraph>=0.13.7",
 ]

{pycontrol_gui-3.0.0b2 → pycontrol_gui-3.0.0b3}/src/pycontrol_gui/session_controller.py

@@ -520,6 +520,7 @@ class SessionController(QObject):
         self._pending_end = None
         self._end_poll.stop()
         self._handled_session_end_signature = signature
+        self._log_run_error(ended)
         self._finish_active_run(ended)
         self.state_changed.emit(session.state)
         self.run_stopped.emit(ended)
@@ -641,6 +642,18 @@ class SessionController(QObject):
         if session.state in (SessionState.CONNECTED, SessionState.READY):
             self._pending_notes.append((note, 0))
 
+    def _log_run_error(self, ended: SessionEnded) -> None:
+        """Persist a board traceback or lost connection to the error log, not just the run's log view."""
+        if not ended.error_message:
+            return
+        run = self._active_run
+        if run is not None:
+            where = f"setup {run.plan.setup_name}, subject {run.plan.subject_id}, port {run.plan.port}"
+        else:
+            where = f"port {self._connected_port}"
+        message = ended.error_message.replace("\r\n", "\n").strip()
+        logger.error("Run on %s (task %s) ended with an error:\n%s", where, self._last_task_name, message)
+
     def _finish_active_run(self, ended: SessionEnded | None = None) -> None:
         """Close and package the run in flight, if any.
 

{pycontrol_gui-3.0.0b2 → pycontrol_gui-3.0.0b3}/tests/test_session_controller.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 import json
+import logging
 import types
 import zipfile
 from dataclasses import replace
@@ -403,7 +404,7 @@ def test_session_controller_hardware_test_does_not_save_data(qtbot, tmp_path: Pa
     assert len(bundles) == 1
 
 
-def test_session_controller_finalizes_run_when_board_reports_error(qtbot, tmp_path: Path) -> None:
+def test_session_controller_finalizes_run_when_board_reports_error(qtbot, tmp_path: Path, caplog) -> None:
     task_path = tmp_path / "task_error.py"
     task_path.write_text("# task fixture\n", encoding="utf-8")
 
@@ -425,13 +426,18 @@ def test_session_controller_finalizes_run_when_board_reports_error(qtbot, tmp_pa
 
         controller.connect_to("BoxA", "/dev/mock0", None)
         controller.upload_task(str(task_path), "task_error")
-        controller.start_run("mouse42", "BoxA", "run_task", "")
-
-        _assert_state_seen(qtbot, seen_states, SessionState.STOPPED)
+        with caplog.at_level(logging.ERROR, logger="pycontrol_gui.session_controller"):
+            controller.start_run("mouse42", "BoxA", "run_task", "")
+            _assert_state_seen(qtbot, seen_states, SessionState.STOPPED)
 
     assert errors == []
     assert len(run_stopped) == 1
     assert run_stopped[0].error_message == "Traceback: boom"
+    # The board traceback also reaches the error log, once, with where it happened.
+    [record] = [r for r in caplog.records if "ended with an error" in r.getMessage()]
+    assert record.levelno == logging.ERROR
+    assert "setup BoxA, subject mouse42" in record.getMessage()
+    assert record.getMessage().endswith("Traceback: boom")
     assert "Run stopped" in infos
     # A task error ends the run; the serial link is fine, so the board stays connected.
     assert controller.session is not None

{pycontrol_gui-3.0.0b2 → pycontrol_gui-3.0.0b3}/uv.lock

@@ -141,7 +141,7 @@ provides-extras = ["analysis", "integrations", "lint", "notion", "s3", "slack",
 
 [[package]]
 name = "pycontrol-gui"
-version = "3.0.0b1"
+version = "3.0.0b2"
 source = { editable = "." }
 dependencies = [
     { name = "packaging" },