pySmartHashtag 0.14.0__tar.gz → 0.14.2__tar.gz

{pysmarthashtag-0.14.0/pySmartHashtag.egg-info → pysmarthashtag-0.14.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pySmartHashtag
-Version: 0.14.0
+Version: 0.14.2
 Summary: A python library to get information from Smart #1, #3 and #5 web API
 Home-page: https://github.com/dasBasti/pySmartHashtag
 Author: dasBasti
@@ -62,6 +62,14 @@ Get this custom integration into homeassistant
 
 [![Project Maintenance][maintenance-shield]](https://platinenmacher.tech)
 
+## Credits
+
+The Smart #5 seat comfort functions (ZAF request format) exist thanks to community contributors:
+
+- [@radzatm](https://github.com/radzatm) captured the working ZAF seat heating request of the Smart #5 with a man-in-the-middle proxy and tested the debug builds ([SmartHashtag#478](https://github.com/DasBasti/SmartHashtag/issues/478)).
+- [@ooooli](https://github.com/ooooli) documented and confirmed the ZAF request format for climate, seat heating, steering wheel heating and front seat ventilation ([SmartHashtag#479](https://github.com/DasBasti/SmartHashtag/issues/479)).
+- [@krlimi69](https://github.com/krlimi69) reported the failing seat heating on the Smart #5 Brabus and tested the fixes ([SmartHashtag#478](https://github.com/DasBasti/SmartHashtag/issues/478)).
+
 ## AI Disclosure
 
 This project uses AI to assist with development.

{pysmarthashtag-0.14.0 → pysmarthashtag-0.14.2}/README.md

@@ -15,6 +15,14 @@ Get this custom integration into homeassistant
 
 [![Project Maintenance][maintenance-shield]](https://platinenmacher.tech)
 
+## Credits
+
+The Smart #5 seat comfort functions (ZAF request format) exist thanks to community contributors:
+
+- [@radzatm](https://github.com/radzatm) captured the working ZAF seat heating request of the Smart #5 with a man-in-the-middle proxy and tested the debug builds ([SmartHashtag#478](https://github.com/DasBasti/SmartHashtag/issues/478)).
+- [@ooooli](https://github.com/ooooli) documented and confirmed the ZAF request format for climate, seat heating, steering wheel heating and front seat ventilation ([SmartHashtag#479](https://github.com/DasBasti/SmartHashtag/issues/479)).
+- [@krlimi69](https://github.com/krlimi69) reported the failing seat heating on the Smart #5 Brabus and tested the fixes ([SmartHashtag#478](https://github.com/DasBasti/SmartHashtag/issues/478)).
+
 ## AI Disclosure
 
 This project uses AI to assist with development.

{pysmarthashtag-0.14.0 → pysmarthashtag-0.14.2/pySmartHashtag.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pySmartHashtag
-Version: 0.14.0
+Version: 0.14.2
 Summary: A python library to get information from Smart #1, #3 and #5 web API
 Home-page: https://github.com/dasBasti/pySmartHashtag
 Author: dasBasti
@@ -62,6 +62,14 @@ Get this custom integration into homeassistant
 
 [![Project Maintenance][maintenance-shield]](https://platinenmacher.tech)
 
+## Credits
+
+The Smart #5 seat comfort functions (ZAF request format) exist thanks to community contributors:
+
+- [@radzatm](https://github.com/radzatm) captured the working ZAF seat heating request of the Smart #5 with a man-in-the-middle proxy and tested the debug builds ([SmartHashtag#478](https://github.com/DasBasti/SmartHashtag/issues/478)).
+- [@ooooli](https://github.com/ooooli) documented and confirmed the ZAF request format for climate, seat heating, steering wheel heating and front seat ventilation ([SmartHashtag#479](https://github.com/DasBasti/SmartHashtag/issues/479)).
+- [@krlimi69](https://github.com/krlimi69) reported the failing seat heating on the Smart #5 Brabus and tested the fixes ([SmartHashtag#478](https://github.com/DasBasti/SmartHashtag/issues/478)).
+
 ## AI Disclosure
 
 This project uses AI to assist with development.

{pysmarthashtag-0.14.0 → pysmarthashtag-0.14.2}/pySmartHashtag.egg-info/SOURCES.txt

@@ -56,6 +56,7 @@ pysmarthashtag/tests/test_charging_limit.py
 pysmarthashtag/tests/test_charging_states.py
 pysmarthashtag/tests/test_cli.py
 pysmarthashtag/tests/test_climate_status.py
+pysmarthashtag/tests/test_climate_zaf.py
 pysmarthashtag/tests/test_dc_charge_info.py
 pysmarthashtag/tests/test_dc_charging.py
 pysmarthashtag/tests/test_endpoint_urls.py

{pysmarthashtag-0.14.0 → pysmarthashtag-0.14.2}/pySmartHashtag.egg-info/scm_file_list.json

@@ -66,6 +66,7 @@
     "pysmarthashtag/tests/test_charging_states.py",
     "pysmarthashtag/tests/test_cli.py",
     "pysmarthashtag/tests/test_climate_status.py",
+    "pysmarthashtag/tests/test_climate_zaf.py",
     "pysmarthashtag/tests/test_dc_charge_info.py",
     "pysmarthashtag/tests/test_dc_charging.py",
     "pysmarthashtag/tests/test_endpoint_urls.py",

{pysmarthashtag-0.14.0 → pysmarthashtag-0.14.2}/pySmartHashtag.egg-info/scm_version.json

@@ -1,7 +1,7 @@
 {
-  "tag": "0.14.0",
+  "tag": "0.14.2",
   "distance": 0,
-  "node": "g05515738dee6f771bb6c3defdb08901548b04be0",
+  "node": "gb73ae6cbc61e57756b26a7bb9ea3fd79957d7a89",
   "dirty": false,
   "branch": "HEAD",
   "node_date": "2026-10-10"

pysmarthashtag-0.14.2/pysmarthashtag/control/climate.py

@@ -0,0 +1,314 @@
+"""Provides an accessible controll of the vehicle's climate functions."""
+
+import json
+import logging
+from enum import Enum
+from typing import TypedDict
+
+from pysmarthashtag.account import SmartAccount
+from pysmarthashtag.api import utils
+from pysmarthashtag.api.client import SmartClient
+from pysmarthashtag.const import API_TELEMATICS_URL
+from pysmarthashtag.control.telematics import send_telematics_command
+from pysmarthashtag.models import SmartHumanCarConnectionError, SmartTokenRefreshNecessary
+
+_LOGGER = logging.getLogger(__name__)
+
+
+class ServiceParameter(TypedDict):
+    """TypedDict for service parameters."""
+
+    key: str
+    value: str
+
+
+class HeatingLocation(str, Enum):
+    """Enum for heating locations in the vehicle."""
+
+    DRIVER_SEAT = "front-left"
+    PASSENGER_SEAT = "front-right"
+    STEERING_WHEEL = "steering_wheel"
+
+
+class VentilationLocation(str, Enum):
+    """Enum for ventilated seats (Smart #5 only)."""
+
+    DRIVER_SEAT = "front-left"
+    PASSENGER_SEAT = "front-right"
+
+
+class RearHeatingLocation(str, Enum):
+    """Enum for heated rear seats (Smart #5 only)."""
+
+    REAR_LEFT = "rear-left"
+    REAR_RIGHT = "rear-right"
+
+
+# ZAF service parameter keys of the Smart #5 comfort functions
+ZAF_HEATING_KEYS = {
+    HeatingLocation.DRIVER_SEAT: "SH.11",
+    HeatingLocation.PASSENGER_SEAT: "SH.19",
+    HeatingLocation.STEERING_WHEEL: "SW",
+}
+ZAF_VENTILATION_KEYS = {
+    VentilationLocation.DRIVER_SEAT: "SV.11",
+    VentilationLocation.PASSENGER_SEAT: "SV.19",
+}
+ZAF_REAR_HEATING_KEYS = {
+    RearHeatingLocation.REAR_LEFT: "SH.21",
+    RearHeatingLocation.REAR_RIGHT: "SH.29",
+}
+ZAF_ALL_COMFORT_KEYS = ("AC", "SH.11", "SH.19", "SH.21", "SH.29", "SW", "DF", "SV.11", "SV.19")
+
+
+class ClimateControll:
+    """Provides an accessible controll of the vehicle's climate functions."""
+
+    BASE_PAYLOAD_TEMPLATE = {
+        "creator": "tc",
+        "operationScheduling": {
+            "duration": 180,
+            "interval": 0,
+            "occurs": 1,
+            "recurrentOperation": False,
+        },
+        "serviceId": "RCE_2",
+    }
+    DEFROST_DURATION = 90
+
+    def __init__(self, account: SmartAccount, vin: str, use_zaf: bool = False):
+        """Initialize the vehicle.
+
+        ``use_zaf`` selects the newer ZAF request format used by the Smart #5
+        instead of the legacy RCE_2 payload of the #1/#3.
+        """
+        self.use_zaf = use_zaf
+        self.account = account
+        self.config = account.config
+        self.vin = vin
+        self.conditioning_temp = 20.0
+        self.heating_levels: dict[HeatingLocation, int] = {
+            HeatingLocation.DRIVER_SEAT: 0,
+            HeatingLocation.PASSENGER_SEAT: 0,
+            HeatingLocation.STEERING_WHEEL: 0,
+        }
+        self.ventilation_levels: dict[VentilationLocation, int] = {
+            VentilationLocation.DRIVER_SEAT: 0,
+            VentilationLocation.PASSENGER_SEAT: 0,
+        }
+        self.rear_heating_levels: dict[RearHeatingLocation, int] = {
+            RearHeatingLocation.REAR_LEFT: 0,
+            RearHeatingLocation.REAR_RIGHT: 0,
+        }
+
+    def _get_zaf_payload(self, active: bool) -> str:
+        """Build the Smart #5 ZAF request. Start and stop both use ``command: start``."""
+        params: dict[str, str] = {"operation": "4"}
+        if active:
+            params["AC"] = "true"
+            params["AC.temp"] = f"{self.conditioning_temp:.1f}"
+            params["AC.duration"] = "180"
+            for key in ZAF_ALL_COMFORT_KEYS[1:]:
+                params[key] = "false"
+            comfort = {
+                **{ZAF_HEATING_KEYS[loc]: lvl for loc, lvl in self.heating_levels.items()},
+                **{ZAF_VENTILATION_KEYS[loc]: lvl for loc, lvl in self.ventilation_levels.items()},
+                **{ZAF_REAR_HEATING_KEYS[loc]: lvl for loc, lvl in self.rear_heating_levels.items()},
+            }
+            for key, level in comfort.items():
+                if level > 0:
+                    params[key] = "true"
+                    params[f"{key}.level"] = str(level)
+        else:
+            for key in ZAF_ALL_COMFORT_KEYS:
+                params[key] = "false"
+        payload = {
+            "serviceId": "ZAF",
+            "command": "start",
+            "creator": "tc",
+            "latest": False,
+            "timeStamp": utils.create_correct_timestamp(),
+            "userId": str(self.config.authentication.api_user_id),
+            "operationScheduling": {
+                "scheduledTime": None,
+                "interval": 0,
+                "occurs": 0,
+                "recurrentOperation": 1,
+                "duration": 60,
+            },
+            "serviceParameters": [{"key": k, "value": v} for k, v in params.items()],
+        }
+        return json.dumps(payload).replace(" ", "")
+
+    def set_ventilation_level(self, location: VentilationLocation, level: int):
+        """Set the (Smart #5) seat ventilation level; selecting one clears the seat's heating."""
+        if not self.use_zaf:
+            raise NotImplementedError("Seat ventilation is only supported on the Smart #5")
+        if not isinstance(level, int) or isinstance(level, bool):
+            raise TypeError("Ventilation level must be an integer")
+        if level > 3 or level < 0:
+            raise ValueError("Seat ventilation level must be between 0 and 3.")
+        self.ventilation_levels[location] = level
+        if level > 0:
+            self.heating_levels[HeatingLocation(location.value)] = 0
+
+    def set_rear_heating_level(self, location: RearHeatingLocation, level: int):
+        """Set the (Smart #5) rear seat heating level."""
+        if not self.use_zaf:
+            raise NotImplementedError("Rear seat heating is only supported on the Smart #5")
+        if not isinstance(level, int) or isinstance(level, bool):
+            raise TypeError("Heating level must be an integer")
+        if level > 3 or level < 0:
+            raise ValueError("Seat heating level must be between 0 and 3.")
+        self.rear_heating_levels[location] = level
+
+    def _get_payload(self, active: bool) -> str:
+        _payload = self.BASE_PAYLOAD_TEMPLATE.copy()
+        _payload["command"] = "stop" if not active else "start"
+        _payload["timestamp"] = utils.create_correct_timestamp()
+        _payload["serviceParameters"] = []
+        _payload["serviceParameters"].append({"key": "rce.conditioner", "value": "1"})
+        _payload["serviceParameters"].append({"key": "rce.temp", "value": f"{self.conditioning_temp:.1f}"})
+        for loc, level in self.heating_levels.items():
+            if level > 0:
+                _payload["serviceParameters"] += self._add_rce_heating_service(loc, f"{level}")
+
+        return json.dumps(_payload).replace(" ", "")
+
+    def _add_rce_heating_service(self, value: str, level: int) -> list[ServiceParameter]:
+        """Create heating service parameters for the payload.
+
+        Args:
+        ----
+            value: The heating location identifier
+            level: The heating level as a string
+
+        Returns:
+        -------
+            List of service parameter dictionaries
+
+        """
+        payload = [{"key": "rce.heat", "value": value}, {"key": "rce.level", "value": level}]
+        return payload
+
+    def set_heating_level(self, location: HeatingLocation, level: int):
+        """Set heating level for the specified location."""
+        if not isinstance(level, int):
+            raise TypeError("Heating level must be an integer")
+        if level > 3 or level < 0:
+            raise ValueError("Seat heating level must be between 0 and 3.")
+        self.heating_levels[location] = level
+        if level > 0 and self.use_zaf and location != HeatingLocation.STEERING_WHEEL:
+            self.ventilation_levels[VentilationLocation(location.value)] = 0
+
+    async def set_climate_conditioning(self, temp: float, active: bool) -> bool:
+        """Set the climate conditioning."""
+
+        # A complete stop on the #5 sends all comfort functions off and needs no temperature
+        if active or not self.use_zaf:
+            if not isinstance(temp, (int, float)):
+                raise TypeError("Temperature must be a number")
+            if temp < 16 or temp > 30:
+                raise ValueError("Temperature must be between 16 and 30 degrees.")
+            self.conditioning_temp = float(temp)
+
+        _LOGGER.debug("Setting climate conditioning: active=%s, temp=%s", active, temp)
+        if self.use_zaf:
+            return (await send_telematics_command(self.account, self.vin, self._get_zaf_payload(active))) is True
+        return await self._send_rce_command(self._get_payload(active))
+
+    def _get_heating_payload(self, active: bool, levels: dict[HeatingLocation, int]) -> str:
+        _payload = self.BASE_PAYLOAD_TEMPLATE.copy()
+        _payload["command"] = "start" if active else "stop"
+        _payload["timestamp"] = utils.create_correct_timestamp()
+        _payload["serviceParameters"] = []
+        if active:
+            for loc, level in levels.items():
+                _payload["serviceParameters"] += self._add_rce_heating_service(loc, f"{level}")
+        else:
+            # Same as the Hello Smart app: list every location, then level 0
+            for loc in levels:
+                _payload["serviceParameters"].append({"key": "rce.heat", "value": loc})
+            _payload["serviceParameters"].append({"key": "rce.level", "value": "0"})
+        return json.dumps(_payload).replace(" ", "")
+
+    async def set_heating(self, active: bool, levels: dict[HeatingLocation, int]) -> bool:
+        """Start or stop seat / steering wheel heating without climate conditioning.
+
+        Unlike set_climate_conditioning, the RCE_2 command carries no
+        rce.conditioner / rce.temp, so the air conditioning is not started.
+        The levels given here are used as-is and do not change heating_levels.
+
+        Args:
+        ----
+            active: True to start heating, False to stop it
+            levels: Heating level (1-3) per location; only the keys are used to stop
+
+        """
+        if not isinstance(active, bool):
+            raise TypeError("Heating state must be a boolean")
+        if not levels:
+            raise ValueError("At least one heating location is required.")
+        for level in levels.values():
+            if not isinstance(level, int):
+                raise TypeError("Heating level must be an integer")
+            if active and (level > 3 or level < 1):
+                raise ValueError("Heating level must be between 1 and 3 to start heating.")
+
+        _LOGGER.debug("Setting heating: active=%s, levels=%s", active, levels)
+        return await self._send_rce_command(self._get_heating_payload(active, levels))
+
+    def _get_defrost_payload(self, active: bool) -> str:
+        _payload = self.BASE_PAYLOAD_TEMPLATE.copy()
+        _payload["command"] = "start" if active else "stop"
+        _payload["timestamp"] = utils.create_correct_timestamp()
+        _payload["operationScheduling"] = {
+            **self.BASE_PAYLOAD_TEMPLATE["operationScheduling"],
+            "duration": self.DEFROST_DURATION if active else 0,
+        }
+        _payload["serviceParameters"] = [
+            {"key": "rce.conditioner", "value": "2"},
+            {"key": "rce.level", "value": "2"},
+        ]
+        return json.dumps(_payload).replace(" ", "")
+
+    async def set_defrost(self, active: bool) -> bool:
+        """Start or stop the front windscreen defrost."""
+        if not isinstance(active, bool):
+            raise TypeError("Defrost state must be a boolean")
+        _LOGGER.debug("Setting front windscreen defrost: active=%s", active)
+        return await self._send_rce_command(self._get_defrost_payload(active))
+
+    async def _send_rce_command(self, params: str) -> bool:
+        """Send a remote climate command to the vehicle."""
+        # Ensure SSL context is created before using the client
+        await self.account._ensure_ssl_context()
+
+        await self.account.select_active_vehicle(self.vin)
+
+        async with SmartClient(self.config) as client:
+            for retry in range(3):
+                try:
+                    vehicles_response = await client.put(
+                        self.account.vehicles[self.vin].base_url + API_TELEMATICS_URL + self.vin,
+                        headers={
+                            **utils.generate_default_header(
+                                client.config.authentication.device_id,
+                                client.config.authentication.api_access_token,
+                                params={},
+                                method="PUT",
+                                url=API_TELEMATICS_URL + self.vin,
+                                body=params,
+                            )
+                        },
+                        content=params.encode("utf-8"),
+                    )
+                    api_result = vehicles_response.json()
+                    return api_result["success"]
+                except SmartTokenRefreshNecessary:
+                    _LOGGER.debug("Got Token Error, retry: %d", retry)
+                    continue
+                except SmartHumanCarConnectionError:
+                    _LOGGER.debug("Got Human Car Connection Error, retry: %d", retry)
+                    continue
+        return False

{pysmarthashtag-0.14.0 → pysmarthashtag-0.14.2}/pysmarthashtag/tests/test_actions.py

@@ -131,3 +131,74 @@ async def test_set_defrost_invalid_state(smart_fixture: respx.Router):
 
     with pytest.raises(TypeError):
         await climate_ctrl.set_defrost("on")
+
+
+@pytest.mark.asyncio
+async def test_set_heating_start_sends_heat_only(smart_fixture: respx.Router):
+    """Test that set_heating starts heating without climate conditioning parameters."""
+    account = await prepare_account_with_vehicles()
+    await account.get_vehicle_information("TestVIN0000000001")
+    climate_ctrl = account.vehicles["TestVIN0000000001"].climate_control
+
+    result = await climate_ctrl.set_heating(True, {HeatingLocation.DRIVER_SEAT: 3, HeatingLocation.PASSENGER_SEAT: 1})
+
+    assert result
+    payload = _last_telematics_payload(smart_fixture)
+    assert payload["serviceId"] == "RCE_2"
+    assert payload["command"] == "start"
+    assert payload["serviceParameters"] == [
+        {"key": "rce.heat", "value": "front-left"},
+        {"key": "rce.level", "value": "3"},
+        {"key": "rce.heat", "value": "front-right"},
+        {"key": "rce.level", "value": "1"},
+    ]
+
+
+@pytest.mark.asyncio
+async def test_set_heating_stop_sets_level_zero(smart_fixture: respx.Router):
+    """Test that set_heating stops all given locations with level 0."""
+    account = await prepare_account_with_vehicles()
+    await account.get_vehicle_information("TestVIN0000000001")
+    climate_ctrl = account.vehicles["TestVIN0000000001"].climate_control
+
+    await climate_ctrl.set_heating(False, {HeatingLocation.STEERING_WHEEL: 0})
+
+    payload = _last_telematics_payload(smart_fixture)
+    assert payload["command"] == "stop"
+    assert payload["serviceParameters"] == [
+        {"key": "rce.heat", "value": "steering_wheel"},
+        {"key": "rce.level", "value": "0"},
+    ]
+
+
+@pytest.mark.asyncio
+async def test_set_heating_does_not_change_conditioning_levels(smart_fixture: respx.Router):
+    """Test that set_heating leaves the levels used for climate conditioning untouched."""
+    account = await prepare_account_with_vehicles()
+    await account.get_vehicle_information("TestVIN0000000001")
+    climate_ctrl = account.vehicles["TestVIN0000000001"].climate_control
+
+    await climate_ctrl.set_heating(True, {HeatingLocation.DRIVER_SEAT: 3})
+
+    assert climate_ctrl.heating_levels[HeatingLocation.DRIVER_SEAT] == 0
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize(
+    ("active", "levels", "exc"),
+    [
+        (True, {}, ValueError),
+        (True, {HeatingLocation.DRIVER_SEAT: 0}, ValueError),
+        (True, {HeatingLocation.DRIVER_SEAT: 4}, ValueError),
+        (True, {HeatingLocation.DRIVER_SEAT: "3"}, TypeError),
+        ("on", {HeatingLocation.DRIVER_SEAT: 3}, TypeError),
+    ],
+)
+async def test_set_heating_invalid_input(smart_fixture: respx.Router, active, levels, exc):
+    """Test that set_heating rejects invalid input."""
+    account = await prepare_account_with_vehicles()
+    await account.get_vehicle_information("TestVIN0000000001")
+    climate_ctrl = account.vehicles["TestVIN0000000001"].climate_control
+
+    with pytest.raises(exc):
+        await climate_ctrl.set_heating(active, levels)

pysmarthashtag-0.14.2/pysmarthashtag/tests/test_climate_zaf.py

@@ -0,0 +1,94 @@
+"""Tests for the Smart #5 ZAF climate payload with seat ventilation."""
+
+import json
+from types import SimpleNamespace
+
+import pytest
+
+from pysmarthashtag.control.climate import ClimateControll, HeatingLocation, VentilationLocation
+
+
+def _ctrl(use_zaf: bool = True) -> ClimateControll:
+    account = SimpleNamespace(config=SimpleNamespace(authentication=SimpleNamespace(api_user_id=42)))
+    return ClimateControll(account, "VIN", use_zaf=use_zaf)
+
+
+def _params(payload: str) -> dict:
+    return {p["key"]: p["value"] for p in json.loads(payload)["serviceParameters"]}
+
+
+def test_start_with_ventilation():
+    ctrl = _ctrl()
+    ctrl.conditioning_temp = 21.0
+    ctrl.set_ventilation_level(VentilationLocation.DRIVER_SEAT, 2)
+    ctrl.set_heating_level(HeatingLocation.PASSENGER_SEAT, 3)
+    payload = json.loads(ctrl._get_zaf_payload(True))
+    assert payload["serviceId"] == "ZAF"
+    assert payload["command"] == "start"
+    assert payload["userId"] == "42"
+    assert payload["latest"] is False
+    params = _params(json.dumps(payload))
+    assert params["operation"] == "4"
+    assert params["AC"] == "true" and params["AC.temp"] == "21.0"
+    assert params["SV.11"] == "true" and params["SV.11.level"] == "2"
+    assert params["SH.19"] == "true" and params["SH.19.level"] == "3"
+    assert params["SH.11"] == "false" and "SH.11.level" not in params
+    assert params["SV.19"] == "false"
+
+
+def test_heating_and_ventilation_are_exclusive():
+    ctrl = _ctrl()
+    ctrl.set_heating_level(HeatingLocation.DRIVER_SEAT, 1)
+    ctrl.set_ventilation_level(VentilationLocation.DRIVER_SEAT, 3)
+    assert ctrl.heating_levels[HeatingLocation.DRIVER_SEAT] == 0
+    ctrl.set_heating_level(HeatingLocation.DRIVER_SEAT, 2)
+    assert ctrl.ventilation_levels[VentilationLocation.DRIVER_SEAT] == 0
+
+
+def test_stop_is_all_off():
+    ctrl = _ctrl()
+    ctrl.set_ventilation_level(VentilationLocation.DRIVER_SEAT, 2)
+    params = _params(ctrl._get_zaf_payload(False))
+    assert json.loads(ctrl._get_zaf_payload(False))["command"] == "start"
+    assert params["operation"] == "4"
+    for key in ("AC", "SH.11", "SH.19", "SH.21", "SH.29", "SW", "DF", "SV.11", "SV.19"):
+        assert params[key] == "false"
+
+
+def test_invalid_level_and_legacy_rejected():
+    ctrl = _ctrl()
+    with pytest.raises(ValueError):
+        ctrl.set_ventilation_level(VentilationLocation.DRIVER_SEAT, 4)
+    with pytest.raises(NotImplementedError):
+        _ctrl(use_zaf=False).set_ventilation_level(VentilationLocation.DRIVER_SEAT, 1)
+
+
+def test_rear_heating_and_all_keys_string_values():
+    from pysmarthashtag.control.climate import RearHeatingLocation
+
+    ctrl = _ctrl()
+    ctrl.set_rear_heating_level(RearHeatingLocation.REAR_LEFT, 2)
+    params = _params(ctrl._get_zaf_payload(True))
+    assert params["SH.21"] == "true" and params["SH.21.level"] == "2"
+    assert params["SH.29"] == "false" and "SH.29.level" not in params
+    with pytest.raises(ValueError):
+        ctrl.set_rear_heating_level(RearHeatingLocation.REAR_LEFT, 4)
+    with pytest.raises(NotImplementedError):
+        _ctrl(use_zaf=False).set_rear_heating_level(RearHeatingLocation.REAR_LEFT, 1)
+
+
+@pytest.mark.asyncio
+async def test_stop_works_with_corrupt_temperature(monkeypatch):
+    sent = []
+
+    async def fake_send(account, vin, payload):
+        sent.append(payload)
+        return True
+
+    monkeypatch.setattr("pysmarthashtag.control.climate.send_telematics_command", fake_send)
+    ctrl = _ctrl()
+    assert await ctrl.set_climate_conditioning("garbage", False) is True
+    assert all(p["value"] == "false" or p["key"] == "operation" for p in json.loads(sent[0])["serviceParameters"])
+    with pytest.raises(TypeError):
+        await ctrl.set_climate_conditioning("garbage", True)
+    assert len(sent) == 1

{pysmarthashtag-0.14.0 → pysmarthashtag-0.14.2}/pysmarthashtag/vehicle/vehicle.py

@@ -162,7 +162,11 @@ class SmartVehicle:
 
         from pysmarthashtag.control.climate import ClimateControll
 
-        self.climate_control = ClimateControll(self.account, self.vin)
+        self.climate_control = ClimateControll(
+            self.account,
+            self.vin,
+            use_zaf=str(self.data.get("seriesCodeVs", "")).startswith(SERIES_CODE_PREFIX_SMART_5),
+        )
 
         from pysmarthashtag.control.charging import ChargingControl
 

pysmarthashtag-0.14.0/pysmarthashtag/control/climate.py

@@ -1,161 +0,0 @@
-"""Provides an accessible controll of the vehicle's climate functions."""
-
-import json
-import logging
-from enum import Enum
-from typing import TypedDict
-
-from pysmarthashtag.account import SmartAccount
-from pysmarthashtag.api import utils
-from pysmarthashtag.api.client import SmartClient
-from pysmarthashtag.const import API_TELEMATICS_URL
-from pysmarthashtag.models import SmartHumanCarConnectionError, SmartTokenRefreshNecessary
-
-_LOGGER = logging.getLogger(__name__)
-
-
-class ServiceParameter(TypedDict):
-    """TypedDict for service parameters."""
-
-    key: str
-    value: str
-
-
-class HeatingLocation(str, Enum):
-    """Enum for heating locations in the vehicle."""
-
-    DRIVER_SEAT = "front-left"
-    PASSENGER_SEAT = "front-right"
-    STEERING_WHEEL = "steering_wheel"
-
-
-class ClimateControll:
-    """Provides an accessible controll of the vehicle's climate functions."""
-
-    BASE_PAYLOAD_TEMPLATE = {
-        "creator": "tc",
-        "operationScheduling": {
-            "duration": 180,
-            "interval": 0,
-            "occurs": 1,
-            "recurrentOperation": False,
-        },
-        "serviceId": "RCE_2",
-    }
-    DEFROST_DURATION = 90
-
-    def __init__(self, account: SmartAccount, vin: str):
-        """Initialize the vehicle."""
-        self.account = account
-        self.config = account.config
-        self.vin = vin
-        self.conditioning_temp = 20.0
-        self.heating_levels: dict[HeatingLocation, int] = {
-            HeatingLocation.DRIVER_SEAT: 0,
-            HeatingLocation.PASSENGER_SEAT: 0,
-            HeatingLocation.STEERING_WHEEL: 0,
-        }
-
-    def _get_payload(self, active: bool) -> str:
-        _payload = self.BASE_PAYLOAD_TEMPLATE.copy()
-        _payload["command"] = "stop" if not active else "start"
-        _payload["timestamp"] = utils.create_correct_timestamp()
-        _payload["serviceParameters"] = []
-        _payload["serviceParameters"].append({"key": "rce.conditioner", "value": "1"})
-        _payload["serviceParameters"].append({"key": "rce.temp", "value": f"{self.conditioning_temp:.1f}"})
-        for loc, level in self.heating_levels.items():
-            if level > 0:
-                _payload["serviceParameters"] += self._add_rce_heating_service(loc, f"{level}")
-
-        return json.dumps(_payload).replace(" ", "")
-
-    def _add_rce_heating_service(self, value: str, level: int) -> list[ServiceParameter]:
-        """Create heating service parameters for the payload.
-
-        Args:
-        ----
-            value: The heating location identifier
-            level: The heating level as a string
-
-        Returns:
-        -------
-            List of service parameter dictionaries
-
-        """
-        payload = [{"key": "rce.heat", "value": value}, {"key": "rce.level", "value": level}]
-        return payload
-
-    def set_heating_level(self, location: HeatingLocation, level: int):
-        """Set heating level for the specified location."""
-        if not isinstance(level, int):
-            raise TypeError("Heating level must be an integer")
-        if level > 3 or level < 0:
-            raise ValueError("Seat heating level must be between 0 and 3.")
-        self.heating_levels[location] = level
-
-    async def set_climate_conditioning(self, temp: float, active: bool) -> bool:
-        """Set the climate conditioning."""
-
-        if not isinstance(temp, (int, float)):
-            raise TypeError("Temperature must be a number")
-        if temp < 16 or temp > 30:
-            raise ValueError("Temperature must be between 16 and 30 degrees.")
-        self.conditioning_temp = float(temp)
-
-        _LOGGER.debug("Setting climate conditioning: active=%s, temp=%.1f", active, self.conditioning_temp)
-        return await self._send_rce_command(self._get_payload(active))
-
-    def _get_defrost_payload(self, active: bool) -> str:
-        _payload = self.BASE_PAYLOAD_TEMPLATE.copy()
-        _payload["command"] = "start" if active else "stop"
-        _payload["timestamp"] = utils.create_correct_timestamp()
-        _payload["operationScheduling"] = {
-            **self.BASE_PAYLOAD_TEMPLATE["operationScheduling"],
-            "duration": self.DEFROST_DURATION if active else 0,
-        }
-        _payload["serviceParameters"] = [
-            {"key": "rce.conditioner", "value": "2"},
-            {"key": "rce.level", "value": "2"},
-        ]
-        return json.dumps(_payload).replace(" ", "")
-
-    async def set_defrost(self, active: bool) -> bool:
-        """Start or stop the front windscreen defrost."""
-        if not isinstance(active, bool):
-            raise TypeError("Defrost state must be a boolean")
-        _LOGGER.debug("Setting front windscreen defrost: active=%s", active)
-        return await self._send_rce_command(self._get_defrost_payload(active))
-
-    async def _send_rce_command(self, params: str) -> bool:
-        """Send a remote climate command to the vehicle."""
-        # Ensure SSL context is created before using the client
-        await self.account._ensure_ssl_context()
-
-        await self.account.select_active_vehicle(self.vin)
-
-        async with SmartClient(self.config) as client:
-            for retry in range(3):
-                try:
-                    vehicles_response = await client.put(
-                        self.account.vehicles[self.vin].base_url + API_TELEMATICS_URL + self.vin,
-                        headers={
-                            **utils.generate_default_header(
-                                client.config.authentication.device_id,
-                                client.config.authentication.api_access_token,
-                                params={},
-                                method="PUT",
-                                url=API_TELEMATICS_URL + self.vin,
-                                body=params,
-                            )
-                        },
-                        content=params.encode("utf-8"),
-                    )
-                    api_result = vehicles_response.json()
-                    return api_result["success"]
-                except SmartTokenRefreshNecessary:
-                    _LOGGER.debug("Got Token Error, retry: %d", retry)
-                    continue
-                except SmartHumanCarConnectionError:
-                    _LOGGER.debug("Got Human Car Connection Error, retry: %d", retry)
-                    continue
-        return False