pvw-cli 1.14.2__tar.gz → 1.14.4__tar.gz

{pvw_cli-1.14.2/pvw_cli.egg-info → pvw_cli-1.14.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pvw-cli
-Version: 1.14.2
+Version: 1.14.4
 Summary: Microsoft Purview CLI with comprehensive automation capabilities
 Author-email: AYOUB KEBAILI <keayoub@msn.com>
 Maintainer-email: AYOUB KEBAILI <keayoub@msn.com>
@@ -61,7 +61,7 @@ Dynamic: license-file
 
 # pvw-cli — Microsoft Purview Command-Line Interface
 
-[![Version](https://img.shields.io/badge/version-1.11.18-blue.svg)](https://github.com/Keayoub/pvw-cli/releases/tag/v1.14.2)
+[![Version](https://img.shields.io/badge/version-1.11.18-blue.svg)](https://github.com/Keayoub/pvw-cli/releases/tag/v1.14.4)
 [![Status](https://img.shields.io/badge/status-stable-success.svg)](https://github.com/Keayoub/pvw-cli)
 [![Docs](https://img.shields.io/badge/docs-github%20pages-0A8F84?logo=githubpages&logoColor=white)](https://keayoub.github.io/pvw-cli/)
 

{pvw_cli-1.14.2 → pvw_cli-1.14.4}/README.md

@@ -1,6 +1,6 @@
 # pvw-cli — Microsoft Purview Command-Line Interface
 
-[![Version](https://img.shields.io/badge/version-1.11.18-blue.svg)](https://github.com/Keayoub/pvw-cli/releases/tag/v1.14.2)
+[![Version](https://img.shields.io/badge/version-1.11.18-blue.svg)](https://github.com/Keayoub/pvw-cli/releases/tag/v1.14.4)
 [![Status](https://img.shields.io/badge/status-stable-success.svg)](https://github.com/Keayoub/pvw-cli)
 [![Docs](https://img.shields.io/badge/docs-github%20pages-0A8F84?logo=githubpages&logoColor=white)](https://keayoub.github.io/pvw-cli/)
 

{pvw_cli-1.14.2 → pvw_cli-1.14.4}/purviewcli/__init__.py

@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: Apache-2.0
 
-__version__ = "1.14.2"
+__version__ = "1.14.4"
 
 # Import main client modules
 from .client import *

{pvw_cli-1.14.2 → pvw_cli-1.14.4}/purviewcli/cli/collections.py

@@ -811,11 +811,17 @@ def resources(collection_name, format, output_json, sort_by, asset_type, data_so
             return
         
         # Build collection map and filter if needed
+        # --collection-name matches against technical name OR friendly name
         target_collections = {}
         for coll in collections_list:
             coll_name = coll.get('name', 'Unknown')
-            if collection_name is None or coll_name == collection_name:
+            friendly_name = coll.get('friendlyName', '')
+            if collection_name is None or coll_name == collection_name or friendly_name == collection_name:
                 target_collections[coll_name] = coll
+
+        if collection_name is not None and not target_collections:
+            click.echo(f"[WARN] No collection found matching '{collection_name}' (checked technical name and friendly name)", err=True)
+            return
         
         # Fetch assets for each target collection
         collections_assets = {}
@@ -824,13 +830,19 @@ def resources(collection_name, format, output_json, sort_by, asset_type, data_so
             click.echo(f"[FETCH] Fetching assets from '{coll_name}'...", err=True)
             
             try:
-                # Build API filter with collectionId and optional entityType
-                filter_dict = {"collectionId": coll_name}
-                
-                # Add entityType filter to API request if specified
+                # Build API filter using the compound AND syntax required by Purview Search API.
+                # A flat dict like {"collectionId": "x", "entityType": "y"} is NOT valid;
+                # multiple conditions must be wrapped in an {"and": [...]} array.
                 if asset_type:
-                    filter_dict["entityType"] = asset_type
-                
+                    filter_dict = {
+                        "and": [
+                            {"collectionId": coll_name},
+                            {"entityType": asset_type}
+                        ]
+                    }
+                else:
+                    filter_dict = {"collectionId": coll_name}
+
                 # Fetch up to 1000 assets per collection (API limit)
                 search_args = {
                     '--filter': json.dumps(filter_dict),

{pvw_cli-1.14.2 → pvw_cli-1.14.4}/purviewcli/cli/unified_catalog.py

@@ -652,13 +652,21 @@ def remove_relationship(product_id, entity_type, entity_id, confirm):
         
         result = client.delete_data_product_relationship(args)
         
-        # DELETE returns 204 No Content on success
-        if result is None or (isinstance(result, dict) and not result.get("error")):
+        # DELETE returns 204 No Content on success.
+        # Error responses carry {"status": "error", "message": "..."} — NOT an "error" key —
+        # so we must check result.get("status") to avoid treating every error as SUCCESS.
+        is_error = isinstance(result, dict) and (
+            result.get("status") == "error"
+            or "error" in result
+        )
+        if result is None or not is_error:
             console.print(f"[green]SUCCESS:[/green] Deleted relationship to {entity_type} '{entity_id}'")
-        elif isinstance(result, dict) and "error" in result:
-            console.print(f"[red]ERROR:[/red] {result.get('error', 'Unknown error')}")
         else:
-            console.print(f"[green]SUCCESS:[/green] Deleted relationship")
+            error_msg = result.get("message") or result.get("error") or "Unknown error"
+            status_code = result.get("status_code", "")
+            detail = f" (HTTP {status_code})" if status_code else ""
+            console.print(f"[red]ERROR:[/red] {error_msg}{detail}")
+            console.print("[dim]Tip: set env var PURVIEWCLI_DEBUG=1 to see the full request/response.[/dim]")
             
     except Exception as e:
         console.print(f"[red]ERROR:[/red] {str(e)}")

{pvw_cli-1.14.2 → pvw_cli-1.14.4}/purviewcli/client/_unified_catalog.py

@@ -1148,12 +1148,13 @@ Use Cases:
         entity_id = args.get("--entity-id", [""])[0]
         
         self.method = "DELETE"
+        # entityId is part of the URL path; entityType is the only query param
         self.endpoint = ENDPOINTS["unified_catalog"]["delete_data_product_relationship"].format(
-            productId=product_id
+            productId=product_id,
+            entityId=entity_id,
         )
         self.params = {
             "entityType": entity_type.upper(),
-            "entityId": entity_id
         }
 
     @decorator

{pvw_cli-1.14.2 → pvw_cli-1.14.4}/purviewcli/client/endpoints.py

@@ -459,7 +459,8 @@ ENDPOINTS = {
         # Data product relationships
         "create_data_product_relationship": "/datagovernance/catalog/dataproducts/{productId}/relationships",
         "list_data_product_relationships": "/datagovernance/catalog/dataproducts/{productId}/relationships",
-        "delete_data_product_relationship": "/datagovernance/catalog/dataproducts/{productId}/relationships",
+        # entityId must be in the URL path (not a query param) for the DELETE to hit the correct resource
+        "delete_data_product_relationship": "/datagovernance/catalog/dataproducts/{productId}/relationships/{entityId}",
         # Data product query
         "query_data_products": "/datagovernance/catalog/dataproducts/query",
         # Terms (UC specific)

{pvw_cli-1.14.2 → pvw_cli-1.14.4/pvw_cli.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pvw-cli
-Version: 1.14.2
+Version: 1.14.4
 Summary: Microsoft Purview CLI with comprehensive automation capabilities
 Author-email: AYOUB KEBAILI <keayoub@msn.com>
 Maintainer-email: AYOUB KEBAILI <keayoub@msn.com>
@@ -61,7 +61,7 @@ Dynamic: license-file
 
 # pvw-cli — Microsoft Purview Command-Line Interface
 
-[![Version](https://img.shields.io/badge/version-1.11.18-blue.svg)](https://github.com/Keayoub/pvw-cli/releases/tag/v1.14.2)
+[![Version](https://img.shields.io/badge/version-1.11.18-blue.svg)](https://github.com/Keayoub/pvw-cli/releases/tag/v1.14.4)
 [![Status](https://img.shields.io/badge/status-stable-success.svg)](https://github.com/Keayoub/pvw-cli)
 [![Docs](https://img.shields.io/badge/docs-github%20pages-0A8F84?logo=githubpages&logoColor=white)](https://keayoub.github.io/pvw-cli/)
 

{pvw_cli-1.14.2 → pvw_cli-1.14.4}/pvw_cli.egg-info/SOURCES.txt

@@ -71,6 +71,7 @@ pvw_cli.egg-info/entry_points.txt
 pvw_cli.egg-info/not-zip-safe
 pvw_cli.egg-info/requires.txt
 pvw_cli.egg-info/top_level.txt
+tests/test_collections_resources_filter.py
 tests/test_copy_data_products.py
 tests/test_copy_entities.py
 tests/test_entity_bulk_read_cli.py
@@ -81,5 +82,6 @@ tests/test_entity_list_cli.py
 tests/test_mcp_server.py
 tests/test_mcp_server_basic.py
 tests/test_relationship_bulk_csv_cli.py
+tests/test_uc_dataproduct_remove_relationship.py
 tests/test_uc_metadata_list_cli.py
 tests/test_unified_catalog_term_update.py

pvw_cli-1.14.4/tests/test_collections_resources_filter.py

@@ -0,0 +1,296 @@
+# SPDX-License-Identifier: Apache-2.0
+"""
+Tests for the two bugs fixed in `pvw collections resources`:
+
+1. --asset-type now sends an {"and": [...]} compound filter to the Search API
+   instead of a flat dict that caused assets from the wrong collection to be returned.
+
+2. --collection-name now resolves against the collection's `friendlyName` field
+   in addition to its technical `name` field.
+"""
+
+import json
+import os
+import sys
+from unittest.mock import MagicMock, call, patch
+
+import pytest
+from click.testing import CliRunner
+
+sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+
+from purviewcli.cli.cli import main
+
+RUNNER = CliRunner()
+
+
+def invoke(*args, **kwargs):
+    return RUNNER.invoke(main, list(args), catch_exceptions=False, **kwargs)
+
+
+# ---------------------------------------------------------------------------
+# Shared fixtures
+# ---------------------------------------------------------------------------
+
+COLLECTIONS_RESPONSE = {
+    "value": [
+        {"name": "col1", "friendlyName": "My First Collection"},
+        {"name": "col2", "friendlyName": "My Second Collection"},
+    ]
+}
+
+ASSET_FABRIC_TABLE = {
+    "id": "aaaa-1111",
+    "name": "Drivers",
+    "entityType": "fabric_lakehouse_table",
+    "assetType": ["Fabric"],
+    "qualifiedName": "https://app.fabric.microsoft.com/groups/xxx/Drivers",
+}
+
+ASSET_POWERBI = {
+    "id": "bbbb-2222",
+    "name": "peakon_verification",
+    "entityType": "powerbi_report",
+    "assetType": ["Power BI"],
+    "qualifiedName": "Power BI/peakon_verification",
+}
+
+
+# ---------------------------------------------------------------------------
+# Bug 1: compound AND filter for --asset-type
+# ---------------------------------------------------------------------------
+
+
+class TestAssetTypeFilterUsesAndSyntax:
+    """The Search API requires {"and": [...]} for compound filters.
+    Sending a flat dict {"collectionId": "x", "entityType": "y"} caused the
+    collectionId restriction to be ignored, returning assets from all collections.
+    """
+
+    @patch("purviewcli.cli.collections.Collections")
+    @patch("purviewcli.client._search.Search")
+    def test_no_asset_type_sends_plain_collectionid_filter(
+        self, mock_search_cls, mock_collections_cls
+    ):
+        """Without --asset-type the filter stays a simple {"collectionId": "..."} dict."""
+        mock_collections = MagicMock()
+        mock_collections_cls.return_value = mock_collections
+        mock_collections.collectionsRead.return_value = COLLECTIONS_RESPONSE
+
+        mock_search = MagicMock()
+        mock_search_cls.return_value = mock_search
+        mock_search.searchQuery.return_value = {"value": [ASSET_FABRIC_TABLE]}
+
+        result = invoke("collections", "resources", "--collection-name", "col1", "--format", "json")
+
+        assert result.exit_code == 0, result.output
+        mock_search.searchQuery.assert_called_once()
+        call_args = mock_search.searchQuery.call_args[0][0]
+        sent_filter = json.loads(call_args["--filter"])
+
+        # Must be a plain dict, not wrapped in "and"
+        assert "and" not in sent_filter
+        assert sent_filter.get("collectionId") == "col1"
+
+    @patch("purviewcli.cli.collections.Collections")
+    @patch("purviewcli.client._search.Search")
+    def test_with_asset_type_sends_and_compound_filter(
+        self, mock_search_cls, mock_collections_cls
+    ):
+        """With --asset-type the filter must use {"and": [{collectionId}, {entityType}]}."""
+        mock_collections = MagicMock()
+        mock_collections_cls.return_value = mock_collections
+        mock_collections.collectionsRead.return_value = COLLECTIONS_RESPONSE
+
+        mock_search = MagicMock()
+        mock_search_cls.return_value = mock_search
+        mock_search.searchQuery.return_value = {"value": [ASSET_FABRIC_TABLE]}
+
+        result = invoke(
+            "collections",
+            "resources",
+            "--collection-name",
+            "col1",
+            "--asset-type",
+            "fabric_lakehouse_table",
+            "--format",
+            "json",
+        )
+
+        assert result.exit_code == 0, result.output
+        mock_search.searchQuery.assert_called_once()
+        call_args = mock_search.searchQuery.call_args[0][0]
+        sent_filter = json.loads(call_args["--filter"])
+
+        # MUST use the compound AND syntax
+        assert "and" in sent_filter, (
+            "Expected {'and': [...]} compound filter but got: " + json.dumps(sent_filter)
+        )
+        conditions = sent_filter["and"]
+        assert isinstance(conditions, list) and len(conditions) == 2
+
+        coll_condition = next((c for c in conditions if "collectionId" in c), None)
+        type_condition = next((c for c in conditions if "entityType" in c), None)
+
+        assert coll_condition is not None, "Missing collectionId condition"
+        assert type_condition is not None, "Missing entityType condition"
+        assert coll_condition["collectionId"] == "col1"
+        assert type_condition["entityType"] == "fabric_lakehouse_table"
+
+    @patch("purviewcli.cli.collections.Collections")
+    @patch("purviewcli.client._search.Search")
+    def test_flat_filter_is_NOT_sent_when_asset_type_given(
+        self, mock_search_cls, mock_collections_cls
+    ):
+        """Regression: the old broken form {"collectionId": x, "entityType": y} must not appear."""
+        mock_collections = MagicMock()
+        mock_collections_cls.return_value = mock_collections
+        mock_collections.collectionsRead.return_value = COLLECTIONS_RESPONSE
+
+        mock_search = MagicMock()
+        mock_search_cls.return_value = mock_search
+        mock_search.searchQuery.return_value = {"value": []}
+
+        invoke(
+            "collections",
+            "resources",
+            "--collection-name",
+            "col1",
+            "--asset-type",
+            "fabric_lakehouse_table",
+        )
+
+        call_args = mock_search.searchQuery.call_args[0][0]
+        sent_filter = json.loads(call_args["--filter"])
+
+        # The old broken flat form must NOT appear
+        assert not (
+            "collectionId" in sent_filter and "entityType" in sent_filter
+        ), "Found old flat filter — collectionId+entityType must not be top-level siblings"
+
+    @patch("purviewcli.cli.collections.Collections")
+    @patch("purviewcli.client._search.Search")
+    def test_asset_type_filter_only_fetches_matching_collection(
+        self, mock_search_cls, mock_collections_cls
+    ):
+        """Only the targeted collection should be queried when --collection-name is given."""
+        mock_collections = MagicMock()
+        mock_collections_cls.return_value = mock_collections
+        mock_collections.collectionsRead.return_value = COLLECTIONS_RESPONSE
+
+        mock_search = MagicMock()
+        mock_search_cls.return_value = mock_search
+        mock_search.searchQuery.return_value = {"value": [ASSET_FABRIC_TABLE]}
+
+        invoke(
+            "collections",
+            "resources",
+            "--collection-name",
+            "col1",
+            "--asset-type",
+            "fabric_lakehouse_table",
+        )
+
+        # searchQuery called exactly once — only for col1, not col2
+        assert mock_search.searchQuery.call_count == 1
+
+
+# ---------------------------------------------------------------------------
+# Bug 2: --collection-name resolves friendly name
+# ---------------------------------------------------------------------------
+
+
+class TestCollectionNameFriendlyNameResolution:
+    """--collection-name should match either the technical 'name' or 'friendlyName'."""
+
+    @patch("purviewcli.cli.collections.Collections")
+    @patch("purviewcli.client._search.Search")
+    def test_technical_name_still_works(self, mock_search_cls, mock_collections_cls):
+        """Existing behaviour: match by technical short-id is preserved."""
+        mock_collections = MagicMock()
+        mock_collections_cls.return_value = mock_collections
+        mock_collections.collectionsRead.return_value = COLLECTIONS_RESPONSE
+
+        mock_search = MagicMock()
+        mock_search_cls.return_value = mock_search
+        mock_search.searchQuery.return_value = {"value": [ASSET_FABRIC_TABLE]}
+
+        result = invoke("collections", "resources", "--collection-name", "col2", "--format", "json")
+
+        assert result.exit_code == 0, result.output
+        assert mock_search.searchQuery.call_count == 1
+        call_args = mock_search.searchQuery.call_args[0][0]
+        sent_filter = json.loads(call_args["--filter"])
+        assert sent_filter.get("collectionId") == "col2"
+
+    @patch("purviewcli.cli.collections.Collections")
+    @patch("purviewcli.client._search.Search")
+    def test_friendly_name_is_resolved_to_technical_name(
+        self, mock_search_cls, mock_collections_cls
+    ):
+        """New behaviour: passing the friendly name must find and query the correct collection."""
+        mock_collections = MagicMock()
+        mock_collections_cls.return_value = mock_collections
+        mock_collections.collectionsRead.return_value = COLLECTIONS_RESPONSE
+
+        mock_search = MagicMock()
+        mock_search_cls.return_value = mock_search
+        mock_search.searchQuery.return_value = {"value": [ASSET_POWERBI]}
+
+        result = invoke(
+            "collections",
+            "resources",
+            "--collection-name",
+            "My Second Collection",  # friendly name, not technical "col2"
+            "--format",
+            "json",
+        )
+
+        assert result.exit_code == 0, result.output
+        # Must have queried exactly one collection
+        assert mock_search.searchQuery.call_count == 1
+        call_args = mock_search.searchQuery.call_args[0][0]
+        sent_filter = json.loads(call_args["--filter"])
+        # And the filter must use the TECHNICAL name "col2", not the friendly name
+        assert sent_filter.get("collectionId") == "col2", (
+            f"Expected collectionId='col2' but got '{sent_filter.get('collectionId')}'"
+        )
+
+    @patch("purviewcli.cli.collections.Collections")
+    @patch("purviewcli.client._search.Search")
+    def test_unknown_name_prints_warning_and_returns(
+        self, mock_search_cls, mock_collections_cls
+    ):
+        """An unrecognised collection name must emit a warning and NOT call the Search API."""
+        mock_collections = MagicMock()
+        mock_collections_cls.return_value = mock_collections
+        mock_collections.collectionsRead.return_value = COLLECTIONS_RESPONSE
+
+        mock_search = MagicMock()
+        mock_search_cls.return_value = mock_search
+
+        result = invoke(
+            "collections", "resources", "--collection-name", "does-not-exist"
+        )
+
+        assert result.exit_code == 0, result.output
+        mock_search.searchQuery.assert_not_called()
+
+    @patch("purviewcli.cli.collections.Collections")
+    @patch("purviewcli.client._search.Search")
+    def test_no_collection_name_queries_all_collections(
+        self, mock_search_cls, mock_collections_cls
+    ):
+        """Without --collection-name every collection in the account is queried."""
+        mock_collections = MagicMock()
+        mock_collections_cls.return_value = mock_collections
+        mock_collections.collectionsRead.return_value = COLLECTIONS_RESPONSE
+
+        mock_search = MagicMock()
+        mock_search_cls.return_value = mock_search
+        mock_search.searchQuery.return_value = {"value": []}
+
+        invoke("collections", "resources")
+
+        # Two collections in the fixture -> two Search API calls
+        assert mock_search.searchQuery.call_count == 2

pvw_cli-1.14.4/tests/test_uc_dataproduct_remove_relationship.py

@@ -0,0 +1,261 @@
+# SPDX-License-Identifier: Apache-2.0
+"""
+Tests for the two bugs fixed in `pvw uc dataproduct remove-relationship`:
+
+1. The DELETE endpoint now has {entityId} in the URL path
+   (previously it was sent only as a query param, which the Purview API ignores for DELETE).
+
+2. API errors are now surfaced to the user correctly.
+   Previously, any response without a literal "error" key was printed as SUCCESS,
+   masking real HTTP errors (404, 403, 400, ...).
+"""
+
+import os
+import sys
+from unittest.mock import MagicMock, patch
+
+import pytest
+from click.testing import CliRunner
+
+sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+
+from purviewcli.cli.cli import main
+from purviewcli.client._unified_catalog import UnifiedCatalogClient
+from purviewcli.client.endpoints import ENDPOINTS
+
+RUNNER = CliRunner()
+
+
+def invoke(*args, **kwargs):
+    return RUNNER.invoke(main, list(args), catch_exceptions=False, **kwargs)
+
+
+PRODUCT_ID = "prod-aaaa-1111"
+ENTITY_ID = "asset-bbbb-2222"
+
+
+# ---------------------------------------------------------------------------
+# Bug 1: endpoint shape — entityId in URL path
+# ---------------------------------------------------------------------------
+
+
+class TestDeleteRelationshipEndpoint:
+    """The entityId must appear in the URL path, not only as a query param."""
+
+    @patch("purviewcli.client.endpoint.get_data")
+    def test_entity_id_in_url_path(self, mock_get_data):
+        """Verify the endpoint string contains the entityId as a path segment."""
+        mock_get_data.return_value = {}  # simulate 204 No Content
+
+        client = UnifiedCatalogClient()
+        client.delete_data_product_relationship(
+            {
+                "--product-id": [PRODUCT_ID],
+                "--entity-type": ["DATAASSET"],
+                "--entity-id": [ENTITY_ID],
+            }
+        )
+
+        call_args = mock_get_data.call_args[0][0]
+        endpoint = call_args["endpoint"]
+
+        assert ENTITY_ID in endpoint, (
+            f"entityId '{ENTITY_ID}' should appear as a path segment in the endpoint, "
+            f"but got: '{endpoint}'"
+        )
+        assert endpoint.endswith(f"/relationships/{ENTITY_ID}"), (
+            f"Endpoint must end with /relationships/{{entityId}}, got: '{endpoint}'"
+        )
+
+    @patch("purviewcli.client.endpoint.get_data")
+    def test_entity_id_NOT_in_query_params(self, mock_get_data):
+        """Regression: entityId must NOT be sent as a query parameter."""
+        mock_get_data.return_value = {}
+
+        client = UnifiedCatalogClient()
+        client.delete_data_product_relationship(
+            {
+                "--product-id": [PRODUCT_ID],
+                "--entity-type": ["DATAASSET"],
+                "--entity-id": [ENTITY_ID],
+            }
+        )
+
+        call_args = mock_get_data.call_args[0][0]
+        params = call_args.get("params", {}) or {}
+
+        assert "entityId" not in params, (
+            f"entityId must NOT be a query param (it belongs in the path), "
+            f"but found params={params}"
+        )
+
+    @patch("purviewcli.client.endpoint.get_data")
+    def test_entity_type_sent_as_query_param(self, mock_get_data):
+        """entityType must still be sent as a query parameter."""
+        mock_get_data.return_value = {}
+
+        client = UnifiedCatalogClient()
+        client.delete_data_product_relationship(
+            {
+                "--product-id": [PRODUCT_ID],
+                "--entity-type": ["DATAASSET"],
+                "--entity-id": [ENTITY_ID],
+            }
+        )
+
+        call_args = mock_get_data.call_args[0][0]
+        params = call_args.get("params", {}) or {}
+
+        assert params.get("entityType") == "DATAASSET", (
+            f"entityType should be uppercase query param 'DATAASSET', got params={params}"
+        )
+
+    @patch("purviewcli.client.endpoint.get_data")
+    def test_http_method_is_delete(self, mock_get_data):
+        mock_get_data.return_value = {}
+
+        client = UnifiedCatalogClient()
+        client.delete_data_product_relationship(
+            {
+                "--product-id": [PRODUCT_ID],
+                "--entity-type": ["TERM"],
+                "--entity-id": [ENTITY_ID],
+            }
+        )
+
+        call_args = mock_get_data.call_args[0][0]
+        assert call_args["method"] == "DELETE"
+
+    def test_endpoint_template_contains_entity_id_placeholder(self):
+        """Sanity-check the endpoint definition in endpoints.py."""
+        template = ENDPOINTS["unified_catalog"]["delete_data_product_relationship"]
+        assert "{entityId}" in template, (
+            f"Endpoint template must contain {{entityId}} placeholder, got: '{template}'"
+        )
+        assert "{productId}" in template
+
+
+# ---------------------------------------------------------------------------
+# Bug 2: error detection — false SUCCESS masking real API errors
+# ---------------------------------------------------------------------------
+
+
+class TestRemoveRelationshipErrorHandling:
+    """The CLI must surface API errors; previously any response without a literal
+    'error' key was printed as SUCCESS."""
+
+    @patch("purviewcli.cli.unified_catalog.UnifiedCatalogClient")
+    def test_204_success_prints_success(self, mock_client_cls):
+        """A real 204 No Content (empty dict) must still show SUCCESS."""
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+        mock_client.delete_data_product_relationship.return_value = {}  # 204 → {}
+
+        result = invoke(
+            "uc", "dataproduct", "remove-relationship",
+            "--product-id", PRODUCT_ID,
+            "--entity-type", "DATAASSET",
+            "--entity-id", ENTITY_ID,
+            "--no-confirm",
+        )
+
+        assert result.exit_code == 0, result.output
+        assert "SUCCESS" in result.output
+        assert "ERROR" not in result.output
+
+    @patch("purviewcli.cli.unified_catalog.UnifiedCatalogClient")
+    def test_404_error_prints_error_not_success(self, mock_client_cls):
+        """A 404 from the API must display ERROR, not SUCCESS.
+
+        This is the regression test for the false-SUCCESS bug:
+        the old code checked result.get('error') which is None for
+        {'status': 'error', 'message': '...', 'status_code': 404},
+        causing it to incorrectly print SUCCESS.
+        """
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+        mock_client.delete_data_product_relationship.return_value = {
+            "status": "error",
+            "message": "HTTP 404: Relationship not found",
+            "status_code": 404,
+        }
+
+        result = invoke(
+            "uc", "dataproduct", "remove-relationship",
+            "--product-id", PRODUCT_ID,
+            "--entity-type", "DATAASSET",
+            "--entity-id", ENTITY_ID,
+            "--no-confirm",
+        )
+
+        assert result.exit_code == 0, result.output
+        assert "ERROR" in result.output, (
+            "Expected ERROR in output for a 404 response, got: " + result.output
+        )
+        assert "SUCCESS" not in result.output, (
+            "Got SUCCESS for a 404 — false-SUCCESS bug still present: " + result.output
+        )
+
+    @patch("purviewcli.cli.unified_catalog.UnifiedCatalogClient")
+    def test_403_error_includes_message_in_output(self, mock_client_cls):
+        """The actual API error message must appear in the output."""
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+        mock_client.delete_data_product_relationship.return_value = {
+            "status": "error",
+            "message": "HTTP 403: Insufficient permissions",
+            "status_code": 403,
+        }
+
+        result = invoke(
+            "uc", "dataproduct", "remove-relationship",
+            "--product-id", PRODUCT_ID,
+            "--entity-type", "DATAASSET",
+            "--entity-id", ENTITY_ID,
+            "--no-confirm",
+        )
+
+        assert "403" in result.output or "Insufficient permissions" in result.output, (
+            "Expected error details in output, got: " + result.output
+        )
+
+    @patch("purviewcli.cli.unified_catalog.UnifiedCatalogClient")
+    def test_none_return_treated_as_success(self, mock_client_cls):
+        """None is a valid no-op success return (some DELETE paths return None)."""
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+        mock_client.delete_data_product_relationship.return_value = None
+
+        result = invoke(
+            "uc", "dataproduct", "remove-relationship",
+            "--product-id", PRODUCT_ID,
+            "--entity-type", "DATAASSET",
+            "--entity-id", ENTITY_ID,
+            "--no-confirm",
+        )
+
+        assert result.exit_code == 0, result.output
+        assert "SUCCESS" in result.output
+
+    @patch("purviewcli.cli.unified_catalog.UnifiedCatalogClient")
+    def test_error_output_includes_debug_tip(self, mock_client_cls):
+        """Errors should hint that PURVIEWCLI_DEBUG=1 can help diagnose the issue."""
+        mock_client = MagicMock()
+        mock_client_cls.return_value = mock_client
+        mock_client.delete_data_product_relationship.return_value = {
+            "status": "error",
+            "message": "HTTP 500: Internal server error",
+            "status_code": 500,
+        }
+
+        result = invoke(
+            "uc", "dataproduct", "remove-relationship",
+            "--product-id", PRODUCT_ID,
+            "--entity-type", "DATAASSET",
+            "--entity-id", ENTITY_ID,
+            "--no-confirm",
+        )
+
+        assert "PURVIEWCLI_DEBUG" in result.output, (
+            "Expected PURVIEWCLI_DEBUG hint in error output, got: " + result.output
+        )