pushframe 5.1.1__tar.gz → 5.1.2__tar.gz

{pushframe-5.1.1 → pushframe-5.1.2}/CHANGELOG.md

@@ -14,6 +14,28 @@ frames; it is not affiliated with Aura Frames Inc.
 
 ## [Unreleased]
 
+## [5.1.2] — 2026-09-30
+
+### Changed (tests)
+
+- **Network guard**: `httpx.Client` is patched for the whole test session
+  so any client built WITHOUT an explicit transport gets a blocking one —
+  except when built inside a live-marked test (the only legitimate
+  real-network shape). An offline test that reaches the real network now
+  fails loudly instead of silently depending on a local .env (the relogin
+  masking that kept the tests workflow red from v5.1.0 to 5.1.1), and a
+  local .env can no longer masquerade as a live posture.
+
+### Fixed (tests)
+
+- **The `tests` workflow is green again** (red on master since v5.1.0 —
+  not a 5.1.1 regression): the 9 offline tests of the 401-retry and
+  write-throttling suites relied on the pre-phase-24 re-login default
+  (`aura.login`); phase 24 made the default token-aware, which fails
+  named off-TTY without env credentials — exactly the CI case. A local
+  `.env` with real credentials masked it locally. All 9 `execute_plan`
+  call sites now pin `relogin=aura.login`; zero product code changed.
+
 ## [5.1.1] — 2026-09-30
 
 ### Changed

{pushframe-5.1.1 → pushframe-5.1.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: pushframe
-Version: 5.1.1
+Version: 5.1.2
 Summary: Unofficial community CLI for Aura Frames digital photo frames (sync a local folder or a Google Photos album; not affiliated with Aura Frames Inc.)
 Project-URL: Homepage, https://github.com/coredmp95/pushframe
 Project-URL: Repository, https://github.com/coredmp95/pushframe

{pushframe-5.1.1 → pushframe-5.1.2}/pushframe/__init__.py

@@ -1,4 +1,4 @@
 # pushframe — unofficial community CLI for Aura Frames (not affiliated).
 # Version single source for the CLI surface (REL-02); pyproject keeps the
 # packaging metadata version and tests/test_version.py enforces lockstep.
-__version__ = "5.1.1"
+__version__ = "5.1.2"

{pushframe-5.1.1 → pushframe-5.1.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "pushframe"
-version = "5.1.1"
+version = "5.1.2"
 description = "Unofficial community CLI for Aura Frames digital photo frames (sync a local folder or a Google Photos album; not affiliated with Aura Frames Inc.)"
 readme = "README.md"
 requires-python = ">=3.14"

pushframe-5.1.2/tests/conftest.py

@@ -0,0 +1,100 @@
+import os
+
+import pytest
+from dotenv import load_dotenv
+
+# Load AURA_EMAIL / AURA_PASSWORD from a local .env so the live read-path tests
+# can run without exporting shell vars. Shell-exported vars still win (override
+# defaults to False), and a missing .env is a no-op — so a credential-less
+# checkout still skips the live suite cleanly (D-02).
+load_dotenv()
+
+
+# ---------------------------------------------------------------------------
+# Network guard (CI hardening, 2026-09-30). An OFFLINE test must never reach
+# the real pushd API. Phase 24's token-aware relogin default let 9 offline
+# tests silently depend on a local .env (the env-password branch) and fail in
+# CI — the mock was bypassed because nothing blocked the DEFAULT transport.
+# While no live test is actually going to run, patch httpx.Client so any
+# client built WITHOUT an explicit transport (the real-network shape) gets a
+# blocking one: every request fails loudly. offline_aura-style tests are
+# unaffected (they pass transport= explicitly); `live` runs opt out.
+# ---------------------------------------------------------------------------
+_NETWORK_GUARD_ACTIVE = False
+_CURRENT_ITEM = None
+
+
+def pytest_runtest_setup(item):
+    """Track the current item so the guard can allow live-marked tests."""
+    global _CURRENT_ITEM
+    _CURRENT_ITEM = item
+
+
+def pytest_runtest_teardown(item):
+    global _CURRENT_ITEM
+    _CURRENT_ITEM = None
+
+
+def _blocking_transport():
+    import httpx
+
+    def handler(request: httpx.Request) -> httpx.Response:
+        raise RuntimeError(
+            'NETWORK GUARD: an offline test reached the real network at '
+            f'{request.url}. Offline tests must go through '
+            'tests.offline.offline_aura (explicit transport) or an injected '
+            'seam. If a product default now escapes the seam, fix the TEST '
+            '(e.g. pin relogin=aura.login), not the product.'
+        )
+
+    return httpx.MockTransport(handler)
+
+
+def pytest_collection_modifyitems(config, items):
+    """Install the network guard for the whole session. It is ALWAYS active:
+    every transport-less httpx.Client gets a blocking transport, EXCEPT when
+    built DURING a live-marked test (the only legitimate real-network shape:
+    the session `aura` fixture constructs the client inside the live test,
+    so the marker is checked at construction time — not at collection, which
+    would let a local .env masquerade as a live posture for offline tests)."""
+    global _NETWORK_GUARD_ACTIVE
+    import httpx
+
+    original = httpx.Client.__init__
+
+    def guarded(self, *args, **kwargs):
+        live_running = _CURRENT_ITEM is not None and \
+            _CURRENT_ITEM.get_closest_marker('live') is not None
+        # httpx.Client's signature is keyword-only; `app` implies transport.
+        if not live_running and 'transport' not in kwargs and 'app' not in kwargs:
+            kwargs['transport'] = _blocking_transport()
+        return original(self, *args, **kwargs)
+
+    # Detection lives ON the patched __init__ (NOT an importable conftest
+    # flag): pytest registers conftest under its own module name, so a test
+    # importing tests.conftest would see a second, never-mutated copy.
+    guarded._network_guard = True
+    httpx.Client.__init__ = guarded
+    _NETWORK_GUARD_ACTIVE = True
+
+
+@pytest.fixture(scope="session")
+def aura():
+    """Authenticated Aura session shared by all live read-path tests.
+
+    Reads AURA_EMAIL/AURA_PASSWORD from the environment and skips the whole
+    live suite cleanly when either is unset (D-02), so a credential-less
+    checkout stays green. When credentials are present it instantiates Aura()
+    and performs the login (READ-01's act, D-03), returning the authenticated
+    instance so all live tests reuse one session.
+    """
+    email = os.getenv("AURA_EMAIL")
+    password = os.getenv("AURA_PASSWORD")
+    if not email or not password:
+        pytest.skip("AURA_EMAIL/AURA_PASSWORD not set; skipping live Aura API tests")
+
+    from pushframe.aura import Aura
+
+    instance = Aura()
+    instance.login()
+    return instance

pushframe-5.1.2/tests/test_network_guard.py

@@ -0,0 +1,41 @@
+"""The network guard itself (2026-09-30 CI hardening).
+
+Meta-test: when the guard is installed, a client built WITHOUT an explicit
+transport — the real-network shape — must fail loudly instead of reaching
+pushd. When it is not installed (a genuine live posture), there is nothing
+to assert and the test skips.
+"""
+import httpx
+import pytest
+
+
+def _guard_installed() -> bool:
+    """True when conftest's blocking transport is patched onto httpx.Client.
+
+    Detection reads the attribute the hook sets on the patched __init__
+    itself — importing the flag from conftest would read a second module
+    copy (pytest registers conftest under its own name).
+    """
+    return getattr(httpx.Client.__init__, '_network_guard', False)
+
+
+def test_guard_blocks_transportless_clients_in_offline_posture():
+    if not _guard_installed():
+        pytest.skip('guard not installed — a genuine live posture is selected')
+    client = httpx.Client(base_url='https://api.pushd.com/v5')
+    with pytest.raises(RuntimeError, match='NETWORK GUARD'):
+        client.get('/frames.json')  # any request: the transport itself blocks
+
+
+def test_guard_never_blocks_explicit_transports():
+    """offline_aura's shape: transport= passes through untouched."""
+    calls = []
+
+    def handler(request: httpx.Request) -> httpx.Response:
+        calls.append(request.url.path)
+        return httpx.Response(200, json={'ok': True})
+
+    client = httpx.Client(transport=httpx.MockTransport(handler))
+    r = client.get('https://api.pushd.com/v5/frames.json')
+    assert r.status_code == 200
+    assert calls == ['/v5/frames.json']

{pushframe-5.1.1 → pushframe-5.1.2}/tests/test_retry_401.py

@@ -169,6 +169,7 @@ def test_401_on_select_asset_recovers_after_relogin_and_resend(tmp_path):
         plan, aura, FRAME_ID, s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
         sleep=lambda *_: None, throttle_seconds=0, chunk_delay_seconds=0,
         asset_probe=_ordered_probe(['absent']),
+        relogin=aura.login,  # pinned: this test encodes the PRE-phase-24 password default
     )
 
     assert result.upload_succeeded == 1
@@ -197,6 +198,7 @@ def test_two_item_chunk_401_resends_only_the_genuinely_absent_item(tmp_path):
         plan, aura, FRAME_ID, s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
         sleep=lambda *_: None, throttle_seconds=0, chunk_delay_seconds=0,
         asset_probe=_ordered_probe(['landed', 'absent']),
+        relogin=aura.login,  # pinned: pre-phase-24 password default
     )
 
     assert result.items_already_landed == 1
@@ -364,6 +366,7 @@ def test_retried_upload_chunk_consumes_5_budget_tokens_total(tmp_path):
         plan, aura, FRAME_ID, s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
         sleep=lambda *_: None, throttle_seconds=0, chunk_delay_seconds=0,
         asset_probe=_ordered_probe(['absent']),
+        relogin=aura.login,  # pinned: pre-phase-24 password default
         budget=budget, clock=lambda: T0, wait_on_budget=False,
     )
 
@@ -391,6 +394,7 @@ def test_all_items_already_landed_consumes_3_tokens_no_resend_charge(tmp_path):
         plan, aura, FRAME_ID, s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
         sleep=lambda *_: None, throttle_seconds=0, chunk_delay_seconds=0,
         asset_probe=_ordered_probe(['landed', 'landed']),
+        relogin=aura.login,  # pinned: pre-phase-24 password default
         budget=budget, clock=lambda: T0, wait_on_budget=False,
     )
 
@@ -419,6 +423,7 @@ def test_probe_itself_never_charges_budget_regardless_of_chunk_size(tmp_path):
         plan, aura, FRAME_ID, s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
         sleep=lambda *_: None, throttle_seconds=0, chunk_delay_seconds=0,
         asset_probe=_ordered_probe(['landed', 'landed', 'landed']),
+        relogin=aura.login,  # pinned: pre-phase-24 password default
         budget=budget, clock=lambda: T0, wait_on_budget=False,
     )
 
@@ -453,6 +458,7 @@ def test_budget_exhausted_propagates_from_retry_acquire_with_no_bypass(tmp_path)
             plan, aura, FRAME_ID, s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
             sleep=lambda *_: None, throttle_seconds=0, chunk_delay_seconds=0,
             asset_probe=_ordered_probe(['absent']),
+            relogin=aura.login,  # pinned: pre-phase-24 password default
             budget=budget, clock=lambda: T0, wait_on_budget=False,
         )
 

{pushframe-5.1.1 → pushframe-5.1.2}/tests/test_version.py

@@ -19,7 +19,7 @@ PYPROJECT = Path(__file__).resolve().parent.parent / "pyproject.toml"
 def test_version_is_first_distribution_release():
     """The current distribution release (moved off 0.1.0 at 5.0.0; page
     metadata fix shipped in 5.0.4)."""
-    assert __version__ == "5.1.1"
+    assert __version__ == "5.1.2"
 
 
 def test_version_matches_pyproject_single_source():

{pushframe-5.1.1 → pushframe-5.1.2}/tests/test_write_throttling.py

@@ -304,11 +304,13 @@ def test_run_of_plain_401_write_failures_aborts_batch(tmp_path):
     overrides[SELECT_ASSET_PATH] = httpx.Response(401, json={'error': 'unauthorized'})
     s3 = _FakeS3Client()
 
+    aura = offline_aura(overrides=overrides)
     with pytest.raises(ConsecutiveWriteFailureError) as exc_info:
         execute_plan(
-            plan, offline_aura(overrides=overrides), FRAME_ID,
+            plan, aura, FRAME_ID,
             s3_client=s3, sqs_client=_FakeSQSClient(),
             throttle_seconds=0, sleep=lambda *_: None,
+            relogin=aura.login,  # pinned: pre-phase-24 password default
         )
 
     err = exc_info.value
@@ -351,12 +353,13 @@ def test_interspersed_failures_do_not_trip_the_backstop(tmp_path, monkeypatch):
 
     monkeypatch.setattr(aura.asset_api, 'batch_update', _flaky_batch_update)
 
-    result = execute_plan(
-        plan, aura, FRAME_ID,
-        s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
-        throttle_seconds=0, sleep=lambda *_: None,
-        batch_size=1,
-    )
+    result =        execute_plan(
+            plan, aura, FRAME_ID,
+            s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
+            throttle_seconds=0, sleep=lambda *_: None,
+            batch_size=1,
+            relogin=aura.login,  # pinned: pre-phase-24 password default
+        )
 
     # No abort: all 8 attempted, 4 succeeded, 4 recorded per-item (D-08 intact).
     assert result.upload_succeeded == 4
@@ -390,12 +393,13 @@ def test_a_success_resets_the_consecutive_run(tmp_path, monkeypatch):
 
     monkeypatch.setattr(aura.asset_api, 'batch_update', _flaky_batch_update)
 
-    result = execute_plan(
-        plan, aura, FRAME_ID,
-        s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
-        throttle_seconds=0, sleep=lambda *_: None,
-        batch_size=1,
-    )
+    result =        execute_plan(
+            plan, aura, FRAME_ID,
+            s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
+            throttle_seconds=0, sleep=lambda *_: None,
+            batch_size=1,
+            relogin=aura.login,  # pinned: pre-phase-24 password default
+        )
 
     assert result.upload_succeeded == 1
     assert len(result.upload_failures) == 8
@@ -444,11 +448,13 @@ def test_max_consecutive_failures_zero_disables_the_backstop(tmp_path):
     overrides = _ok_overrides()
     overrides[SELECT_ASSET_PATH] = httpx.Response(401, json={'error': 'unauthorized'})
 
+    aura = offline_aura(overrides=overrides)
     result = execute_plan(
-        plan, offline_aura(overrides=overrides), FRAME_ID,
+        plan, aura, FRAME_ID,
         s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
         throttle_seconds=0, sleep=lambda *_: None,
         max_consecutive_failures=0,
+        relogin=aura.login,  # pinned: pre-phase-24 password default
     )
 
     assert result.upload_succeeded == 0
@@ -469,12 +475,14 @@ def test_consecutive_run_spans_upload_and_delete_phases(tmp_path):
     overrides[SELECT_ASSET_PATH] = httpx.Response(401, json={'error': 'unauthorized'})
     overrides[REMOVE_ASSET_PATH] = httpx.Response(401, json={'error': 'unauthorized'})
 
+    aura = offline_aura(overrides=overrides)
     with pytest.raises(ConsecutiveWriteFailureError) as exc_info:
         execute_plan(
-            plan, offline_aura(overrides=overrides), FRAME_ID,
+            plan, aura, FRAME_ID,
             s3_client=_FakeS3Client(), sqs_client=_FakeSQSClient(),
             throttle_seconds=0, sleep=lambda *_: None,
             batch_size=1,
+            relogin=aura.login,  # pinned: pre-phase-24 password default
         )
 
     err = exc_info.value

{pushframe-5.1.1 → pushframe-5.1.2}/uv.lock

@@ -432,7 +432,7 @@ wheels = [
 
 [[package]]
 name = "pushframe"
-version = "5.1.1"
+version = "5.1.2"
 source = { editable = "." }
 dependencies = [
     { name = "boto3" },

pushframe-5.1.1/tests/conftest.py

@@ -1,32 +0,0 @@
-import os
-
-import pytest
-from dotenv import load_dotenv
-
-# Load AURA_EMAIL / AURA_PASSWORD from a local .env so the live read-path tests
-# can run without exporting shell vars. Shell-exported vars still win (override
-# defaults to False), and a missing .env is a no-op — so a credential-less
-# checkout still skips the live suite cleanly (D-02).
-load_dotenv()
-
-
-@pytest.fixture(scope="session")
-def aura():
-    """Authenticated Aura session shared by all live read-path tests.
-
-    Reads AURA_EMAIL/AURA_PASSWORD from the environment and skips the whole
-    live suite cleanly when either is unset (D-02), so a credential-less
-    checkout stays green. When credentials are present it instantiates Aura()
-    and performs the login (READ-01's act, D-03), returning the authenticated
-    instance so all live tests reuse one session.
-    """
-    email = os.getenv("AURA_EMAIL")
-    password = os.getenv("AURA_PASSWORD")
-    if not email or not password:
-        pytest.skip("AURA_EMAIL/AURA_PASSWORD not set; skipping live Aura API tests")
-
-    from pushframe.aura import Aura
-
-    instance = Aura()
-    instance.login()
-    return instance