pum 1.3.0__tar.gz → 1.3.1__tar.gz

{pum-1.3.0 → pum-1.3.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pum
-Version: 1.3.0
+Version: 1.3.1
 Summary: Pum stands for "Postgres Upgrades Manager". It is a Database migration management tool very similar to flyway-db or Liquibase, based on metadata tables.
 Author-email: Denis Rouzaud <denis@opengis.ch>
 License-Expression: GPL-2.0-or-later

{pum-1.3.0 → pum-1.3.1}/pum/schema_migrations.py

@@ -74,10 +74,9 @@ class SchemaMigrations:
             "schema": psycopg.sql.Literal(self.config.config.pum.migration_table_schema),
         }
 
-        with connection.transaction():
-            cursor = SqlContent(query).execute(connection, parameters=parameters)
-            result = cursor._pum_results[0] if cursor._pum_results else None
-            return result[0] if result else False
+        cursor = SqlContent(query).execute(connection, parameters=parameters)
+        result = cursor._pum_results[0] if cursor._pum_results else None
+        return result[0] if result else False
 
     def exists_in_other_schemas(self, connection: psycopg.Connection) -> list[str]:
         """Check if the schema_migrations information table exists in other schemas.
@@ -100,9 +99,8 @@ class SchemaMigrations:
         parameters = {
             "schema": psycopg.sql.Literal(self.config.config.pum.migration_table_schema),
         }
-        with connection.transaction():
-            cursor = SqlContent(query).execute(connection, parameters=parameters)
-            return [row[0] for row in (cursor._pum_results or [])]
+        cursor = SqlContent(query).execute(connection, parameters=parameters)
+        return [row[0] for row in (cursor._pum_results or [])]
 
     def create(
         self,
@@ -346,14 +344,13 @@ INSERT INTO {table} (
             "table": self.migration_table_identifier,
         }
 
-        with connection.transaction():
-            cursor = SqlContent(query).execute(connection, parameters=parameters)
-            row = cursor._pum_results[0] if cursor._pum_results else None
-            if row is None:
-                raise PumSchemaMigrationNoBaselineError(
-                    f"Baseline version not found in the {self.migration_table_identifier_str} table."
-                )
-            return packaging.version.parse(row[0])
+        cursor = SqlContent(query).execute(connection, parameters=parameters)
+        row = cursor._pum_results[0] if cursor._pum_results else None
+        if row is None:
+            raise PumSchemaMigrationNoBaselineError(
+                f"Baseline version not found in the {self.migration_table_identifier_str} table."
+            )
+        return packaging.version.parse(row[0])
 
     def migration_details(self, connection: psycopg.Connection, version: str | None = None) -> dict:
         """Return the migration details from the migration table.
@@ -404,14 +401,13 @@ INSERT INTO {table} (
                 "version": psycopg.sql.Literal(version),
             }
 
-        with connection.transaction():
-            cursor = SqlContent(query).execute(connection, parameters=parameters)
-            row = cursor._pum_results[0] if cursor._pum_results else None
-            if row is None:
-                raise PumSchemaMigrationError(
-                    f"Migration details not found for version {version} in the {self.migration_table_identifier_str} table."
-                )
-            return dict(zip([desc[0] for desc in cursor._pum_description], row, strict=False))
+        cursor = SqlContent(query).execute(connection, parameters=parameters)
+        row = cursor._pum_results[0] if cursor._pum_results else None
+        if row is None:
+            raise PumSchemaMigrationError(
+                f"Migration details not found for version {version} in the {self.migration_table_identifier_str} table."
+            )
+        return dict(zip([desc[0] for desc in cursor._pum_description], row, strict=False))
 
     def compare(self, connection: psycopg.Connection) -> int:
         """Compare the migrations details in the database to the changelogs in the source.

{pum-1.3.0 → pum-1.3.1}/pum.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pum
-Version: 1.3.0
+Version: 1.3.1
 Summary: Pum stands for "Postgres Upgrades Manager". It is a Database migration management tool very similar to flyway-db or Liquibase, based on metadata tables.
 Author-email: Denis Rouzaud <denis@opengis.ch>
 License-Expression: GPL-2.0-or-later

{pum-1.3.0 → pum-1.3.1}/pum.egg-info/SOURCES.txt

@@ -38,5 +38,4 @@ test/test_hooks.py
 test/test_roles.py
 test/test_schema_migrations.py
 test/test_sql_content.py
-test/test_transaction_fix.py
 test/test_upgrader.py

pum-1.3.0/test/test_transaction_fix.py

@@ -1,100 +0,0 @@
-import unittest
-from pathlib import Path
-
-import psycopg
-
-from pum.pum_config import PumConfig
-from pum.schema_migrations import SchemaMigrations
-
-
-class TestTransactionFix(unittest.TestCase):
-    """Test that verifies the transaction fix prevents 'idle in transaction' state."""
-
-    def setUp(self) -> None:
-        """Set up the test environment."""
-        self.pg_service = "pum_test"
-
-    def test_schema_migrations_exists_transaction_state(self) -> None:
-        """Test that schema_migrations.exists() doesn't leave connection in 'idle in transaction'."""
-        test_dir = Path("test") / "data" / "single_changelog"
-        cfg = PumConfig(test_dir, pum={"module": "test_single_changelog"})
-        sm = SchemaMigrations(cfg)
-
-        with psycopg.connect(f"service={self.pg_service}") as conn:
-            # Clean up any existing table
-            with conn.transaction():
-                conn.execute("DROP TABLE IF EXISTS public.pum_migrations")
-
-            # Initial state should be IDLE
-            self.assertEqual(conn.info.transaction_status.name, "IDLE")
-
-            # Call exists() which executes a query
-            sm.exists(conn)
-
-            # After the call, connection should still be IDLE (not "IDLE_IN_TRANSACTION")
-            # This will FAIL if the transaction block is not used in exists()
-            transaction_status = conn.info.transaction_status.name
-            self.assertEqual(
-                transaction_status,
-                "IDLE",
-                f"Connection in '{transaction_status}' state after exists() - should use transaction block",
-            )
-
-    def test_schema_migrations_baseline_transaction_state(self) -> None:
-        """Test that schema_migrations.baseline() doesn't leave connection in 'idle in transaction'."""
-        test_dir = Path("test") / "data" / "single_changelog"
-        cfg = PumConfig(test_dir, pum={"module": "test_single_changelog"})
-        sm = SchemaMigrations(cfg)
-
-        with psycopg.connect(f"service={self.pg_service}") as conn:
-            # Create the migrations table with some data
-            with conn.transaction():
-                sm.create(conn)
-                sm.set_baseline(conn, "1.0.0", commit=False)
-
-            # Initial state should be IDLE
-            self.assertEqual(conn.info.transaction_status.name, "IDLE")
-
-            # Call baseline() which executes a query
-            sm.baseline(conn)
-
-            # After the call, connection should still be IDLE
-            transaction_status = conn.info.transaction_status.name
-            self.assertEqual(
-                transaction_status,
-                "IDLE",
-                f"Connection in '{transaction_status}' state after baseline() - should use transaction block",
-            )
-
-            # Clean up
-            with conn.transaction():
-                conn.execute("DROP TABLE IF EXISTS public.pum_migrations")
-
-    def test_multiple_queries_without_transaction_causes_idle_in_transaction(self) -> None:
-        """Test that demonstrates the problem: queries without transaction blocks cause 'idle in transaction'."""
-        with psycopg.connect(f"service={self.pg_service}") as conn:
-            # Start with IDLE state
-            self.assertEqual(conn.info.transaction_status.name, "IDLE")
-
-            # Execute a query WITHOUT using a transaction block
-            # This simulates the old buggy behavior
-            cursor = conn.cursor()
-            cursor.execute("SELECT 1")
-            cursor.fetchone()
-            cursor.close()
-
-            # Now the connection is stuck in INTRANS (idle in transaction)
-            transaction_status = conn.info.transaction_status.name
-            self.assertEqual(
-                transaction_status,
-                "INTRANS",
-                "Without transaction blocks, connection gets stuck in INTRANS (idle in transaction)",
-            )
-
-            # Need to explicitly commit to get back to IDLE
-            conn.commit()
-            self.assertEqual(conn.info.transaction_status.name, "IDLE")
-
-
-if __name__ == "__main__":
-    unittest.main()