pulpcore 3.77.0__tar.gz → 3.77.1__tar.gz

{pulpcore-3.77.0 → pulpcore-3.77.1}/CHANGES.md

@@ -8,6 +8,29 @@
 
 [//]: # (towncrier release notes start)
 
+## 3.77.1 (2025-05-08) {: #3.77.1 }
+
+### REST API {: #3.77.1-rest-api }
+
+#### Bugfixes {: #3.77.1-rest-api-bugfix }
+
+- On-demand or pull-through content is now immediately cached upon first request.
+  [#6540](https://github.com/pulp/pulpcore/issues/6540)
+
+### Plugin API {: #3.77.1-plugin-api }
+
+No significant changes.
+
+### Pulp File {: #3.77.1-pulp-file }
+
+No significant changes.
+
+### Pulp Cert Guard {: #3.77.1-pulp-cert-guard }
+
+No significant changes.
+
+---
+
 ## 3.77.0 (2025-05-06) {: #3.77.0 }
 
 ### REST API {: #3.77.0-rest-api }

{pulpcore-3.77.0 → pulpcore-3.77.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pulpcore
-Version: 3.77.0
+Version: 3.77.1
 Summary: Pulp Django Application and Related Modules
 Author-email: Pulp Team <pulp-list@redhat.com>
 Project-URL: Homepage, https://pulpproject.org

{pulpcore-3.77.0 → pulpcore-3.77.1}/pulp_certguard/app/__init__.py

@@ -6,6 +6,6 @@ class PulpCertGuardPluginAppConfig(PulpPluginAppConfig):
 
     name = "pulp_certguard.app"
     label = "certguard"
-    version = "3.77.0"
+    version = "3.77.1"
     python_package_name = "pulpcore"
     domain_compatible = True

{pulpcore-3.77.0 → pulpcore-3.77.1}/pulp_file/app/__init__.py

@@ -8,6 +8,6 @@ class PulpFilePluginAppConfig(PulpPluginAppConfig):
 
     name = "pulp_file.app"
     label = "file"
-    version = "3.77.0"
+    version = "3.77.1"
     python_package_name = "pulpcore"
     domain_compatible = True

{pulpcore-3.77.0 → pulpcore-3.77.1}/pulpcore/app/apps.py

@@ -247,7 +247,7 @@ class PulpAppConfig(PulpPluginAppConfig):
     label = "core"
 
     # The version of this app
-    version = "3.77.0"
+    version = "3.77.1"
 
     # The python package name providing this app
     python_package_name = "pulpcore"

{pulpcore-3.77.0 → pulpcore-3.77.1}/pulpcore/cache/cache.py

@@ -8,7 +8,7 @@ from django.http import HttpResponseRedirect, HttpResponse, FileResponse as ApiF
 
 from rest_framework.request import Request as ApiRequest
 
-from aiohttp.web import FileResponse, Response, HTTPSuccessful, Request
+from aiohttp.web import FileResponse, Response, HTTPSuccessful, Request, StreamResponse
 from aiohttp.web_exceptions import HTTPFound
 
 from redis import ConnectionError
@@ -401,6 +401,11 @@ class AsyncContentCache(AsyncCache):
         except (HTTPSuccessful, HTTPFound) as e:
             response = e
 
+        original_response = response
+        if isinstance(response, StreamResponse):
+            if hasattr(response, "future_response"):
+                response = response.future_response
+
         entry = {"headers": dict(response.headers), "status": response.status}
         if expires is not None:
             # Redis TTL is not sufficient: https://github.com/pulp/pulpcore/issues/4845
@@ -427,12 +432,12 @@ class AsyncContentCache(AsyncCache):
             entry["location"] = str(response.location)
             entry["type"] = "Redirect"
         else:
-            # We don't cache StreamResponses or errors
+            # We don't cache errors
             return response
 
         # TODO look into smaller format, maybe some compression on the text
         await self.set(key, json.dumps(entry), expires, base_key=base_key)
-        return response
+        return original_response
 
     def make_key(self, request):
         """Makes the key based off the request"""

{pulpcore-3.77.0 → pulpcore-3.77.1}/pulpcore/content/handler.py

@@ -1093,26 +1093,8 @@ class Handler:
             ret.update({ca.relative_path: ca for ca in cas})
         return ret
 
-    async def _serve_content_artifact(self, content_artifact, headers, request):
-        """
-        Handle response for a Content Artifact with the file present.
-
-        Depending on where the file storage (e.g. filesystem, S3, etc) this could be responding with
-        the file (filesystem) or a redirect (S3).
-
-        Args:
-            content_artifact (pulpcore.app.models.ContentArtifact) The Content Artifact to
-                respond with.
-            headers (dict): A dictionary of response headers.
-            request(aiohttp.web.Request) The request to prepare a response for.
-
-        Raises:
-            [aiohttp.web_exceptions.HTTPFound][]: When we need to redirect to the file
-            NotImplementedError: If file is stored in a file storage we can't handle
-
-        Returns:
-            The [aiohttp.web.FileResponse][] for the file.
-        """
+    def _build_response_from_content_artifact(self, content_artifact, headers, request):
+        """Helper method to build the correct response to serve a ContentArtifact."""
 
         def _set_params_from_headers(hdrs, storage_domain):
             # Map standard-response-headers to storage-object-specific keys
@@ -1137,7 +1119,47 @@ class Handler:
         artifact_name = artifact_file.name
         domain = get_domain()
         storage = domain.get_storage()
+        headers["X-PULP-ARTIFACT-SIZE"] = str(artifact_file.size)
+
+        if domain.storage_class == "pulpcore.app.models.storage.FileSystem":
+            path = storage.path(artifact_name)
+            if not os.path.exists(path):
+                raise Exception(_("Expected path '{}' is not found").format(path))
+            return FileResponse(path, headers=headers)
+        elif not domain.redirect_to_object_storage:
+            return ArtifactResponse(content_artifact.artifact, headers=headers)
+        elif domain.storage_class == "storages.backends.s3boto3.S3Boto3Storage":
+            return HTTPFound(_build_url(http_method=request.method), headers=headers)
+        elif domain.storage_class in (
+            "storages.backends.azure_storage.AzureStorage",
+            "storages.backends.gcloud.GoogleCloudStorage",
+        ):
+            return HTTPFound(_build_url(), headers=headers)
+        else:
+            raise NotImplementedError()
 
+    async def _serve_content_artifact(self, content_artifact, headers, request):
+        """
+        Handle response for a Content Artifact with the file present.
+
+        Depending on where the file storage (e.g. filesystem, S3, etc) this could be responding with
+        the file (filesystem) or a redirect (S3).
+
+        Args:
+            content_artifact (pulpcore.app.models.ContentArtifact) The Content Artifact to
+                respond with.
+            headers (dict): A dictionary of response headers.
+            request(aiohttp.web.Request) The request to prepare a response for.
+
+        Raises:
+            [aiohttp.web_exceptions.HTTPFound][]: When we need to redirect to the file
+            NotImplementedError: If file is stored in a file storage we can't handle
+            HTTPRequestRangeNotSatisfiable: If the request is for a range that is not
+                satisfiable.
+        Returns:
+            The [aiohttp.web.FileResponse][] for the file.
+        """
+        artifact_file = content_artifact.artifact.file
         content_length = artifact_file.size
 
         try:
@@ -1152,25 +1174,13 @@ class Handler:
             size = artifact_file.size or "*"
             raise HTTPRequestRangeNotSatisfiable(headers={"Content-Range": f"bytes */{size}"})
 
-        headers["X-PULP-ARTIFACT-SIZE"] = str(content_length)
         artifacts_size_counter.add(content_length)
 
-        if domain.storage_class == "pulpcore.app.models.storage.FileSystem":
-            path = storage.path(artifact_name)
-            if not os.path.exists(path):
-                raise Exception(_("Expected path '{}' is not found").format(path))
-            return FileResponse(path, headers=headers)
-        elif not domain.redirect_to_object_storage:
-            return ArtifactResponse(content_artifact.artifact, headers=headers)
-        elif domain.storage_class == "storages.backends.s3boto3.S3Boto3Storage":
-            raise HTTPFound(_build_url(http_method=request.method), headers=headers)
-        elif domain.storage_class in (
-            "storages.backends.azure_storage.AzureStorage",
-            "storages.backends.gcloud.GoogleCloudStorage",
-        ):
-            raise HTTPFound(_build_url(), headers=headers)
+        response = self._build_response_from_content_artifact(content_artifact, headers, request)
+        if isinstance(response, HTTPFound):
+            raise response
         else:
-            raise NotImplementedError()
+            return response
 
     async def _stream_remote_artifact(
         self, request, response, remote_artifact, save_artifact=True, repository=None
@@ -1214,6 +1224,7 @@ class Handler:
             size = remote_artifact.size or "*"
             raise HTTPRequestRangeNotSatisfiable(headers={"Content-Range": f"bytes */{size}"})
 
+        original_headers = response.headers.copy()
         actual_content_length = None
 
         if range_start or range_stop:
@@ -1323,9 +1334,14 @@ class Handler:
             content_artifacts = await asyncio.shield(
                 sync_to_async(self._save_artifact)(download_result, remote_artifact, request)
             )
+            ca = content_artifacts[remote_artifact.content_artifact.relative_path]
+            # If cache is enabled, add the future response to our stream response
+            if settings.CACHE_ENABLED:
+                response.future_response = self._build_response_from_content_artifact(
+                    ca, original_headers, request
+                )
             # Try to add content to repository if present & supported
             if repository and repository.PULL_THROUGH_SUPPORTED:
-                ca = content_artifacts[remote_artifact.content_artifact.relative_path]
                 await sync_to_async(repository.pull_through_add_content)(ca)
         await response.write_eof()
 

{pulpcore-3.77.0 → pulpcore-3.77.1}/pulpcore/tests/functional/api/using_plugin/test_content_cache.py

@@ -16,7 +16,7 @@ from pulpcore.tests.functional.utils import get_from_url
 @pytest.mark.parallel
 def test_full_workflow(
     file_repo_with_auto_publish,
-    basic_manifest_path,
+    duplicate_filename_paths,
     file_remote_factory,
     file_bindings,
     distribution_base_url,
@@ -37,7 +37,8 @@ def test_full_workflow(
         return r.status, r.headers.get("X-PULP-CACHE")
 
     # Sync from the remote and assert that a new repository version is created
-    remote = file_remote_factory(manifest_path=basic_manifest_path, policy="immediate")
+    manifest_1, manifest_2 = duplicate_filename_paths
+    remote = file_remote_factory(manifest_path=manifest_1, policy="immediate")
     body = RepositorySyncURL(remote=remote.pulp_href)
     monitor_task(
         file_bindings.RepositoriesFileApi.sync(file_repo_with_auto_publish.pulp_href, body).task
@@ -129,6 +130,21 @@ def test_full_workflow(
         url = urljoin(distro_base_url, file)
         assert (200, "HIT" if i % 2 == 1 else "MISS") == _check_cache(url), file
 
+    # Sync a new remote with same filenames but on-demand
+    remote = file_remote_factory(manifest_path=manifest_2, policy="on_demand")
+    body = RepositorySyncURL(remote=remote.pulp_href)
+    monitor_task(
+        file_bindings.RepositoriesFileApi.sync(file_repo_with_auto_publish.pulp_href, body).task
+    )
+    repo = file_bindings.RepositoriesFileApi.read(file_repo_with_auto_publish.pulp_href)
+    assert repo.latest_version_href.endswith("/versions/3/")
+
+    # Test that cache is invalidated from sync, but on-demand responses are immediately cached
+    files = ["1.iso", "1.iso", "2.iso", "2.iso", "3.iso", "3.iso"]
+    for i, file in enumerate(files):
+        url = urljoin(distro_base_url, file)
+        assert (200, "HIT" if i % 2 == 1 else None) == _check_cache(url), file
+
     # Tests that deleting a repository invalidates the cache"""
     monitor_task(file_bindings.RepositoriesFileApi.delete(repo.pulp_href).task)
     files = ["", "PULP_MANIFEST", "2.iso"]

{pulpcore-3.77.0 → pulpcore-3.77.1}/pulpcore.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pulpcore
-Version: 3.77.0
+Version: 3.77.1
 Summary: Pulp Django Application and Related Modules
 Author-email: Pulp Team <pulp-list@redhat.com>
 Project-URL: Homepage, https://pulpproject.org

{pulpcore-3.77.0 → pulpcore-3.77.1}/pyproject.toml

@@ -7,7 +7,7 @@ build-backend = 'setuptools.build_meta'
 
 [project]
 name = "pulpcore"
-version = "3.77.0"
+version = "3.77.1"
 description = "Pulp Django Application and Related Modules"
 readme = "README.md"
 authors = [
@@ -207,7 +207,7 @@ ignore = [
 [tool.bumpversion]
 # This section is managed by the plugin template. Do not edit manually.
 
-current_version = "3.77.0"
+current_version = "3.77.1"
 commit = false
 tag = false
 parse = "(?P<major>\\d+)\\.(?P<minor>\\d+)\\.(?P<alpha>0a)?(?P<patch>\\d+)(\\.(?P<release>[a-z]+))?"