pulpcore 3.28.43__tar.gz → 3.28.44__tar.gz

{pulpcore-3.28.43 → pulpcore-3.28.44}/CHANGES.md

@@ -8,6 +8,21 @@
 
 [//]: # (towncrier release notes start)
 
+## 3.28.44 (2026-03-10) {: #3.28.44 }
+
+### REST API {: #3.28.44-rest-api }
+
+#### Bugfixes {: #3.28.44-rest-api-bugfix }
+
+- Moved artifact checksum validation from module-level settings code to a Django system check.
+  [#7380](https://github.com/pulp/pulpcore/issues/7380)
+
+### Plugin API {: #3.28.44-plugin-api }
+
+No significant changes.
+
+---
+
 ## 3.28.43 (2025-12-09) {: #3.28.43 }
 
 ### REST API {: #3.28.43-rest-api }

{pulpcore-3.28.43 → pulpcore-3.28.44}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pulpcore
-Version: 3.28.43
+Version: 3.28.44
 Summary: Pulp Django Application and Related Modules
 Home-page: https://pulpproject.org
 Author: Pulp Team

{pulpcore-3.28.43 → pulpcore-3.28.44}/pulpcore/app/apps.py

@@ -234,7 +234,7 @@ class PulpAppConfig(PulpPluginAppConfig):
     label = "core"
 
     # The version of this app
-    version = "3.28.43"
+    version = "3.28.44"
 
     # The python package name providing this app
     python_package_name = "pulpcore"

pulpcore-3.28.44/pulpcore/app/checks.py

@@ -0,0 +1,119 @@
+from pathlib import Path
+
+from django.conf import settings
+from django.core.checks import (
+    Debug as CheckDebug,
+    Error as CheckError,
+    Warning as CheckWarning,
+    Tags,
+    register,
+)
+from django.db.models import Q
+
+from pulpcore import constants
+
+
+@register(deploy=True)
+def content_origin_check(app_configs, **kwargs):
+    messages = []
+    if getattr(settings, "CONTENT_ORIGIN", "UNREACHABLE") == "UNREACHABLE":
+        messages.append(
+            CheckError(
+                "CONTENT_ORIGIN is a required setting but it was not configured. This may be "
+                "caused by invalid read permissions of the settings file. Note that "
+                "CONTENT_ORIGIN is set by the installation automatically.",
+                id="pulpcore.E001",
+            )
+        )
+    return messages
+
+
+@register(deploy=True)
+def storage_paths(app_configs, **kwargs):
+    warnings = []
+
+    if settings.DEFAULT_FILE_STORAGE == "pulpcore.app.models.storage.FileSystem":
+        try:
+            media_root_dev = Path(settings.MEDIA_ROOT).stat().st_dev
+        except OSError:
+            media_root_dev = None
+            warnings.append(
+                CheckWarning(
+                    "Your MEDIA_ROOT setting points to a path that does not exist.",
+                    id="pulpcore.W001",
+                )
+            )
+
+        try:
+            working_dir_dev = Path(settings.WORKING_DIRECTORY).stat().st_dev
+        except OSError:
+            working_dir_dev = None
+            warnings.append(
+                CheckWarning(
+                    "Your WORKING_DIRECTORY setting points to a path that does not exist.",
+                    id="pulpcore.W002",
+                )
+            )
+
+        if media_root_dev and media_root_dev != working_dir_dev:
+            warnings.append(
+                CheckWarning(
+                    "MEDIA_ROOT and WORKING_DIRECTORY are on different filesystems. "
+                    "It is highly recommended that these live on the same filesystem",
+                    id="pulpcore.W003",
+                )
+            )
+
+    return warnings
+
+
+@register(Tags.database)
+def check_artifact_checksums(app_configs, **kwargs):
+    from pulpcore.app.models import Artifact, RemoteArtifact
+
+    messages = []
+    allowed = set(settings.ALLOWED_CONTENT_CHECKSUMS)
+    forbidden = set(constants.ALL_KNOWN_CONTENT_CHECKSUMS).difference(allowed)
+
+    try:
+        for checksum in allowed:
+            if Artifact.objects.filter(**{checksum: None}).exists():
+                messages.append(
+                    CheckError(
+                        f"There have been identified artifacts missing checksum '{checksum}'. "
+                        "Run 'pulpcore-manager handle-artifact-checksums' first to populate "
+                        "missing artifact checksums.",
+                        id="pulpcore.E002",
+                    )
+                )
+        for checksum in forbidden:
+            if Artifact.objects.exclude(**{checksum: None}).exists():
+                messages.append(
+                    CheckWarning(
+                        f"There have been identified artifacts with forbidden checksum "
+                        f"'{checksum}'. Run 'pulpcore-manager handle-artifact-checksums' "
+                        "to unset forbidden checksums.",
+                        id="pulpcore.W004",
+                    )
+                )
+
+        has_any_checksum = ~Q(**{c: None for c in constants.ALL_KNOWN_CONTENT_CHECKSUMS})
+        missing_allowed = Q(**{c: None for c in allowed})
+        if RemoteArtifact.objects.filter(has_any_checksum & missing_allowed).exists():
+            messages.append(
+                CheckWarning(
+                    "Detected remote content without allowed checksums. "
+                    "Run 'pulpcore-manager handle-artifact-checksums --report' to "
+                    "view this content.",
+                    id="pulpcore.W005",
+                )
+            )
+    except Exception:
+        messages.append(
+            CheckDebug(
+                "Skipping artifact checksum checks (table may not exist yet).",
+                id="pulpcore.D001",
+            )
+        )
+
+    return messages

{pulpcore-3.28.43 → pulpcore-3.28.44}/pulpcore/app/settings.py

@@ -18,7 +18,6 @@ from pkg_resources import iter_entry_points
 
 from cryptography.fernet import Fernet
 from django.core.exceptions import ImproperlyConfigured
-from django.db import connection
 
 from pulpcore import constants
 
@@ -410,69 +409,6 @@ FORBIDDEN_CHECKSUMS = set(constants.ALL_KNOWN_CONTENT_CHECKSUMS).difference(
     ALLOWED_CONTENT_CHECKSUMS
 )
 
-_SKIPPED_COMMANDS_FOR_CONTENT_CHECKS = [
-    "handle-artifact-checksums",
-    "migrate",
-    "collectstatic",
-    "openapi",
-]
-
-if not (len(sys.argv) >= 2 and sys.argv[1] in _SKIPPED_COMMANDS_FOR_CONTENT_CHECKS):
-    try:
-        with connection.cursor() as cursor:
-            for checksum in ALLOWED_CONTENT_CHECKSUMS:
-                # can't import Artifact here so use a direct db connection
-                cursor.execute(f"SELECT count(pulp_id) FROM core_artifact WHERE {checksum} IS NULL")
-                row = cursor.fetchone()
-                if row[0] > 0:
-                    raise ImproperlyConfigured(
-                        (
-                            "There have been identified artifacts missing checksum '{}'. "
-                            "Run 'pulpcore-manager handle-artifact-checksums' first to populate "
-                            "missing artifact checksums."
-                        ).format(checksum)
-                    )
-            for checksum in FORBIDDEN_CHECKSUMS:
-                # can't import Artifact here so use a direct db connection
-                cursor.execute(
-                    f"SELECT count(pulp_id) FROM core_artifact WHERE {checksum} IS NOT NULL"
-                )
-                row = cursor.fetchone()
-                if row[0] > 0:
-                    raise ImproperlyConfigured(
-                        (
-                            "There have been identified artifacts with forbidden checksum '{}'. "
-                            "Run 'pulpcore-manager handle-artifact-checksums' first to unset "
-                            "forbidden checksums."
-                        ).format(checksum)
-                    )
-
-            # warn if there are remote artifacts with checksums but no allowed checksums
-            cond = " AND ".join([f"{c} IS NULL" for c in constants.ALL_KNOWN_CONTENT_CHECKSUMS])
-            no_checksum_query = f"SELECT pulp_id FROM core_remoteartifact WHERE {cond}"
-            cond = " AND ".join([f"{c} IS NULL" for c in ALLOWED_CONTENT_CHECKSUMS])
-            cursor.execute(
-                f"SELECT count(pulp_id) FROM core_remoteartifact WHERE {cond} AND "
-                f"pulp_id NOT IN ({no_checksum_query})"
-            )
-            row = cursor.fetchone()
-            if row[0] > 0:
-                _logger.warning(
-                    (
-                        "Warning: detected remote content without allowed checksums. "
-                        "Run 'pulpcore-manager handle-artifact-checksums --report' to "
-                        "view this content."
-                    )
-                )
-
-    except ImproperlyConfigured as e:
-        raise e
-    except Exception:
-        # our check could fail if the table hasn't been created yet or we can't get a db connection
-        pass
-    finally:
-        connection.close()
-
 settings.set("V3_API_ROOT", settings.API_ROOT + "api/v3/")  # Not user configurable
 settings.set("V3_DOMAIN_API_ROOT", settings.API_ROOT + "<slug:pulp_domain>/api/v3/")
 settings.set("V3_API_ROOT_NO_FRONT_SLASH", settings.V3_API_ROOT.lstrip("/"))

{pulpcore-3.28.43 → pulpcore-3.28.44}/pulpcore.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pulpcore
-Version: 3.28.43
+Version: 3.28.44
 Summary: Pulp Django Application and Related Modules
 Home-page: https://pulpproject.org
 Author: Pulp Team

{pulpcore-3.28.43 → pulpcore-3.28.44}/pyproject.toml

@@ -89,12 +89,14 @@ ignore = [
     ".github/**",
     "lint_requirements.txt",
     ".flake8",
+    "AGENTS.md",
+    "CLAUDE.md",
 ]
 
 [tool.bumpversion]
 # This section is managed by the plugin template. Do not edit manually.
 
-current_version = "3.28.43"
+current_version = "3.28.44"
 commit = false
 tag = false
 parse = "(?P<major>\\d+)\\.(?P<minor>\\d+)\\.(?P<alpha>0a)?(?P<patch>\\d+)(\\.(?P<release>[a-z]+))?"

{pulpcore-3.28.43 → pulpcore-3.28.44}/setup.py

@@ -8,7 +8,7 @@ with open("requirements.txt") as requirements:
 
 setup(
     name="pulpcore",
-    version="3.28.43",
+    version="3.28.44",
     description="Pulp Django Application and Related Modules",
     long_description=long_description,
     long_description_content_type="text/markdown",

pulpcore-3.28.43/pulpcore/app/checks.py

@@ -1,58 +0,0 @@
-from pathlib import Path
-
-from django.conf import settings
-from django.core.checks import Error as CheckError, Warning as CheckWarning, register
-
-
-@register(deploy=True)
-def content_origin_check(app_configs, **kwargs):
-    messages = []
-    if getattr(settings, "CONTENT_ORIGIN", "UNREACHABLE") == "UNREACHABLE":
-        messages.append(
-            CheckError(
-                "CONTENT_ORIGIN is a required setting but it was not configured. This may be "
-                "caused by invalid read permissions of the settings file. Note that "
-                "CONTENT_ORIGIN is set by the installation automatically.",
-                id="pulpcore.E001",
-            )
-        )
-    return messages
-
-
-@register(deploy=True)
-def storage_paths(app_configs, **kwargs):
-    warnings = []
-
-    if settings.DEFAULT_FILE_STORAGE == "pulpcore.app.models.storage.FileSystem":
-        try:
-            media_root_dev = Path(settings.MEDIA_ROOT).stat().st_dev
-        except OSError:
-            media_root_dev = None
-            warnings.append(
-                CheckWarning(
-                    "Your MEDIA_ROOT setting points to a path that does not exist.",
-                    id="pulpcore.W001",
-                )
-            )
-
-        try:
-            working_dir_dev = Path(settings.WORKING_DIRECTORY).stat().st_dev
-        except OSError:
-            working_dir_dev = None
-            warnings.append(
-                CheckWarning(
-                    "Your WORKING_DIRECTORY setting points to a path that does not exist.",
-                    id="pulpcore.W002",
-                )
-            )
-
-        if media_root_dev and media_root_dev != working_dir_dev:
-            warnings.append(
-                CheckWarning(
-                    "MEDIA_ROOT and WORKING_DIRECTORY are on different filesystems. "
-                    "It is highly recommended that these live on the same filesystem",
-                    id="pulpcore.W003",
-                )
-            )
-
-    return warnings