pulpcore 3.118.2__tar.gz → 3.118.4__tar.gz

{pulpcore-3.118.2 → pulpcore-3.118.4}/CHANGES.md

@@ -8,6 +8,48 @@
 
 [//]: # (towncrier release notes start)
 
+## 3.118.4 (2026-10-21) {: #3.118.4 }
+
+### REST API {: #3.118.4-rest-api }
+
+#### Bugfixes {: #3.118.4-rest-api-bugfix }
+
+- Fixed a foreign key error when a first-time pull-through download fails digest validation; the content app now reports the intended checksum error and closes the connection.
+
+### Plugin API {: #3.118.4-plugin-api }
+
+No significant changes.
+
+### Pulp File {: #3.118.4-pulp-file }
+
+No significant changes.
+
+### Pulp Cert Guard {: #3.118.4-pulp-cert-guard }
+
+No significant changes.
+
+---
+
+## 3.118.3 (2026-10-15) {: #3.118.3 }
+
+### REST API {: #3.118.3-rest-api }
+
+No significant changes.
+
+### Plugin API {: #3.118.3-plugin-api }
+
+No significant changes.
+
+### Pulp File {: #3.118.3-pulp-file }
+
+No significant changes.
+
+### Pulp Cert Guard {: #3.118.3-pulp-cert-guard }
+
+No significant changes.
+
+---
+
 ## 3.118.2 (2026-10-13) {: #3.118.2 }
 
 ### REST API {: #3.118.2-rest-api }

{pulpcore-3.118.2 → pulpcore-3.118.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pulpcore
-Version: 3.118.2
+Version: 3.118.4
 Summary: Pulp Django Application and Related Modules
 Author-email: Pulp Team <pulp-list@redhat.com>
 License-Expression: GPL-2.0-or-later

{pulpcore-3.118.2 → pulpcore-3.118.4}/pulp_certguard/app/__init__.py

@@ -6,6 +6,6 @@ class PulpCertGuardPluginAppConfig(PulpPluginAppConfig):
 
     name = "pulp_certguard.app"
     label = "certguard"
-    version = "3.118.2"
+    version = "3.118.4"
     python_package_name = "pulpcore"
     domain_compatible = True

{pulpcore-3.118.2 → pulpcore-3.118.4}/pulp_file/app/__init__.py

@@ -8,6 +8,6 @@ class PulpFilePluginAppConfig(PulpPluginAppConfig):
 
     name = "pulp_file.app"
     label = "file"
-    version = "3.118.2"
+    version = "3.118.4"
     python_package_name = "pulpcore"
     domain_compatible = True

{pulpcore-3.118.2 → pulpcore-3.118.4}/pulpcore/app/apps.py

@@ -238,7 +238,7 @@ class PulpAppConfig(PulpPluginAppConfig):
     label = "core"
 
     # The version of this app
-    version = "3.118.2"
+    version = "3.118.4"
 
     # The python package name providing this app
     python_package_name = "pulpcore"

{pulpcore-3.118.2 → pulpcore-3.118.4}/pulpcore/content/__init__.py

@@ -58,18 +58,18 @@ async def _heartbeat():
     msg = "Content App '{name}' heartbeat written, sleeping for '{interarrival}' seconds".format(
         name=name, interarrival=heartbeat_interval
     )
-    fail_msg = ("Content App '{name}' failed to write a heartbeat to the database.").format(
-        name=name
-    )
+    fail_msg = f"Content App '{name}' failed to register or write a heartbeat to the database."
     versions = {app.label: app.version for app in pulp_plugin_configs()}
-
     try:
         app_status = await AppStatus.objects.acreate(
             name=name, app_type="content", versions=versions
         )
     except IntegrityError:
         log.error(f"A content app with name {name} already exists in the database.")
-        exit(Arbiter.WORKER_BOOT_ERROR)
+        os._exit(Arbiter.WORKER_BOOT_ERROR)
+    except (InterfaceError, DatabaseError) as e:
+        log.error(f"Content App '{name}' failed to register with the database. Exception: {str(e)}")
+        os._exit(Arbiter.WORKER_BOOT_ERROR)
     try:
         while True:
             await asyncio.sleep(heartbeat_interval)
@@ -83,7 +83,7 @@ async def _heartbeat():
                     log.debug(msg)
                 except (InterfaceError, DatabaseError) as e:
                     log.error(f"{fail_msg} Exception: {str(e)}")
-                    exit(Arbiter.WORKER_BOOT_ERROR)
+                    os._exit(Arbiter.WORKER_BOOT_ERROR)
     finally:
         if app_status:
             await app_status.adelete()

{pulpcore-3.118.2 → pulpcore-3.118.4}/pulpcore/content/handler.py

@@ -1352,8 +1352,11 @@ class Handler:
                 extra_data={"disable_retry_list": (DigestValidationError,)}
             )
         except DigestValidationError:
-            remote_artifact.failed_at = timezone.now()
-            await remote_artifact.asave()
+            # First-time pull-through RAs point at an unsaved ContentArtifact, so saving would
+            # violate the foreign key.
+            if not remote_artifact.content_artifact._state.adding:
+                remote_artifact.failed_at = timezone.now()
+                await remote_artifact.asave()
             close_tcp_connection(request.transport._sock)
             REMOTE_CONTENT_FETCH_FAILURE_COOLDOWN = settings.REMOTE_CONTENT_FETCH_FAILURE_COOLDOWN
             raise RuntimeError(

{pulpcore-3.118.2 → pulpcore-3.118.4}/pulpcore/tests/unit/content/test_handler.py

@@ -20,6 +20,7 @@ from pulpcore.content.handler import (
     PathNotResolved,
     _current_distribution,
 )
+from pulpcore.exceptions import DigestValidationError
 from pulpcore.plugin.models import (
     Artifact,
     Content,
@@ -788,3 +789,78 @@ async def test_async_pull_through_add(ca1, monkeypatch, app_status):
         await repo.adelete()
         if task:
             await task.adelete()
+
+
+@pytest.fixture
+def digest_failure_downloader(monkeypatch):
+    class FailingDownloader:
+        path = None
+
+        async def handle_data(self, data):
+            pass
+
+        async def finalize(self):
+            pass
+
+        async def run(self, extra_data=None):
+            raise DigestValidationError("actual", "expected", url="https://123/c123")
+
+    monkeypatch.setattr(Remote, "get_downloader", lambda self, **kwargs: FailingDownloader())
+    close_mock = Mock()
+    monkeypatch.setattr("pulpcore.content.handler.close_tcp_connection", close_mock)
+    return close_mock
+
+
+def _failing_stream_args():
+    request = Mock(match_info={"path": "c123"}, http_range=Mock(start=None, stop=None))
+    response = web.StreamResponse()
+    response.write_eof = AsyncMock()
+    return request, response
+
+
+def _assert_not_completed_cleanly(close_mock, request, response):
+    """The connection is force-closed and the response is never finished for the client."""
+    close_mock.assert_called_once_with(request.transport._sock)
+    response.write_eof.assert_not_awaited()
+
+
+@pytest.mark.asyncio
+@pytest.mark.django_db
+async def test_pull_through_digest_failure_new_content_artifact(digest_failure_downloader):
+    """A failed digest on a first-time pull-through raises the checksum error, not IntegrityError."""
+    remote = await create_remote()
+    ca = ContentArtifact(relative_path="c123")
+    ra = RemoteArtifact(remote=remote, url="https://123/c123", content_artifact=ca, sha256="bad")
+    request, response = _failing_stream_args()
+
+    try:
+        with pytest.raises(RuntimeError, match="failed checksum validation"):
+            await Handler()._stream_remote_artifact(request, response, ra, save_artifact=True)
+        _assert_not_completed_cleanly(digest_failure_downloader, request, response)
+        assert ra.failed_at is None
+        assert not await RemoteArtifact.objects.filter(url="https://123/c123").aexists()
+    finally:
+        await remote.adelete()
+
+
+@pytest.mark.asyncio
+@pytest.mark.django_db
+async def test_pull_through_digest_failure_existing_content_artifact(digest_failure_downloader):
+    """A failed digest on an existing ContentArtifact still records failed_at."""
+    content = await create_content()
+    ca = await create_content_artifact(content)
+    remote = await create_remote()
+    ra = await RemoteArtifact.objects.acreate(
+        remote=remote, url="https://123/c123", content_artifact=ca, sha256="bad"
+    )
+    request, response = _failing_stream_args()
+
+    try:
+        with pytest.raises(RuntimeError, match="failed checksum validation"):
+            await Handler()._stream_remote_artifact(request, response, ra, save_artifact=True)
+        _assert_not_completed_cleanly(digest_failure_downloader, request, response)
+        await ra.arefresh_from_db()
+        assert ra.failed_at is not None
+    finally:
+        await content.adelete()
+        await remote.adelete()

pulpcore-3.118.4/pulpcore/tests/unit/content/test_heartbeat.py

@@ -0,0 +1,55 @@
+from unittest.mock import AsyncMock, Mock
+
+import pytest
+from django.db.utils import IntegrityError, InterfaceError, OperationalError
+from gunicorn.arbiter import Arbiter
+
+from pulpcore.app.models.status import AppStatus, AppStatusManager
+from pulpcore.content import _heartbeat
+from pulpcore.content.handler import Handler
+
+
+class MockException(Exception):
+    pass
+
+
+@pytest.mark.parametrize("error_class", [InterfaceError, OperationalError])
+@pytest.mark.asyncio
+async def test_exits_on_heartbeat_database_failure(monkeypatch, settings, error_class):
+    mock_app_status = AsyncMock()
+    mock_app_status.asave_heartbeat.side_effect = [error_class(), error_class()]
+    mock_acreate = AsyncMock()
+    mock_acreate.return_value = mock_app_status
+    monkeypatch.setattr(AppStatusManager, "acreate", mock_acreate)
+    monkeypatch.setattr(AppStatus, "objects", AppStatusManager())
+    mock_reset_db = Mock()
+    monkeypatch.setattr(Handler, "_reset_db_connection", mock_reset_db)
+    mock_exit = Mock(side_effect=SystemExit(Arbiter.WORKER_BOOT_ERROR))
+    monkeypatch.setattr("pulpcore.content.os._exit", mock_exit)
+    settings.CONTENT_APP_TTL = 1
+    monkeypatch.setattr("pulpcore.content.asyncio.sleep", AsyncMock(return_value=None))
+
+    with pytest.raises(SystemExit) as exc:
+        await _heartbeat()
+
+    assert exc.value.code == Arbiter.WORKER_BOOT_ERROR
+    assert mock_app_status.asave_heartbeat.await_count == 2
+    mock_reset_db.assert_called_once_with()
+    mock_exit.assert_called_once_with(Arbiter.WORKER_BOOT_ERROR)
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize("error_class", [IntegrityError, OperationalError])
+async def test_exits_on_initial_registration_database_failure(monkeypatch, settings, error_class):
+    mock_acreate = AsyncMock(side_effect=error_class())
+    monkeypatch.setattr(AppStatusManager, "acreate", mock_acreate)
+    monkeypatch.setattr(AppStatus, "objects", AppStatusManager())
+    mock_exit = Mock(side_effect=SystemExit(Arbiter.WORKER_BOOT_ERROR))
+    monkeypatch.setattr("pulpcore.content.os._exit", mock_exit)
+
+    with pytest.raises(SystemExit) as exc:
+        await _heartbeat()
+
+    assert exc.value.code == Arbiter.WORKER_BOOT_ERROR
+    mock_exit.assert_called_once_with(Arbiter.WORKER_BOOT_ERROR)
+    assert mock_acreate.await_count == 1

{pulpcore-3.118.2 → pulpcore-3.118.4}/pulpcore.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pulpcore
-Version: 3.118.2
+Version: 3.118.4
 Summary: Pulp Django Application and Related Modules
 Author-email: Pulp Team <pulp-list@redhat.com>
 License-Expression: GPL-2.0-or-later

{pulpcore-3.118.2 → pulpcore-3.118.4}/pyproject.toml

@@ -7,7 +7,7 @@ build-backend = 'setuptools.build_meta'
 
 [project]
 name = "pulpcore"
-version = "3.118.2"
+version = "3.118.4"
 description = "Pulp Django Application and Related Modules"
 readme = "README.md"
 authors = [
@@ -207,7 +207,7 @@ ignore = [
 [tool.bumpversion]
 # This section is managed by the plugin template. Do not edit manually.
 
-current_version = "3.118.2"
+current_version = "3.118.4"
 commit = false
 tag = false
 parse = "(?P<major>\\d+)\\.(?P<minor>\\d+)\\.(?P<alpha>0a)?(?P<patch>\\d+)(\\.(?P<release>[a-z]+))?"

pulpcore-3.118.2/pulpcore/tests/unit/content/test_heartbeat.py

@@ -1,37 +0,0 @@
-from unittest.mock import AsyncMock, Mock, call
-
-import pytest
-from django.db.utils import InterfaceError, OperationalError
-
-from pulpcore.app.models.status import AppStatus, AppStatusManager
-from pulpcore.content import _heartbeat
-from pulpcore.content.handler import Handler
-
-
-class MockException(Exception):
-    pass
-
-
-@pytest.mark.parametrize("error_class", [InterfaceError, OperationalError])
-@pytest.mark.asyncio
-async def test_db_connection_interface_error(monkeypatch, settings, error_class):
-    """
-    Test that if an InterfaceError or OperationalError is raised,
-    Handler._reset_db_connection() is called
-    """
-
-    mock_app_status = AsyncMock()
-    mock_app_status.asave_heartbeat.side_effect = [error_class(), error_class()]
-    mock_acreate = AsyncMock()
-    mock_acreate.return_value = mock_app_status
-    monkeypatch.setattr(AppStatusManager, "acreate", mock_acreate)
-    monkeypatch.setattr(AppStatus, "objects", AppStatusManager())
-    mock_reset_db = Mock()
-    monkeypatch.setattr(Handler, "_reset_db_connection", mock_reset_db)
-    settings.CONTENT_APP_TTL = 1
-
-    with pytest.raises(SystemExit):
-        await _heartbeat()
-
-    mock_app_status.asave_heartbeat.assert_called()
-    mock_reset_db.assert_has_calls([call()])