pulpcore 3.104.0__tar.gz → 3.104.2__tar.gz

{pulpcore-3.104.0 → pulpcore-3.104.2}/CHANGES.md

@@ -8,6 +8,54 @@
 
 [//]: # (towncrier release notes start)
 
+## 3.104.2 (2026-03-05) {: #3.104.2 }
+
+### REST API {: #3.104.2-rest-api }
+
+#### Bugfixes {: #3.104.2-rest-api-bugfix }
+
+- Fixed a typo in `GroupRoleSerializer` that caused a 500 error when listing group roles with a domain set.
+  [#7095](https://github.com/pulp/pulpcore/issues/7095)
+- Fixed RemoteSerializer to fail when it contains invalid parameters.
+  [#7385](https://github.com/pulp/pulpcore/issues/7385)
+
+### Plugin API {: #3.104.2-plugin-api }
+
+No significant changes.
+
+### Pulp File {: #3.104.2-pulp-file }
+
+No significant changes.
+
+### Pulp Cert Guard {: #3.104.2-pulp-cert-guard }
+
+No significant changes.
+
+---
+
+## 3.104.1 (2026-03-02) {: #3.104.1 }
+
+### REST API {: #3.104.1-rest-api }
+
+#### Bugfixes {: #3.104.1-rest-api-bugfix }
+
+- Fix regression (crash) during retain_repo_versions cleanup.
+  [#7371](https://github.com/pulp/pulpcore/issues/7371)
+
+### Plugin API {: #3.104.1-plugin-api }
+
+No significant changes.
+
+### Pulp File {: #3.104.1-pulp-file }
+
+No significant changes.
+
+### Pulp Cert Guard {: #3.104.1-pulp-cert-guard }
+
+No significant changes.
+
+---
+
 ## 3.104.0 (2026-02-24) {: #3.104.0 }
 
 ### REST API {: #3.104.0-rest-api }

{pulpcore-3.104.0 → pulpcore-3.104.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pulpcore
-Version: 3.104.0
+Version: 3.104.2
 Summary: Pulp Django Application and Related Modules
 Author-email: Pulp Team <pulp-list@redhat.com>
 License-Expression: GPL-2.0-or-later

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulp_certguard/app/__init__.py

@@ -6,6 +6,6 @@ class PulpCertGuardPluginAppConfig(PulpPluginAppConfig):
 
     name = "pulp_certguard.app"
     label = "certguard"
-    version = "3.104.0"
+    version = "3.104.2"
     python_package_name = "pulpcore"
     domain_compatible = True

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulp_file/app/__init__.py

@@ -8,6 +8,6 @@ class PulpFilePluginAppConfig(PulpPluginAppConfig):
 
     name = "pulp_file.app"
     label = "file"
-    version = "3.104.0"
+    version = "3.104.2"
     python_package_name = "pulpcore"
     domain_compatible = True

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulpcore/app/apps.py

@@ -239,7 +239,7 @@ class PulpAppConfig(PulpPluginAppConfig):
     label = "core"
 
     # The version of this app
-    version = "3.104.0"
+    version = "3.104.2"
 
     # The python package name providing this app
     python_package_name = "pulpcore"

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulpcore/app/management/commands/datarepair.py

@@ -58,7 +58,6 @@ class Command(BaseCommand):
                             rv._content_relationships().values_list("content__pk", flat=True)
                         )
                         if cached_id_set != repositorycontent_id_set:
-                            number_broken += 1
                             if not has_printed_domain:
                                 self.stdout.write(f'In domain "{domain.name}"')
                                 has_printed_domain = True
@@ -73,12 +72,16 @@ class Command(BaseCommand):
                     repositorycontent_id_count = rv._content_relationships().count()
                     if repositorycontent_id_count == 0:
                         continue
-                    rv_count_details = models.RepositoryVersionContentDetails.objects.get(
+                    rv_count_details = models.RepositoryVersionContentDetails.objects.filter(
                         repository_version=rv,
                         count_type=models.RepositoryVersionContentDetails.PRESENT,
                     )
 
-                    if rv_count_details.count != repositorycontent_id_count:
+                    # need to sum across all content types
+                    total_count = sum(rvcd.count for rvcd in rv_count_details)
+
+                    if total_count != repositorycontent_id_count:
+                        needs_fix = True
                         if not has_printed_domain:
                             self.stdout.write(f'In domain "{domain.name}"')
                             has_printed_domain = True
@@ -88,12 +91,15 @@ class Command(BaseCommand):
                             "RepositoryContent and RepositoryVersionContentDetails"
                         )
 
-                    if needs_fix and not dry_run:
-                        rv.content_ids = list(
-                            rv._content_relationships().values_list("content__pk", flat=True)
-                        )
-                        rv.save()
-                        rv._compute_counts()
+                    if needs_fix:
+                        number_broken += 1
+
+                        if not dry_run:
+                            rv.content_ids = list(
+                                rv._content_relationships().values_list("content__pk", flat=True)
+                            )
+                            rv.save()
+                            rv._compute_counts()
 
             self.stdout.write()
 
@@ -101,7 +107,10 @@ class Command(BaseCommand):
             self.stdout.write("Finished. (OK)")
         else:
             if dry_run:
-                self.stdout.write("Finished. (no changes)")
+                self.stdout.write(
+                    f"Finished. (dry run: {number_broken} incorrect repository versions "
+                    f"- no changes)"
+                )
             else:
                 self.stdout.write(f"Finished. ({number_broken} repository versions fixed)")
 

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulpcore/app/models/repository.py

@@ -1313,7 +1313,8 @@ class RepositoryVersion(BaseModel):
         """
         with transaction.atomic():
             # relatively inexpensive sanity check for memoization
-            assert len(self.content_ids) == self._content_relationships().count()
+            if self.content_ids:
+                assert len(self.content_ids) == self._content_relationships().count()
             # delete existing content details and recompute them all
             RepositoryVersionContentDetails.objects.filter(repository_version=self).delete()
             counts_list = []

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulpcore/app/serializers/repository.py

@@ -73,7 +73,7 @@ class RepositorySerializer(ModelSerializer):
         )
 
 
-class RemoteSerializer(RemoteNetworkConfigSerializer, ModelSerializer, HiddenFieldsMixin):
+class RemoteSerializer(ModelSerializer, RemoteNetworkConfigSerializer, HiddenFieldsMixin):
     """
     Every remote defined by a plugin should have a Remote serializer that inherits from this
     class. Please import from `pulpcore.plugin.serializers` rather than from this module directly.

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulpcore/app/serializers/user.py

@@ -419,7 +419,7 @@ class GroupRoleSerializer(ValidateRoleMixin, ModelSerializer, NestedHyperlinkedM
         help_text=_(
             "Domain this role should be applied on, mutually exclusive with content_object."
         ),
-        view_name="domain-detail",
+        view_name="domains-detail",
         queryset=Domain.objects.all(),
         allow_null=True,
         required=False,

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulpcore/tests/functional/api/test_users_groups.py

@@ -73,3 +73,22 @@ def test_groups_add_bad_user(pulpcore_bindings, gen_object_with_cleanup):
     ).pulp_href
     with pytest.raises(ApiException, match="foo"):
         pulpcore_bindings.GroupsUsersApi.create(group_href, group_user={"username": "foo"})
+
+
+@pytest.mark.parallel
+def test_group_roles_with_domain(pulpcore_bindings, gen_object_with_cleanup):
+    """Test that group roles with a domain can be listed and serialized.
+
+    Regression test for https://github.com/pulp/pulpcore/issues/7095
+    """
+    group = gen_object_with_cleanup(pulpcore_bindings.GroupsApi, {"name": str(uuid.uuid4())})
+    default_domain = pulpcore_bindings.DomainsApi.list(name="default").results[0]
+    gen_object_with_cleanup(
+        pulpcore_bindings.GroupsRolesApi,
+        group.pulp_href,
+        {"role": "core.task_viewer", "content_object": None, "domain": default_domain.pulp_href},
+    )
+
+    roles = pulpcore_bindings.GroupsRolesApi.list(group.pulp_href)
+    assert roles.count == 1
+    assert roles.results[0].domain == default_domain.pulp_href

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulpcore/tests/unit/serializers/test_repository.py

@@ -255,3 +255,13 @@ def test_validate_repo_remote_via_publication(monkeypatch, field):
     serializer = DistributionSerializer()
     with pytest.raises(serializers.ValidationError, match=error_msg):
         serializer.validate(data)
+
+
+def test_create_remote_with_invalid_parameter():
+    """
+    Test that the creation of a RemoteSerializer with an invalid parameter fails.
+    """
+    data = {**MINIMAL_DATA, "foo": "bar"}
+    serializer = RemoteSerializer(data=data)
+    with pytest.raises(serializers.ValidationError, match="Unexpected field"):
+        serializer.validate(data)

{pulpcore-3.104.0 → pulpcore-3.104.2}/pulpcore.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pulpcore
-Version: 3.104.0
+Version: 3.104.2
 Summary: Pulp Django Application and Related Modules
 Author-email: Pulp Team <pulp-list@redhat.com>
 License-Expression: GPL-2.0-or-later

{pulpcore-3.104.0 → pulpcore-3.104.2}/pyproject.toml

@@ -7,7 +7,7 @@ build-backend = 'setuptools.build_meta'
 
 [project]
 name = "pulpcore"
-version = "3.104.0"
+version = "3.104.2"
 description = "Pulp Django Application and Related Modules"
 readme = "README.md"
 authors = [
@@ -206,7 +206,7 @@ ignore = [
 [tool.bumpversion]
 # This section is managed by the plugin template. Do not edit manually.
 
-current_version = "3.104.0"
+current_version = "3.104.2"
 commit = false
 tag = false
 parse = "(?P<major>\\d+)\\.(?P<minor>\\d+)\\.(?P<alpha>0a)?(?P<patch>\\d+)(\\.(?P<release>[a-z]+))?"