pull-request-fixer 0.1.8__tar.gz → 0.1.9__tar.gz

{pull_request_fixer-0.1.8 → pull_request_fixer-0.1.9}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: pull-request-fixer
-Version: 0.1.8
+Version: 0.1.9
 Summary: Fix GitHub pull request titles, descriptions and files, for one pull request or across an organization
 Project-URL: Homepage, https://github.com/lfreleng-actions/pull-request-fixer
 Project-URL: Repository, https://github.com/lfreleng-actions/pull-request-fixer.git
@@ -306,8 +306,8 @@ These flags apply to the `git` method only:
   <noreply@linuxfoundation.org>` without signing
 
 If your global Git configuration has no `user.name` or `user.email`, the
-tool falls back to the bot identity. You cannot combine `--bot-identity`
-with `--disable-signing`.
+tool falls back to the bot identity, without signing. You cannot combine
+`--bot-identity` with `--disable-signing`.
 
 ### Previewing changes
 

{pull_request_fixer-0.1.8 → pull_request_fixer-0.1.9}/README.md

@@ -264,8 +264,8 @@ These flags apply to the `git` method only:
   <noreply@linuxfoundation.org>` without signing
 
 If your global Git configuration has no `user.name` or `user.email`, the
-tool falls back to the bot identity. You cannot combine `--bot-identity`
-with `--disable-signing`.
+tool falls back to the bot identity, without signing. You cannot combine
+`--bot-identity` with `--disable-signing`.
 
 ### Previewing changes
 

{pull_request_fixer-0.1.8 → pull_request_fixer-0.1.9}/pyproject.toml

@@ -118,9 +118,17 @@ skip-magic-trailing-comma = false
 line-ending = "auto"
 
 [tool.basedpyright]
-pythonVersion = "3.12"
+# Check against the oldest supported Python (requires-python >= 3.10), so
+# use of a newer standard library API is reported rather than hidden.
+pythonVersion = "3.10"
 pythonPlatform = "All"
 typeCheckingMode = "standard"
+# Scope a bare ``basedpyright`` invocation to our own code.  The
+# pre-commit hook passes these same paths as explicit targets with
+# ``pass_filenames: false`` (explicit arguments override ``include``);
+# this list governs the runs that supply no targets --- a bare
+# ``basedpyright`` on the command line, and an editor's language server
+# --- so those analyse the same set the hook does.
 include = ["src", "tests", "scripts", "test_blocked_pr_logic.py", "test_integration.py"]
 exclude = [
     "src/pull_request_fixer/_version.py",
@@ -130,17 +138,25 @@ exclude = [
 ]
 
 # --- Errors we want to catch and fix ---
-reportMissingTypeArgument = "warning"
-reportOptionalMemberAccess = "warning"
-reportCallIssue = "warning"
-reportAssignmentType = "warning"
-reportReturnType = "warning"
-reportGeneralTypeIssues = "warning"
-reportUninitializedInstanceVariable = "warning"
+# These are genuine type defects, so they fail the build.  The
+# ``--warnings`` flag on the pre-commit hook additionally fails on any
+# rule still classified as a warning, so a newly introduced diagnostic
+# cannot slip through by virtue of its default severity.
+reportMissingTypeArgument = "error"
+reportOptionalMemberAccess = "error"
+reportCallIssue = "error"
+reportAssignmentType = "error"
+reportReturnType = "error"
+reportGeneralTypeIssues = "error"
+reportUninitializedInstanceVariable = "error"
 
 # --- Intentional patterns we suppress ---
 # Third-party imports cannot be resolved in pre-commit.ci sandbox
 reportMissingImports = false
+# Same cause, different symptom: a typed stub can resolve in the sandbox
+# without the package source.  An artefact of where the check runs, not
+# of the code.
+reportMissingModuleSource = false
 # Typer uses Option() calls in parameter defaults by design
 reportCallInDefaultInitializer = false
 # Typer parameters are consumed by the framework, not the function body

{pull_request_fixer-0.1.8 → pull_request_fixer-0.1.9}/src/pull_request_fixer/_version.py

@@ -18,7 +18,7 @@ version_tuple: tuple[int | str, ...]
 commit_id: str | None
 __commit_id__: str | None
 
-__version__ = version = '0.1.8'
-__version_tuple__ = version_tuple = (0, 1, 8)
+__version__ = version = '0.1.9'
+__version_tuple__ = version_tuple = (0, 1, 9)
 
 __commit_id__ = commit_id = None

{pull_request_fixer-0.1.8 → pull_request_fixer-0.1.9}/src/pull_request_fixer/cli.py

@@ -146,6 +146,7 @@ app = typer.Typer(
 
 # aislop-ignore-next-line complexity/function-too-long -- top-level CLI command
 def main(
+    *,
     target: str = typer.Argument(
         None,
         help="GitHub organization name/URL or PR URL (e.g., 'myorg', 'https://github.com/myorg', or 'https://github.com/owner/repo/pull/123')",
@@ -695,8 +696,8 @@ async def process_single_pr(
                             owner,
                             repo_name,
                             pr_number,
-                            result,
-                            command_args,
+                            result=result,
+                            command_args=command_args,
                         )
 
                 return
@@ -945,8 +946,8 @@ async def _process_pr_files(
                     owner,
                     repo_name,
                     pr_number,
-                    result,
-                    command_args,
+                    result=result,
+                    command_args=command_args,
                 )
 
         return result_dict
@@ -1278,6 +1279,7 @@ async def scan_and_fix_organization(
 # aislop-ignore-next-line complexity/function-too-long -- single-PR processing flow
 async def process_pr(
     client: GitHubClient,
+    *,
     owner: str,
     repo_name: str,
     pr_data: dict[str, Any],
@@ -1737,6 +1739,7 @@ async def create_file_fix_comment(
     owner: str,
     repo: str,
     pr_number: int,
+    *,
     result: GitHubFixResult,
     command_args: dict[str, Any],
 ) -> None:

{pull_request_fixer-0.1.8 → pull_request_fixer-0.1.9}/src/pull_request_fixer/git_config.py

@@ -74,6 +74,34 @@ def _set_repo_git_config(repo_dir: Path, key: str, value: str) -> bool:
         return False
 
 
+def _apply_bot_identity(
+    repo_dir: Path, bot_name: str, bot_email: str, mode: str
+) -> dict[str, str]:
+    """Configure the bot identity with commit signing disabled.
+
+    Signing is switched off explicitly so a global ``commit.gpgsign=true``
+    cannot make the bot attempt to sign with a key it does not have.
+
+    Args:
+        repo_dir: Repository directory path
+        bot_name: Bot name to commit as
+        bot_email: Bot email to commit as
+        mode: Mode label recorded in the returned configuration
+
+    Returns:
+        Dict with applied configuration details
+    """
+    _set_repo_git_config(repo_dir, "user.name", bot_name)
+    _set_repo_git_config(repo_dir, "user.email", bot_email)
+    _set_repo_git_config(repo_dir, "commit.gpgsign", "false")
+    return {
+        "user.name": bot_name,
+        "user.email": bot_email,
+        "commit.gpgsign": "false",
+        "mode": mode,
+    }
+
+
 def configure_git_identity(
     repo_dir: Path,
     mode: str = GitConfigMode.USER_INHERIT,
@@ -99,17 +127,11 @@ def configure_git_identity(
         msg = f"Invalid mode: {mode}"
         raise ValueError(msg)
 
-    applied_config: dict[str, str] = {}
-
     if mode == GitConfigMode.BOT_IDENTITY:
-        # Use bot identity without signing
         logger.debug("Configuring git with bot identity (no signing)")
-        _set_repo_git_config(repo_dir, "user.name", bot_name)
-        _set_repo_git_config(repo_dir, "user.email", bot_email)
-        applied_config["user.name"] = bot_name
-        applied_config["user.email"] = bot_email
-        applied_config["mode"] = "bot_identity"
-        return applied_config
+        return _apply_bot_identity(
+            repo_dir, bot_name, bot_email, "bot_identity"
+        )
 
     # For USER_INHERIT and USER_NO_SIGN modes, try to get user's config
     user_name = _get_global_git_config("user.name")
@@ -119,12 +141,11 @@ def configure_git_identity(
         logger.warning(
             "User git config not found, falling back to bot identity"
         )
-        _set_repo_git_config(repo_dir, "user.name", bot_name)
-        _set_repo_git_config(repo_dir, "user.email", bot_email)
-        applied_config["user.name"] = bot_name
-        applied_config["user.email"] = bot_email
-        applied_config["mode"] = "bot_identity_fallback"
-        return applied_config
+        return _apply_bot_identity(
+            repo_dir, bot_name, bot_email, "bot_identity_fallback"
+        )
+
+    applied_config: dict[str, str] = {}
 
     # Set user identity
     _set_repo_git_config(repo_dir, "user.name", user_name)

{pull_request_fixer-0.1.8 → pull_request_fixer-0.1.9}/src/pull_request_fixer/github_client.py

@@ -550,6 +550,7 @@ class GitHubClient:
         owner: str,
         repo: str,
         path: str,
+        *,
         content: str,
         message: str,
         branch: str,

{pull_request_fixer-0.1.8 → pull_request_fixer-0.1.9}/src/pull_request_fixer/pr_file_fixer.py

@@ -788,7 +788,12 @@ class PRFileFixer:
 
         for file_data in matching_files:
             result = await self._apply_fix_to_file(
-                fixer, file_data, owner, repo, branch, spec
+                fixer,
+                file_data,
+                owner=owner,
+                repo=repo,
+                branch=branch,
+                spec=spec,
             )
             if result is None:
                 continue
@@ -811,6 +816,7 @@ class PRFileFixer:
         self,
         fixer: FileFixer,
         file_data: dict[str, Any],
+        *,
         owner: str,
         repo: str,
         branch: str,
@@ -946,10 +952,10 @@ class PRFileFixer:
                     owner,
                     repo,
                     file_info["path"],
-                    file_info["content"],
-                    commit_message,
-                    branch,
-                    current_sha,
+                    content=file_info["content"],
+                    message=commit_message,
+                    branch=branch,
+                    sha=current_sha,
                 )
                 self.logger.debug(
                     f"Successfully updated {file_info['path']} (fallback)"