prodc 0.7.0__tar.gz → 0.7.2__tar.gz

{prodc-0.7.0 → prodc-0.7.2}/CHANGELOG.md

@@ -4,6 +4,22 @@ All notable changes are documented here. Versioning is [SemVer](https://semver.o
 
 ## [Unreleased]
 
+### Fixed
+
+- A vitest or Playwright proof now finds a test whose title is a template literal: the locator
+  `at most 50 rows` matches `it(`at most ${LIMIT} rows`)`. Before, the proof was BROKEN.
+
+## [0.7.1] - 2026-11-09
+
+### Changed
+
+- `ux-miller` recipe: replaced placeholder with a source-scanning vitest guard that tests
+  a named page-size constant against the agreed threshold (derived from crm
+  `apps/website/src/design/millerLaw.guard.test.ts`).
+- `ux-jakob` recipe: replaced placeholder playwright test with a source-scanning vitest guard
+  that checks every dialog/modal for the shared Escape hook and verifies the logo link in
+  Nav.tsx (derived from crm `apps/website/src/design/jakobLaw.guard.test.ts`).
+
 ## [0.7.0] - 2026-11-09
 
 ### Added

{prodc-0.7.0 → prodc-0.7.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: prodc
-Version: 0.7.0
+Version: 0.7.2
 Summary: Product management as code: roles, flows, and features traced to evidence.
 Project-URL: Homepage, https://gitlab.com/cardona-oss/prodc
 Project-URL: Repository, https://gitlab.com/cardona-oss/prodc

{prodc-0.7.0 → prodc-0.7.2}/src/prodc/__init__.py

@@ -1,3 +1,3 @@
 """prodc: product management as code."""
 
-__version__ = "0.7.0"  # the single source of truth; pyproject reads it via [tool.hatch.version]
+__version__ = "0.7.2"  # the single source of truth; pyproject reads it via [tool.hatch.version]

{prodc-0.7.0 → prodc-0.7.2}/src/prodc/adapters.py

@@ -580,18 +580,37 @@ class VitestAdapter:
 def _titles_missing(text: str, title: str, sep: str) -> str | None:
     """The first segment of ``title`` that does not appear in a test file's source, else None.
 
-    Each title segment must appear in the source. A quote escaped in the literal is tolerated.
+    Each title segment must appear in the source. A quote escaped in the literal is tolerated. A
+    segment also matches a template-literal title when it is that title with each ``${...}``
+    filled in, as vitest and Playwright render it (``at most ${LIMIT} rows`` matches
+    ``at most 50 rows``).
     """
+    templates = _template_titles(text)
     for seg in (s.strip() for s in title.split(sep)):
         if (
             seg not in text
             and seg.replace("'", "\\'") not in text
             and seg.replace('"', '\\"') not in text
+            and not any(t.fullmatch(seg) for t in templates)
         ):
             return seg
     return None
 
 
+#: A backtick string holding at least one ``${...}`` substitution.
+_TEMPLATE_RE = re.compile(r"`(?P<body>(?:\\.|[^`\\])*\$\{(?:\\.|[^`\\])*)`")
+_SUBST_RE = re.compile(r"\$\{[^}]*\}")
+
+
+def _template_titles(text: str) -> list[re.Pattern[str]]:
+    """A regex per template literal in ``text``: literal parts escaped, each ``${...}`` as ``.+``."""
+    out: list[re.Pattern[str]] = []
+    for m in _TEMPLATE_RE.finditer(text):
+        parts = _SUBST_RE.split(m["body"])
+        out.append(re.compile(".+".join(re.escape(part) for part in parts), re.DOTALL))
+    return out
+
+
 def _js_inventory(root: Path, patterns: Sequence[str], test_re: re.Pattern[str]) -> list[str]:
     """Every ``file#title`` that ``test_re`` finds; a title with ``${`` is computed, so skipped."""
     out: set[str] = set()

{prodc-0.7.0 → prodc-0.7.2}/src/prodc/catalog/ux.py

@@ -212,24 +212,35 @@ _MILLER = CatalogEntry(
     checkable=True,
     recipe=Recipe(
         kind="vitest",
-        summary="Assert that any list beyond the threshold has pagination or section headers.",
-        # TODO: replace with the guard from crm/tyko once it is extracted.
+        summary="Assert that the page-size constant used by your list components stays at or below the agreed threshold.",
+        # Real guard from crm: apps/website/src/design/millerLaw.guard.test.ts
+        # The guard tests a named constant, not a rendered component; jsdom has no virtual scroll.
+        # Adapt PAGE_SIZE_CONSTANT and the import path for your app.
         snippet="""\
-// tests/design/list-paging.test.ts
-import { render } from '@testing-library/react'
-import { ItemList } from '../src/ItemList'
-
-const THRESHOLD = {N}
-const items = Array.from({ length: THRESHOLD + 1 }, (_, i) => ({ id: i, label: `Item ${i}` }))
-
-test('long list shows a pager or section headers', () => {
-  const { container } = render(<ItemList items={items} />)
-  const hasPager = container.querySelector('[aria-label="pagination"]') !== null
-  const hasGroups = container.querySelectorAll('[role="group"]').length > 1
-  expect(hasPager || hasGroups).toBe(true)
-})
+// src/design/millerLaw.guard.test.ts
+import { describe, expect, it } from "vitest";
+import { PAGE_SIZE_CONSTANT } from "./primitives/pageSize";
+// Replace PAGE_SIZE_CONSTANT with the constant your list component uses, e.g. DESKTOP_PAGE_SIZE.
+
+const LIMIT = {N};
+
+describe("Miller's Law: list page cap stays within agreed bounds", () => {
+  it(`page cap is at most ${LIMIT} rows`, () => {
+    expect(
+      PAGE_SIZE_CONSTANT,
+      `PAGE_SIZE_CONSTANT (${PAGE_SIZE_CONSTANT}) exceeds the ${LIMIT}-row cap — ` +
+        "update this guard and the ux-miller principle YAML if the change is intentional",
+    ).toBeLessThanOrEqual(LIMIT);
+  });
+
+  it("watches a real module: PAGE_SIZE_CONSTANT is defined and positive", () => {
+    // Proves the import resolved and the module exports a real value.
+    expect(typeof PAGE_SIZE_CONSTANT).toBe("number");
+    expect(PAGE_SIZE_CONSTANT).toBeGreaterThan(0);
+  });
+});
 """,
-        proof_locator_hint="vitest:tests/design/list-paging.test.ts::long list shows a pager or section headers",
+        proof_locator_hint="vitest:src/design/millerLaw.guard.test.ts::Miller's Law: list page cap stays within agreed bounds > page cap is at most {N} rows",
     ),
 )
 
@@ -244,28 +255,66 @@ _JAKOB = CatalogEntry(
     ),
     checkable=True,
     recipe=Recipe(
-        kind="playwright",
-        summary="Verify Escape closes dialogs, Enter submits forms, and the logo links home.",
-        # TODO: replace with the guard from crm/tyko once it is extracted.
+        kind="vitest",
+        summary="Source-scan every dialog/modal file for Escape handling and check the logo link in the nav component.",
+        # Real guard from crm: apps/website/src/design/jakobLaw.guard.test.ts
+        # jsdom has no global keydown dispatch in this setup; source scanning is the only way
+        # to verify the structural invariants without spinning up a browser.
+        # Adapt DIALOG_HOOK and the logo assertion to your app's conventions.
         snippet="""\
-// tests/design/conventions.spec.ts
-import { test, expect } from '@playwright/test'
-
-test('Escape closes the dialog', async ({ page }) => {
-  await page.goto('/')
-  await page.click('[data-testid="open-dialog"]')
-  await expect(page.locator('[role="dialog"]')).toBeVisible()
-  await page.keyboard.press('Escape')
-  await expect(page.locator('[role="dialog"]')).not.toBeVisible()
-})
-
-test('logo links to home', async ({ page }) => {
-  await page.goto('/about')
-  await page.click('[data-testid="site-logo"]')
-  await expect(page).toHaveURL('/')
-})
+// src/design/jakobLaw.guard.test.ts
+import { readdirSync, readFileSync, statSync } from "node:fs";
+import { join, relative } from "node:path";
+import { describe, expect, it } from "vitest";
+
+const SRC = join(import.meta.dirname, "..");
+const DIALOG_PATTERN = /(?:Dialog|Modal)\\.tsx$/;
+
+// The shared hook (or keyword) every dialog must use to wire Escape.
+// Adapt to match your app: a hook name, an imported function, or a bare string like "Escape".
+const DIALOG_HOOK = "useDialogFocus";
+
+function dialogFiles(dir: string): string[] {
+  const out: string[] = [];
+  for (const entry of readdirSync(dir)) {
+    const full = join(dir, entry);
+    if (statSync(full).isDirectory()) out.push(...dialogFiles(full));
+    else if (DIALOG_PATTERN.test(entry)) out.push(full);
+  }
+  return out;
+}
+
+describe("Jakob's Law: app conventions match user expectations", () => {
+  it("every dialog and modal file uses the shared Escape handler", () => {
+    const offenders: string[] = [];
+    for (const file of dialogFiles(SRC)) {
+      const src = readFileSync(file, "utf8");
+      if (!src.includes(DIALOG_HOOK)) offenders.push(relative(SRC, file));
+    }
+    expect(
+      offenders,
+      `These dialogs do not use ${DIALOG_HOOK}; Escape will not close them:\\n  ${offenders.join("\\n  ")}`,
+    ).toEqual([]);
+  });
+
+  it("the logo in Nav.tsx links to the home route", () => {
+    const nav = readFileSync(join(SRC, "components/Nav.tsx"), "utf8");
+    // Adapt the regex to match your logo link. The pattern matches the home
+    // route href within 300 characters before the logo element.
+    expect(nav, "logo in Nav.tsx must link to the home route").toMatch(
+      /to="\\/[^"]*"[\\s\\S]{1,300}<(?:Logo|Wordmark|SiteLogo)/,
+    );
+  });
+
+  it("watches a real tree: at least 4 dialog/modal files must exist", () => {
+    expect(
+      dialogFiles(SRC).length,
+      "fewer than 4 dialog/modal files found — the guard may not be scanning the right directory",
+    ).toBeGreaterThanOrEqual(4);
+  });
+});
 """,
-        proof_locator_hint="playwright:tests/design/conventions.spec.ts::Escape closes the dialog",
+        proof_locator_hint="vitest:src/design/jakobLaw.guard.test.ts::Jakob's Law: app conventions match user expectations > every dialog and modal file uses the shared Escape handler",
     ),
 )
 

{prodc-0.7.0 → prodc-0.7.2}/tests/test_vitest.py

@@ -108,3 +108,25 @@ def test_config_builds_vitest_adapter(tmp_path: Path) -> None:
     )
     cfg = Config.load(tmp_path / "prodc.toml")
     assert isinstance(cfg.adapters["fe"], VitestAdapter)
+
+
+_TEMPLATE_TEST = """import { it } from 'vitest'
+const DESKTOP_LIMIT = 50
+it(`desktop page cap is at most ${DESKTOP_LIMIT} rows`, () => {})
+"""
+
+
+def test_template_literal_title_matches_its_rendered_text(tmp_path: Path) -> None:
+    (tmp_path / "m.test.ts").write_text(_TEMPLATE_TEST, encoding="utf-8")
+    adapter = VitestAdapter(tmp_path, None)
+    assert adapter.resolve("m.test.ts#desktop page cap is at most 50 rows").state is (
+        ProofState.DELIVERED
+    )
+
+
+def test_template_literal_title_does_not_match_other_text(tmp_path: Path) -> None:
+    (tmp_path / "m.test.ts").write_text(_TEMPLATE_TEST, encoding="utf-8")
+    adapter = VitestAdapter(tmp_path, None)
+    assert adapter.resolve("m.test.ts#mobile page cap is at most 50 rows").state is (
+        ProofState.BROKEN
+    )