prodc 0.3.77__tar.gz → 0.3.78__tar.gz

{prodc-0.3.77 → prodc-0.3.78}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: prodc
-Version: 0.3.77
+Version: 0.3.78
 Summary: Product management as code: roles, flows, and features traced to evidence.
 Project-URL: Homepage, https://gitlab.com/jorgeecardona/prodc
 Project-URL: Repository, https://gitlab.com/jorgeecardona/prodc

{prodc-0.3.77 → prodc-0.3.78}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "prodc"
-version = "0.3.77"
+version = "0.3.78"
 description = "Product management as code: roles, flows, and features traced to evidence."
 readme = "README.md"
 requires-python = ">=3.12"

{prodc-0.3.77 → prodc-0.3.78}/src/prodc/cli/app.py

@@ -133,6 +133,13 @@ def main(argv: list[str] | None = None) -> int:
     pl.add_argument(
         "--include-drafts", action="store_true", help="include draft (staged) needs (#60)"
     )
+    pl.add_argument(
+        "--revisit",
+        type=int,
+        default=None,
+        metavar="DAYS",
+        help="only needs whose importance is undated or set more than DAYS ago — a refresh pass (#59)",
+    )
     pl.set_defaults(func=cmd_plan)
 
     ar = sub.add_parser("argument", help="show the GSN assurance graph and its defects")

{prodc-0.3.77 → prodc-0.3.78}/src/prodc/cli/commands.py

@@ -37,6 +37,7 @@ from ..status import (
     applicable_needs,
     argument_defects,
     evidence_age_days,
+    importance_revisit_due,
     proof_suggestions,
     recurrence,
     relink_suggestions,
@@ -384,7 +385,20 @@ def cmd_brief(args: argparse.Namespace) -> int:
         return 2
     scoped = applicable_needs(needs, args.client)
     results = resolve(scoped, cfg.adapters, cfg.source_adapters)
-    print(brief_json(args.client, results) if args.json else render_brief(args.client, results))
+    # "Confirm still wanted" (#58): needs whose evidence is older than the stale threshold, to
+    # re-check with the client in the meeting. Only when [lint].stale_after_days is configured.
+    stale: list[tuple[NeedResult, int]] = []
+    if cfg.stale_after_days is not None:
+        today = date.today()
+        for r in results:
+            age = evidence_age_days(r.need, today)
+            if age is not None and age > cfg.stale_after_days:
+                stale.append((r, age))
+    print(
+        brief_json(args.client, results, stale)
+        if args.json
+        else render_brief(args.client, results, stale)
+    )
     return 0
 
 
@@ -397,10 +411,14 @@ def cmd_plan(args: argparse.Namespace) -> int:
     needs = board_needs(list(model.needs), include_drafts=args.include_drafts)  # drafts off (#60)
     results = resolve(needs, cfg.adapters, cfg.source_adapters)
     recurrence_counts = {rec.baseline.id: rec.count for rec in recurrence(needs)}
+    revisit = args.revisit is not None
+    if revisit:
+        today = date.today()
+        results = [r for r in results if importance_revisit_due(r.need, today, args.revisit)]
     print(
-        plan_json(results, recurrence_counts)
+        plan_json(results, recurrence_counts, revisit=revisit)
         if args.json
-        else render_plan(results, recurrence_counts)
+        else render_plan(results, recurrence_counts, revisit=revisit)
     )
     return 0
 
@@ -1090,7 +1108,9 @@ def _cmd_relink(cfg: Config, results: list[NeedResult], args: argparse.Namespace
                 print(f"{s.need.id}: {s.need.text}")
                 last = s.need.id
             print(f"    {s.score:.2f}  {s.broken} → {s.locator}")
-        print(f"suggest --relink: {len(suggestions)} candidate(s) at min-score {args.min_score:.2f}")
+        print(
+            f"suggest --relink: {len(suggestions)} candidate(s) at min-score {args.min_score:.2f}"
+        )
     return 0
 
 
@@ -1136,7 +1156,9 @@ def _apply_relinks(
     else:
         verb = "would relink" if args.dry_run else "relinked"
         for s, edit in applied:
-            print(f"{verb} {s.broken} → {s.locator} on {s.need.id} ({s.score:.2f}) in {edit.path.name}")
+            print(
+                f"{verb} {s.broken} → {s.locator} on {s.need.id} ({s.score:.2f}) in {edit.path.name}"
+            )
             print(edit.diff, end="")
         print(f"suggest --relink --apply: {verb} {len(applied)} locator(s)")
     return 0

{prodc-0.3.77 → prodc-0.3.78}/src/prodc/cli/render.py

@@ -331,7 +331,11 @@ def render_show(r: NeedResult, importance_label: str | None = None) -> str:
     return "\n".join(lines)
 
 
-def render_brief(client: str, results: list[NeedResult]) -> str:
+def render_brief(
+    client: str,
+    results: list[NeedResult],
+    stale: list[tuple[NeedResult, int]] | None = None,
+) -> str:
     open_ = brief_open(results)
     out = [f"brief — {client}: {len(open_)} open question{'s' if len(open_) != 1 else ''}"]
     if not open_:
@@ -347,6 +351,10 @@ def render_brief(client: str, results: list[NeedResult]) -> str:
             if g
         )
         out.append(f"  {bang} {r.need.id:<12} [{gaps}]  {r.need.text}")
+    if stale:
+        out.append(f"  confirm still wanted ({len(stale)} with evidence past the stale threshold):")
+        for r, age in sorted(stale, key=lambda t: (-t[1], t[0].need.id)):
+            out.append(f"    ~ {r.need.id:<12} {age}d old   {r.need.text}")
     return "\n".join(out)
 
 
@@ -359,9 +367,16 @@ def _importance_cell(need: Need) -> str:
     return f"imp={need.importance}{' (guess)' if weak else ''}"
 
 
-def render_plan(results: list[NeedResult], recurrence_counts: dict[str, int]) -> str:
+def render_plan(
+    results: list[NeedResult], recurrence_counts: dict[str, int], *, revisit: bool = False
+) -> str:
     ranked = rank(results, recurrence_counts)
-    out = ["plan — ranked backlog (must + state + evidence + recurrence, importance refines)"]
+    header = (
+        f"plan — revisit: {len(ranked)} need(s) with undated or stale importance (#59)"
+        if revisit
+        else "plan — ranked backlog (must + state + evidence + recurrence, importance refines)"
+    )
+    out = [header]
     for i, r in enumerate(ranked, 1):
         bang = "!!" if r.need.must else "  "
         imp = _importance_cell(r.need)

{prodc-0.3.77 → prodc-0.3.78}/src/prodc/cli/serialize.py

@@ -130,7 +130,11 @@ def show_json(r: NeedResult) -> str:
     return json.dumps(payload, indent=2)
 
 
-def brief_json(client: str, results: list[NeedResult]) -> str:
+def brief_json(
+    client: str,
+    results: list[NeedResult],
+    stale: list[tuple[NeedResult, int]] | None = None,
+) -> str:
     open_ = brief_open(results)
     return json.dumps(
         {
@@ -146,15 +150,22 @@ def brief_json(client: str, results: list[NeedResult]) -> str:
                 }
                 for r in open_
             ],
+            "confirm_still_wanted": [
+                {"id": r.need.id, "text": r.need.text, "evidence_age": age}
+                for r, age in sorted(stale or [], key=lambda t: (-t[1], t[0].need.id))
+            ],
         },
         indent=2,
     )
 
 
-def plan_json(results: list[NeedResult], recurrence_counts: dict[str, int]) -> str:
+def plan_json(
+    results: list[NeedResult], recurrence_counts: dict[str, int], *, revisit: bool = False
+) -> str:
     ranked = rank(results, recurrence_counts)
     return json.dumps(
         {
+            "revisit": revisit,
             "plan": [
                 {
                     "rank": i,
@@ -168,7 +179,7 @@ def plan_json(results: list[NeedResult], recurrence_counts: dict[str, int]) -> s
                     "importance_is_guess": (r.need.importance is not None and r.need.is_opinion),
                 }
                 for i, r in enumerate(ranked, 1)
-            ]
+            ],
         },
         indent=2,
     )

{prodc-0.3.77 → prodc-0.3.78}/src/prodc/config.py

@@ -272,7 +272,9 @@ class Config:
             raise ConfigError("[lint].importance_revisit_days must be a positive integer")
         draft_max_age = lint_tbl.get("draft_max_age_days")
         if draft_max_age is not None and (
-            not isinstance(draft_max_age, int) or isinstance(draft_max_age, bool) or draft_max_age < 1
+            not isinstance(draft_max_age, int)
+            or isinstance(draft_max_age, bool)
+            or draft_max_age < 1
         ):
             raise ConfigError("[lint].draft_max_age_days must be a positive integer")
 

{prodc-0.3.77 → prodc-0.3.78}/src/prodc/loader.py

@@ -150,7 +150,9 @@ def _withdrawal(raw: object, where: str) -> Withdrawal | None:
         kind = WithdrawalKind(kind_name)
     except ValueError:
         kinds = "|".join(k.value for k in WithdrawalKind)
-        raise LoaderError(f"{where}.kind: unknown withdrawal kind {kind_name!r} ({kinds})") from None
+        raise LoaderError(
+            f"{where}.kind: unknown withdrawal kind {kind_name!r} ({kinds})"
+        ) from None
     return Withdrawal(reason=reason, date=date, kind=kind)
 
 

{prodc-0.3.77 → prodc-0.3.78}/src/prodc/model.py

@@ -74,7 +74,9 @@ class Source:
 
     kind: SourceKind
     who: str | None = None
-    role: str | None = None  # id of the Role the `who` spoke as — whose signal this is (#52 follow-up)
+    role: str | None = (
+        None  # id of the Role the `who` spoke as — whose signal this is (#52 follow-up)
+    )
     date: str | None = None
     quote: str | None = None
     locator: str | None = None
@@ -215,7 +217,9 @@ class Need:
     release: str | None = None  # id of the Release slice this need ships in; None = unslotted
     product: bool = True  # False = infra/NFR/internal, excluded from product coverage (#48)
     draft: bool = False  # True = staged, not yet counted on the board until promoted (#60)
-    draft_added: str | None = None  # ISO date this need was staged (#60); lets a lint age-gate it later
+    draft_added: str | None = (
+        None  # ISO date this need was staged (#60); lets a lint age-gate it later
+    )
     withdrawn: Withdrawal | None = None  # a decision against this need — off the board (#74)
     answer: Answer | None = (
         None  # which way a settled need resolved (yes/no/inconclusive); None=open-ended

{prodc-0.3.77 → prodc-0.3.78}/src/prodc/status.py

@@ -78,6 +78,24 @@ def evidence_age_days(need: Need, today: date) -> int | None:
     return (today - max(dates)).days if dates else None
 
 
+def importance_revisit_due(need: Need, today: date, max_age_days: int) -> bool:
+    """Whether a need's importance should be revisited — for ``plan --revisit`` (#59).
+
+    Due when the need has an importance set but it is either never dated (no ``importance_set_at``)
+    or last set more than ``max_age_days`` ago. A need with no importance is never due — there is
+    nothing to revisit. A malformed date is treated as not-due (the lint warning owns that defect).
+    """
+    if need.importance is None:
+        return False
+    when = need.importance_set_at
+    if when is None:
+        return True
+    try:
+        return (today - date.fromisoformat(when)).days > max_age_days
+    except ValueError:
+        return False
+
+
 def _resolve_proof(locator: str, adapters: dict[str, Adapter]) -> ProofResult:
     name, sep, payload = locator.partition(":")
     adapter = adapters.get(name)

{prodc-0.3.77 → prodc-0.3.78}/tests/test_importance.py

@@ -164,3 +164,52 @@ needs:
     payload = json.loads(capsys.readouterr().out)
     n1 = next(n for n in payload["needs"] if n["id"] == "N-1")
     assert n1["importance_set_at"] == "2026-10-01"
+
+
+# --- plan --revisit (#59 follow-up) -----------------------------------------
+
+
+def test_plan_revisit_filters_to_undated_and_stale(
+    tmp_path: Path, capsys: pytest.CaptureFixture[str]
+) -> None:
+    from prodc.cli import main
+
+    old = (date.today() - timedelta(days=400)).isoformat()
+    recent = (date.today() - timedelta(days=5)).isoformat()
+    needs = f"""
+needs:
+  - id: UNDATED
+    text: importance set, never dated
+    importance: 2
+  - id: STALE
+    text: importance set long ago
+    importance: 3
+    importance_set_at: {old}
+  - id: FRESH
+    text: importance set recently
+    importance: 1
+    importance_set_at: {recent}
+  - id: NONE
+    text: no importance at all
+"""
+    main(["plan", "--revisit", "30", "--config", str(_project(tmp_path, _TOML, needs)), "--json"])
+    payload = json.loads(capsys.readouterr().out)
+    assert payload["revisit"] is True
+    assert {p["id"] for p in payload["plan"]} == {"UNDATED", "STALE"}
+
+
+def test_plan_without_revisit_lists_all(tmp_path: Path, capsys: pytest.CaptureFixture[str]) -> None:
+    from prodc.cli import main
+
+    needs = """
+needs:
+  - id: N-1
+    text: a thing
+    importance: 2
+  - id: N-2
+    text: another thing
+"""
+    main(["plan", "--config", str(_project(tmp_path, _TOML, needs)), "--json"])
+    payload = json.loads(capsys.readouterr().out)
+    assert payload["revisit"] is False
+    assert {p["id"] for p in payload["plan"]} == {"N-1", "N-2"}

{prodc-0.3.77 → prodc-0.3.78}/tests/test_relink.py

@@ -95,7 +95,7 @@ def test_relink_skips_when_adapter_absent(
 ) -> None:
     # A locator whose adapter does not exist is BROKEN but has no inventory to relink against.
     (tmp_path / "needs").mkdir(parents=True, exist_ok=True)
-    (tmp_path / "prodc.toml").write_text("[prodc]\nneeds = [\"needs/*.yaml\"]\n", encoding="utf-8")
+    (tmp_path / "prodc.toml").write_text('[prodc]\nneeds = ["needs/*.yaml"]\n', encoding="utf-8")
     (tmp_path / "needs" / "a.yaml").write_text(
         "needs:\n  - id: N-1\n    text: t\n    proofs: ['ghost:1']\n", encoding="utf-8"
     )

{prodc-0.3.77 → prodc-0.3.78}/tests/test_review.py

@@ -58,7 +58,9 @@ def test_review_list_carries_staged_date_and_dup(
     assert rows["D-2"]["duplicate"] is None
 
 
-def test_review_promote_sets_draft_false(tmp_path: Path, capsys: pytest.CaptureFixture[str]) -> None:
+def test_review_promote_sets_draft_false(
+    tmp_path: Path, capsys: pytest.CaptureFixture[str]
+) -> None:
     cfg = _project(tmp_path)
     code = main(["review", "--promote", "D-1", "--config", str(cfg)])
     assert code == 0
@@ -113,7 +115,9 @@ def test_review_dry_run_writes_nothing(tmp_path: Path, capsys: pytest.CaptureFix
     assert "dry-run" in capsys.readouterr().out
 
 
-def test_review_preserves_header_comment(tmp_path: Path, capsys: pytest.CaptureFixture[str]) -> None:
+def test_review_preserves_header_comment(
+    tmp_path: Path, capsys: pytest.CaptureFixture[str]
+) -> None:
     cfg = _project(tmp_path)
     main(["review", "--drop", "D-2", "--config", str(cfg)])
     capsys.readouterr()

{prodc-0.3.77 → prodc-0.3.78}/tests/test_source_role.py

@@ -13,7 +13,7 @@ from prodc.loader import LoaderError, load
 from prodc.model import Need, Source, SourceKind
 from prodc.writer import capture_source
 
-_TOML = "[prodc]\nneeds = [\"needs/*.yaml\"]\n"
+_TOML = '[prodc]\nneeds = ["needs/*.yaml"]\n'
 
 _NEEDS = """
 roles:

{prodc-0.3.77 → prodc-0.3.78}/tests/test_staleness.py

@@ -152,3 +152,51 @@ needs:
     assert code == 0
     written = (tmp_path / "needs" / "a.yaml").read_text(encoding="utf-8")
     assert "observed_at:" in written and "2026-10-05" in written
+
+
+# --- brief "confirm still wanted" (#58 follow-up) ---------------------------
+
+
+def _client_needs() -> str:
+    old = (date.today() - timedelta(days=400)).isoformat()
+    fresh = date.today().isoformat()
+    return f"""
+needs:
+  - id: OLD-1
+    text: acme wants the old thing
+    client: acme
+    sources:
+      - kind: primary
+        who: Ana
+        quote: "I need this"
+        observed_at: {old}
+  - id: FRESH-1
+    text: acme wants the fresh thing
+    client: acme
+    sources:
+      - kind: primary
+        who: Bob
+        quote: "me too"
+        observed_at: {fresh}
+"""
+
+
+def test_brief_confirm_still_wanted(tmp_path: Path, capsys: pytest.CaptureFixture[str]) -> None:
+    from prodc.cli import main
+
+    toml = _TOML + "\n[lint]\nstale_after_days = 180\n"
+    main(["brief", "acme", "--config", str(_project(tmp_path, toml, _client_needs())), "--json"])
+    payload = json.loads(capsys.readouterr().out)
+    stale = {s["id"] for s in payload["confirm_still_wanted"]}
+    assert stale == {"OLD-1"}  # only the >180d evidence is up for re-confirmation
+
+
+def test_brief_no_confirm_section_without_knob(
+    tmp_path: Path, capsys: pytest.CaptureFixture[str]
+) -> None:
+    from prodc.cli import main
+
+    # no [lint].stale_after_days configured -> nothing to re-confirm
+    main(["brief", "acme", "--config", str(_project(tmp_path, _TOML, _client_needs())), "--json"])
+    payload = json.loads(capsys.readouterr().out)
+    assert payload["confirm_still_wanted"] == []

{prodc-0.3.77 → prodc-0.3.78}/tests/test_withdrawn.py

@@ -306,8 +306,18 @@ def test_withdraw_writes_non_default_kind(tmp_path: Path) -> None:
 
     cfg = _project(tmp_path)
     code = main(
-        ["withdraw", "N-1", "--reason", "off strategy", "--kind", "out_of_scope",
-         "--date", "2026-10-15", "--config", str(cfg)]
+        [
+            "withdraw",
+            "N-1",
+            "--reason",
+            "off strategy",
+            "--kind",
+            "out_of_scope",
+            "--date",
+            "2026-10-15",
+            "--config",
+            str(cfg),
+        ]
     )
     assert code == 0
     by_id = {n.id: n for n in load(Config.load(cfg)).needs}