proactive-gate 0.7.2__tar.gz → 0.7.3__tar.gz

{proactive_gate-0.7.2 → proactive_gate-0.7.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: proactive-gate
-Version: 0.7.2
+Version: 0.7.3
 Summary: Decide whether a proactive assistant may speak now: ordered checks, budgets, quiet hours, JSON policies, shared conformance fixtures with the TypeScript package.
 Project-URL: Homepage, https://bubblegunn.github.io/proactive-gate/
 Project-URL: Documentation, https://bubblegunn.github.io/proactive-gate/start/

{proactive_gate-0.7.2 → proactive_gate-0.7.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "proactive-gate"
-version = "0.7.2"
+version = "0.7.3"
 description = "Decide whether a proactive assistant may speak now: ordered checks, budgets, quiet hours, JSON policies, shared conformance fixtures with the TypeScript package."
 readme = "README.md"
 requires-python = ">=3.11"

{proactive_gate-0.7.2 → proactive_gate-0.7.3}/src/proactive_gate/__init__.py

@@ -22,7 +22,7 @@ from .types import (
     UserState,
 )
 
-__version__ = "0.7.2"
+__version__ = "0.7.3"
 
 __all__ = [
     "EN", "PRIORITY_RANK", "KNOWN_CHECKS", "AsyncGate", "AsyncMemoryStore", "AsyncSqliteStore", "AsyncStore", "Candidate", "Check",

{proactive_gate-0.7.2 → proactive_gate-0.7.3}/src/proactive_gate/explain.py

@@ -501,10 +501,19 @@ def _summarize(decision: Decision, sentences: Mapping[str, SentenceTemplate]) ->
     clause = _t(sentences, template, facts)
     # For a deferral the hold ends at retryAt; when the clause already names the
     # instant (snooze's reason is "snoozed until X"), naming it twice reads worse.
+    #
+    # The summary may headline an instant ONLY when the decision will actually be
+    # reconsidered at it. quietHours can only reject, and its facts carry the
+    # window end as holdUntil, so this used to render a reject as "held until
+    # 08:00" -- telling the reader the message goes out at 08:00 when nothing
+    # would ever send it. The window is not lost: the clause still names it.
     clause_says_when = "until" in facts
-    until = facts.get("holdUntil")
-    if until is None and not clause_says_when and decision.deferred_by and decision.retry_at is not None:
-        until = iso_z(decision.retry_at)
+    will_be_reconsidered = entry.outcome == "defer"
+    until = None
+    if will_be_reconsidered:
+        until = facts.get("holdUntil")
+        if until is None and not clause_says_when and decision.retry_at is not None:
+            until = iso_z(decision.retry_at)
     held_facts: Facts = {"clause": clause}
     if until is not None:
         held_facts["until"] = until

{proactive_gate-0.7.2 → proactive_gate-0.7.3}/tests/test_explain.py

@@ -63,7 +63,21 @@ def test_plain_sentence_and_machine_reason_are_both_on_hand() -> None:
     d = evaluate([checks.QuietHours()], now=NIGHT)
     e = explain(d)
     assert d.reason == "quiet hours 22:00 to 08:00 Europe/Istanbul; priority normal is below the floor (critical)"
-    assert e.summary == "Held until 08:00 because the user's quiet hours run 22:00 to 08:00 Europe/Istanbul and normal priority is below the critical floor needed to override them."
+    # Not "Held until 08:00": QuietHours only rejects, and nothing retries a
+    # reject. The expectation was changed because it pinned a defect, not
+    # because a test failed. See test_a_reject_never_names_an_instant below.
+    assert e.summary == "Held because the user's quiet hours run 22:00 to 08:00 Europe/Istanbul and normal priority is below the critical floor needed to override them."
+
+
+def test_a_reject_never_names_an_instant() -> None:
+    """The summary may headline a time only when the decision is reconsidered at it."""
+    d = evaluate([checks.QuietHours()], now=NIGHT)
+    assert d.allowed is False
+    assert d.retry_at is None, "the fixture must be a reject, or this test proves nothing"
+    assert d.deferred_by is None
+    summary = explain(d).summary
+    assert "until" not in summary, f"a reject must not name an instant: {summary}"
+    assert "quiet hours run 22:00 to 08:00" in summary
 
 
 def test_not_stopped_every_check_gets_a_sentence() -> None:
@@ -353,9 +367,13 @@ def test_language_is_a_parameter() -> None:
     assert explain(d).summary == explain(d, language="en").summary
     with pytest.raises(ValueError, match='no sentence catalog for language "tr"'):
         explain(d, language="tr")
-    tr = {"summary.held": lambda f: f"{f['until']} kadar bekletildi, çünkü {f['clause']}"}
+    # `until` is optional: the summary carries it only when the decision will be
+    # reconsidered at it, so a caller catalog must handle its absence the way the
+    # shipped English one does. This template used to index it directly and only
+    # worked because the fixture happened to be a reject that wrongly named a time.
+    tr = {"summary.held": lambda f: f"{f['until'] + ' kadar ' if f.get('until') else ''}bekletildi, çünkü {f['clause']}"}
     e = explain(d, language="tr", catalogs={"tr": tr})
-    assert e.summary.startswith("08:00 kadar bekletildi, çünkü")
+    assert e.summary.startswith("Bekletildi, çünkü")
     assert len(EN) > 0