portal 3.2.4__tar.gz → 3.4.1__tar.gz

{portal-3.2.4/portal.egg-info → portal-3.4.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: portal
-Version: 3.2.4
+Version: 3.4.1
 Summary: Fast and reliable distributed systems in Python
 Home-page: http://github.com/danijar/portal
 Author: Danijar Hafner

{portal-3.2.4 → portal-3.4.1}/portal/__init__.py

@@ -1,4 +1,4 @@
-__version__ = '3.2.4'
+__version__ = '3.4.1'
 
 import multiprocessing as mp
 try:

{portal-3.2.4 → portal-3.4.1}/portal/batching.py

@@ -162,7 +162,7 @@ def batcher(
 
   try:
     outer = server_socket.ServerSocket(outer_port, f'{name}Server', **kwargs)
-    inner = client.Client('localhost', inner_port, f'{name}Client', **kwargs)
+    inner = client.Client(inner_port, f'{name}Client', **kwargs)
     batches = {}  # {method: ([addr], [reqnum], structure, [array])}
     jobs = []
     shutdown = False

{portal-3.2.4 → portal-3.4.1}/portal/client.py

@@ -11,8 +11,7 @@ from . import packlib
 
 class Client:
 
-  def __init__(
-      self, host, port=None, name='Client', maxinflight=16, **kwargs):
+  def __init__(self, addr, name='Client', maxinflight=16, **kwargs):
     assert 1 <= maxinflight, maxinflight
     self.maxinflight = maxinflight
     self.reqnum = iter(itertools.count(0))
@@ -25,8 +24,7 @@ class Client:
     self.lock = threading.Lock()
     # Socket is created after the above attributes because the callbacks access
     # some of the attributes.
-    self.socket = client_socket.ClientSocket(
-        host, port, name, start=False, **kwargs)
+    self.socket = client_socket.ClientSocket(addr, name, start=False, **kwargs)
     self.socket.callbacks_recv.append(self._recv)
     self.socket.callbacks_disc.append(self._disc)
     self.socket.callbacks_conn.append(self._conn)

{portal-3.2.4 → portal-3.4.1}/portal/client_socket.py

@@ -29,19 +29,19 @@ class Options:
   keepalive_fails: int = 10
   logging: bool = True
   logging_color: str = 'yellow'
+  connect_wait: float = 0.1
 
 
 class ClientSocket:
 
-  def __init__(self, host, port=None, name='Client', start=True, **kwargs):
-    assert port or ':' in host, (host, port)
-    assert '://' not in host, (host, port)
-    if port is None:
-      host, port = host.rsplit(':', 1)
-      assert host and port, (host, port)
-    self.addr = (host, port)
+  def __init__(self, addr, name='Client', start=True, **kwargs):
+    addr = str(addr)
+    assert '://' not in addr, addr
+    host, port = addr.rsplit(':', 1) if ':' in addr else ('', addr)
     self.name = name
     self.options = Options(**{**contextlib.context.clientkw, **kwargs})
+    host = host or ('::1' if self.options.ipv6 else '127.0.0.1')
+    self.addr = (host, port)
 
     self.callbacks_recv = []
     self.callbacks_conn = []
@@ -203,35 +203,39 @@ class ClientSocket:
         error = e
       except socket.gaierror as e:
         error = e
-      time.sleep(0.1)
       if once:
         self._log(f'Still trying to connect... ({error})')
         once = False
       sock.close()
+      time.sleep(self.options.connect_wait)
     return None
 
   def _create(self):
     if self.options.ipv6:
       sock = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)
+      sock.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_V6ONLY, 1)
     else:
       sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-    # sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
+    # sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)  # TODO
+
     after = self.options.keepalive_after
     every = self.options.keepalive_every
     fails = self.options.keepalive_fails
-    if sys.platform == 'linux':
-      sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
-      sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPIDLE, after)
-      sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPINTVL, every)
-      sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPCNT, fails)
-      sock.setsockopt(
-          socket.IPPROTO_TCP, socket.TCP_USER_TIMEOUT,
-          1000 * (after + every * fails))
-    if sys.platform == 'darwin':
-      sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
-      sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPALIVE, every)
-    if sys.platform == 'win32':
-      sock.ioctl(socket.SIO_KEEPALIVE_VALS, (1, after * 1000, every * 1000))
+    if after and every and fails:
+      if sys.platform == 'linux':
+        sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
+        sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPIDLE, after)
+        sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPINTVL, every)
+        sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPCNT, fails)
+        sock.setsockopt(
+            socket.IPPROTO_TCP, socket.TCP_USER_TIMEOUT,
+            1000 * (after + every * fails))
+      if sys.platform == 'darwin':
+        sock.setsockopt(socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)
+        sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_KEEPALIVE, every)
+      if sys.platform == 'win32':
+        sock.ioctl(socket.SIO_KEEPALIVE_VALS, (1, after * 1000, every * 1000))
+
     return sock
 
   def _log(self, *args):

{portal-3.2.4 → portal-3.4.1}/portal/contextlib.py

@@ -21,10 +21,13 @@ class Context:
     self.interval = 20
     self.clientkw = {}
     self.serverkw = {}
+    self.printlock = threading.Lock()
     self.done = threading.Event()
     self.watcher = None
-    self.mp = mp.get_context()
-    self.printlock = self.mp.Lock()
+
+  @property
+  def mp(self):
+    return mp.get_context('spawn')
 
   def options(self):
     return {

{portal-3.2.4 → portal-3.4.1}/portal/server.py

@@ -47,12 +47,13 @@ class Server:
     if block:
       self.loop.join(timeout=None)
 
-  def close(self, timeout=None):
+  def close(self, timeout=None, internal=False):
     assert self.running
     self.socket.shutdown()
     self.running = False
-    self.loop.join(timeout)
-    self.loop.kill()
+    if not internal:
+      self.loop.join(timeout)
+      self.loop.kill()
     [x.close() for x in self.pools]
     self.socket.close()
 
@@ -123,14 +124,16 @@ class Server:
           data = job.result()
           if job.postfn:
             data, info = data
-          else:
-            job.active.release()
+            del info
           data = packlib.pack(data)
           status = int(0).to_bytes(8, 'little', signed=False)
           self.socket.send(job.addr, job.reqnum, status, *data)
           self.metrics['send'] += 1
         except Exception as e:
           self._error(job.addr, job.reqnum, 4, f'Error in server method: {e}')
+        finally:
+          if not job.postfn:
+            job.active.release()
       if completed:
         while self.postfn_inp and self.postfn_inp[0].done():
           job = self.postfn_inp.popleft()
@@ -149,6 +152,5 @@ class Server:
     self.socket.send(addr, reqnum, status, data)
     if self.errors:
       # Wait until the error is delivered to the client and then raise.
-      self.socket.shutdown()
-      self.socket.close()
+      self.close(internal=True)
       raise RuntimeError(message)

{portal-3.2.4 → portal-3.4.1}/portal/server_socket.py

@@ -37,21 +37,23 @@ class ServerSocket:
 
   def __init__(self, port, name='Server', **kwargs):
     if isinstance(port, str):
-      port = int(port.rsplit(':', 1)[1])
+      assert '://' not in port, port
+      port = int(port.rsplit(':', 1)[-1])
     self.name = name
     self.options = Options(**{**contextlib.context.serverkw, **kwargs})
     if self.options.ipv6:
       self.sock = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)
-      self.addr = (self.options.host, port, 0, 0)
+      self.sock.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_V6ONLY, 1)
+      self.addr = (self.options.host or '::', port, 0, 0)
     else:
       self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-      self.addr = (self.options.host, port)
+      self.addr = (self.options.host or '0.0.0.0', port)
     self.sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
-    # self.sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
+    # self.sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)  # TODO
     self._log(f'Binding to {self.addr[0]}:{self.addr[1]}')
     self.sock.bind(self.addr)
     self.sock.setblocking(False)
-    self.sock.listen()
+    self.sock.listen(8192)
     self.sel = selectors.DefaultSelector()
     self.sel.register(self.sock, selectors.EVENT_READ, data=None)
     self._log(f'Listening at {self.addr[0]}:{self.addr[1]}')

{portal-3.2.4 → portal-3.4.1}/portal/utils.py

@@ -98,10 +98,12 @@ def free_port():
   # Return a port that is currently free. This function is not thread or
   # process safe, because there is no way to guarantee that the port will still
   # be free at the time it will be used.
-  if contextlib.context.serverkw.get('ipv6', False):
-    family, addr = socket.AF_INET6, ('localhost', 0, 0, 0)
+  ipv6 = contextlib.context.serverkw.get('ipv6', False)
+  host = contextlib.context.serverkw.get('host', '')
+  if ipv6:
+    family, addr = socket.AF_INET6, (host or '::', 0, 0, 0)
   else:
-    family, addr = socket.AF_INET, ('localhost', 0)
+    family, addr = socket.AF_INET, (host or '0.0.0.0', 0)
   sock = socket.socket(family, socket.SOCK_STREAM)
   sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
   sock.bind(addr)

{portal-3.2.4 → portal-3.4.1/portal.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: portal
-Version: 3.2.4
+Version: 3.4.1
 Summary: Fast and reliable distributed systems in Python
 Home-page: http://github.com/danijar/portal
 Author: Danijar Hafner

{portal-3.2.4 → portal-3.4.1}/tests/test_batching.py

@@ -23,7 +23,7 @@ class TestBatching:
       return 2 * x
     server.bind('fn', fn, batch=4)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     futures = [client.fn(x) for x in range(8)]
     results = [x.result() for x in futures]
     assert (results == 2 * np.arange(8)).all()
@@ -38,7 +38,7 @@ class TestBatching:
       return 2 * x
     server.bind('fn', fn, batch=4)
     server.start(block=False)
-    clients = [portal.Client('localhost', port) for _ in range(8)]
+    clients = [portal.Client(port) for _ in range(8)]
     futures = [x.fn(i) for i, x in enumerate(clients)]
     results = [x.result() for x in futures]
     assert (results == 2 * np.arange(8)).all()
@@ -53,7 +53,7 @@ class TestBatching:
       return 2 * x
     server.bind('fn', fn, workers=4, batch=4)
     server.start(block=False)
-    clients = [portal.Client('localhost', port) for _ in range(32)]
+    clients = [portal.Client(port) for _ in range(32)]
     futures = [x.fn(i) for i, x in enumerate(clients)]
     results = [x.result() for x in futures]
     assert (results == 2 * np.arange(32)).all()
@@ -70,14 +70,14 @@ class TestBatching:
     server.start(block=False)
 
     kwargs = dict(name='ProxyClient', maxinflight=4)
-    proxy_client = portal.Client('localhost', inner_port, **kwargs)
+    proxy_client = portal.Client(inner_port, **kwargs)
     proxy_server = portal.BatchServer(
         outer_port, 'ProxyServer', workers=workers)
     proxy_server.bind(
         'fn2', lambda x: proxy_client.fn(x).result(), batch=2)
     proxy_server.start(block=False)
 
-    client = portal.Client('localhost', outer_port, 'OuterClient')
+    client = portal.Client(outer_port, 'OuterClient')
     futures = [client.fn2(x) for x in range(16)]
     results = [future.result() for future in futures]
     assert (results == 2 * np.arange(16)).all()
@@ -102,7 +102,7 @@ class TestBatching:
     server = portal.BatchServer(port)
     server.bind('fn', lambda x: x, batch=4)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     futures = [client.fn(data) for _ in range(4)]
     results = [x.result() for x in futures]
     for result in results:
@@ -116,7 +116,7 @@ class TestBatching:
     server = portal.BatchServer(port, errors=False)
     server.bind('fn', lambda x: x, batch=2)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     future1 = client.fn({'a': np.array(12)})
     future2 = client.fn(42)
     with pytest.raises(RuntimeError):
@@ -133,12 +133,12 @@ class TestBatching:
     server = portal.BatchServer(port)
     server.bind('fn', lambda x: 2 * x, batch=4)
     server.start(block=False)
-    client = portal.Client('localhost', port, name='Client1', autoconn=False)
+    client = portal.Client(port, 'Client1', autoconn=False)
     client.connect()
     future1 = client.fn(1)
     future2 = client.fn(2)
     client.close()
-    client = portal.Client('localhost', port, name='Client2')
+    client = portal.Client(port, 'Client2')
     future3 = client.fn(3)
     future4 = client.fn(4)
     with pytest.raises(portal.Disconnected):
@@ -156,7 +156,7 @@ class TestBatching:
     server = portal.BatchServer(port)
     server.bind('fn', lambda x: 2 * x, batch=2)
     server.start(block=False)
-    client = portal.Client('localhost', port, autoconn=False)
+    client = portal.Client(port, autoconn=False)
     client.connect()
     future1 = client.fn(1)
     server.close()

{portal-3.2.4 → portal-3.4.1}/tests/test_client.py

@@ -20,14 +20,14 @@ class TestClient:
       pass
     server.bind('fn', fn)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     assert client.fn().result() is None
     client.close()
     server.close()
 
   def test_manual_connect(self):
     port = portal.free_port()
-    client = portal.Client('localhost', port, autoconn=False)
+    client = portal.Client(port, autoconn=False)
     assert not client.connected
     server = portal.Server(port)
     server.bind('fn', lambda x: x)
@@ -44,7 +44,7 @@ class TestClient:
     server = portal.Server(port)
     server.bind('fn', lambda x: x)
     server.start(block=False)
-    client = portal.Client('localhost', port, autoconn=False)
+    client = portal.Client(port, autoconn=False)
     client.connect()
     assert client.fn(1).result() == 1
     server.close()
@@ -77,7 +77,7 @@ class TestClient:
     results = []
 
     def client():
-      client = portal.Client('localhost', port)
+      client = portal.Client(port)
       results.append(client.fn(12).result())
       client.close()
 
@@ -95,7 +95,7 @@ class TestClient:
     server = portal.Server(port)
     server.bind('fn', lambda x: x)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     future1 = client.fn(1)
     future2 = client.fn(2)
     future3 = client.fn(3)
@@ -113,7 +113,7 @@ class TestClient:
       return x
     server.bind('fn', fn)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     future = client.fn(42)
     with pytest.raises(TimeoutError):
       future.result(timeout=0)
@@ -142,7 +142,7 @@ class TestClient:
     server.bind('fn', fn, workers=4)
     server.start(block=False)
 
-    client = portal.Client('localhost', port, maxinflight=2)
+    client = portal.Client(port, maxinflight=2)
     futures = [client.fn(i) for i in range(16)]
     results = [x.result() for x in futures]
     assert results == list(range(16))
@@ -155,7 +155,7 @@ class TestClient:
     server = portal.Server(port)
     server.bind('fn', lambda x: x)
     server.start(block=False)
-    client = portal.Client('localhost', port, maxinflight=1)
+    client = portal.Client(port, maxinflight=1)
     client.fn(1)
     client.fn(2)
     future3 = client.fn(3)
@@ -175,7 +175,7 @@ class TestClient:
       return x
     server.bind('fn', fn)
     server.start(block=False)
-    client = portal.Client('localhost', port, maxinflight=1)
+    client = portal.Client(port, maxinflight=1)
     client.fn(1)
     client.fn(2)
     time.sleep(0.2)
@@ -191,7 +191,7 @@ class TestClient:
     server = portal.Server(port)
     server.bind('fn', lambda x: x, workers=4)
     server.start(block=False)
-    client = portal.Client('localhost', port, maxinflight=8)
+    client = portal.Client(port, maxinflight=8)
     barrier = threading.Barrier(users)
 
     def user():
@@ -228,7 +228,7 @@ class TestClient:
       server.close()
 
     def client():
-      client = portal.Client('localhost', port, maxinflight=2)
+      client = portal.Client(port, maxinflight=2)
       futures = [client.fn(x) for x in range(5)]
       results = [x.result() for x in futures]
       assert results == list(range(5))
@@ -265,8 +265,7 @@ class TestClient:
       server.close()
 
     def client():
-      client = portal.Client(
-          'localhost', port, maxinflight=1, autoconn=True)
+      client = portal.Client(port, maxinflight=1, autoconn=True)
       assert client.fn(1).result() == 1
       a.wait()
       b.wait()
@@ -304,8 +303,7 @@ class TestClient:
       server.close()
 
     def client():
-      client = portal.Client(
-          'localhost', port, maxinflight=1, autoconn=False)
+      client = portal.Client(port, maxinflight=1, autoconn=False)
       client.connect()
       assert client.fn(1).result() == 1
       a.wait()
@@ -322,6 +320,26 @@ class TestClient:
         portal.Thread(client),
     ])
 
+  @pytest.mark.parametrize('ipv6', (False, True))
+  @pytest.mark.parametrize('fmt,typ', (
+      ('{port}', int),
+      ('{port}', str),
+      (':{port}', str),
+      ('localhost:{port}', str),
+      ('{localhost}:{port}', str),
+  ))
+  def test_address_formats(self, fmt, typ, ipv6):
+    port = portal.free_port()
+    server = portal.Server(port, ipv6=ipv6)
+    server.bind('fn', lambda x: x)
+    server.start(block=False)
+    localhost = '::1' if ipv6 else '127.0.0.1'
+    addr = typ(fmt.format(port=port, localhost=localhost))
+    client = portal.Client(addr, ipv6=ipv6)
+    assert client.fn(42).result() == 42
+    client.close()
+    server.close()
+
   def test_resolver(self):
     portnum = portal.free_port()
 

{portal-3.2.4 → portal-3.4.1}/tests/test_server.py

@@ -24,7 +24,7 @@ class TestServer:
       return 2 * x
     server.bind('fn', fn)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     future = client.call('fn', 42)
     assert future.result() == 84
     client.close()
@@ -39,7 +39,7 @@ class TestServer:
     server = Server(port)
     server.bind('fn', fn)
     with server:
-      client = portal.Client('localhost', port)
+      client = portal.Client(port)
       future = client.fn({'foo': np.array(1)})
       result = future.result()
       assert result['foo'] == 2
@@ -51,7 +51,7 @@ class TestServer:
     server = Server(port)
     server.bind('fn', lambda data: data)
     server.start(block=False)
-    clients = [portal.Client('localhost', port) for _ in range(10)]
+    clients = [portal.Client(port) for _ in range(10)]
     futures = [client.fn(i) for i, client in enumerate(clients)]
     results = [future.result() for future in futures]
     assert results == list(range(10))
@@ -65,7 +65,7 @@ class TestServer:
     server.bind('add', lambda x, y: x + y)
     server.bind('sub', lambda x, y: x - y)
     with server:
-      client = portal.Client('localhost', port)
+      client = portal.Client(port)
       assert client.add(3, 5).result() == 8
       assert client.sub(3, 5).result() == -2
       client.close()
@@ -76,7 +76,7 @@ class TestServer:
     server = Server(port, errors=False)
     server.bind('foo', lambda x: x)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     future = client.bar(42)
     try:
       future.result()
@@ -99,7 +99,7 @@ class TestServer:
     server.bind('fn', fn)
     server.start(block=False)
 
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     assert client.fn(1).result() == 1
     with pytest.raises(RuntimeError):
       client.fn(2).result()
@@ -108,8 +108,9 @@ class TestServer:
     client.close()
     server.close()
 
+  @pytest.mark.parametrize('repeat', range(3))
   @pytest.mark.parametrize('Server', SERVERS)
-  def test_server_errors_raise(self, Server):
+  def test_server_errors_raise(self, repeat, Server):
     port = portal.free_port()
 
     def server(port):
@@ -126,7 +127,7 @@ class TestServer:
     server = portal.Process(server, port, start=True)
     del os.environ['PYTHONWARNINGS']
 
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     assert client.fn(1).result() == 1
     assert server.running
     with pytest.raises((RuntimeError, TimeoutError)):
@@ -155,7 +156,7 @@ class TestServer:
     server = Server(port, workers=4)
     server.bind('fn', workfn, postfn)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     futures = [client.fn(x) for x in range(10)]
     results = [x.result() for x in futures]
     server.close()
@@ -188,7 +189,7 @@ class TestServer:
     server = Server(port, workers=workers)
     server.bind('fn', workfn, postfn)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     futures = [client.fn(i) for i in range(20)]
     [future.result() for future in futures]
     client.close()
@@ -210,7 +211,7 @@ class TestServer:
     server.bind('slow', slow)
     server.bind('fast', fast)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     slow_future = client.slow(0)
     fast_future = client.fast(0)
     assert not slow_future.done()
@@ -237,7 +238,7 @@ class TestServer:
     server.bind('slow', slow, workers=1)
     server.bind('fast', fast, workers=1)
     server.start(block=False)
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     slow_future = client.slow(0)
     fast_future = client.fast(0)
     # Both requests are processed in parallel, so the fast request returns
@@ -258,12 +259,12 @@ class TestServer:
     server.start(block=False)
 
     kwargs = dict(name='ProxyClient', maxinflight=4)
-    proxy_client = portal.Client('localhost', inner_port, **kwargs)
+    proxy_client = portal.Client(inner_port, **kwargs)
     proxy_server = Server(outer_port, 'ProxyServer', workers=workers)
     proxy_server.bind('fn2', lambda x: proxy_client.fn(x).result())
     proxy_server.start(block=False)
 
-    client = portal.Client('localhost', outer_port, 'OuterClient')
+    client = portal.Client(outer_port, 'OuterClient')
     futures = [client.fn2(x) for x in range(20)]
     results = [future.result() for future in futures]
     assert results == list(range(0, 40, 2))
@@ -291,7 +292,7 @@ class TestServer:
     def client(port):
       data = portal.SharedArray((3, 2), np.float32)
       data.array[:] = np.arange(6, dtype=np.float32).reshape(3, 2)
-      client = portal.Client('localhost', port)
+      client = portal.Client(port)
       result = client.call('fn', data).result()
       assert result.name == data.name
       assert result, data
@@ -320,7 +321,7 @@ class TestServer:
     server.bind('fn', fn)
     server.start(block=False)
 
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     client.fn(1)
     barrier.wait()
     client.close()
@@ -328,7 +329,25 @@ class TestServer:
     assert stats['numrecv'] == 1
     assert stats['numsend'] == 0
 
-    client = portal.Client('localhost', port)
+    client = portal.Client(port)
     assert client.fn(2).result() == 2
     client.close()
     server.close()
+
+  @pytest.mark.parametrize('ipv6', (False, True))
+  @pytest.mark.parametrize('fmt,typ', (
+      ('{port}', int),
+      ('{port}', str),
+      (':{port}', str),
+      ('localhost:{port}', str),
+      ('123.456:789:::{port}', str),
+  ))
+  def test_port_formats(self, fmt, typ, ipv6):
+    port = portal.free_port()
+    server = portal.Server(typ(fmt.format(port=port)), ipv6=ipv6)
+    server.bind('fn', lambda x: x)
+    server.start(block=False)
+    client = portal.Client(port, ipv6=ipv6)
+    assert client.fn(42).result() == 42
+    client.close()
+    server.close()

{portal-3.2.4 → portal-3.4.1}/tests/test_socket.py

@@ -6,15 +6,16 @@ import portal
 
 class TestSocket:
 
-  def test_basic(self):
+  @pytest.mark.parametrize('ipv6', (False, True))
+  def test_basic(self, ipv6):
     port = portal.free_port()
-    server = portal.ServerSocket(port)
-    client = portal.ClientSocket('localhost', port)
+    server = portal.ServerSocket(port, ipv6=ipv6)
+    client = portal.ClientSocket(port, ipv6=ipv6)
     client.connect()
     assert client.connected
     client.send(b'foo')
     addr, data = server.recv()
-    assert addr[0] == '127.0.0.1'
+    assert addr[0] == '::1' if ipv6 else '127.0.0.1'
     assert data == b'foo'
     server.send(addr, b'bar')
     assert client.recv() == b'bar'
@@ -24,7 +25,7 @@ class TestSocket:
   def test_multi_buffer(self):
     port = portal.free_port()
     server = portal.ServerSocket(port)
-    client = portal.ClientSocket('localhost', port)
+    client = portal.ClientSocket(port)
     client.send(b'foo', b'bar', b'baz')
     addr, data = server.recv()
     assert data == b'foobarbaz'
@@ -36,7 +37,7 @@ class TestSocket:
   def test_multiple_send(self):
     port = portal.free_port()
     server = portal.ServerSocket(port)
-    client = portal.ClientSocket('localhost', port)
+    client = portal.ClientSocket(port)
     client.send(b'foo')
     client.send(b'ba', b'r')
     client.send(b'baz')
@@ -58,7 +59,7 @@ class TestSocket:
   def test_disconnect_server(self, repeat):
     port = portal.free_port()
     server = portal.ServerSocket(port)
-    client = portal.ClientSocket('localhost', port, autoconn=False)
+    client = portal.ClientSocket(port, autoconn=False)
     client.connect()
     server.close()
     with pytest.raises(portal.Disconnected):
@@ -79,14 +80,14 @@ class TestSocket:
   def test_disconnect_client(self, repeat):
     port = portal.free_port()
     server = portal.ServerSocket(port)
-    client = portal.ClientSocket('localhost', port)
+    client = portal.ClientSocket(port)
     client.send(b'foo')
     assert server.recv()[1] == b'foo'
     assert len(server.connections) == 1
     client.close()
     time.sleep(0.2)
     assert len(server.connections) == 0
-    client = portal.ClientSocket('localhost', port)
+    client = portal.ClientSocket(port)
     time.sleep(0.2)
     assert len(server.connections) == 1
     server.close()
@@ -107,7 +108,7 @@ class TestSocket:
 
     def client_fn(port, q):
       client = portal.ClientSocket(
-          'localhost', port,
+          port,
           autoconn=False,
           keepalive_after=1,
           keepalive_every=1,
@@ -154,7 +155,7 @@ class TestSocket:
 
     def client(port):
       data = bytearray(size)
-      client = portal.ClientSocket('localhost', port)
+      client = portal.ClientSocket(port)
       for _ in range(prefetch):
         client.send(data)
       for _ in range(100):
@@ -184,7 +185,7 @@ class TestSocket:
      server.close()
 
    def client(port):
-     client = portal.ClientSocket('localhost', port)
+     client = portal.ClientSocket(port)
      client.send(b'foo')
      assert client.recv() == bytes(1024 ** 2)
      client.close()