portacode 1.4.16.dev11__tar.gz → 1.4.17.dev0__tar.gz

{portacode-1.4.16.dev11 → portacode-1.4.17.dev0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: portacode
-Version: 1.4.16.dev11
+Version: 1.4.17.dev0
 Summary: Portacode CLI client and SDK
 Home-page: https://github.com/portacode/portacode
 Author: Meena Erian

{portacode-1.4.16.dev11 → portacode-1.4.17.dev0}/portacode/_version.py

@@ -28,7 +28,7 @@ version_tuple: VERSION_TUPLE
 commit_id: COMMIT_ID
 __commit_id__: COMMIT_ID
 
-__version__ = version = '1.4.16.dev11'
-__version_tuple__ = version_tuple = (1, 4, 16, 'dev11')
+__version__ = version = '1.4.17.dev0'
+__version_tuple__ = version_tuple = (1, 4, 17, 'dev0')
 
 __commit_id__ = commit_id = None

{portacode-1.4.16.dev11 → portacode-1.4.17.dev0}/portacode/connection/handlers/proxmox_infra.py

@@ -777,6 +777,57 @@ def _build_full_container_summary(records: List[Dict[str, Any]], config: Dict[st
     return summary
 
 
+def _compute_free_resources(summary: Dict[str, Any]) -> Dict[str, float]:
+    """Return free resources using the same math as the dashboard."""
+    free_ram = None
+    free_disk = None
+    free_cpu = None
+    host_ram = summary.get("host_total_ram_mib")
+    alloc_ram = summary.get("allocated_ram_mib")
+    if host_ram is not None and alloc_ram is not None:
+        free_ram = max(float(host_ram) - float(alloc_ram), 0.0)
+
+    host_disk = summary.get("host_total_disk_gib")
+    alloc_disk = summary.get("allocated_disk_gib")
+    if host_disk is not None and alloc_disk is not None:
+        free_disk = max(float(host_disk) - float(alloc_disk), 0.0)
+
+    host_cpu = summary.get("host_total_cpu_cores")
+    alloc_cpu = summary.get("allocated_cpu_share")
+    if host_cpu is not None and alloc_cpu is not None:
+        free_cpu = max(float(host_cpu) - float(alloc_cpu), 0.0)
+
+    return {
+        "ram_mib": free_ram,
+        "disk_gib": free_disk,
+        "cpu_share": free_cpu,
+    }
+
+
+def _assert_capacity_for_payload(payload: Dict[str, Any], summary: Dict[str, Any]) -> None:
+    """Validate requested container resources against current free capacity."""
+    free = _compute_free_resources(summary)
+    shortages: List[str] = []
+
+    req_ram = float(payload.get("ram_mib", 0))
+    free_ram = free.get("ram_mib")
+    if free_ram is not None and req_ram > free_ram:
+        shortages.append(f"RAM (need {int(req_ram)} MiB, free {int(free_ram)} MiB)")
+
+    req_disk = float(payload.get("disk_gib", 0))
+    free_disk = free.get("disk_gib")
+    if free_disk is not None and req_disk > free_disk:
+        shortages.append(f"Disk (need {req_disk:.1f} GiB, free {free_disk:.1f} GiB)")
+
+    req_cpu = float(payload.get("cpus", 0))
+    free_cpu = free.get("cpu_share")
+    if free_cpu is not None and req_cpu > free_cpu:
+        shortages.append(f"CPU (need {req_cpu:.2f} vCPU, free {free_cpu:.2f} vCPU)")
+
+    if shortages:
+        raise RuntimeError(f"Insufficient resources: {', '.join(shortages)}")
+
+
 def _get_managed_containers_summary(force: bool = False) -> Dict[str, Any]:
     def _refresh_container_statuses(records: List[Dict[str, Any]], config: Dict[str, Any] | None) -> None:
         if not records or not config:
@@ -1102,22 +1153,18 @@ def _start_container(proxmox: Any, node: str, vmid: int) -> Tuple[Dict[str, Any]
         logger.info("Container %s already running (%ss)", vmid, uptime)
         return status, 0.0
 
-    node_status = proxmox.nodes(node).status.get()
-    mem_total_mb = int(node_status.get("memory", {}).get("total", 0) // (1024**2))
-    cores_total = int(node_status.get("cpuinfo", {}).get("cores", 0))
-
-    running = _list_running_managed(proxmox, node)
-    used_mem_mb = sum(int(cfg.get("memory", 0)) for _, cfg in running)
-    used_cores = sum(int(cfg.get("cores", 0)) for _, cfg in running)
-
-    target_cfg = proxmox.nodes(node).lxc(vmid).config.get()
-    target_mem_mb = int(target_cfg.get("memory", 0))
-    target_cores = int(target_cfg.get("cores", 0))
-
-    if mem_total_mb and used_mem_mb + target_mem_mb > mem_total_mb:
-        raise RuntimeError("Not enough RAM to start this container safely.")
-    if cores_total and used_cores + target_cores > cores_total:
-        raise RuntimeError("Not enough CPU cores to start this container safely.")
+    # Validate capacity using the same math as the dashboard.
+    summary = _get_managed_containers_summary(force=True)
+    cfg = proxmox.nodes(node).lxc(vmid).config.get()
+    payload = {
+        "ram_mib": _to_mib(cfg.get("memory")),
+        "disk_gib": _pick_container_disk_gib("lxc", cfg, {"rootfs": cfg.get("rootfs")}),
+        "cpus": _pick_container_cpu_share("lxc", cfg, {}),
+    }
+    try:
+        _assert_capacity_for_payload(payload, summary)
+    except RuntimeError as exc:
+        raise RuntimeError(f"Not enough resources to start container {vmid}: {exc}") from exc
 
     upid = proxmox.nodes(node).lxc(vmid).status.start.post()
     return _wait_for_task(proxmox, node, upid)
@@ -1855,6 +1902,12 @@ class CreateProxmoxContainerHandler(SyncHandler):
             payload["cores"] = int(max(math.ceil(payload["cpus"]), 1))
             payload["memory"] = int(payload["ram_mib"])
             payload["node"] = node
+            # Validate against current free resources (same math as dashboard charts).
+            summary = _get_managed_containers_summary(force=True)
+            try:
+                _assert_capacity_for_payload(payload, summary)
+            except RuntimeError as exc:
+                raise RuntimeError(f"Not enough resources to create the container safely: {exc}") from exc
             logger.debug(
                 "Provisioning container node=%s template=%s ram=%s cpu=%s storage=%s",
                 node,

{portacode-1.4.16.dev11 → portacode-1.4.17.dev0}/portacode.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: portacode
-Version: 1.4.16.dev11
+Version: 1.4.17.dev0
 Summary: Portacode CLI client and SDK
 Home-page: https://github.com/portacode/portacode
 Author: Meena Erian