portacode 1.3.35__tar.gz → 1.3.37__tar.gz

{portacode-1.3.35 → portacode-1.3.37}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: portacode
-Version: 1.3.35
+Version: 1.3.37
 Summary: Portacode CLI client and SDK
 Home-page: https://github.com/portacode/portacode
 Author: Meena Erian

{portacode-1.3.35 → portacode-1.3.37}/portacode/_version.py

@@ -28,7 +28,7 @@ version_tuple: VERSION_TUPLE
 commit_id: COMMIT_ID
 __commit_id__: COMMIT_ID
 
-__version__ = version = '1.3.35'
-__version_tuple__ = version_tuple = (1, 3, 35)
+__version__ = version = '1.3.37'
+__version_tuple__ = version_tuple = (1, 3, 37)
 
 __commit_id__ = commit_id = None

{portacode-1.3.35 → portacode-1.3.37}/portacode/connection/handlers/project_state/git_manager.py

@@ -61,6 +61,9 @@ class GitManager:
         self.is_git_repo = False
         self._change_callback = change_callback
         
+        # Track git processes spawned by this specific GitManager instance
+        self._tracked_git_processes = set()
+        
         # Periodic monitoring attributes
         self._monitoring_task: Optional[asyncio.Task] = None
         self._cached_status_summary: Optional[Dict[str, int]] = None
@@ -84,9 +87,29 @@ class GitManager:
             self.repo = Repo(self.project_path)
             self.is_git_repo = True
             logger.info("Initialized Git repo for project: %s", self.project_path)
+            
+            # Track initial git processes after repo creation
+            self._track_current_git_processes()
+            
         except (InvalidGitRepositoryError, Exception) as e:
             logger.debug("Not a Git repository or Git error: %s", e)
     
+    def _track_current_git_processes(self):
+        """Track currently running git cat-file processes for this repo."""
+        try:
+            import psutil
+            for proc in psutil.process_iter(['pid', 'cmdline', 'cwd']):
+                try:
+                    cmdline = proc.info['cmdline']
+                    if (cmdline and len(cmdline) >= 2 and 
+                        'git' in cmdline[0] and 'cat-file' in cmdline[1] and
+                        proc.info['cwd'] == self.project_path):
+                        self._tracked_git_processes.add(proc.pid)
+                except (psutil.NoSuchProcess, psutil.AccessDenied):
+                    continue
+        except Exception as e:
+            logger.debug("Error tracking git processes: %s", e)
+    
     def reinitialize(self):
         """Reinitialize git repo detection (useful when .git directory is created after initialization)."""
         logger.info("Reinitializing git repo detection for: %s", self.project_path)
@@ -1933,4 +1956,43 @@ class GitManager:
     def cleanup(self):
         """Cleanup resources when GitManager is being destroyed."""
         logger.info("Cleaning up GitManager for %s", self.project_path)
-        self.stop_periodic_monitoring()
+        self.stop_periodic_monitoring()
+        
+        # CRITICAL: Close GitPython repo to cleanup git cat-file processes
+        if self.repo:
+            try:
+                # Force cleanup of git command processes
+                if hasattr(self.repo.git, 'clear_cache'):
+                    self.repo.git.clear_cache()
+                self.repo.close()
+                logger.info("Successfully closed GitPython repo for %s", self.project_path)
+            except Exception as e:
+                logger.warning("Error during git repo cleanup for %s: %s", self.project_path, e)
+            finally:
+                self.repo = None
+        
+        # Clean up only the git processes tracked by this specific GitManager instance
+        try:
+            import psutil
+            killed_count = 0
+            
+            for pid in list(self._tracked_git_processes):
+                try:
+                    proc = psutil.Process(pid)
+                    if proc.is_running():
+                        proc.terminate()
+                        killed_count += 1
+                        logger.info("Terminated tracked git process %d", pid)
+                except (psutil.NoSuchProcess, psutil.AccessDenied):
+                    pass
+                finally:
+                    self._tracked_git_processes.discard(pid)
+            
+            if killed_count > 0:
+                logger.info("Cleaned up %d tracked git processes for session", killed_count)
+                
+        except Exception as e:
+            logger.warning("Error cleaning up tracked git processes: %s", e)
+        
+        # Clear the tracking set
+        self._tracked_git_processes.clear()

{portacode-1.3.35 → portacode-1.3.37}/portacode/connection/handlers/system_handlers.py

@@ -3,6 +3,8 @@
 import logging
 import os
 import platform
+import threading
+import time
 from pathlib import Path
 from typing import Any, Dict
 from portacode import __version__
@@ -12,6 +14,25 @@ from .base import SyncHandler
 
 logger = logging.getLogger(__name__)
 
+# Global CPU monitoring
+_cpu_percent = 0.0
+_cpu_thread = None
+_cpu_lock = threading.Lock()
+
+def _cpu_monitor():
+    """Background thread to update CPU usage every 5 seconds."""
+    global _cpu_percent
+    while True:
+        _cpu_percent = psutil.cpu_percent(interval=5.0)
+
+def _ensure_cpu_thread():
+    """Ensure CPU monitoring thread is running (singleton)."""
+    global _cpu_thread
+    with _cpu_lock:
+        if _cpu_thread is None or not _cpu_thread.is_alive():
+            _cpu_thread = threading.Thread(target=_cpu_monitor, daemon=True)
+            _cpu_thread.start()
+
 
 def _get_os_info() -> Dict[str, Any]:
     """Get operating system information with robust error handling."""
@@ -98,15 +119,13 @@ class SystemInfoHandler(SyncHandler):
         """Get system information including OS details."""
         logger.debug("Collecting system information...")
         
+        # Ensure CPU monitoring thread is running
+        _ensure_cpu_thread()
+        
         # Collect basic system metrics
         info = {}
         
-        try:
-            info["cpu_percent"] = psutil.cpu_percent(interval=0.1)
-            logger.debug("CPU usage: %s%%", info["cpu_percent"])
-        except Exception as e:
-            logger.warning("Failed to get CPU info: %s", e)
-            info["cpu_percent"] = 0.0
+        info["cpu_percent"] = _cpu_percent
             
         try:
             info["memory"] = psutil.virtual_memory()._asdict()

{portacode-1.3.35 → portacode-1.3.37}/portacode/connection/terminal.py

@@ -420,6 +420,14 @@ class TerminalManager:
                 pass
         self._ctl_task = asyncio.create_task(self._control_loop())
         
+        # Start periodic system info sender
+        if getattr(self, "_system_info_task", None):
+            try:
+                self._system_info_task.cancel()
+            except Exception:
+                pass
+        self._system_info_task = asyncio.create_task(self._periodic_system_info())
+        
         # For initial connections, request client sessions after control loop starts
         if is_initial:
             asyncio.create_task(self._initial_connection_setup())
@@ -518,6 +526,20 @@ class TerminalManager:
                 # Continue processing other messages
                 continue
 
+    async def _periodic_system_info(self) -> None:
+        """Send system_info event every 10 seconds when clients are connected."""
+        while True:
+            try:
+                await asyncio.sleep(10)
+                if self._client_session_manager.has_interested_clients():
+                    from .handlers.system_handlers import SystemInfoHandler
+                    handler = SystemInfoHandler(self._control_channel, self._context)
+                    system_info = handler.execute({})
+                    await self._send_session_aware(system_info)
+            except Exception as exc:
+                logger.exception("Error in periodic system info: %s", exc)
+                continue
+
     async def _send_initial_data_to_clients(self, newly_added_sessions: List[str] = None):
         """Send initial system info and terminal list to connected clients.
         

{portacode-1.3.35 → portacode-1.3.37}/portacode.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: portacode
-Version: 1.3.35
+Version: 1.3.37
 Summary: Portacode CLI client and SDK
 Home-page: https://github.com/portacode/portacode
 Author: Meena Erian

{portacode-1.3.35 → portacode-1.3.37}/portacode.egg-info/SOURCES.txt

@@ -87,9 +87,12 @@ testing_framework/core/runner.py
 testing_framework/core/shared_cli_manager.py
 testing_framework/core/test_discovery.py
 todo/agent_context_management.md
+todo/UI_UX/opening_a_file_on_desktop_results_in_nothing.md
 todo/issues/device_performance_degradation.md
 todo/issues/git_data_not_captured_in_proxmox.md
 todo/issues/indefinite_resource_loading.md
+todo/issues/portacode_service_silently_down.md
 todo/issues/premature_terminal_exit.md
+todo/issues/project_cpu_hotspots.md
 todo/issues/terminals_exit_upon_starting.md
 tools/test_python_ntp_clock.py

portacode-1.3.37/todo/UI_UX/opening_a_file_on_desktop_results_in_nothing.md

@@ -0,0 +1 @@
+In desktop or big screens, the project workspace allows the user to squeeze the code editor unill it's fully collapsed and not visible. When it's in that state and then the user attempts to open a file, visually, it looks like nothing happended even though the file tab was already opened but in the collapsed editor. This can be confusing for users and in such scenario, opening any new tabs in the code editor should automatically expand the code editor and make it visible.

portacode-1.3.37/todo/issues/portacode_service_silently_down.md

@@ -0,0 +1,69 @@
+
+
+Frequency of reoccurence: Rare
+Importance: Critical
+
+The issue has been happening with recent versions of portacode, probably after adding handlers for search_project_files and read_project_file where the service will be running and the command "portacode service status" shows "Service status: active" and in verbose mode, here's the output:
+
+menas@portacode-streamer:~/portacode$ portacode service status -v
+Service status: active
+
+--- system output ---
+● portacode.service - Portacode persistent connection (system-wide)
+     Loaded: loaded (/etc/systemd/system/portacode.service; enabled; vendor preset: enabled)
+     Active: active (running) since Tue 2025-10-28 17:20:26 UTC; 16h ago
+   Main PID: 1123848 (python3)
+      Tasks: 53 (limit: 19020)
+     Memory: 30.7M
+        CPU: 1h 19min 54.804s
+     CGroup: /system.slice/portacode.service
+             ├─1123848 /usr/bin/python3 -m portacode connect --non-interactive
+             ├─1124026 git cat-file --batch-check
+             ├─1124106 git cat-file --batch-check
+             ├─1157407 git cat-file --batch-check
+             ├─1159306 git cat-file --batch-check
+             ├─1160451 git cat-file --batch-check
+             ├─1162408 git cat-file --batch-check
+             ├─1164471 git cat-file --batch-check
+             ├─1181608 git cat-file --batch-check
+             ├─1192855 git cat-file --batch-check
+             └─1211883 git cat-file --batch-check
+
+Oct 29 09:20:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:20:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=4.18ms, latency=7.25ms, server=time.cloudflare.com
+Oct 29 09:25:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:25:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=3.51ms, latency=6.30ms, server=time.cloudflare.com
+Oct 29 09:30:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:30:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=2.85ms, latency=7.06ms, server=time.cloudflare.com
+Oct 29 09:36:40 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:37:59 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=10.93ms, latency=15.25ms, server=time.cloudflare.com
+Oct 29 09:42:58 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:42:58 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=7.10ms, latency=5.28ms, server=time.cloudflare.com
+
+--- recent logs ---
+-- Logs begin at Thu 2025-10-02 13:56:04 UTC, end at Wed 2025-10-29 09:43:24 UTC. --
+Oct 29 08:55:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 08:55:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=7.12ms, latency=9.52ms, server=time.cloudflare.com
+Oct 29 09:00:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:00:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=4.70ms, latency=5.65ms, server=time.cloudflare.com
+Oct 29 09:05:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:05:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=4.28ms, latency=6.05ms, server=time.cloudflare.com
+Oct 29 09:10:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:10:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=1.89ms, latency=6.13ms, server=time.cloudflare.com
+Oct 29 09:15:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:15:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=0.81ms, latency=6.46ms, server=time.cloudflare.com
+Oct 29 09:20:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:20:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=4.18ms, latency=7.25ms, server=time.cloudflare.com
+Oct 29 09:25:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:25:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=3.51ms, latency=6.30ms, server=time.cloudflare.com
+Oct 29 09:30:43 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:30:43 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=2.85ms, latency=7.06ms, server=time.cloudflare.com
+Oct 29 09:36:40 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:37:59 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=10.93ms, latency=15.25ms, server=time.cloudflare.com
+Oct 29 09:42:58 portacode-streamer python3[1123848]: [INFO] 🔄 Starting periodic NTP sync...
+Oct 29 09:42:58 portacode-streamer python3[1123848]: [INFO] ✅ NTP sync successful: offset=7.10ms, latency=5.28ms, server=time.cloudflare.com
+
+menas@portacode-streamer:~/portacode$ 
+
+
+not showing any errors, however, it got disconnected from the server and is still showing as offline on the server

portacode-1.3.37/todo/issues/project_cpu_hotspots.md

@@ -0,0 +1,33 @@
+# Portacode Project Connection CPU Hotspots
+
+## Context
+Devices spike to 100% CPU as soon as a client session connects to specific projects. The analysis below highlights the most expensive paths invoked during project onboarding and state sync, pinpointing the five most likely culprits.
+
+## Top 5 Likely Causes
+1. **Full project rescan on every refresh**  
+   - `portacode/connection/handlers/project_state/manager.py:361` rebuilds the entire project item list on each refresh, walking every monitored directory and re-sorting the full item set.  
+   - During the same pass, `git_status_map` is populated via a threadpool call into `GitManager.get_file_status_batch` (`portacode/connection/handlers/project_state/manager.py:396` → `portacode/connection/handlers/project_state/git_manager.py:295`), which shells out to several `git` commands (`status`, `diff`, `ls-files`). For large trees this keeps CPU saturated.
+
+2. **Recursive `.git` watcher flood**  
+   - Every project session starts a recursive watchdog on the `.git` directory (`portacode/connection/handlers/project_state/file_system_watcher.py:170`).  
+   - The handler forwards virtually any qualifying Git event into `_handle_file_change` (`portacode/connection/handlers/project_state/manager.py:816`), which in turn calls `_refresh_project_state` (`portacode/connection/handlers/project_state/manager.py:881`).  
+   - Busy repositories generate continuous `.git/objects` churn, so the device keeps re-running the heavy refresh path above even when workspace files stay untouched.
+
+3. **Unbounded project-state initialisers**  
+   - Each `client_sessions_update` spawns `_manage_project_states_for_session_changes` via `loop.create_task` without guard rails (`portacode/connection/terminal.py:96-104`).  
+   - Rapid consecutive updates therefore overlap the expensive `ProjectStateManager.initialize_project_state` calls inside that coroutine (`portacode/connection/terminal.py:192` / `portacode/connection/handlers/project_state/manager.py:131`). Multiple full scans and git probes run simultaneously, pegging CPU.
+
+4. **Per-session git monitoring loops**  
+   - A fresh `GitManager` is created for every client session, even when they point at the same project folder (`portacode/connection/handlers/project_state/manager.py:146-155`).  
+   - Each instance schedules its own `_monitor_git_changes` loop (`portacode/connection/handlers/project_state/git_manager.py:1803` → `portacode/connection/handlers/project_state/git_manager.py:1843`) that executes `git status`, `git diff` and related commands every five seconds. With multiple viewers attached to a large repo, these redundant polls easily saturate CPU.
+
+5. **Hashing every changed file on each update**  
+   - `_refresh_project_state` refreshes `git_detailed_status` for every run (`portacode/connection/handlers/project_state/manager.py:905-912`).  
+   - `GitManager.get_detailed_status` (`portacode/connection/handlers/project_state/git_manager.py:1187-1292`) computes SHA hashes for each staged, unstaged and untracked file by reading their full contents. When sizeable files change—or when the refresh path is invoked frequently via the `.git` watcher above—this repeated hashing drives sustained CPU usage.
+
+## Recommended Next Steps
+- Introduce incremental diffing (e.g., track dirty directories) so `_build_flattened_items_structure` only touches changed paths.
+- Throttle or narrow `.git` monitoring (consider ignoring `objects/` and batching events).
+- Debounce `client_sessions_update` orchestration so only one state-initialisation task can run per session/project at a time.
+- Promote `GitManager` to be shared per project/root and pause the periodic monitor when no deltas are detected.
+- Cache git detailed status / file hashes and invalidate selectively instead of recomputing every refresh.