port-ocean 0.22.0__tar.gz → 0.22.2__tar.gz

{port_ocean-0.22.0 → port_ocean-0.22.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: port-ocean
-Version: 0.22.0
+Version: 0.22.2
 Summary: Port Ocean is a CLI tool for managing your Port projects.
 Home-page: https://app.getport.io
 Keywords: ocean,port-ocean,port
@@ -35,6 +35,7 @@ Requires-Dist: prometheus-client (>=0.21.1,<0.22.0)
 Requires-Dist: pydantic[dotenv] (>=1.10.8,<2.0.0)
 Requires-Dist: pydispatcher (>=2.0.7,<3.0.0)
 Requires-Dist: pyhumps (>=3.8.0,<4.0.0)
+Requires-Dist: pytest-cov (>=6.0.0,<7.0.0)
 Requires-Dist: python-dateutil (>=2.9.0.post0,<3.0.0)
 Requires-Dist: pyyaml (>=6.0,<7.0)
 Requires-Dist: rich (>=13.4.1,<14.0.0) ; extra == "cli"

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/clients/port/mixins/entities.py

@@ -133,7 +133,7 @@ class EntityClientMixin:
         request_options: RequestOptions,
         user_agent_type: UserAgentType | None = None,
         should_raise: bool = True,
-    ) -> list[Entity]:
+    ) -> list[tuple[bool, Entity]]:
         modified_entities_results = await asyncio.gather(
             *(
                 self.upsert_entity(
@@ -146,17 +146,17 @@ class EntityClientMixin:
             ),
             return_exceptions=True,
         )
-        entity_results = [
-            entity for entity in modified_entities_results if isinstance(entity, Entity)
-        ]
-        if not should_raise:
-            return entity_results
 
-        for entity_result in modified_entities_results:
-            if isinstance(entity_result, Exception):
-                raise entity_result
+        entities_results: list[tuple[bool, Entity]] = []
+        for original_entity, result in zip(entities, modified_entities_results):
+            if isinstance(result, Exception) and should_raise:
+                raise result
+            elif isinstance(result, Entity):
+                entities_results.append((True, result))
+            elif result is False:
+                entities_results.append((False, original_entity))
 
-        return entity_results
+        return entities_results
 
     async def delete_entity(
         self,

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/core/defaults/common.py

@@ -68,6 +68,7 @@ def deconstruct_blueprints_to_creation_steps(
         with_relations.append(blueprint.copy())
 
         blueprint.pop("teamInheritance", {})
+        blueprint.pop("ownership", {})
         blueprint.pop("relations", {})
         bare_blueprint.append(blueprint)
 

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/core/defaults/initialize.py

@@ -42,8 +42,8 @@ def deconstruct_blueprints_to_creation_steps(
         blueprint.pop("mirrorProperties", {})
         blueprint.pop("aggregationProperties", {})
         with_relations.append(blueprint.copy())
-
         blueprint.pop("teamInheritance", {})
+        blueprint.pop("ownership", {})
         blueprint.pop("relations", {})
         bare_blueprint.append(blueprint)
 

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/core/handlers/entities_state_applier/port/applier.py

@@ -121,26 +121,20 @@ class HttpEntitiesStateApplier(BaseEntitiesStateApplier):
     ) -> list[Entity]:
         logger.info(f"Upserting {len(entities)} entities")
         modified_entities: list[Entity] = []
-        if event.port_app_config.create_missing_related_entities:
-            modified_entities = await self.context.port_client.batch_upsert_entities(
-                entities,
-                event.port_app_config.get_port_request_options(),
-                user_agent_type,
-                should_raise=False,
-            )
-        else:
-            for entity in entities:
-                upsertedEntity = await self.context.port_client.upsert_entity(
-                    entity,
-                    event.port_app_config.get_port_request_options(),
-                    user_agent_type,
-                    should_raise=False,
-                )
-                if upsertedEntity:
-                    modified_entities.append(upsertedEntity)
-                # condition to false to differentiate from `result_entity.is_using_search_identifier`
-                if upsertedEntity is False:
-                    event.entity_topological_sorter.register_entity(entity)
+        upserted_entities: list[tuple[bool, Entity]] = []
+
+        upserted_entities = await self.context.port_client.batch_upsert_entities(
+            entities,
+            event.port_app_config.get_port_request_options(),
+            user_agent_type,
+            should_raise=False,
+        )
+
+        for is_upserted, entity in upserted_entities:
+            if is_upserted:
+                modified_entities.append(entity)
+            else:
+                event.entity_topological_sorter.register_entity(entity)
         return modified_entities
 
     async def delete(

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/core/handlers/port_app_config/models.py

@@ -22,7 +22,7 @@ class EntityMapping(BaseModel):
     identifier: str | IngestSearchQuery
     title: str | None
     blueprint: str
-    team: str | None
+    team: str | IngestSearchQuery | None
     properties: dict[str, str] = Field(default_factory=dict)
     relations: dict[str, str | IngestSearchQuery] = Field(default_factory=dict)
 
@@ -51,6 +51,7 @@ class ResourceConfig(BaseModel):
 
 
 class PortAppConfig(BaseModel):
+    _default_entity_deletion_threshold: float = 0.9
     enable_merge_entity: bool = Field(alias="enableMergeEntity", default=True)
     delete_dependent_entities: bool = Field(
         alias="deleteDependentEntities", default=True
@@ -58,8 +59,8 @@ class PortAppConfig(BaseModel):
     create_missing_related_entities: bool = Field(
         alias="createMissingRelatedEntities", default=True
     )
-    entity_deletion_threshold: float = Field(
-        alias="entityDeletionThreshold", default=0.9
+    entity_deletion_threshold: float | None = Field(
+        alias="entityDeletionThreshold", default=None
     )
     resources: list[ResourceConfig] = Field(default_factory=list)
 
@@ -71,8 +72,13 @@ class PortAppConfig(BaseModel):
             "validation_only": False,
         }
 
+    def get_entity_deletion_threshold(self) -> float | None:
+        if self.entity_deletion_threshold is not None:
+            return self.entity_deletion_threshold
+        return self._default_entity_deletion_threshold
+
     def to_request(self) -> dict[str, Any]:
-        return {
+        mapping = {
             "deleteDependentEntities": self.delete_dependent_entities,
             "createMissingRelatedEntities": self.create_missing_related_entities,
             "enableMergeEntity": self.enable_merge_entity,
@@ -81,6 +87,9 @@ class PortAppConfig(BaseModel):
                 for resource in self.resources
             ],
         }
+        if self.entity_deletion_threshold is not None:
+            mapping["entityDeletionThreshold"] = self.entity_deletion_threshold
+        return mapping
 
     class Config:
         allow_population_by_field_name = True

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/core/integrations/mixins/sync.py

@@ -102,7 +102,7 @@ class SyncMixin(HandlerMixin):
             entities, user_agent_type
         )
         await self.entities_state_applier.delete_diff(
-            {"before": entities_at_port, "after": modified_entities}, user_agent_type, app_config.entity_deletion_threshold
+            {"before": entities_at_port, "after": modified_entities}, user_agent_type, app_config.get_entity_deletion_threshold()
         )
 
         logger.info("Finished syncing change")

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/core/integrations/mixins/sync_raw.py

@@ -671,7 +671,7 @@ class SyncRawMixin(HandlerMixin, EventsMixin):
                     )
                     await self.entities_state_applier.delete_diff(
                         {"before": entities_at_port, "after": generated_entities},
-                        user_agent_type, app_config.entity_deletion_threshold
+                        user_agent_type, app_config.get_entity_deletion_threshold()
                     )
 
                     logger.info("Resync finished successfully")

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/core/models.py

@@ -40,7 +40,7 @@ class Entity(BaseModel):
     identifier: Any
     blueprint: Any
     title: Any
-    team: str | None | list[Any] = []
+    team: str | None | list[Any] | dict[str, Any] = []
     properties: dict[str, Any] = {}
     relations: dict[str, Any] = {}
 
@@ -50,7 +50,11 @@ class Entity(BaseModel):
 
     @property
     def is_using_search_relation(self) -> bool:
-        return any(isinstance(relation, dict) for relation in self.relations.values())
+        return any(
+            isinstance(relation, dict) for relation in self.relations.values()
+        ) or (
+            self.team is not None and any(isinstance(team, dict) for team in self.team)
+        )
 
 
 class BlueprintRelation(BaseModel):

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/core/utils/utils.py

@@ -110,7 +110,8 @@ def get_port_diff(before: Iterable[Entity], after: Iterable[Entity]) -> EntityPo
 
 
 def are_teams_different(
-    first_team: str | None | list[Any], second_team: str | None | list[Any]
+    first_team: str | None | list[Any] | dict[str, Any],
+    second_team: str | None | list[Any] | dict[str, Any],
 ) -> bool:
     if isinstance(first_team, list) and isinstance(second_team, list):
         return sorted(first_team) != sorted(second_team)
@@ -122,6 +123,7 @@ def are_entities_fields_equal(
 ) -> bool:
     """
     Compare two entity fields by serializing them to JSON and comparing their SHA-256 hashes.
+    Removes keys with None values before comparison if the corresponding key doesn't exist in the other dict.
 
     Args:
         first_entity_field: First entity field dictionary to compare
@@ -130,7 +132,13 @@ def are_entities_fields_equal(
     Returns:
         bool: True if the entity fields have identical content
     """
-    first_props = json.dumps(first_entity_field, sort_keys=True)
+    first_entity_field_copy = first_entity_field.copy()
+
+    for key in list(first_entity_field.keys()):
+        if first_entity_field[key] is None and key not in second_entity_field:
+            del first_entity_field_copy[key]
+
+    first_props = json.dumps(first_entity_field_copy, sort_keys=True)
     second_props = json.dumps(second_entity_field, sort_keys=True)
     first_hash = hashlib.sha256(first_props.encode()).hexdigest()
     second_hash = hashlib.sha256(second_props.encode()).hexdigest()

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/tests/clients/port/mixins/test_entities.py

@@ -41,8 +41,9 @@ async def test_batch_upsert_entities_read_timeout_should_raise_false(
         result_entities = await entity_client.batch_upsert_entities(
             entities=all_entities, request_options=MagicMock(), should_raise=False
         )
+        entities_only = [entity for _, entity in result_entities]
 
-        assert result_entities == expected_result_entities
+        assert entities_only == expected_result_entities
 
 
 async def test_batch_upsert_entities_read_timeout_should_raise_true(

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/tests/core/conftest.py

@@ -177,10 +177,11 @@ def create_entity(
     blueprint: str,
     relation: dict[str, str] | None = None,
     is_to_fail: bool = False,
+    team: str | list[str] | dict[str, Any] | None = None,
 ) -> Entity:
     if relation is None:
         relation = {}
-    entity = Entity(identifier=id, blueprint=blueprint)
+    entity = Entity(identifier=id, blueprint=blueprint, team=team)
     entity.relations = relation
     entity.properties = {"mock_is_to_fail": is_to_fail}
     return entity

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/tests/core/handlers/entities_state_applier/test_applier.py

@@ -95,6 +95,30 @@ async def test_delete_diff_custom_threshold_above_threshold_not_deleted(
     mock_safe_delete.assert_not_called()
 
 
+@pytest.mark.asyncio
+async def test_delete_diff_custom_threshold_0_not_deleted(
+    mock_context: PortOceanContext,
+) -> None:
+    applier = HttpEntitiesStateApplier(mock_context)
+    entities = EntityDiff(
+        before=[
+            Entity(identifier="1", blueprint="test"),
+            Entity(identifier="2", blueprint="test"),
+        ],
+        after=[
+            Entity(identifier="2", blueprint="test"),
+            Entity(identifier="3", blueprint="test"),
+        ],
+    )
+
+    with patch.object(applier, "_safe_delete") as mock_safe_delete:
+        await applier.delete_diff(
+            entities, UserAgentType.exporter, entity_deletion_threshold=0
+        )
+
+    mock_safe_delete.assert_not_called()
+
+
 @pytest.mark.asyncio
 async def test_applier_with_mock_context(
     mock_ocean: Ocean,
@@ -130,6 +154,74 @@ async def test_applier_with_mock_context(
             assert result[0].identifier == "test_entity"
 
 
+@pytest.mark.asyncio
+async def test_applier_one_not_upserted(
+    mock_ocean: Ocean,
+    mock_context: PortOceanContext,
+    mock_port_app_config: PortAppConfig,
+) -> None:
+    # Create an applier using the mock_context fixture
+    applier = HttpEntitiesStateApplier(mock_context)
+
+    # Create test entities
+    entity = Entity(identifier="test_entity", blueprint="test_blueprint")
+
+    async with event_context(EventType.RESYNC, trigger_type="machine") as event:
+        # Mock the register_entity method
+        event.entity_topological_sorter.register_entity = Mock()  # type: ignore
+        event.port_app_config = mock_port_app_config
+
+        # Test the upsert method with mocked client
+        with patch.object(mock_ocean.port_client.client, "post") as mock_post:
+            mock_post.return_value = Mock(
+                status_code=404,
+                json=lambda: {"ok": False, "error": "not_found"},
+            )
+
+            result = await applier.upsert([entity], UserAgentType.exporter)
+
+            # Assert that the post method was called
+            mock_post.assert_called_once()
+            assert len(result) == 0
+            event.entity_topological_sorter.register_entity.assert_called_once_with(
+                entity
+            )
+
+
+@pytest.mark.asyncio
+async def test_applier_error_upserting(
+    mock_ocean: Ocean,
+    mock_context: PortOceanContext,
+    mock_port_app_config: PortAppConfig,
+) -> None:
+    # Create an applier using the mock_context fixture
+    applier = HttpEntitiesStateApplier(mock_context)
+
+    # Create test entities
+    entity = Entity(identifier="test_entity", blueprint="test_blueprint")
+
+    async with event_context(EventType.RESYNC, trigger_type="machine") as event:
+        # Mock the register_entity method
+        event.entity_topological_sorter.register_entity = Mock()  # type: ignore
+        event.port_app_config = mock_port_app_config
+
+        # Test the upsert method with mocked client
+        with patch.object(mock_ocean.port_client.client, "post") as mock_post:
+            mock_post.return_value = Mock(
+                status_code=404,
+                json=lambda: {"ok": False, "error": "not_found"},
+            )
+
+            result = await applier.upsert([entity], UserAgentType.exporter)
+
+            # Assert that the post method was called
+            mock_post.assert_called_once()
+            assert len(result) == 0
+            event.entity_topological_sorter.register_entity.assert_called_once_with(
+                entity
+            )
+
+
 @pytest.mark.asyncio
 async def test_using_create_entity_helper(
     mock_ocean: Ocean,

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/tests/core/handlers/entity_processor/test_jq_entity_processor.py

@@ -249,7 +249,7 @@ class TestJQEntityProcessor:
             result = await mocked_processor._search(data, pattern)
             assert result == "bar"
 
-    @pytest.mark.timeout(15)
+    @pytest.mark.timeout(30)
     async def test_parse_items_performance_10000(
         self, mocked_processor: JQEntityProcessor
     ) -> None:

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/tests/core/handlers/mixins/test_sync_raw.py

@@ -417,6 +417,30 @@ async def test_map_entities_compared_with_port_no_port_entities_all_entities_are
     assert "entity_2" in [e.identifier for e in changed_entities]
 
 
+@pytest.mark.asyncio
+async def test_map_entities_compared_with_port_returns_original_entities_when_using_team_search_query(
+    mock_sync_raw_mixin: SyncRawMixin,
+    mock_resource_config: ResourceConfig,
+) -> None:
+
+    team_search_query = {
+        "combinator": "and",
+        "rules": [{"property": "$team", "operator": "=", "value": "my-team"}],
+    }
+
+    entities = [
+        create_entity("entity_1", "service", {}, False, team=team_search_query),
+        create_entity("entity_2", "service", {}, False, team=team_search_query),
+    ]
+
+    changed_entities = await mock_sync_raw_mixin._map_entities_compared_with_port(
+        entities, mock_resource_config, UserAgentType.exporter
+    )
+
+    assert len(changed_entities) == 2
+    assert changed_entities == entities
+
+
 @pytest.mark.asyncio
 async def test_map_entities_compared_with_port_with_existing_entities_only_changed_third_party_entities_are_mapped(
     mock_sync_raw_mixin: SyncRawMixin,

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/tests/core/handlers/port_app_config/test_base.py

@@ -78,6 +78,88 @@ async def test_get_port_app_config_success(
         result.resources[0].port.entity.mappings.properties["defaultBranch"]
         == ".default_branch"
     )
+    assert result.entity_deletion_threshold is None
+    port_app_config_handler.mock_get_port_app_config.assert_called_once()
+
+
+@pytest.mark.asyncio
+async def test_get_port_app_config_get_entity_deletion_threshold_with_flag_defined(
+    port_app_config_handler: MockPortAppConfig,
+) -> None:
+    # Arrange
+    valid_config = {
+        "entityDeletionThreshold": 0.1,
+        "resources": [
+            {
+                "kind": "repository",
+                "selector": {"query": "true"},
+                "port": {
+                    "entity": {
+                        "mappings": {
+                            "identifier": ".name",
+                            "title": ".name",
+                            "blueprint": '"service"',
+                            "properties": {
+                                "description": ".description",
+                                "url": ".html_url",
+                                "defaultBranch": ".default_branch",
+                            },
+                        }
+                    }
+                },
+            }
+        ],
+    }
+    port_app_config_handler.mock_get_port_app_config.return_value = valid_config
+
+    # Act
+    async with event_context(EventType.RESYNC, trigger_type="machine"):
+        result = await port_app_config_handler.get_port_app_config()
+        deletion_threshold = result.get_entity_deletion_threshold()
+
+    # Assert
+    assert isinstance(result, PortAppConfig)
+    assert deletion_threshold == 0.1
+    port_app_config_handler.mock_get_port_app_config.assert_called_once()
+
+
+@pytest.mark.asyncio
+async def test_get_port_app_config_get_entity_deletion_threshold_with_flag_not_defined(
+    port_app_config_handler: MockPortAppConfig,
+) -> None:
+    # Arrange
+    valid_config = {
+        "resources": [
+            {
+                "kind": "repository",
+                "selector": {"query": "true"},
+                "port": {
+                    "entity": {
+                        "mappings": {
+                            "identifier": ".name",
+                            "title": ".name",
+                            "blueprint": '"service"',
+                            "properties": {
+                                "description": ".description",
+                                "url": ".html_url",
+                                "defaultBranch": ".default_branch",
+                            },
+                        }
+                    }
+                },
+            }
+        ]
+    }
+    port_app_config_handler.mock_get_port_app_config.return_value = valid_config
+
+    # Act
+    async with event_context(EventType.RESYNC, trigger_type="machine"):
+        result = await port_app_config_handler.get_port_app_config()
+        deletion_threshold = result.get_entity_deletion_threshold()
+
+    # Assert
+    assert isinstance(result, PortAppConfig)
+    assert deletion_threshold == result._default_entity_deletion_threshold
     port_app_config_handler.mock_get_port_app_config.assert_called_once()
 
 

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/tests/core/utils/test_resolve_entities_diff.py

@@ -246,6 +246,58 @@ def test_are_entities_fields_equal_different_nested_relations_should_be_false()
     )
 
 
+def test_are_entities_fields_equal_null_properties_should_be_true() -> None:
+    assert (
+        are_entities_fields_equal(
+            {
+                "team": None,
+                "members": ["user1", "user2"],
+                "metadata": {"role": "admin"},
+            },
+            {"members": ["user1", "user2"], "metadata": {"role": "admin"}},
+        )
+        is True
+    )
+
+
+def test_are_entities_fields_equal_null_properties_and_real_data_in_other_entity_should_be_false() -> (
+    None
+):
+    assert (
+        are_entities_fields_equal(
+            {
+                "team": None,
+                "members": ["user1", "user2"],
+                "metadata": {"role": "admin"},
+            },
+            {
+                "team": "team_id1",
+                "members": ["user1", "user2"],
+                "metadata": {"role": "admin"},
+            },
+        )
+        is False
+    )
+
+
+def test_are_entities_fields_equal_null_properties_in_both_should_be_true() -> None:
+    assert (
+        are_entities_fields_equal(
+            {
+                "team": None,
+                "members": ["user1", "user2"],
+                "metadata": {"role": "admin"},
+            },
+            {
+                "team": None,
+                "members": ["user1", "user2"],
+                "metadata": {"role": "admin"},
+            },
+        )
+        is True
+    )
+
+
 def test_are_entities_different_identical_entities_should_be_false() -> None:
     entity1 = create_test_entity(
         "",

{port_ocean-0.22.0 → port_ocean-0.22.2}/port_ocean/tests/helpers/fixtures.py

@@ -2,7 +2,6 @@ from os import path
 from typing import Any, Callable, Dict, List, Tuple, Union
 
 import pytest
-import pytest_asyncio
 
 from port_ocean.clients.port.client import PortClient
 from port_ocean.core.handlers.port_app_config.models import ResourceConfig
@@ -26,7 +25,7 @@ def port_client_for_fake_integration() -> Tuple[SmokeTestDetails, PortClient]:
     return smoke_test_details, port_client
 
 
-@pytest_asyncio.fixture
+@pytest.fixture
 def get_mocked_ocean_app(request: Any) -> Callable[[], Ocean]:
     test_dir = path.join(path.dirname(request.module.__file__), "..")
 
@@ -36,7 +35,7 @@ def get_mocked_ocean_app(request: Any) -> Callable[[], Ocean]:
     return get_ocean_app
 
 
-@pytest_asyncio.fixture
+@pytest.fixture
 def get_mock_ocean_resource_configs(request: Any) -> Callable[[], List[ResourceConfig]]:
     module_dir = path.join(path.dirname(request.module.__file__), "..")
 

{port_ocean-0.22.0 → port_ocean-0.22.2}/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "port-ocean"
-version = "0.22.0"
+version = "0.22.2"
 description = "Port Ocean is a CLI tool for managing your Port projects."
 readme = "README.md"
 homepage = "https://app.getport.io"
@@ -63,6 +63,7 @@ rich = { version = "^13.4.1", optional = true }
 cookiecutter = { version = "^2.1.1", optional = true }
 jinja2-time = { version = "^0.2.0", optional = true }
 prometheus-client = "^0.21.1"
+pytest-cov = "^6.0.0"
 
 [tool.poetry.extras]
 cli = ["click", "rich", "cookiecutter", "jinja2-time"]