polyglot-sql 0.4.0__tar.gz → 0.4.1__tar.gz

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/Cargo.lock

@@ -605,7 +605,7 @@ dependencies = [
 
 [[package]]
 name = "polyglot-sql"
-version = "0.4.0"
+version = "0.4.1"
 dependencies = [
  "criterion",
  "once_cell",
@@ -621,7 +621,7 @@ dependencies = [
 
 [[package]]
 name = "polyglot-sql-ffi"
-version = "0.4.0"
+version = "0.4.1"
 dependencies = [
  "cbindgen",
  "polyglot-sql",
@@ -631,11 +631,11 @@ dependencies = [
 
 [[package]]
 name = "polyglot-sql-function-catalogs"
-version = "0.4.0"
+version = "0.4.1"
 
 [[package]]
 name = "polyglot-sql-python"
-version = "0.4.0"
+version = "0.4.1"
 dependencies = [
  "polyglot-sql",
  "pyo3",
@@ -646,7 +646,7 @@ dependencies = [
 
 [[package]]
 name = "polyglot-sql-wasm"
-version = "0.4.0"
+version = "0.4.1"
 dependencies = [
  "console_error_panic_hook",
  "js-sys",

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/Cargo.toml

@@ -6,7 +6,7 @@ exclude = [
 ]
 
 [workspace.package]
-version = "0.4.0"
+version = "0.4.1"
 edition = "2021"
 license = "MIT"
 authors = ["polyglot contributors"]

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: polyglot-sql
-Version: 0.4.0
+Version: 0.4.1
 Classifier: Development Status :: 4 - Beta
 Classifier: Intended Audience :: Developers
 Classifier: License :: OSI Approved :: MIT License

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/crates/polyglot-sql/Cargo.toml

@@ -28,7 +28,7 @@ generate = []
 transpile = ["generate"]
 builder = ["generate"]
 ast-tools = []
-semantic = ["generate", "ast-tools"]
+semantic = ["ast-tools"]
 openlineage = ["semantic"]
 diff = ["generate"]
 planner = []
@@ -106,7 +106,7 @@ thiserror = { workspace = true }
 unicode-segmentation = { workspace = true }
 stacker = { version = "0.1", optional = true }
 ts-rs = { version = "12.0", features = ["serde-compat"], optional = true }
-polyglot-sql-function-catalogs = { path = "../polyglot-sql-function-catalogs", version = "0.4.0", optional = true, default-features = false }
+polyglot-sql-function-catalogs = { path = "../polyglot-sql-function-catalogs", version = "0.4.1", optional = true, default-features = false }
 
 [dev-dependencies]
 pretty_assertions = "1.4"

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/crates/polyglot-sql/src/expressions.rs

@@ -8346,7 +8346,7 @@ pub struct IndexColumn {
 #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
 #[cfg_attr(feature = "bindings", derive(TS))]
 pub struct DropIndex {
-    pub name: Identifier,
+    pub name: TableRef,
     pub table: Option<TableRef>,
     pub if_exists: bool,
     /// PostgreSQL CONCURRENTLY modifier
@@ -8357,7 +8357,7 @@ pub struct DropIndex {
 impl DropIndex {
     pub fn new(name: impl Into<String>) -> Self {
         Self {
-            name: Identifier::new(name),
+            name: TableRef::new(name),
             table: None,
             if_exists: false,
             concurrently: false,

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/crates/polyglot-sql/src/generator.rs

@@ -11108,7 +11108,7 @@ impl Generator {
         }
 
         self.write_space();
-        self.generate_identifier(&di.name)?;
+        self.generate_table(&di.name)?;
 
         if let Some(ref table) = di.table {
             self.write_space();
@@ -38852,6 +38852,15 @@ mod tests {
     fn test_drop_index() {
         let result = roundtrip("DROP INDEX idx_name");
         assert_eq!(result, "DROP INDEX idx_name");
+
+        let result = roundtrip(r#"DROP INDEX IF EXISTS "idx_tokenKey__pb_users_auth_""#);
+        assert_eq!(
+            result,
+            r#"DROP INDEX IF EXISTS "idx_tokenKey__pb_users_auth_""#
+        );
+
+        let result = roundtrip(r#"DROP INDEX "public"."IdxMixed""#);
+        assert_eq!(result, r#"DROP INDEX "public"."IdxMixed""#);
     }
 
     #[test]

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/crates/polyglot-sql/src/openlineage.rs

@@ -550,11 +550,24 @@ fn input_fields_for_output(
     let description = output_field
         .expression
         .as_ref()
-        .map(|expr| expr.sql_for(options.dialect));
+        .and_then(|expr| transformation_description(expr, options.dialect));
 
     terminal_fields_to_openlineage(terminals, subtype, description, options, warnings)
 }
 
+fn transformation_description(expr: &Expression, dialect: DialectType) -> Option<String> {
+    #[cfg(feature = "generate")]
+    {
+        Some(expr.sql_for(dialect))
+    }
+
+    #[cfg(not(feature = "generate"))]
+    {
+        let _ = (expr, dialect);
+        None
+    }
+}
+
 fn terminal_fields_to_openlineage(
     terminals: Vec<TerminalField>,
     subtype: &str,

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/crates/polyglot-sql/src/optimizer/subquery.rs

@@ -1176,7 +1176,7 @@ fn extract_subquery_to_cte(
 ) -> Expression {
     match source {
         Expression::Subquery(sub) => {
-            let inner_sql = crate::generator::Generator::sql(&sub.this).unwrap_or_default();
+            let subquery_key = subquery_identity_key(&sub.this);
             let alias_name = sub
                 .alias
                 .as_ref()
@@ -1184,7 +1184,7 @@ fn extract_subquery_to_cte(
                 .unwrap_or_default();
 
             // Check for duplicate subquery (reuse existing CTE)
-            if let Some(existing_name) = seen_sql.get(&inner_sql) {
+            if let Some(existing_name) = seen_sql.get(&subquery_key) {
                 let mut tref = TableRef::new(existing_name.as_str());
                 if !alias_name.is_empty() {
                     tref.alias = Some(Identifier::new(&alias_name));
@@ -1199,7 +1199,7 @@ fn extract_subquery_to_cte(
                 find_new_name(taken, "_cte")
             };
             taken.insert(cte_name.clone());
-            seen_sql.insert(inner_sql, cte_name.clone());
+            seen_sql.insert(subquery_key, cte_name.clone());
 
             // Create CTE
             new_ctes.push(Cte {
@@ -1223,6 +1223,22 @@ fn extract_subquery_to_cte(
     }
 }
 
+fn subquery_identity_key(expr: &Expression) -> String {
+    #[cfg(feature = "generate")]
+    {
+        crate::generator::Generator::sql(expr).unwrap_or_else(|_| structural_subquery_key(expr))
+    }
+
+    #[cfg(not(feature = "generate"))]
+    {
+        structural_subquery_key(expr)
+    }
+}
+
+fn structural_subquery_key(expr: &Expression) -> String {
+    serde_json::to_string(expr).unwrap_or_else(|_| format!("{expr:?}"))
+}
+
 /// Unnest correlated subqueries where possible.
 ///
 /// This transforms correlated subqueries into JOINs for better performance.

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/crates/polyglot-sql/src/parser.rs

@@ -18529,12 +18529,9 @@ impl Parser {
 
         let if_exists = self.match_keywords(&[TokenType::If, TokenType::Exists]);
 
-        // Parse potentially qualified index name (a.b.c)
-        let mut name_parts = vec![self.expect_identifier()?];
-        while self.match_token(TokenType::Dot) {
-            name_parts.push(self.expect_identifier()?);
-        }
-        let name = Identifier::new(name_parts.join("."));
+        // Parse potentially qualified index name (a.b.c), preserving quoted
+        // state independently for every part.
+        let name = self.parse_table_ref()?;
 
         // Optional ON table
         let table = if self.match_token(TokenType::On) {
@@ -60646,10 +60643,27 @@ OPTIONS (
 
         if let Expression::DropIndex(di) = &result[0] {
             assert!(di.if_exists);
+            assert_eq!(di.name.name.name, "idx_email");
+            assert!(!di.name.name.quoted);
             assert!(di.table.is_some());
         }
     }
 
+    #[test]
+    fn test_parse_drop_index_preserves_qualified_quoted_name() {
+        let result = Parser::parse_sql(r#"DROP INDEX IF EXISTS "public"."IdxEmail""#).unwrap();
+
+        if let Expression::DropIndex(di) = &result[0] {
+            let schema = di.name.schema.as_ref().expect("schema");
+            assert_eq!(schema.name, "public");
+            assert!(schema.quoted);
+            assert_eq!(di.name.name.name, "IdxEmail");
+            assert!(di.name.name.quoted);
+        } else {
+            panic!("Expected DropIndex");
+        }
+    }
+
     #[test]
     fn test_parse_create_view() {
         let result =

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/crates/polyglot-sql/tests/identity_roundtrip.rs

@@ -777,6 +777,7 @@ mod ddl_drop_tests {
     #[test]
     fn test_drop_index() {
         assert_roundtrip("DROP INDEX a.b.c");
+        assert_roundtrip(r#"DROP INDEX "a"."B""#);
     }
 
     #[test]

{polyglot_sql-0.4.0 → polyglot_sql-0.4.1}/crates/polyglot-sql/tests/sqlglot_compat.rs

@@ -330,6 +330,22 @@ mod ddl_tests {
             roundtrip("DROP INDEX IF EXISTS idx"),
             "DROP INDEX IF EXISTS idx"
         );
+        assert_eq!(
+            transpile(
+                r#"DROP INDEX IF EXISTS "idx_tokenKey__pb_users_auth_""#,
+                DialectType::PostgreSQL,
+                DialectType::PostgreSQL
+            ),
+            r#"DROP INDEX IF EXISTS "idx_tokenKey__pb_users_auth_""#
+        );
+        assert_eq!(
+            transpile(
+                "DROP INDEX IF EXISTS `idx_tokenKey__pb_users_auth_`",
+                DialectType::SQLite,
+                DialectType::PostgreSQL
+            ),
+            r#"DROP INDEX IF EXISTS "idx_tokenKey__pb_users_auth_""#
+        );
     }
 
     #[test]