plsqlwks 0.1.3__tar.gz → 0.1.5__tar.gz

{plsqlwks-0.1.3 → plsqlwks-0.1.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: plsqlwks
-Version: 0.1.3
+Version: 0.1.5
 Summary: An ncurses SQL and PL/SQL workspace for Oracle databases.
 License-Expression: LicenseRef-plsqlwks-Donationware
 Project-URL: Repository, https://gitlab.com/unununu/plsqlwks
@@ -23,7 +23,7 @@ Dynamic: license-file
 
 # plsqlwks
 
-An ncurses SQL and PL/SQL workspace for the local Oracle database.
+An ncurses SQL and PL/SQL workspace for Oracle databases.
 
 ![PLSQLWKS PREVIEW](https://gitlab.com/unununu/plsqlwks/-/raw/main/img/preview.png)
 
@@ -48,15 +48,24 @@ Override the defaults with environment variables:
 export ORACLE_USER=hr
 export ORACLE_PASSWORD_FILE=~/.config/plsqlwks/orapass
 export ORACLE_DSN='127.0.0.1:1521/free'
-export PLSQLWKS_WORKSPACE=/mnt/d/dev/plsqlwks/workspace
+export PLSQLWKS_WORKSPACE=/path/to/workspace
+export PLSQLWKS_MAX_ROWS=200
+export PLSQLWKS_ARRAYSIZE=100
 ```
 
 Password files preserve leading and trailing spaces; only final CR/LF line
 endings are removed. On POSIX systems, create the file for the current user and
 protect it with `chmod 600`.
 
+`PLSQLWKS_MAX_ROWS` sets the maximum number of rows in each result page, while
+`PLSQLWKS_ARRAYSIZE` sets the Oracle cursor array size. Both values must be
+positive integers.
+
 ## Install
 
+Python 3.10 or newer is required, along with a compatible terminal and a Python
+build that provides the standard-library `curses` module.
+
 For development, install the package in editable mode:
 
 ```bash
@@ -65,15 +74,27 @@ python3 -m pip install -e '.[dev]'
 
 `oracledb` is the only runtime dependency. Supporting functionality uses the Python standard library.
 
-See the [release checklist](https://gitlab.com/unununu/plsqlwks/-/blob/main/RELEASING.md)
-for the quality, packaging, and GitLab release process.
-
 For a regular local install, use:
 
 ```bash
 python3 -m pip install .
 ```
 
+Run the default test and lint checks from a development checkout with:
+
+```bash
+python3 -m pytest -q
+python3 -m ruff check .
+```
+
+Oracle integration tests require the connection environment variables shown
+above and an accessible password file. Enable every test group with:
+
+```bash
+PLSQLWKS_TEST_ORACLE=1 PLSQLWKS_TEST_PTY=1 PLSQLWKS_TEST_SLOW=1 \
+  python3 -m pytest -q -rs
+```
+
 ## Run
 
 After installation, start the workspace with:
@@ -92,6 +113,15 @@ The CLI option takes precedence over `PLSQLWKS_WORKSPACE`. For compatibility, a
 source checkout that already contains a configured `workspace/` continues to
 use it and displays a migration notice; files are never moved automatically.
 
+Choose the initial transaction mode for one invocation with `--manual` or
+`--autocommit`. These options override `[database] autocommit` from the active
+`config.ini`:
+
+```bash
+plsqlwks --manual
+plsqlwks --autocommit
+```
+
 You can also run it directly as a module from the source tree:
 
 ```bash
@@ -104,7 +134,25 @@ The app opens a split-screen terminal workspace:
 - results/messages below
 - command/status bar at the bottom
 
-The terminal UI uses the active UTF-8 locale for keyboard input and display. If a terminal starts in a plain `C` locale, the app falls back to `C.UTF-8` when available.
+The terminal UI uses the active locale for keyboard input and display. If that
+locale cannot be initialized, the app tries `C.UTF-8`, `en_US.UTF-8`, and
+`UTF-8`. A valid plain `C` locale remains active, so configure a UTF-8 locale in
+the shell when non-ASCII input or display is required.
+
+Oracle operations run serially on one persistent background worker. The UI
+continues to redraw and accept input while an operation runs, but it rejects a
+second database operation until the active one finishes. `Ctrl-C` requests
+interruption of the active operation. Reconnecting closes open result pages and
+clears query results loaded by the previous connection. If a manual transaction
+has pending changes, reconnect first asks whether to commit, roll back, discard
+the session, or cancel. Commit or rollback must succeed before reconnect closes
+the old connection. If either action fails, plsqlwks does not close the current
+connection or clear its loaded results; reconnect can be tried again with an
+explicit discard. Discard closes the session without resolving the transaction
+explicitly, so Oracle rolls its uncommitted work back.
+If the old connection is already dead and reports an error while closing,
+plsqlwks still attempts the replacement connection and reports the close error
+as a warning after a successful reconnect.
 
 After a successful quit, plsqlwks records the open file-backed tabs, active tab, and cursor positions in the managed `[session.tabs]` section of `config.ini`. Fresh platform-default workspaces use the user-config directory; explicitly selected and legacy workspaces keep `config.ini` inside the workspace for compatibility. On the next start the app tries each saved path independently, silently skips files that are missing or unreadable, and leaves the initial empty tab in place when none can be opened. A saved cursor position that no longer exists in its file starts at the beginning instead. Untitled, template, and generated schema tabs are not persisted because they do not have a file to reopen.
 
@@ -127,7 +175,7 @@ After a successful quit, plsqlwks records the open file-backed tabs, active tab,
 | `Alt-1`..`Alt-9` | Jump to visible file tab |
 | `Ctrl-Q` | Quit |
 | `Ctrl-C` while running | Interrupt the active database operation |
-| `Ctrl-Alt-C` | Commit the current transaction |
+| `Ctrl-Alt-C` | Insert the active result-grid draft, or commit when no draft is active |
 | `Ctrl-Alt-R` | Roll back the current transaction |
 
 ### Editor
@@ -182,7 +230,12 @@ Set `[database] remember_bind_values = yes` in the active `config.ini` to prefil
 
 Editor search is literal and case-insensitive. `Ctrl-F` prompts for text and selects the found occurrence; `Ctrl-N` and `Ctrl-P` repeat the last search forward or backward with wraparound.
 
-Editor autocomplete is available with `Shift-Tab`. It completes PL/SQL keywords, current-schema object names, and table/view columns from cached or lazily loaded database metadata; multiple matches open a picker. Use `Alt-+` to reload schema-object metadata and clear cached column metadata.
+Editor autocomplete is available with `Shift-Tab`. It completes PL/SQL keywords,
+current-schema object names, and table/view columns from cached or lazily loaded
+database metadata; multiple matches open a picker. Database-object and column
+completion currently supports conventional unquoted identifiers; quoted
+mixed-case names are not preserved. Use `Alt-+` to reload schema-object metadata
+and clear cached column metadata.
 
 Editor syntax and explain-plan colors can be overridden in the active `config.ini` with color names or numeric curses color indexes. Unsupported values fall back to the built-in palette for the current terminal:
 
@@ -225,16 +278,35 @@ Read-only mode is a client-side guardrail that rejects statements which the SQL
 | `PageUp` / `PageDown` | Scroll explain-plan lines by page |
 | `Home` / `End` | Move to the first/last explain-plan line |
 
-When more result rows are available, `PageDown` at the loaded end fetches and appends the next result page. For simple single-table queries that select `ROWID`, press `Enter` on a non-`ROWID` cell to update that table column by rowid. Press `INS` in the grid to prepare a draft row at the top of the grid, edit its cells with `Enter`, use `Ctrl-Alt-C` to insert it, or use `Esc` to cancel it.
+When more result rows are available, `PageDown` at the loaded end fetches and
+appends the next result page. For simple queries against one conventional
+unquoted current-schema table that include `ROWID`, press `Enter` on a directly
+selected unquoted table column to update it by rowid. Press `INS` in the grid to
+prepare a draft row at the top of the grid, edit its cells with `Enter`, use
+`Ctrl-Alt-C` to insert it, or use `Esc` to cancel it.
 Database null values are displayed and entered as `<NULL>` in editable results. Plain `NULL` is stored as literal text.
-Grid edits compare the typed value that was originally loaded as well as the `ROWID`. If another session changes or deletes the row first, the edit is rejected and the query must be refreshed. NUMBER input uses decimal notation with a period; DATE and TIMESTAMP input uses ISO `YYYY-MM-DD[ HH:MM:SS[.ffffff]]`; RAW and BLOB input uses hexadecimal bytes. Character and CLOB input is preserved as entered. Types that cannot be compared without losing information, including time-zone timestamps and timestamps with precision above six, are read-only in the grid.
-Displayed CLOB and BLOB values are limited to the first 65,536 characters or bytes and include a truncation marker with the full size. Truncated LOB cells cannot be edited safely. CSV export uses the displayed result values and therefore retains the same explicit LOB limit; schema-browser DDL is always read in full.
+Grid edits compare the selected cell's originally loaded typed value as well as
+the `ROWID`. If another session changes that cell or deletes the row first, the
+edit is rejected and the query must be refreshed. Changes to other cells in the
+same row do not cause a conflict. NUMBER input uses decimal notation with a
+period; DATE and TIMESTAMP input uses ISO
+`YYYY-MM-DD[ HH:MM:SS[.ffffff]]`; RAW and BLOB input uses hexadecimal bytes.
+Character and CLOB input is preserved as entered. Types that cannot be compared
+without losing information, including time-zone timestamps and timestamps with
+precision above six, are read-only in the grid.
+Displayed CLOB and BLOB values are limited to the first 65,536 characters or
+bytes and include a truncation marker with the full size. Truncated LOB cells
+cannot be edited safely. Schema-browser DDL is always read in full.
 `F7` cycles a grid fullscreen view that starts with the table header on the first terminal line and uses the last line for data, an editor-only fullscreen view, and a split layout with 2/3 editor and 1/3 data grid.
 
 ### Schema Browser
 
 The `F9` schema browser groups tables, views, procedures, functions, packages, triggers, sequences, indexes, and private synonyms from the current schema. Type while the browser is focused to filter object names with a case-insensitive substring match; groups without matches are hidden and matching groups expand automatically without changing their saved expansion state.
 
+Definition loading supports conventional unquoted identifiers. Quoted
+mixed-case objects can appear in the browser but their definitions cannot
+currently be loaded from it.
+
 | Key | Action |
 | --- | --- |
 | Printable text | Filter object names |
@@ -272,7 +344,8 @@ The `F9` schema browser groups tables, views, procedures, functions, packages, t
 workspace/
   sql/       saved SQL files
   plsql/     saved PL/SQL files
-  results/   exported query output
+  results/   reserved output directory
 ```
 
-The first launch creates the workspace folders and starter SQL/PLSQL files.
+The first launch creates the workspace folders and starter SQL/PLSQL files. The
+terminal UI does not currently provide a query-export command.

{plsqlwks-0.1.3 → plsqlwks-0.1.5}/README.md

@@ -1,6 +1,6 @@
 # plsqlwks
 
-An ncurses SQL and PL/SQL workspace for the local Oracle database.
+An ncurses SQL and PL/SQL workspace for Oracle databases.
 
 ![PLSQLWKS PREVIEW](https://gitlab.com/unununu/plsqlwks/-/raw/main/img/preview.png)
 
@@ -25,15 +25,24 @@ Override the defaults with environment variables:
 export ORACLE_USER=hr
 export ORACLE_PASSWORD_FILE=~/.config/plsqlwks/orapass
 export ORACLE_DSN='127.0.0.1:1521/free'
-export PLSQLWKS_WORKSPACE=/mnt/d/dev/plsqlwks/workspace
+export PLSQLWKS_WORKSPACE=/path/to/workspace
+export PLSQLWKS_MAX_ROWS=200
+export PLSQLWKS_ARRAYSIZE=100
 ```
 
 Password files preserve leading and trailing spaces; only final CR/LF line
 endings are removed. On POSIX systems, create the file for the current user and
 protect it with `chmod 600`.
 
+`PLSQLWKS_MAX_ROWS` sets the maximum number of rows in each result page, while
+`PLSQLWKS_ARRAYSIZE` sets the Oracle cursor array size. Both values must be
+positive integers.
+
 ## Install
 
+Python 3.10 or newer is required, along with a compatible terminal and a Python
+build that provides the standard-library `curses` module.
+
 For development, install the package in editable mode:
 
 ```bash
@@ -42,15 +51,27 @@ python3 -m pip install -e '.[dev]'
 
 `oracledb` is the only runtime dependency. Supporting functionality uses the Python standard library.
 
-See the [release checklist](https://gitlab.com/unununu/plsqlwks/-/blob/main/RELEASING.md)
-for the quality, packaging, and GitLab release process.
-
 For a regular local install, use:
 
 ```bash
 python3 -m pip install .
 ```
 
+Run the default test and lint checks from a development checkout with:
+
+```bash
+python3 -m pytest -q
+python3 -m ruff check .
+```
+
+Oracle integration tests require the connection environment variables shown
+above and an accessible password file. Enable every test group with:
+
+```bash
+PLSQLWKS_TEST_ORACLE=1 PLSQLWKS_TEST_PTY=1 PLSQLWKS_TEST_SLOW=1 \
+  python3 -m pytest -q -rs
+```
+
 ## Run
 
 After installation, start the workspace with:
@@ -69,6 +90,15 @@ The CLI option takes precedence over `PLSQLWKS_WORKSPACE`. For compatibility, a
 source checkout that already contains a configured `workspace/` continues to
 use it and displays a migration notice; files are never moved automatically.
 
+Choose the initial transaction mode for one invocation with `--manual` or
+`--autocommit`. These options override `[database] autocommit` from the active
+`config.ini`:
+
+```bash
+plsqlwks --manual
+plsqlwks --autocommit
+```
+
 You can also run it directly as a module from the source tree:
 
 ```bash
@@ -81,7 +111,25 @@ The app opens a split-screen terminal workspace:
 - results/messages below
 - command/status bar at the bottom
 
-The terminal UI uses the active UTF-8 locale for keyboard input and display. If a terminal starts in a plain `C` locale, the app falls back to `C.UTF-8` when available.
+The terminal UI uses the active locale for keyboard input and display. If that
+locale cannot be initialized, the app tries `C.UTF-8`, `en_US.UTF-8`, and
+`UTF-8`. A valid plain `C` locale remains active, so configure a UTF-8 locale in
+the shell when non-ASCII input or display is required.
+
+Oracle operations run serially on one persistent background worker. The UI
+continues to redraw and accept input while an operation runs, but it rejects a
+second database operation until the active one finishes. `Ctrl-C` requests
+interruption of the active operation. Reconnecting closes open result pages and
+clears query results loaded by the previous connection. If a manual transaction
+has pending changes, reconnect first asks whether to commit, roll back, discard
+the session, or cancel. Commit or rollback must succeed before reconnect closes
+the old connection. If either action fails, plsqlwks does not close the current
+connection or clear its loaded results; reconnect can be tried again with an
+explicit discard. Discard closes the session without resolving the transaction
+explicitly, so Oracle rolls its uncommitted work back.
+If the old connection is already dead and reports an error while closing,
+plsqlwks still attempts the replacement connection and reports the close error
+as a warning after a successful reconnect.
 
 After a successful quit, plsqlwks records the open file-backed tabs, active tab, and cursor positions in the managed `[session.tabs]` section of `config.ini`. Fresh platform-default workspaces use the user-config directory; explicitly selected and legacy workspaces keep `config.ini` inside the workspace for compatibility. On the next start the app tries each saved path independently, silently skips files that are missing or unreadable, and leaves the initial empty tab in place when none can be opened. A saved cursor position that no longer exists in its file starts at the beginning instead. Untitled, template, and generated schema tabs are not persisted because they do not have a file to reopen.
 
@@ -104,7 +152,7 @@ After a successful quit, plsqlwks records the open file-backed tabs, active tab,
 | `Alt-1`..`Alt-9` | Jump to visible file tab |
 | `Ctrl-Q` | Quit |
 | `Ctrl-C` while running | Interrupt the active database operation |
-| `Ctrl-Alt-C` | Commit the current transaction |
+| `Ctrl-Alt-C` | Insert the active result-grid draft, or commit when no draft is active |
 | `Ctrl-Alt-R` | Roll back the current transaction |
 
 ### Editor
@@ -159,7 +207,12 @@ Set `[database] remember_bind_values = yes` in the active `config.ini` to prefil
 
 Editor search is literal and case-insensitive. `Ctrl-F` prompts for text and selects the found occurrence; `Ctrl-N` and `Ctrl-P` repeat the last search forward or backward with wraparound.
 
-Editor autocomplete is available with `Shift-Tab`. It completes PL/SQL keywords, current-schema object names, and table/view columns from cached or lazily loaded database metadata; multiple matches open a picker. Use `Alt-+` to reload schema-object metadata and clear cached column metadata.
+Editor autocomplete is available with `Shift-Tab`. It completes PL/SQL keywords,
+current-schema object names, and table/view columns from cached or lazily loaded
+database metadata; multiple matches open a picker. Database-object and column
+completion currently supports conventional unquoted identifiers; quoted
+mixed-case names are not preserved. Use `Alt-+` to reload schema-object metadata
+and clear cached column metadata.
 
 Editor syntax and explain-plan colors can be overridden in the active `config.ini` with color names or numeric curses color indexes. Unsupported values fall back to the built-in palette for the current terminal:
 
@@ -202,16 +255,35 @@ Read-only mode is a client-side guardrail that rejects statements which the SQL
 | `PageUp` / `PageDown` | Scroll explain-plan lines by page |
 | `Home` / `End` | Move to the first/last explain-plan line |
 
-When more result rows are available, `PageDown` at the loaded end fetches and appends the next result page. For simple single-table queries that select `ROWID`, press `Enter` on a non-`ROWID` cell to update that table column by rowid. Press `INS` in the grid to prepare a draft row at the top of the grid, edit its cells with `Enter`, use `Ctrl-Alt-C` to insert it, or use `Esc` to cancel it.
+When more result rows are available, `PageDown` at the loaded end fetches and
+appends the next result page. For simple queries against one conventional
+unquoted current-schema table that include `ROWID`, press `Enter` on a directly
+selected unquoted table column to update it by rowid. Press `INS` in the grid to
+prepare a draft row at the top of the grid, edit its cells with `Enter`, use
+`Ctrl-Alt-C` to insert it, or use `Esc` to cancel it.
 Database null values are displayed and entered as `<NULL>` in editable results. Plain `NULL` is stored as literal text.
-Grid edits compare the typed value that was originally loaded as well as the `ROWID`. If another session changes or deletes the row first, the edit is rejected and the query must be refreshed. NUMBER input uses decimal notation with a period; DATE and TIMESTAMP input uses ISO `YYYY-MM-DD[ HH:MM:SS[.ffffff]]`; RAW and BLOB input uses hexadecimal bytes. Character and CLOB input is preserved as entered. Types that cannot be compared without losing information, including time-zone timestamps and timestamps with precision above six, are read-only in the grid.
-Displayed CLOB and BLOB values are limited to the first 65,536 characters or bytes and include a truncation marker with the full size. Truncated LOB cells cannot be edited safely. CSV export uses the displayed result values and therefore retains the same explicit LOB limit; schema-browser DDL is always read in full.
+Grid edits compare the selected cell's originally loaded typed value as well as
+the `ROWID`. If another session changes that cell or deletes the row first, the
+edit is rejected and the query must be refreshed. Changes to other cells in the
+same row do not cause a conflict. NUMBER input uses decimal notation with a
+period; DATE and TIMESTAMP input uses ISO
+`YYYY-MM-DD[ HH:MM:SS[.ffffff]]`; RAW and BLOB input uses hexadecimal bytes.
+Character and CLOB input is preserved as entered. Types that cannot be compared
+without losing information, including time-zone timestamps and timestamps with
+precision above six, are read-only in the grid.
+Displayed CLOB and BLOB values are limited to the first 65,536 characters or
+bytes and include a truncation marker with the full size. Truncated LOB cells
+cannot be edited safely. Schema-browser DDL is always read in full.
 `F7` cycles a grid fullscreen view that starts with the table header on the first terminal line and uses the last line for data, an editor-only fullscreen view, and a split layout with 2/3 editor and 1/3 data grid.
 
 ### Schema Browser
 
 The `F9` schema browser groups tables, views, procedures, functions, packages, triggers, sequences, indexes, and private synonyms from the current schema. Type while the browser is focused to filter object names with a case-insensitive substring match; groups without matches are hidden and matching groups expand automatically without changing their saved expansion state.
 
+Definition loading supports conventional unquoted identifiers. Quoted
+mixed-case objects can appear in the browser but their definitions cannot
+currently be loaded from it.
+
 | Key | Action |
 | --- | --- |
 | Printable text | Filter object names |
@@ -249,7 +321,8 @@ The `F9` schema browser groups tables, views, procedures, functions, packages, t
 workspace/
   sql/       saved SQL files
   plsql/     saved PL/SQL files
-  results/   exported query output
+  results/   reserved output directory
 ```
 
-The first launch creates the workspace folders and starter SQL/PLSQL files.
+The first launch creates the workspace folders and starter SQL/PLSQL files. The
+terminal UI does not currently provide a query-export command.

{plsqlwks-0.1.3 → plsqlwks-0.1.5}/plsqlwks/__init__.py

@@ -1,3 +1,3 @@
 """ncurses SQL and PL/SQL workspace."""
 
-__version__ = "0.1.3"
+__version__ = "0.1.5"

{plsqlwks-0.1.3 → plsqlwks-0.1.5}/plsqlwks/ui/app_db.py

@@ -41,6 +41,11 @@ class TransactionCompletion:
     cleanup_error: Exception | None = None
 
 
+@dataclass(frozen=True)
+class ConnectionCompletion:
+    old_session_close_error: Exception | None = None
+
+
 @dataclass(frozen=True)
 class TransactionModeChange:
     resolution: str | None
@@ -224,6 +229,12 @@ class AppDbMixin:
         worker.shutdown(timeout=timeout)
 
     def try_connect(self, force: bool = False) -> None:
+        if force:
+            self.reconnect_database()
+            return
+        self._start_connect(force=False)
+
+    def _start_connect(self, *, force: bool) -> None:
         if self.reject_if_db_operation_active():
             return
 
@@ -231,13 +242,23 @@ class AppDbMixin:
             self.close_all_result_continuations()
             self.invalidate_results_after_rollback()
 
-        def connect(db: Any, progress: Callable[[str], None]) -> None:
+        def connect(db: Any, progress: Callable[[str], None]) -> ConnectionCompletion:
+            close_error = None
             if force:
-                db.close()
+                try:
+                    db.close()
+                except Exception as exc:
+                    close_error = exc
             db.ensure_connected()
+            return ConnectionCompletion(close_error)
 
-        def connected(_result: Any) -> None:
+        def connected(result: ConnectionCompletion) -> None:
             self.state.status = f"Connected as {self.state.config.user}"
+            if result.old_session_close_error is not None:
+                self.state.status += (
+                    " (warning: old session close failed: "
+                    f"{short_error(result.old_session_close_error)})"
+                )
 
         def connect_failed(exc: Exception) -> None:
             self.state.status = "Connection failed"
@@ -273,11 +294,19 @@ class AppDbMixin:
             return
         self.state.status = "Transaction mode unchanged"
 
-    def prompt_pending_transaction(self, cancel_status: str) -> str | None:
+    def prompt_pending_transaction(
+        self,
+        cancel_status: str,
+        *,
+        allow_discard: bool = False,
+    ) -> str | None:
         if not has_uncommitted_changes(self.state.db):
             return "none"
+        choices = "c=commit, r=rollback, x=cancel"
+        if allow_discard:
+            choices = "c=commit, r=rollback, d=discard session, x=cancel"
         answer = self.prompt(
-            "Pending transaction: c=commit, r=rollback, x=cancel",
+            f"Pending transaction: {choices}",
             "",
         )
         if answer is None:
@@ -288,6 +317,8 @@ class AppDbMixin:
             return "commit"
         if normalized in {"r", "rollback"}:
             return "rollback"
+        if allow_discard and normalized in {"d", "discard", "discard session"}:
+            return "discard"
         self.state.status = cancel_status
         return None
 
@@ -369,6 +400,8 @@ class AppDbMixin:
         self,
         after_success: Callable[[], None] | None = None,
         after_error: Callable[[], None] | None = None,
+        *,
+        preserve_results_on_error: bool = False,
     ) -> bool:
         if self.reject_if_db_operation_active():
             return False
@@ -380,7 +413,10 @@ class AppDbMixin:
 
         def commit_failed(exc: Exception) -> None:
             self.state.status = "Commit failed"
-            self.set_results(["ERROR committing transaction:", *wrap_error(exc)])
+            self.set_results(
+                ["ERROR committing transaction:", *wrap_error(exc)],
+                clear_table=not preserve_results_on_error,
+            )
             if after_error is not None:
                 after_error()
 
@@ -396,6 +432,8 @@ class AppDbMixin:
         self,
         after_success: Callable[[], None] | None = None,
         after_error: Callable[[], None] | None = None,
+        *,
+        preserve_results_on_error: bool = False,
     ) -> bool:
         if self.reject_if_db_operation_active():
             return False
@@ -423,7 +461,10 @@ class AppDbMixin:
 
         def rollback_failed(exc: Exception) -> None:
             self.state.status = "Rollback failed"
-            self.set_results(["ERROR rolling back transaction:", *wrap_error(exc)])
+            self.set_results(
+                ["ERROR rolling back transaction:", *wrap_error(exc)],
+                clear_table=not preserve_results_on_error,
+            )
             if after_error is not None:
                 after_error()
 

{plsqlwks-0.1.3 → plsqlwks-0.1.5}/plsqlwks/ui/app_input.py

@@ -161,7 +161,32 @@ class AppInputMixin:
         self.commit_transaction()
 
     def reconnect_database(self) -> None:
-        self.try_connect(force=True)
+        if self.reject_if_db_operation_active():
+            return
+        resolution = self.prompt_pending_transaction(
+            "Reconnect cancelled",
+            allow_discard=True,
+        )
+        if resolution is None:
+            return
+
+        def reconnect_after_resolution() -> None:
+            self._start_connect(force=True)
+
+        if resolution == "commit":
+            self.commit_transaction(
+                after_success=reconnect_after_resolution,
+                preserve_results_on_error=True,
+            )
+        elif resolution == "rollback":
+            self.rollback_transaction(
+                after_success=reconnect_after_resolution,
+                preserve_results_on_error=True,
+            )
+        elif resolution in {"discard", "none"}:
+            reconnect_after_resolution()
+        else:
+            self.state.status = "Reconnect cancelled"
 
     def refresh_workspace_file_list(self) -> None:
         self.state.files = _legacy_ui_attr("list_workspace_files", list_workspace_files)(self.state.config)