plato-sdk-v2 2.8.2__tar.gz → 2.8.3__tar.gz

{plato_sdk_v2-2.8.2 → plato_sdk_v2-2.8.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: plato-sdk-v2
-Version: 2.8.2
+Version: 2.8.3
 Summary: Python SDK for the Plato API
 Author-email: Plato <support@plato.so>
 License-Expression: MIT

plato_sdk_v2-2.8.3/VERSION

@@ -0,0 +1 @@
+2.8.3

{plato_sdk_v2-2.8.2 → plato_sdk_v2-2.8.3}/plato/cli/pm.py

@@ -43,6 +43,8 @@ from plato.cli.utils import (
 from plato.v1.flow_executor import FlowExecutor
 from plato.v1.models.flow import Flow
 from plato.v1.sdk import Plato
+from plato.v2.async_.client import AsyncPlato
+from plato.v2.types import Env
 
 # =============================================================================
 # CONSTANTS
@@ -724,18 +726,25 @@ def review_data(
         help="Artifact UUID to review. If not provided, uses server's data_artifact_id.",
     ),
 ):
-    """Launch browser with EnvGen Recorder extension for data review.
+    """
+    Launch browser with Data Review extension for data review.
 
-    Opens Chrome with the EnvGen Recorder extension installed for reviewing
-    data artifacts. The extension sidebar can be used to record and submit reviews.
-    Press Control-C to exit when done.
+    Opens Chrome with the Data Review extension installed for reviewing
+    data artifacts. Close the browser when done.
 
-    Requires simulator status: data_review_requested
+    SPECIFYING SIMULATOR AND ARTIFACT:
 
-    Options:
-        -s, --simulator: Simulator name. Supports colon notation for artifact:
-            '-s sim' (uses server's data_artifact_id) or '-s sim:<uuid>'
-        -a, --artifact: Explicit artifact UUID to review. Overrides server's value.
+        -s <simulator>                      Use server's data_artifact_id
+        -s <simulator> -a <artifact-uuid>   Explicit artifact
+        -s <simulator>:<artifact-uuid>      Colon notation (same as above)
+
+    EXAMPLES:
+
+        plato pm review data -s fathom
+        plato pm review data -s fathom -a e9c25ca5-1234-5678-9abc-def012345678
+        plato pm review data -s fathom:e9c25ca5-1234-5678-9abc-def012345678
+
+    Requires simulator status: data_review_requested
     """
     api_key = require_api_key()
 
@@ -744,8 +753,6 @@ def review_data(
         simulator, artifact, require_artifact=False, command_name="review data"
     )
 
-    # Determine target URL based on simulator
-    target_url = f"https://{simulator_name}.web.plato.so"
     console.print(f"[cyan]Simulator:[/cyan] {simulator_name}")
 
     # Fetch simulator config and get artifact ID if not provided
@@ -790,45 +797,75 @@ def review_data(
         console.print(f"[cyan]Artifact:[/cyan] {artifact_id}")
 
     # Find Chrome extension source
-    package_dir = Path(__file__).resolve().parent.parent  # v1/
+    package_dir = Path(__file__).resolve().parent.parent  # plato/
     is_installed = "site-packages" in str(package_dir)
 
     if is_installed:
-        extension_source_path = package_dir / "extensions" / "envgen-recorder-old"
+        extension_source_path = package_dir / "extensions" / "data-review"
     else:
-        repo_root = package_dir.parent.parent.parent  # plato-client/
-        extension_source_path = repo_root / "extensions" / "envgen-recorder-old"
+        repo_root = package_dir.parent.parent  # plato-client/
+        extension_source_path = repo_root / "extensions" / "data-review"
 
     # Fallback to env var
     if not extension_source_path.exists():
         plato_client_dir_env = os.getenv("PLATO_CLIENT_DIR")
         if plato_client_dir_env:
-            env_path = Path(plato_client_dir_env) / "extensions" / "envgen-recorder-old"
+            env_path = Path(plato_client_dir_env) / "extensions" / "data-review"
             if env_path.exists():
                 extension_source_path = env_path
 
     if not extension_source_path.exists():
-        console.print("[red]❌ EnvGen Recorder extension not found[/red]")
+        console.print("[red]❌ Data Review extension not found[/red]")
         console.print(f"\n[yellow]Expected location:[/yellow] {extension_source_path}")
         raise typer.Exit(1)
 
     # Copy extension to temp directory
     temp_ext_dir = Path(tempfile.mkdtemp(prefix="plato-extension-"))
-    extension_path = temp_ext_dir / "envgen-recorder"
+    extension_path = temp_ext_dir / "data-review"
 
     console.print("[cyan]Copying extension to temp directory...[/cyan]")
     shutil.copytree(extension_source_path, extension_path, dirs_exist_ok=False)
     console.print(f"[green]✅ Extension copied to: {extension_path}[/green]")
 
     async def _review_data():
+        base_url = _get_base_url()
+        plato = AsyncPlato(api_key=api_key, base_url=base_url)
+        session = None
         playwright = None
         browser = None
 
         try:
+            # Check if we have an artifact ID to create a session
+            if not artifact_id:
+                console.print("[red]❌ No artifact ID available. Cannot create session.[/red]")
+                console.print("[yellow]Specify artifact with: plato pm review data -s simulator:artifact_id[/yellow]")
+                raise typer.Exit(1)
+
+            # Create session with artifact
+            console.print(f"[cyan]Creating {simulator_name} environment with artifact {artifact_id}...[/cyan]")
+            session = await plato.sessions.create(
+                envs=[Env.artifact(artifact_id)],
+                timeout=300,
+            )
+            console.print(f"[green]✅ Session created: {session.session_id}[/green]")
+
+            # Reset environment
+            console.print("[cyan]Resetting environment...[/cyan]")
+            await session.reset()
+            console.print("[green]✅ Environment reset complete![/green]")
+
+            # Get public URL
+            public_urls = await session.get_public_url()
+            first_alias = session.envs[0].alias if session.envs else None
+            public_url = public_urls.get(first_alias) if first_alias else None
+            if not public_url and public_urls:
+                public_url = list(public_urls.values())[0]
+            console.print(f"[cyan]Public URL:[/cyan] {public_url}")
+
             user_data_dir = Path.home() / ".plato" / "chrome-data"
             user_data_dir.mkdir(parents=True, exist_ok=True)
 
-            console.print("[cyan]Launching Chrome with EnvGen Recorder extension...[/cyan]")
+            console.print("[cyan]Launching Chrome with Data Review extension...[/cyan]")
 
             from playwright.async_api import async_playwright
 
@@ -869,13 +906,14 @@ def review_data(
             else:
                 console.print("[yellow]⚠️  Could not find extension ID. Please set API key manually.[/yellow]")
 
-            # Step 1: Navigate to target URL first
-            console.print(f"[cyan]Navigating to {target_url}...[/cyan]")
+            # Navigate to public URL (user logs in manually with displayed credentials)
+            console.print("[cyan]Opening environment...[/cyan]")
             main_page = await browser.new_page()
-            await main_page.goto(target_url, wait_until="domcontentloaded")
-            console.print(f"[green]✅ Loaded: {target_url}[/green]")
+            if public_url:
+                await main_page.goto(public_url)
+                console.print(f"[green]✅ Loaded: {public_url}[/green]")
 
-            # Step 2: Use options page to set API key
+            # Use options page to set API key
             if extension_id:
                 options_page = await browser.new_page()
                 try:
@@ -899,17 +937,16 @@ def review_data(
                     await options_page.close()
 
             # Bring main page to front
-            await main_page.bring_to_front()
+            if main_page:
+                await main_page.bring_to_front()
 
             console.print()
             console.print("[bold]Instructions:[/bold]")
-            console.print("  1. Click the EnvGen Recorder extension icon to open the sidebar")
-            if simulator:
-                console.print(f"  2. Click 'Configure Session' and enter '{simulator}' as the simulator name")
-            else:
-                console.print("  2. Click 'Configure Session' and enter a simulator name")
-            console.print("  3. Use the extension to record and submit reviews")
-            console.print("  4. When done, press Control-C to exit")
+            console.print("  1. Click the Data Review extension icon to open the sidebar")
+            console.print(f"  2. Enter '{simulator_name}' as the simulator name and click Start Review")
+            console.print("  3. Take screenshots and add comments for any issues")
+            console.print("  4. Select Pass or Reject and submit the review")
+            console.print("  5. When done, press Control-C to exit")
 
             # Show recent review if available
             if recent_review:
@@ -922,10 +959,20 @@ def review_data(
                 else:
                     console.print(f"[bold green]📋 Most Recent Data Review: PASSED[/bold green] ({timestamp})")
 
-                comments = recent_review.get("comments")
-                if comments:
+                # Handle both old 'comments' field and new 'sim_comments' structure
+                sim_comments = recent_review.get("sim_comments")
+                if sim_comments:
                     console.print("\n[yellow]Reviewer Comments:[/yellow]")
-                    console.print(f"  {comments}")
+                    for i, item in enumerate(sim_comments, 1):
+                        comment_text = item.get("comment", "")
+                        if comment_text:
+                            console.print(f"  {i}. {comment_text}")
+                else:
+                    # Fallback to old comments field
+                    comments = recent_review.get("comments")
+                    if comments:
+                        console.print("\n[yellow]Reviewer Comments:[/yellow]")
+                        console.print(f"  {comments}")
                 console.print("=" * 60)
 
             console.print()
@@ -946,6 +993,8 @@ def review_data(
 
         finally:
             try:
+                if session:
+                    await session.close()
                 if browser:
                     await browser.close()
                 if playwright:
@@ -953,7 +1002,7 @@ def review_data(
                 if temp_ext_dir.exists():
                     shutil.rmtree(temp_ext_dir, ignore_errors=True)
             except Exception as e:
-                console.print(f"[yellow]⚠️  Browser cleanup error: {e}[/yellow]")
+                console.print(f"[yellow]⚠️  Cleanup error: {e}[/yellow]")
 
     handle_async(_review_data())
 

plato_sdk_v2-2.8.2/VERSION

@@ -1 +0,0 @@
-2.8.2