plain 0.22.2__tar.gz → 0.23.0__tar.gz

{plain-0.22.2 → plain-0.23.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: plain
-Version: 0.22.2
+Version: 0.23.0
 Summary: A web framework for building products with Python.
 Author-email: Dave Gaeddert <dave.gaeddert@dropseed.dev>
 License-File: LICENSE

{plain-0.22.2 → plain-0.23.0}/plain/urls/resolvers.py

@@ -16,7 +16,6 @@ from urllib.parse import quote
 from plain.preflight.urls import check_resolver
 from plain.runtime import settings
 from plain.utils.datastructures import MultiValueDict
-from plain.utils.functional import cached_property
 from plain.utils.http import RFC3986_SUBDELIMS, escape_leading_slashes
 from plain.utils.regex_helper import normalize
 
@@ -106,7 +105,7 @@ def _get_cached_resolver(urls_module):
         urls_module = import_module(urls_module)
 
     router = routers_registry.get_module_router(urls_module)
-    return URLResolver(pattern=RegexPattern(r"^/"), router_class=router)
+    return URLResolver(pattern=RegexPattern(r"^/"), router=router)
 
 
 @functools.cache
@@ -120,16 +119,18 @@ def get_ns_resolver(ns_pattern, resolver, converters):
     pattern.converters = dict(converters)
 
     class _NestedRouter(RouterBase):
+        namespace = ""
         urls = resolver.url_patterns
 
-    ns_resolver = URLResolver(pattern=pattern, router_class=_NestedRouter)
+    ns_resolver = URLResolver(pattern=pattern, router=_NestedRouter())
 
     class _NamespacedRouter(RouterBase):
+        namespace = ""
         urls = [ns_resolver]
 
     return URLResolver(
         pattern=RegexPattern(r"^/"),
-        router_class=_NamespacedRouter,
+        router=_NamespacedRouter(),
     )
 
 
@@ -138,18 +139,23 @@ class URLResolver:
         self,
         *,
         pattern,
-        router_class,
+        router,
     ):
         self.pattern = pattern
-        self.router_class = router_class
+        self.router = router
         self._reverse_dict = {}
         self._namespace_dict = {}
         self._app_dict = {}
         self._populated = False
         self._local = local()
 
+        # Set these immediately, in part so we can find routers
+        # where the attributes weren't set correctly.
+        self.namespace = self.router.namespace
+        self.url_patterns = self.router.urls
+
     def __repr__(self):
-        return f"<{self.__class__.__name__} {repr(self.router_class)} ({self.namespace}) {self.pattern.describe()}>"
+        return f"<{self.__class__.__name__} {repr(self.router)} ({self.namespace}) {self.pattern.describe()}>"
 
     def check(self):
         messages = []
@@ -313,15 +319,6 @@ class URLResolver:
             raise Resolver404({"tried": tried, "path": new_path})
         raise Resolver404({"path": path})
 
-    @cached_property
-    def url_patterns(self):
-        # Don't need to instantiate the class because they are just class attributes for now.
-        return self.router_class.urls
-
-    @cached_property
-    def namespace(self):
-        return self.router_class.namespace
-
     def reverse(self, lookup_view, *args, **kwargs):
         if args and kwargs:
             raise ValueError("Don't mix *args and **kwargs in call to reverse()!")

{plain-0.22.2 → plain-0.23.0}/plain/urls/routers.py

@@ -1,5 +1,4 @@
 import re
-from abc import ABC
 from types import ModuleType
 from typing import TYPE_CHECKING
 
@@ -14,9 +13,16 @@ if TYPE_CHECKING:
     from plain.views import View
 
 
-class RouterBase(ABC):
-    namespace: str = ""
-    urls: list  # Required
+class RouterBase:
+    """
+    Base class for defining url patterns.
+
+    A namespace is required, and generally recommended,
+    except for the root router in app.urls where it is typically "".
+    """
+
+    namespace: str
+    urls: list
 
 
 class RoutersRegistry:
@@ -26,9 +32,12 @@ class RoutersRegistry:
         self._routers = {}
 
     def register_router(self, router_class):
+        router = (
+            router_class()
+        )  # Don't necessarily need to instantiate it yet, but will likely add methods.
         router_module_name = router_class.__module__
-        self._routers[router_module_name] = router_class
-        return router_class
+        self._routers[router_module_name] = router
+        return router
 
     def get_module_router(self, module):
         if isinstance(module, str):
@@ -62,17 +71,18 @@ def include(
         # We were given an explicit list of sub-patterns,
         # so we generate a router for it
         class _IncludeRouter(RouterBase):
+            namespace = ""
             urls = module_or_urls
 
-        return URLResolver(pattern=pattern, router_class=_IncludeRouter)
+        return URLResolver(pattern=pattern, router=_IncludeRouter())
     else:
         # We were given a module, so we need to look up the router for that module
         module = module_or_urls
-        router_class = routers_registry.get_module_router(module)
+        router = routers_registry.get_module_router(module)
 
         return URLResolver(
             pattern=pattern,
-            router_class=router_class,
+            router=router,
         )
 
 
@@ -109,4 +119,9 @@ def path(route: str | re.Pattern, view: "View", *, name: str = "") -> URLPattern
 
 
 routers_registry = RoutersRegistry()
-register_router = routers_registry.register_router
+
+
+def register_router(router_class):
+    """Decorator to register a router class"""
+    routers_registry.register_router(router_class)
+    return router_class  # Return the class, not the instance

{plain-0.22.2 → plain-0.23.0}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "plain"
-version = "0.22.2"
+version = "0.23.0"
 description = "A web framework for building products with Python."
 authors = [{name = "Dave Gaeddert", email = "dave.gaeddert@dropseed.dev"}]
 readme = "README.md"

{plain-0.22.2 → plain-0.23.0}/tests/app/urls.py

@@ -9,6 +9,7 @@ class TestView(View):
 
 @register_router
 class Router(RouterBase):
+    namespace = ""
     urls = [
         path("", TestView),
     ]