plain 0.20.0__tar.gz → 0.21.1__tar.gz

{plain-0.20.0 → plain-0.21.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: plain
-Version: 0.20.0
+Version: 0.21.1
 Summary: A web framework for building products with Python.
 Author-email: Dave Gaeddert <dave.gaeddert@dropseed.dev>
 License-File: LICENSE

{plain-0.20.0 → plain-0.21.1}/plain/internal/handlers/base.py

@@ -14,11 +14,16 @@ logger = logging.getLogger("plain.request")
 
 
 # These middleware classes are always used by Plain.
-BUILTIN_MIDDLEWARE = [
-    "plain.internal.middleware.headers.DefaultHeadersMiddleware",
-    "plain.internal.middleware.https.HttpsRedirectMiddleware",
+BUILTIN_BEFORE_MIDDLEWARE = [
+    "plain.internal.middleware.headers.DefaultHeadersMiddleware",  # Runs after response, to set missing headers
+    "plain.internal.middleware.https.HttpsRedirectMiddleware",  # Runs before response, to redirect to HTTPS quickly
+    "plain.csrf.middleware.CsrfViewMiddleware",  # Runs before and after get_response...
+]
+
+BUILTIN_AFTER_MIDDLEWARE = [
+    # Want this to run first (when reversed) so the slash middleware
+    # can immediately redirect to the slash-appended path if there is one.
     "plain.internal.middleware.slash.RedirectSlashMiddleware",
-    "plain.csrf.middleware.CsrfViewMiddleware",
 ]
 
 
@@ -34,7 +39,9 @@ class BaseHandler:
         get_response = self._get_response
         handler = convert_exception_to_response(get_response)
 
-        middlewares = reversed(BUILTIN_MIDDLEWARE + settings.MIDDLEWARE)
+        middlewares = reversed(
+            BUILTIN_BEFORE_MIDDLEWARE + settings.MIDDLEWARE + BUILTIN_AFTER_MIDDLEWARE
+        )
 
         for middleware_path in middlewares:
             middleware = import_string(middleware_path)

{plain-0.20.0 → plain-0.21.1}/plain/views/objects.py

@@ -1,5 +1,6 @@
 from plain.exceptions import ImproperlyConfigured, ObjectDoesNotExist
-from plain.http import Http404, Response, ResponseRedirect
+from plain.forms import Form
+from plain.http import Http404, Response
 
 from .forms import FormView
 from .templates import TemplateView
@@ -80,6 +81,8 @@ class CreateView(ObjectTemplateViewMixin, FormView):
     View for creating a new object, with a response rendered by a template.
     """
 
+    template_name_suffix = "_form"
+
     def post(self) -> Response:
         """
         Handle POST requests: instantiate a form instance with the passed
@@ -152,30 +155,41 @@ class UpdateView(ObjectTemplateViewMixin, FormView):
         return kwargs
 
 
-class DeleteView(ObjectTemplateViewMixin, TemplateView):
+class DeleteView(ObjectTemplateViewMixin, FormView):
     """
     View for deleting an object retrieved with self.get_object(), with a
     response rendered by a template.
     """
 
+    class EmptyDeleteForm(Form):
+        def __init__(self, instance, *args, **kwargs):
+            self.instance = instance
+            super().__init__(*args, **kwargs)
+
+        def save(self):
+            self.instance.delete()
+
+    form_class = EmptyDeleteForm
     template_name_suffix = "_confirm_delete"
 
+    def post(self) -> Response:
+        """
+        Handle POST requests: instantiate a form instance with the passed
+        POST variables and then check if it's valid.
+        """
+        self.load_object()
+        return super().post()
+
     def get_form_kwargs(self):
         """Return the keyword arguments for instantiating the form."""
         kwargs = super().get_form_kwargs()
         kwargs.update({"instance": self.object})
         return kwargs
 
-    def get_success_url(self):
-        if self.success_url:
-            return self.success_url.format(**self.object.__dict__)
-        else:
-            raise ImproperlyConfigured("No URL to redirect to. Provide a success_url.")
-
-    def post(self):
-        self.load_object()
-        self.object.delete()
-        return ResponseRedirect(self.get_success_url())
+    def form_valid(self, form):
+        """If the form is valid, save the associated model."""
+        form.save()
+        return super().form_valid(form)
 
 
 class ListView(TemplateView):

{plain-0.20.0 → plain-0.21.1}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "plain"
-version = "0.20.0"
+version = "0.21.1"
 description = "A web framework for building products with Python."
 authors = [{name = "Dave Gaeddert", email = "dave.gaeddert@dropseed.dev"}]
 readme = "README.md"