plain.postgres 0.103.3__tar.gz → 0.103.5__tar.gz

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/.gitignore

@@ -3,6 +3,7 @@
 *.egg-info
 *.py[co]
 __pycache__
+.pytest_cache
 *.DS_Store
 *.swp
 *.swo

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: plain.postgres
-Version: 0.103.3
+Version: 0.103.5
 Summary: Model your data and store it in a database.
 Author-email: Dave Gaeddert <dave.gaeddert@dropseed.dev>
 License-Expression: BSD-3-Clause

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/plain/postgres/CHANGELOG.md

@@ -1,5 +1,26 @@
 # plain-postgres changelog
 
+## [0.103.5](https://github.com/dropseed/plain/releases/plain-postgres@0.103.5) (2026-05-19)
+
+### What's changed
+
+- **Pooled connections are now validated on checkout.** The connection pool runs `check_connection` on each `getconn()`, so a connection closed server-side while idle in the pool (a server or pooler idle timeout) is discarded and replaced rather than handed out dead. This closes a class of `OperationalError: the connection is closed` failures on the first query of a request after an idle period. ([31ad84f423](https://github.com/dropseed/plain/commit/31ad84f423))
+- Standardized `__all__` in `forms.py` to a list for consistency with the rest of the codebase. ([64ee8a4de0](https://github.com/dropseed/plain/commit/64ee8a4de0))
+
+### Upgrade instructions
+
+- No changes required.
+
+## [0.103.4](https://github.com/dropseed/plain/releases/plain-postgres@0.103.4) (2026-05-12)
+
+### What's changed
+
+- **`postgres.duplicate_indexes` preflight check now skips partial indexes** (those with a `condition=`). Previously a bare `Index(fields=[fk])` carried for FK coverage was flagged as redundant with a partial composite `Index(fields=[fk, ...], condition=Q(...))`, contradicting the `postgres.missing_fk_index` check. The two warnings are now mutually consistent — partials don't cover full-column lookups, so they can't shadow a single-column index. ([1e8a3f72db](https://github.com/dropseed/plain/commit/1e8a3f72db))
+
+### Upgrade instructions
+
+- No changes required. Apps that were silencing `postgres.duplicate_indexes` to work around the false positive can drop the silence.
+
 ## [0.103.3](https://github.com/dropseed/plain/releases/plain-postgres@0.103.3) (2026-05-08)
 
 ### What's changed

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/plain/postgres/forms.py

@@ -23,14 +23,14 @@ from plain.postgres.fields.base import ColumnField, DefaultableField
 if TYPE_CHECKING:
     from plain.postgres.fields import Field as ModelField
 
-__all__ = (
+__all__ = [
     "ModelForm",
     "BaseModelForm",
     "model_to_dict",
     "fields_for_model",
     "ModelChoiceField",
     "ModelMultipleChoiceField",
-)
+]
 
 
 def construct_instance(

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/plain/postgres/preflight.py

@@ -27,16 +27,23 @@ def _get_app_models() -> list[Any]:
 
 
 def _collect_model_indexes(model: Any) -> list[tuple[str, list[str], bool]]:
-    """Collect all index field-lists for a model as (name, fields, is_unique) tuples."""
+    """Collect (name, fields, is_unique) for non-partial indexes/constraints.
+
+    Partials are skipped for the same reason as in ``_fk_covered_field_names``.
+    """
     all_indexes: list[tuple[str, list[str], bool]] = []
 
     for index in model.model_options.indexes:
-        if index.fields:
+        if index.fields and not index.is_partial:
             fields = [f.lstrip("-") for f in index.fields]
             all_indexes.append((index.name, fields, False))
 
     for constraint in model.model_options.constraints:
-        if isinstance(constraint, UniqueConstraint) and constraint.fields:
+        if (
+            isinstance(constraint, UniqueConstraint)
+            and constraint.fields
+            and not constraint.is_partial
+        ):
             all_indexes.append((constraint.name, list(constraint.fields), True))
 
     return all_indexes

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/plain/postgres/sources.py

@@ -175,6 +175,10 @@ class PoolSource(ConnectionSource):
             kwargs=params,
             open=False,
             reset=_reset_pooled_connection,
+            # Validate each connection on checkout. One closed server-side
+            # while idle in the pool (server or pooler idle timeout) is
+            # discarded and replaced rather than handed out dead.
+            check=ConnectionPool.check_connection,
             min_size=plain_settings.POSTGRES_POOL_MIN_SIZE,
             max_size=plain_settings.POSTGRES_POOL_MAX_SIZE,
             max_lifetime=plain_settings.POSTGRES_POOL_MAX_LIFETIME,

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "plain.postgres"
-version = "0.103.3"
+version = "0.103.5"
 description = "Model your data and store it in a database."
 authors = [{ name = "Dave Gaeddert", email = "dave.gaeddert@dropseed.dev" }]
 readme = "README.md"
@@ -16,7 +16,7 @@ dependencies = ["plain>=0.134.0,<1.0.0", "psycopg>=3.2", "psycopg-pool>=3.2"]
 "plain.postgres" = "plain.postgres.test.pytest"
 
 [dependency-groups]
-dev = ["plain.pytest<1.0.0", "opentelemetry-sdk>=1.34.1"]
+dev = ["plain.pytest<1.0.0", "plain.templates>=0.1.0,<1.0.0", "opentelemetry-sdk>=1.34.1"]
 
 [tool.hatch.build.targets.wheel]
 packages = ["plain"]

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/tests/app/examples/urls.py

@@ -9,27 +9,27 @@ class ExamplesRouter(Router):
     namespace = "examples"
     urls = [
         path(
-            "forms/create/",
+            "forms/create",
             views.FormsExampleCreateView,
             name="forms_create",
         ),
         path(
-            "forms/<int:pk>/update/",
+            "forms/<int:pk>/update",
             views.FormsExampleUpdateView,
             name="forms_update",
         ),
         path(
-            "child-cascade/create/",
+            "child-cascade/create",
             views.ChildCascadeCreateView,
             name="child_cascade_create",
         ),
         path(
-            "db-defaults/create/",
+            "db-defaults/create",
             views.DBDefaultsExampleCreateView,
             name="db_defaults_create",
         ),
         path(
-            "secret-store/create/",
+            "secret-store/create",
             views.SecretStoreCreateView,
             name="secret_store_create",
         ),

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/tests/app/examples/views.py

@@ -3,9 +3,8 @@ from __future__ import annotations
 import json
 from typing import Any
 
-from plain.forms import BaseForm
 from plain.http import Response
-from plain.views import CreateView, UpdateView
+from plain.templates.views import CreateView, UpdateView
 
 from .forms import (
     ChildCascadeForm,
@@ -20,14 +19,16 @@ class _NoTemplateFormView:
     """Bypass template requirements in test views.
 
     CreateView/UpdateView normally need a template for GET and for
-    form-invalid responses. These tests only exercise POST behavior, so
-    we return plain Responses instead of rendering templates.
+    rendering an invalid form. These tests only exercise POST behavior,
+    so we return plain Responses instead of rendering templates.
     """
 
     def get(self) -> Response:
         return Response("ok")
 
-    def form_invalid(self, form: BaseForm) -> Response:
+    def render(self, **context: Any) -> Response:
+        """Invalid-form re-render: serialize the form errors as JSON."""
+        form = context["form"]
         errors: dict[str, list[str]] = {
             name: [str(err) for err in errs] for name, errs in form.errors.items()
         }

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/tests/app/settings.py

@@ -1,6 +1,7 @@
 SECRET_KEY = "test"
 URLS_ROUTER = "app.urls.AppRouter"
 INSTALLED_PACKAGES = [
+    "plain.templates",
     "plain.postgres",
     "app.examples",
 ]

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/tests/app/urls.py

@@ -17,7 +17,7 @@ class LogoutView(View):
 class AppRouter(Router):
     namespace = ""
     urls = [
-        include("examples/", ExamplesRouter),
-        path("login/", LoginView, name="login"),
-        path("logout/", LogoutView, name="logout"),
+        include("examples", ExamplesRouter),
+        path("login", LoginView, name="login"),
+        path("logout", LogoutView, name="logout"),
     ]

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/tests/internal/test_connection_lifecycle.py

@@ -92,10 +92,10 @@ class StreamingDBQueryView(View):
 class TestRouter(Router):
     namespace = ""
     urls = [
-        path("db-query/", DBQueryView, name="db_query"),
-        path("async-db-query/", AsyncDBQueryView, name="async_db_query"),
-        path("sse-db-query/", DBQuerySSEView, name="sse_db_query"),
-        path("streaming-db-query/", StreamingDBQueryView, name="streaming_db_query"),
+        path("db-query", DBQueryView, name="db_query"),
+        path("async-db-query", AsyncDBQueryView, name="async_db_query"),
+        path("sse-db-query", DBQuerySSEView, name="sse_db_query"),
+        path("streaming-db-query", StreamingDBQueryView, name="streaming_db_query"),
     ]
 
 
@@ -192,7 +192,7 @@ class TestConnectionLifecycle:
 
         with _patched_init_counter() as count:
             client = _fresh_client()
-            response = client.get("/db-query/")
+            response = client.get("/db-query")
 
         assert response.status_code == 200
         assert response.content == b"1"
@@ -205,14 +205,14 @@ class TestConnectionLifecycle:
         with _patched_init_counter() as count:
             client = _fresh_client()
 
-            response1 = client.get("/db-query/")
+            response1 = client.get("/db-query")
             assert response1.status_code == 200
             first_conn_id = id(_db_conn.get())
 
-            response2 = client.get("/db-query/")
+            response2 = client.get("/db-query")
             assert response2.status_code == 200
 
-            response3 = client.get("/db-query/")
+            response3 = client.get("/db-query")
             assert response3.status_code == 200
 
         assert count[0] == 1, f"Expected 1 connection for 3 requests, got {count[0]}"
@@ -235,7 +235,7 @@ class TestConnectionLifecycle:
         with _patched_init_counter() as count:
             client = _fresh_client()
 
-            response1 = client.get("/db-query/")
+            response1 = client.get("/db-query")
             assert response1.status_code == 200
 
             # Wrapper persists; inner connection was returned to the pool.
@@ -246,7 +246,7 @@ class TestConnectionLifecycle:
             )
 
             # Second request: same wrapper, checks out a connection, returns it.
-            response2 = client.get("/db-query/")
+            response2 = client.get("/db-query")
             assert response2.status_code == 200
             assert conn is _db_conn.get()
 
@@ -265,7 +265,7 @@ class TestConnectionLifecycle:
         ] + original
         try:
             client = _fresh_client()
-            response = client.get("/db-query/")
+            response = client.get("/db-query")
             assert response.status_code == 200
 
             assert len(_tracking_seen) == 1
@@ -286,7 +286,7 @@ class TestAsyncViewConnectionLifecycle:
         """
         with _patched_init_counter() as count:
             client = _fresh_client()
-            response = client.get("/async-db-query/")
+            response = client.get("/async-db-query")
 
         assert response.status_code == 200
         assert response.content == b"1"
@@ -302,7 +302,7 @@ class TestAsyncViewConnectionLifecycle:
         """
         with _patched_init_counter() as count:
             client = _fresh_client()
-            response = client.get("/sse-db-query/")
+            response = client.get("/sse-db-query")
 
         assert response.status_code == 200
         assert "text/event-stream" in response.headers["Content-Type"]
@@ -349,7 +349,7 @@ class TestStreamingResponseCleanup:
             ):
                 handler = BaseHandler()
                 handler.load_middleware()
-                request = RequestFactory().get("/streaming-db-query/")
+                request = RequestFactory().get("/streaming-db-query")
 
                 async def run() -> Response:
                     with concurrent.futures.ThreadPoolExecutor(

plain_postgres-0.103.5/tests/internal/test_preflight_duplicate_indexes.py

@@ -0,0 +1,102 @@
+"""Unit tests for `_collect_model_indexes` — the helper that feeds
+`postgres.duplicate_indexes`. Partial indexes/constraints must be
+excluded so the check doesn't contradict `postgres.missing_fk_indexes`,
+which already treats partials as non-covering.
+"""
+
+from __future__ import annotations
+
+from types import SimpleNamespace
+
+from plain.postgres import Q
+from plain.postgres.constraints import UniqueConstraint
+from plain.postgres.indexes import Index
+from plain.postgres.preflight import _collect_model_indexes
+
+
+def _model(*, indexes=(), constraints=()) -> SimpleNamespace:
+    """Minimal model_options stand-in for the helper."""
+    return SimpleNamespace(
+        model_options=SimpleNamespace(
+            indexes=list(indexes), constraints=list(constraints)
+        )
+    )
+
+
+def _names(collected) -> set[str]:
+    return {name for name, _fields, _unique in collected}
+
+
+def test_non_partial_index_collected():
+    model = _model(indexes=[Index(name="t_team_idx", fields=["team"])])
+    assert _names(_collect_model_indexes(model)) == {"t_team_idx"}
+
+
+def test_non_partial_unique_constraint_collected():
+    model = _model(constraints=[UniqueConstraint(fields=["team"], name="t_team_uniq")])
+    assert _names(_collect_model_indexes(model)) == {"t_team_uniq"}
+
+
+def test_partial_index_excluded():
+    model = _model(
+        indexes=[
+            Index(
+                name="t_team_open_idx",
+                fields=["team", "created_at"],
+                condition=Q(resolved_at__isnull=True),
+            )
+        ]
+    )
+    assert _collect_model_indexes(model) == []
+
+
+def test_partial_unique_constraint_excluded():
+    model = _model(
+        constraints=[
+            UniqueConstraint(
+                fields=["team"],
+                name="t_team_active_uniq",
+                condition=Q(deleted_at__isnull=True),
+            )
+        ]
+    )
+    assert _collect_model_indexes(model) == []
+
+
+def test_bare_index_not_flagged_against_partial_prefix():
+    """A bare `Index(fields=[fk])` carried for FK coverage must survive
+    alongside a partial composite `Index(fields=[fk, other], condition=...)`
+    — otherwise the duplicate check fights the missing-FK check."""
+    model = _model(
+        indexes=[
+            Index(name="t_team_idx", fields=["team"]),
+            Index(
+                name="t_team_open_idx",
+                fields=["team", "created_at"],
+                condition=Q(resolved_at__isnull=True),
+            ),
+        ]
+    )
+    assert _names(_collect_model_indexes(model)) == {"t_team_idx"}
+
+
+def test_mixed_keeps_only_non_partial():
+    model = _model(
+        indexes=[
+            Index(name="t_a_idx", fields=["a"]),
+            Index(
+                name="t_a_partial_idx",
+                fields=["a"],
+                condition=Q(deleted_at__isnull=True),
+            ),
+        ],
+        constraints=[
+            UniqueConstraint(fields=["b"], name="t_b_uniq"),
+            UniqueConstraint(
+                fields=["b"],
+                name="t_b_active_uniq",
+                condition=Q(deleted_at__isnull=True),
+            ),
+        ],
+    )
+    assert _names(_collect_model_indexes(model)) == {"t_a_idx", "t_b_uniq"}

{plain_postgres-0.103.3 → plain_postgres-0.103.5}/tests/public/test_modelform_roundtrip.py

@@ -42,7 +42,7 @@ def _valid_post_data() -> dict[str, str]:
 class TestFormsExampleCreate:
     def test_create_roundtrip_all_field_types(self, db):
         client = Client()
-        response = client.post("/examples/forms/create/", data=_valid_post_data())
+        response = client.post("/examples/forms/create", data=_valid_post_data())
 
         assert response.status_code == 302, response.content
         assert response.headers["Location"] == "/ok/"
@@ -69,7 +69,7 @@ class TestFormsExampleCreate:
         client = Client()
         data = _valid_post_data()
         del data["is_active"]  # unchecked checkboxes aren't posted
-        response = client.post("/examples/forms/create/", data=data)
+        response = client.post("/examples/forms/create", data=data)
 
         assert response.status_code == 302, response.content
         assert FormsExample.query.get().is_active is False
@@ -78,7 +78,7 @@ class TestFormsExampleCreate:
         client = Client()
         data = _valid_post_data()
         data["count"] = "not-an-int"
-        response = client.post("/examples/forms/create/", data=data)
+        response = client.post("/examples/forms/create", data=data)
 
         assert response.status_code == 400
         errors = json.loads(response.content)
@@ -88,7 +88,7 @@ class TestFormsExampleCreate:
         client = Client()
         data = _valid_post_data()
         data["status"] = "archived"  # not in the declared choices
-        response = client.post("/examples/forms/create/", data=data)
+        response = client.post("/examples/forms/create", data=data)
 
         assert response.status_code == 400
         errors = json.loads(response.content)
@@ -98,7 +98,7 @@ class TestFormsExampleCreate:
         client = Client()
         data = _valid_post_data()
         data["external_id"] = "not-a-uuid"
-        response = client.post("/examples/forms/create/", data=data)
+        response = client.post("/examples/forms/create", data=data)
 
         assert response.status_code == 400
         errors = json.loads(response.content)
@@ -108,18 +108,18 @@ class TestFormsExampleCreate:
         client = Client()
         data = _valid_post_data()
         data["event_date"] = "not-a-date"
-        response = client.post("/examples/forms/create/", data=data)
+        response = client.post("/examples/forms/create", data=data)
 
         assert response.status_code == 400
         errors = json.loads(response.content)
         assert "event_date" in errors
 
     def test_blank_required_field_returns_400_with_error(self, db):
-        """Required field sent as empty string → form_invalid path with errors."""
+        """Required field sent as empty string → invalid-form path with errors."""
         client = Client()
         data = _valid_post_data()
         data["name"] = ""
-        response = client.post("/examples/forms/create/", data=data)
+        response = client.post("/examples/forms/create", data=data)
 
         assert response.status_code == 400
         errors = json.loads(response.content)
@@ -130,7 +130,7 @@ class TestFormsExampleCreate:
         client = Client()
         data = _valid_post_data()
         del data["name"]
-        response = client.post("/examples/forms/create/", data=data)
+        response = client.post("/examples/forms/create", data=data)
 
         assert response.status_code == 400
 
@@ -157,7 +157,7 @@ class TestFormsExampleUpdate:
         data["name"] = "After"
         data["count"] = "100"
 
-        response = client.post(f"/examples/forms/{existing.id}/update/", data=data)
+        response = client.post(f"/examples/forms/{existing.id}/update", data=data)
 
         assert response.status_code == 302, response.content
 
@@ -173,7 +173,7 @@ class TestFormsExampleUpdate:
         data = _valid_post_data()
         data["count"] = "not-an-int"
 
-        response = client.post(f"/examples/forms/{existing.id}/update/", data=data)
+        response = client.post(f"/examples/forms/{existing.id}/update", data=data)
 
         assert response.status_code == 400
         existing.refresh_from_db()
@@ -188,7 +188,7 @@ class TestForeignKeyRoundTrip:
         parent = DeleteParent.query.create(name="parent-1")
         client = Client()
         response = client.post(
-            "/examples/child-cascade/create/", data={"parent": str(parent.id)}
+            "/examples/child-cascade/create", data={"parent": str(parent.id)}
         )
 
         assert response.status_code == 302, response.content
@@ -198,7 +198,7 @@ class TestForeignKeyRoundTrip:
     def test_create_with_nonexistent_fk_returns_400(self, db):
         client = Client()
         response = client.post(
-            "/examples/child-cascade/create/", data={"parent": "999999"}
+            "/examples/child-cascade/create", data={"parent": "999999"}
         )
 
         assert response.status_code == 400
@@ -207,7 +207,7 @@ class TestForeignKeyRoundTrip:
 
     def test_create_with_blank_required_fk_returns_400(self, db):
         client = Client()
-        response = client.post("/examples/child-cascade/create/", data={"parent": ""})
+        response = client.post("/examples/child-cascade/create", data={"parent": ""})
 
         assert response.status_code == 400
         errors = json.loads(response.content)
@@ -222,7 +222,7 @@ class TestDBExpressionDefaultsRoundTrip:
     def test_blank_db_default_fields_are_filled_by_database(self, db):
         client = Client()
         response = client.post(
-            "/examples/db-defaults/create/",
+            "/examples/db-defaults/create",
             data={"name": "sample", "db_uuid": "", "created_at": ""},
         )
 
@@ -236,7 +236,7 @@ class TestDBExpressionDefaultsRoundTrip:
         supplied = "11111111-1111-1111-1111-111111111111"
         client = Client()
         response = client.post(
-            "/examples/db-defaults/create/",
+            "/examples/db-defaults/create",
             data={
                 "name": "sample",
                 "db_uuid": supplied,
@@ -259,7 +259,7 @@ class TestEncryptedFieldsRoundTrip:
     def test_create_roundtrip_with_encrypted_text(self, db):
         client = Client()
         response = client.post(
-            "/examples/secret-store/create/",
+            "/examples/secret-store/create",
             data={
                 "name": "prod-key",
                 "api_key": "sk-live-abc123",
@@ -278,7 +278,7 @@ class TestEncryptedFieldsRoundTrip:
     def test_blank_optional_encrypted_text_accepted(self, db):
         client = Client()
         response = client.post(
-            "/examples/secret-store/create/",
+            "/examples/secret-store/create",
             data={
                 "name": "minimal",
                 "api_key": "sk-test",