pl-e2e-test 0.1.6__tar.gz → 0.1.7__tar.gz

{pl_e2e_test-0.1.6/src/pl_e2e_test.egg-info → pl_e2e_test-0.1.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pl-e2e-test
-Version: 0.1.6
+Version: 0.1.7
 Summary: Fuzz PrairieLearn question lifecycles against the real Python element runtime
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/PrairieLearn/pl-e2e-test
@@ -335,9 +335,12 @@ Compound elements keep the declared answer name as their grading identity while
 namespaced child fields for browser inputs. For example, an element with
 `answers-name="match"` may test and parse `match-dropdown-0` and `match-dropdown-1`,
 then store its score in `partial_scores["match"]`; it does not need to invent a
-`submitted_answers["match"]` value. After parsing, every raw field must either remain
-non-null under its child key or produce a non-null value under its declared parent
-answer. This also supports elements that normalize `answer-input` into `answer`.
+`submitted_answers["match"]` value. After parsing, every raw field associated with a
+declared gradable answer must either remain non-null under its child key or produce a
+non-null value under its declared parent answer. This also supports elements that
+normalize `answer-input` into `answer`. Unassociated transport fields from file-producing
+elements may instead be consumed into `submitted_answers["_files"]`; they are not answer
+parse-coverage obligations.
 
 This contract keeps element-specific synthesis with the element or question that owns
 the data. PrairieLearn's tuple-based `pl-matching` state normalizes to arrays at the JSON
@@ -480,7 +483,8 @@ environment. From a clean branch, run:
 make publish-version VERSION=0.2.0
 ```
 
-This runs the full checks, updates `pyproject.toml` and `uv.lock`, builds the
+This installs Python 3.13, performs the same locked dependency sync used in CI, runs
+the full checks, updates `pyproject.toml` and `uv.lock`, builds and smoke-tests the
 distributions, creates a release commit and annotated `v0.2.0` tag, and atomically
 pushes the branch and tag. The tag starts the workflow on `ubuntu-latest`; the workflow
 rechecks the tag/version match, tests, builds, generates attestations, and publishes

{pl_e2e_test-0.1.6 → pl_e2e_test-0.1.7}/README.md

@@ -311,9 +311,12 @@ Compound elements keep the declared answer name as their grading identity while
 namespaced child fields for browser inputs. For example, an element with
 `answers-name="match"` may test and parse `match-dropdown-0` and `match-dropdown-1`,
 then store its score in `partial_scores["match"]`; it does not need to invent a
-`submitted_answers["match"]` value. After parsing, every raw field must either remain
-non-null under its child key or produce a non-null value under its declared parent
-answer. This also supports elements that normalize `answer-input` into `answer`.
+`submitted_answers["match"]` value. After parsing, every raw field associated with a
+declared gradable answer must either remain non-null under its child key or produce a
+non-null value under its declared parent answer. This also supports elements that
+normalize `answer-input` into `answer`. Unassociated transport fields from file-producing
+elements may instead be consumed into `submitted_answers["_files"]`; they are not answer
+parse-coverage obligations.
 
 This contract keeps element-specific synthesis with the element or question that owns
 the data. PrairieLearn's tuple-based `pl-matching` state normalizes to arrays at the JSON
@@ -456,7 +459,8 @@ environment. From a clean branch, run:
 make publish-version VERSION=0.2.0
 ```
 
-This runs the full checks, updates `pyproject.toml` and `uv.lock`, builds the
+This installs Python 3.13, performs the same locked dependency sync used in CI, runs
+the full checks, updates `pyproject.toml` and `uv.lock`, builds and smoke-tests the
 distributions, creates a release commit and annotated `v0.2.0` tag, and atomically
 pushes the branch and tag. The tag starts the workflow on `ubuntu-latest`; the workflow
 rechecks the tag/version match, tests, builds, generates attestations, and publishes

{pl_e2e_test-0.1.6 → pl_e2e_test-0.1.7}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "pl-e2e-test"
-version = "0.1.6"
+version = "0.1.7"
 description = "Fuzz PrairieLearn question lifecycles against the real Python element runtime"
 readme = "README.md"
 requires-python = ">=3.13"

{pl_e2e_test-0.1.6 → pl_e2e_test-0.1.7/src/pl_e2e_test.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pl-e2e-test
-Version: 0.1.6
+Version: 0.1.7
 Summary: Fuzz PrairieLearn question lifecycles against the real Python element runtime
 License-Expression: MIT
 Project-URL: Homepage, https://github.com/PrairieLearn/pl-e2e-test
@@ -335,9 +335,12 @@ Compound elements keep the declared answer name as their grading identity while
 namespaced child fields for browser inputs. For example, an element with
 `answers-name="match"` may test and parse `match-dropdown-0` and `match-dropdown-1`,
 then store its score in `partial_scores["match"]`; it does not need to invent a
-`submitted_answers["match"]` value. After parsing, every raw field must either remain
-non-null under its child key or produce a non-null value under its declared parent
-answer. This also supports elements that normalize `answer-input` into `answer`.
+`submitted_answers["match"]` value. After parsing, every raw field associated with a
+declared gradable answer must either remain non-null under its child key or produce a
+non-null value under its declared parent answer. This also supports elements that
+normalize `answer-input` into `answer`. Unassociated transport fields from file-producing
+elements may instead be consumed into `submitted_answers["_files"]`; they are not answer
+parse-coverage obligations.
 
 This contract keeps element-specific synthesis with the element or question that owns
 the data. PrairieLearn's tuple-based `pl-matching` state normalizes to arrays at the JSON
@@ -480,7 +483,8 @@ environment. From a clean branch, run:
 make publish-version VERSION=0.2.0
 ```
 
-This runs the full checks, updates `pyproject.toml` and `uv.lock`, builds the
+This installs Python 3.13, performs the same locked dependency sync used in CI, runs
+the full checks, updates `pyproject.toml` and `uv.lock`, builds and smoke-tests the
 distributions, creates a release commit and annotated `v0.2.0` tag, and atomically
 pushes the branch and tag. The tag starts the workflow on `ubuntu-latest`; the workflow
 rechecks the tag/version match, tests, builds, generates attestations, and publishes

{pl_e2e_test-0.1.6 → pl_e2e_test-0.1.7}/src/prairielearn_e2e/harness.py

@@ -128,13 +128,13 @@ def _assert_full_credit(data: dict[str, Any], answer_names: tuple[str, ...]) ->
     submitted_answers = data["submitted_answers"]
     unparsed: list[str] = []
     for raw_name in data["raw_submitted_answers"]:
-        if submitted_answers.get(raw_name) is not None:
-            continue
         parent_name = _associated_answer_name(raw_name, answer_names)
-        parent_parsed = (
-            parent_name is not None and submitted_answers.get(parent_name) is not None
-        )
-        if not parent_parsed:
+        if parent_name is None:
+            continue
+        if (
+            submitted_answers.get(raw_name) is None
+            and submitted_answers.get(parent_name) is None
+        ):
             unparsed.append(raw_name)
     if unparsed:
         raise HarnessError(

{pl_e2e_test-0.1.6 → pl_e2e_test-0.1.7}/tests/test_harness.py

@@ -25,6 +25,10 @@ class RecordingBackend:
 
 
 class ElementOwnedAnswerBackend(RecordingBackend):
+    def __init__(self, *, null_after_parse: bool = False) -> None:
+        super().__init__()
+        self.null_after_parse = null_after_parse
+
     def process(
         self, phase: Phase, html: str, data: dict[str, Any]
     ) -> tuple[str | None, set[str]]:
@@ -32,6 +36,27 @@ class ElementOwnedAnswerBackend(RecordingBackend):
         if phase == "test":
             data["raw_submitted_answers"]["diagram"] = '{"nodes":[1,2]}'
             data["partial_scores"]["diagram"] = {"score": 1}
+        elif phase == "parse" and self.null_after_parse:
+            data["submitted_answers"]["diagram"] = None
+        return result
+
+
+class UnassociatedFileFieldBackend(RecordingBackend):
+    def process(
+        self, phase: Phase, html: str, data: dict[str, Any]
+    ) -> tuple[str | None, set[str]]:
+        result = super().process(phase, html, data)
+        if phase == "test":
+            data["raw_submitted_answers"].update(
+                {
+                    "diagram": '{"nodes":[1,2]}',
+                    "_file_transport_token": '[{"name":"notes.txt"}]',
+                }
+            )
+            data["partial_scores"]["diagram"] = {"score": 1}
+        elif phase == "parse":
+            data["submitted_answers"].pop("_file_transport_token")
+            data["submitted_answers"]["_files"] = [{"name": "notes.txt"}]
         return result
 
 
@@ -183,6 +208,44 @@ def test_element_owned_answer_supplies_submission_without_correct_answer(
     assert result.partial_scores == {"diagram": {"score": 1}}
 
 
+def test_unassociated_raw_file_field_does_not_require_submitted_answer(
+    tmp_path: Path,
+) -> None:
+    harness = _answer_harness(
+        tmp_path,
+        UnassociatedFileFieldBackend(),
+        html='<custom-answer answers-name="diagram"></custom-answer>',
+        selector="custom-answer",
+    )
+
+    result = harness.run_grade(0)
+
+    assert result.raw_submitted_answers == {
+        "diagram": '{"nodes":[1,2]}',
+        "_file_transport_token": '[{"name":"notes.txt"}]',
+    }
+    assert result.submitted_answers == {
+        "diagram": '{"nodes":[1,2]}',
+        "_files": [{"name": "notes.txt"}],
+    }
+    assert result.partial_scores == {"diagram": {"score": 1}}
+
+
+def test_direct_answer_rejects_unparsed_value(tmp_path: Path) -> None:
+    harness = _answer_harness(
+        tmp_path,
+        ElementOwnedAnswerBackend(null_after_parse=True),
+        html='<custom-answer answers-name="diagram"></custom-answer>',
+        selector="custom-answer",
+    )
+
+    with pytest.raises(
+        HarnessError,
+        match="raw submission fields did not parse successfully: diagram",
+    ):
+        harness.run_grade(0)
+
+
 def test_question_test_hook_round_trips_structured_submission(tmp_path: Path) -> None:
     harness = _answer_harness(
         tmp_path,

{pl_e2e_test-0.1.6 → pl_e2e_test-0.1.7}/tests/test_publish_version.py

@@ -62,6 +62,9 @@ def prepare_release_repository(
         """#!/usr/bin/env bash
 set -euo pipefail
 printf '%s\\n' "$*" >> "${FAKE_UV_LOG}"
+if [[ -n "${FAKE_UV_FAIL_ON:-}" && "$*" == "${FAKE_UV_FAIL_ON}" ]]; then
+  exit 1
+fi
 if [[ "${1:-}" == version && "${2:-}" == --short ]]; then
   printf '%s\\n' "${FAKE_CURRENT_VERSION}"
 fi
@@ -109,6 +112,13 @@ def test_publish_version_can_tag_an_unpushed_prebumped_commit(tmp_path: Path):
         == release_commit
     )
     assert "version 0.4.0" not in uv_log.read_text().splitlines()
+    assert uv_log.read_text().splitlines()[1:3] == [
+        "python install 3.13",
+        "sync --locked --python 3.13",
+    ]
+    assert "run --python 3.13 python scripts/smoke_dist.py" in (
+        uv_log.read_text().splitlines()
+    )
     assert "Published v0.4.0" in result.stdout
 
 
@@ -132,3 +142,28 @@ def test_publish_version_rejects_pushed_prebumped_commit(tmp_path: Path):
 
     assert result.returncode == 1
     assert "prebumped-version bypass requires an unpushed commit" in result.stderr
+
+
+def test_publish_version_does_not_tag_when_locked_sync_fails(tmp_path: Path):
+    repository, remote, environment, uv_log = prepare_release_repository(tmp_path)
+    release_commit = git("rev-parse", "HEAD", cwd=repository)
+    environment["FAKE_UV_FAIL_ON"] = "sync --locked --python 3.13"
+
+    result = publish(repository, environment, allow_prebumped=True)
+
+    assert result.returncode == 1
+    assert git("rev-parse", "HEAD", cwd=repository) == release_commit
+    assert (
+        run(
+            "git",
+            "--git-dir",
+            str(remote),
+            "rev-parse",
+            "--verify",
+            "refs/tags/v0.4.0",
+            cwd=tmp_path,
+            check=False,
+        ).returncode
+        != 0
+    )
+    assert uv_log.read_text().splitlines()[-1] == "sync --locked --python 3.13"