pjdev-gitlab 5.3.0__tar.gz → 5.4.0__tar.gz

{pjdev_gitlab-5.3.0 → pjdev_gitlab-5.4.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: pjdev-gitlab
-Version: 5.3.0
+Version: 5.4.0
 Project-URL: Documentation, https://gitlab.purplejay.io/keystone/python/-/tree/main/pjdev-gitlab/README.md
 Project-URL: Issues, https://gitlab.purplejay.io/keystone/python/-/issues
 Project-URL: Source, https://gitlab.purplejay.io/keystone/python

{pjdev_gitlab-5.3.0 → pjdev_gitlab-5.4.0}/src/pjdev_gitlab/__about__.py

@@ -1,4 +1,4 @@
 # SPDX-FileCopyrightText: 2026-present Chris O'Neill <chris@purplejay.io>
 #
 # SPDX-License-Identifier: MIT
-__version__ = "5.3.0"
+__version__ = "5.4.0"

{pjdev_gitlab-5.3.0 → pjdev_gitlab-5.4.0}/src/pjdev_gitlab/users_service.py

@@ -146,6 +146,86 @@ async def get_user(user_id: Any, *, client: Optional[AsyncClient] = None) -> Use
     return User.model_validate(row)
 
 
+class UserUpdateNotApplied(RuntimeError):
+    """GitLab answered 200 but returned a record that does not reflect the change.
+
+    ``PUT /users/:id`` drops attributes it will not apply instead of rejecting
+    the request -- an administrator cannot be flagged ``external``, for one.
+    Without this check a caller marking seats external reads the 200 as done
+    while the seat stays billable, which is the same class of confident-wrong
+    answer the projection check above exists to prevent.
+    """
+
+
+@async_retry_http(status_codes_to_ignore=_IGNORE_4XX)
+async def _put_user_row(
+    user_id: Any, payload: dict[str, Any], client: Optional[AsyncClient]
+) -> dict[str, Any]:
+    async def _exec(_client: AsyncClient) -> dict[str, Any]:
+        r = await _client.put(f"/users/{encode_path_segment(user_id)}", json=payload)
+        r.raise_for_status()
+        return r.json()
+
+    if client is None:
+        async with http_client() as _client:
+            return await _exec(_client)
+    return await _exec(client)
+
+
+async def update_user(
+    user_id: Any,
+    *,
+    external: Optional[bool] = None,
+    extra_fields: Optional[dict[str, Any]] = None,
+    client: Optional[AsyncClient] = None,
+) -> User:
+    """Update a user via ``PUT /users/:id`` and return the updated record.
+
+    Admin-only, and the response is the admin projection, so a credential
+    without admin mode raises :class:`AdminModeRequired` (or is refused
+    outright with a 403). ``external`` is sent as a JSON boolean -- the string
+    ``"true"`` dance in :func:`list_users` applies to query parameters, not to
+    a request body -- and passing ``None`` leaves the flag alone rather than
+    clearing it.
+
+    ``extra_fields`` is merged into the payload for attributes without a named
+    parameter here. Only ``external`` is verified against the response:
+    GitLab defers some writes rather than applying them (an ``email`` change
+    waits on confirmation and echoes back the old address), so checking every
+    field would report those as failures.
+    """
+    payload: dict[str, Any] = dict(extra_fields or {})
+    if external is not None:
+        payload["external"] = external
+    if not payload:
+        raise ValueError("update_user needs at least one field to change")
+
+    row = await _put_user_row(user_id, payload, client)
+
+    # Both checks sit outside the retry decorator on purpose: it funnels every
+    # exception into an ExceptionGroup, which would bury the message.
+    assert_admin_projection(row)
+    if external is not None and row.get("external") != external:
+        raise UserUpdateNotApplied(
+            f"GitLab accepted PUT /users/{user_id} but returned "
+            f"external={row.get('external')!r} after a request for "
+            f"external={external!r}. GitLab refuses to flag an administrator "
+            "external, and drops the attribute silently when it does."
+        )
+    return User.model_validate(row)
+
+
+async def set_user_external(
+    user_id: Any, external: bool = True, *, client: Optional[AsyncClient] = None
+) -> User:
+    """Flag a user ``external``, or clear the flag with ``external=False``.
+
+    External users do not consume a billable seat, so this is the write half of
+    :func:`list_external_users`.
+    """
+    return await update_user(user_id, external=external, client=client)
+
+
 @async_retry_http(status_codes_to_ignore=_IGNORE_4XX)
 async def list_memberships(
     user_id: Any, *, client: Optional[AsyncClient] = None

{pjdev_gitlab-5.3.0 → pjdev_gitlab-5.4.0}/test_report_pjdev-gitlab.txt

@@ -5,134 +5,143 @@ rootdir: /builds/keystone/python/pjdev-gitlab
 configfile: pyproject.toml
 plugins: anyio-4.14.2, respx-0.23.1, asyncio-1.4.0
 asyncio: mode=Mode.AUTO, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
-collecting ... collected 127 items
+collecting ... collected 136 items
 
 tests/tests_for_api_utilities.py::test_build_auth_defaults_to_private_token PASSED [  0%]
 tests/tests_for_api_utilities.py::test_build_auth_selects_bearer_for_oauth PASSED [  1%]
 tests/tests_for_api_utilities.py::test_bearer_scheme_sends_authorization_header PASSED [  2%]
-tests/tests_for_api_utilities.py::test_encode_path_segment PASSED        [  3%]
+tests/tests_for_api_utilities.py::test_encode_path_segment PASSED        [  2%]
 tests/tests_for_api_utilities.py::test_paginate_consumes_x_next_page PASSED [  3%]
 tests/tests_for_api_utilities.py::test_async_retry_http_aborts_on_ignored_status PASSED [  4%]
 tests/tests_for_api_utilities.py::test_async_retry_http_retries_on_5xx PASSED [  5%]
-tests/tests_for_api_utilities.py::test_upload_to_project_returns_markdown PASSED [  6%]
-tests/tests_for_git_sync_service.py::test_build_remote_url[https://gitlab.example.com-g/s/n-https://gitlab.example.com/g/s/n.git] PASSED [  7%]
+tests/tests_for_api_utilities.py::test_upload_to_project_returns_markdown PASSED [  5%]
+tests/tests_for_git_sync_service.py::test_build_remote_url[https://gitlab.example.com-g/s/n-https://gitlab.example.com/g/s/n.git] PASSED [  6%]
 tests/tests_for_git_sync_service.py::test_build_remote_url[https://gitlab.example.com/-/g/n/-https://gitlab.example.com/g/n.git] PASSED [  7%]
 tests/tests_for_git_sync_service.py::test_build_remote_url[https://gitlab.example.com-g/n.git-https://gitlab.example.com/g/n.git] PASSED [  8%]
-tests/tests_for_git_sync_service.py::test_build_remote_url_empty_repo_errors PASSED [  9%]
-tests/tests_for_git_sync_service.py::test_default_target_dir[developers/claude-skills-claude-skills] PASSED [ 10%]
-tests/tests_for_git_sync_service.py::test_default_target_dir[g/s/name.git-name] PASSED [ 11%]
+tests/tests_for_git_sync_service.py::test_build_remote_url_empty_repo_errors PASSED [  8%]
+tests/tests_for_git_sync_service.py::test_default_target_dir[developers/claude-skills-claude-skills] PASSED [  9%]
+tests/tests_for_git_sync_service.py::test_default_target_dir[g/s/name.git-name] PASSED [ 10%]
 tests/tests_for_git_sync_service.py::test_default_target_dir[solo-solo] PASSED [ 11%]
-tests/tests_for_git_sync_service.py::test_clone_when_target_missing PASSED [ 12%]
-tests/tests_for_git_sync_service.py::test_clone_passes_token_via_askpass_env_only PASSED [ 13%]
-tests/tests_for_git_sync_service.py::test_clone_with_branch PASSED       [ 14%]
-tests/tests_for_git_sync_service.py::test_update_when_target_is_repo PASSED [ 14%]
-tests/tests_for_git_sync_service.py::test_update_with_existing_branch_checks_out_and_ff PASSED [ 15%]
-tests/tests_for_git_sync_service.py::test_update_with_new_branch_creates_from_fetch_head PASSED [ 16%]
-tests/tests_for_git_sync_service.py::test_update_adds_origin_when_absent PASSED [ 17%]
-tests/tests_for_git_sync_service.py::test_update_detached_head_errors PASSED [ 18%]
-tests/tests_for_git_sync_service.py::test_clone_failure_removes_partial_target PASSED [ 18%]
-tests/tests_for_git_sync_service.py::test_target_exists_but_not_a_repo_errors PASSED [ 19%]
-tests/tests_for_git_sync_service.py::test_missing_token_errors PASSED    [ 20%]
-tests/tests_for_git_sync_service.py::test_ff_only_failure_propagates PASSED [ 21%]
-tests/tests_for_issues_service.py::test_search_issues_paginates PASSED   [ 22%]
-tests/tests_for_issues_service.py::test_create_issue_with_image_uploads_first_then_creates PASSED [ 22%]
-tests/tests_for_issues_service.py::test_set_issue_state PASSED           [ 23%]
-tests/tests_for_issues_service.py::test_set_issue_labels_modes PASSED    [ 24%]
-tests/tests_for_issues_service.py::test_aggregate_issues_by_label PASSED [ 25%]
-tests/tests_for_issues_service.py::test_comment_on_issue PASSED          [ 25%]
-tests/tests_for_issues_service.py::test_list_issue_notes_delegates_to_notes_service PASSED [ 26%]
-tests/tests_for_merge_requests_service.py::test_get_merge_request PASSED [ 27%]
-tests/tests_for_merge_requests_service.py::test_comment_on_merge_request PASSED [ 28%]
-tests/tests_for_merge_requests_service.py::test_inline_diff_comment_payload_shape PASSED [ 29%]
-tests/tests_for_merge_requests_service.py::test_approve_and_unapprove PASSED [ 29%]
-tests/tests_for_merge_requests_service.py::test_list_merge_request_notes_delegates_to_notes_service PASSED [ 30%]
-tests/tests_for_models.py::test_config_api_base_url_strips_trailing_slash PASSED [ 31%]
-tests/tests_for_models.py::test_issue_extra_fields_ignored PASSED        [ 32%]
-tests/tests_for_models.py::test_merge_request_basic PASSED               [ 33%]
-tests/tests_for_models.py::test_config_env_loading PASSED                [ 33%]
-tests/tests_for_notes_service.py::test_list_notes_for_merge_request PASSED [ 34%]
-tests/tests_for_notes_service.py::test_list_notes_for_issue_uses_the_issue_path PASSED [ 35%]
-tests/tests_for_notes_service.py::test_list_notes_can_drop_system_notes PASSED [ 36%]
-tests/tests_for_notes_service.py::test_list_notes_forwards_sort_and_order_by PASSED [ 37%]
-tests/tests_for_notes_service.py::test_get_note PASSED                   [ 37%]
-tests/tests_for_notes_service.py::test_list_discussions_groups_notes_into_threads PASSED [ 38%]
-tests/tests_for_notes_service.py::test_list_discussions_dropping_system_notes_drops_emptied_threads PASSED [ 39%]
-tests/tests_for_notes_service.py::test_get_discussion PASSED             [ 40%]
-tests/tests_for_notes_service.py::test_reply_to_discussion_posts_to_the_thread PASSED [ 40%]
-tests/tests_for_notes_service.py::test_reply_to_note_resolves_the_containing_thread PASSED [ 41%]
-tests/tests_for_notes_service.py::test_reply_to_note_raises_when_the_note_is_not_there PASSED [ 42%]
-tests/tests_for_notes_service.py::test_find_discussion_for_note_returns_none_when_absent PASSED [ 43%]
-tests/tests_for_notes_service.py::test_quick_action_only_reply_raises_a_useful_error PASSED [ 44%]
-tests/tests_for_notes_service.py::test_notes_paginate_across_pages PASSED [ 44%]
-tests/tests_for_oauth_cli.py::test_missing_client_id_errors PASSED       [ 45%]
-tests/tests_for_oauth_cli.py::test_success_prints_only_token PASSED      [ 46%]
-tests/tests_for_oauth_cli.py::test_reads_config_from_env PASSED          [ 47%]
-tests/tests_for_oauth_cli.py::test_bad_redirect_port_errors PASSED       [ 48%]
-tests/tests_for_oauth_cli.py::test_oauth_error_returns_one PASSED        [ 48%]
-tests/tests_for_oauth_service.py::test_make_pkce_challenge_is_s256_of_verifier PASSED [ 49%]
-tests/tests_for_oauth_service.py::test_cache_path_is_per_host_and_private PASSED [ 50%]
-tests/tests_for_oauth_service.py::test_token_if_valid_expiry PASSED      [ 51%]
-tests/tests_for_oauth_service.py::test_store_token_response_roundtrip PASSED [ 51%]
-tests/tests_for_oauth_service.py::test_store_token_response_requires_access_token PASSED [ 52%]
-tests/tests_for_oauth_service.py::test_refresh_access_token_success PASSED [ 53%]
-tests/tests_for_oauth_service.py::test_refresh_access_token_returns_none_on_error PASSED [ 54%]
-tests/tests_for_oauth_service.py::test_get_access_token_reuses_valid_cache PASSED [ 55%]
-tests/tests_for_oauth_service.py::test_get_access_token_refreshes_expired_cache PASSED [ 55%]
-tests/tests_for_oauth_service.py::test_get_access_token_requires_client_id PASSED [ 56%]
-tests/tests_for_oauth_service.py::test_parse_scopes_accepts_space_and_comma_separated PASSED [ 57%]
-tests/tests_for_oauth_service.py::test_scopes_satisfy_is_subset_check PASSED [ 58%]
-tests/tests_for_oauth_service.py::test_with_admin_mode_is_idempotent_and_stable PASSED [ 59%]
-tests/tests_for_oauth_service.py::test_token_if_valid_rejects_narrower_cached_scope PASSED [ 59%]
-tests/tests_for_oauth_service.py::test_get_access_token_does_not_reuse_api_token_for_admin_mode PASSED [ 60%]
-tests/tests_for_oauth_service.py::test_get_access_token_reuses_cache_that_already_has_admin_mode PASSED [ 61%]
-tests/tests_for_oauth_service.py::test_get_access_token_rejects_a_grant_missing_the_requested_scope PASSED [ 62%]
-tests/tests_for_packages_service.py::test_upload_generic_package_url_shape PASSED [ 62%]
-tests/tests_for_packages_service.py::test_download_generic_package PASSED [ 63%]
-tests/tests_for_packages_service.py::test_list_packages PASSED           [ 64%]
-tests/tests_for_repo_files_service.py::test_get_file_url_encoded PASSED  [ 65%]
-tests/tests_for_repo_files_service.py::test_download_file_writes_to_dest PASSED [ 66%]
-tests/tests_for_repo_files_service.py::test_download_directory_walks_tree PASSED [ 66%]
-tests/tests_for_sync_cli.py::test_missing_repo_errors PASSED             [ 67%]
-tests/tests_for_sync_cli.py::test_missing_client_id_errors PASSED        [ 68%]
-tests/tests_for_sync_cli.py::test_success_prints_path_and_forwards_args PASSED [ 69%]
-tests/tests_for_sync_cli.py::test_reads_config_from_env PASSED           [ 70%]
-tests/tests_for_sync_cli.py::test_oauth_error_returns_one PASSED         [ 70%]
-tests/tests_for_sync_cli.py::test_sync_error_returns_one PASSED          [ 71%]
-tests/tests_for_sync_cli.py::test_bad_redirect_port_errors PASSED        [ 72%]
-tests/tests_for_users_service.py::test_assert_admin_projection_accepts_admin_row PASSED [ 73%]
-tests/tests_for_users_service.py::test_assert_admin_projection_names_the_missing_fields PASSED [ 74%]
-tests/tests_for_users_service.py::test_list_users_returns_admin_fields PASSED [ 74%]
-tests/tests_for_users_service.py::test_list_users_raises_without_admin_mode PASSED [ 75%]
-tests/tests_for_users_service.py::test_list_users_sends_only_true_filters PASSED [ 76%]
-tests/tests_for_users_service.py::test_list_external_users_filters_on_the_flag_not_the_query_param PASSED [ 77%]
-tests/tests_for_users_service.py::test_list_external_users_can_include_bots PASSED [ 77%]
-tests/tests_for_users_service.py::test_get_user_requires_admin_projection PASSED [ 78%]
-tests/tests_for_work_items_service.py::test_make_work_item_gid_passthrough_and_coerce PASSED [ 79%]
-tests/tests_for_work_items_service.py::test_work_item_from_node_flattens_widgets PASSED [ 80%]
-tests/tests_for_work_items_service.py::test_graphql_raises_on_errors PASSED [ 81%]
-tests/tests_for_work_items_service.py::test_paginate_graphql_follows_end_cursor PASSED [ 81%]
-tests/tests_for_work_items_service.py::test_get_work_item_by_global_id PASSED [ 82%]
-tests/tests_for_work_items_service.py::test_get_work_item_by_project_path_and_iid_uses_namespace_lookup PASSED [ 83%]
-tests/tests_for_work_items_service.py::test_get_work_item_omits_the_status_widget_by_default PASSED [ 84%]
-tests/tests_for_work_items_service.py::test_get_work_item_include_status_selects_the_widget_and_lifts_it PASSED [ 85%]
-tests/tests_for_work_items_service.py::test_get_work_item_missing_raises PASSED [ 85%]
-tests/tests_for_work_items_service.py::test_get_work_item_status_by_project_path_and_iid PASSED [ 86%]
-tests/tests_for_work_items_service.py::test_get_work_item_status_by_global_id_skips_the_iid_lookup PASSED [ 87%]
+tests/tests_for_git_sync_service.py::test_clone_when_target_missing PASSED [ 11%]
+tests/tests_for_git_sync_service.py::test_clone_passes_token_via_askpass_env_only PASSED [ 12%]
+tests/tests_for_git_sync_service.py::test_clone_with_branch PASSED       [ 13%]
+tests/tests_for_git_sync_service.py::test_update_when_target_is_repo PASSED [ 13%]
+tests/tests_for_git_sync_service.py::test_update_with_existing_branch_checks_out_and_ff PASSED [ 14%]
+tests/tests_for_git_sync_service.py::test_update_with_new_branch_creates_from_fetch_head PASSED [ 15%]
+tests/tests_for_git_sync_service.py::test_update_adds_origin_when_absent PASSED [ 16%]
+tests/tests_for_git_sync_service.py::test_update_detached_head_errors PASSED [ 16%]
+tests/tests_for_git_sync_service.py::test_clone_failure_removes_partial_target PASSED [ 17%]
+tests/tests_for_git_sync_service.py::test_target_exists_but_not_a_repo_errors PASSED [ 18%]
+tests/tests_for_git_sync_service.py::test_missing_token_errors PASSED    [ 19%]
+tests/tests_for_git_sync_service.py::test_ff_only_failure_propagates PASSED [ 19%]
+tests/tests_for_issues_service.py::test_search_issues_paginates PASSED   [ 20%]
+tests/tests_for_issues_service.py::test_create_issue_with_image_uploads_first_then_creates PASSED [ 21%]
+tests/tests_for_issues_service.py::test_set_issue_state PASSED           [ 22%]
+tests/tests_for_issues_service.py::test_set_issue_labels_modes PASSED    [ 22%]
+tests/tests_for_issues_service.py::test_aggregate_issues_by_label PASSED [ 23%]
+tests/tests_for_issues_service.py::test_comment_on_issue PASSED          [ 24%]
+tests/tests_for_issues_service.py::test_list_issue_notes_delegates_to_notes_service PASSED [ 25%]
+tests/tests_for_merge_requests_service.py::test_get_merge_request PASSED [ 25%]
+tests/tests_for_merge_requests_service.py::test_comment_on_merge_request PASSED [ 26%]
+tests/tests_for_merge_requests_service.py::test_inline_diff_comment_payload_shape PASSED [ 27%]
+tests/tests_for_merge_requests_service.py::test_approve_and_unapprove PASSED [ 27%]
+tests/tests_for_merge_requests_service.py::test_list_merge_request_notes_delegates_to_notes_service PASSED [ 28%]
+tests/tests_for_models.py::test_config_api_base_url_strips_trailing_slash PASSED [ 29%]
+tests/tests_for_models.py::test_issue_extra_fields_ignored PASSED        [ 30%]
+tests/tests_for_models.py::test_merge_request_basic PASSED               [ 30%]
+tests/tests_for_models.py::test_config_env_loading PASSED                [ 31%]
+tests/tests_for_notes_service.py::test_list_notes_for_merge_request PASSED [ 32%]
+tests/tests_for_notes_service.py::test_list_notes_for_issue_uses_the_issue_path PASSED [ 33%]
+tests/tests_for_notes_service.py::test_list_notes_can_drop_system_notes PASSED [ 33%]
+tests/tests_for_notes_service.py::test_list_notes_forwards_sort_and_order_by PASSED [ 34%]
+tests/tests_for_notes_service.py::test_get_note PASSED                   [ 35%]
+tests/tests_for_notes_service.py::test_list_discussions_groups_notes_into_threads PASSED [ 36%]
+tests/tests_for_notes_service.py::test_list_discussions_dropping_system_notes_drops_emptied_threads PASSED [ 36%]
+tests/tests_for_notes_service.py::test_get_discussion PASSED             [ 37%]
+tests/tests_for_notes_service.py::test_reply_to_discussion_posts_to_the_thread PASSED [ 38%]
+tests/tests_for_notes_service.py::test_reply_to_note_resolves_the_containing_thread PASSED [ 38%]
+tests/tests_for_notes_service.py::test_reply_to_note_raises_when_the_note_is_not_there PASSED [ 39%]
+tests/tests_for_notes_service.py::test_find_discussion_for_note_returns_none_when_absent PASSED [ 40%]
+tests/tests_for_notes_service.py::test_quick_action_only_reply_raises_a_useful_error PASSED [ 41%]
+tests/tests_for_notes_service.py::test_notes_paginate_across_pages PASSED [ 41%]
+tests/tests_for_oauth_cli.py::test_missing_client_id_errors PASSED       [ 42%]
+tests/tests_for_oauth_cli.py::test_success_prints_only_token PASSED      [ 43%]
+tests/tests_for_oauth_cli.py::test_reads_config_from_env PASSED          [ 44%]
+tests/tests_for_oauth_cli.py::test_bad_redirect_port_errors PASSED       [ 44%]
+tests/tests_for_oauth_cli.py::test_oauth_error_returns_one PASSED        [ 45%]
+tests/tests_for_oauth_service.py::test_make_pkce_challenge_is_s256_of_verifier PASSED [ 46%]
+tests/tests_for_oauth_service.py::test_cache_path_is_per_host_and_private PASSED [ 47%]
+tests/tests_for_oauth_service.py::test_token_if_valid_expiry PASSED      [ 47%]
+tests/tests_for_oauth_service.py::test_store_token_response_roundtrip PASSED [ 48%]
+tests/tests_for_oauth_service.py::test_store_token_response_requires_access_token PASSED [ 49%]
+tests/tests_for_oauth_service.py::test_refresh_access_token_success PASSED [ 50%]
+tests/tests_for_oauth_service.py::test_refresh_access_token_returns_none_on_error PASSED [ 50%]
+tests/tests_for_oauth_service.py::test_get_access_token_reuses_valid_cache PASSED [ 51%]
+tests/tests_for_oauth_service.py::test_get_access_token_refreshes_expired_cache PASSED [ 52%]
+tests/tests_for_oauth_service.py::test_get_access_token_requires_client_id PASSED [ 52%]
+tests/tests_for_oauth_service.py::test_parse_scopes_accepts_space_and_comma_separated PASSED [ 53%]
+tests/tests_for_oauth_service.py::test_scopes_satisfy_is_subset_check PASSED [ 54%]
+tests/tests_for_oauth_service.py::test_with_admin_mode_is_idempotent_and_stable PASSED [ 55%]
+tests/tests_for_oauth_service.py::test_token_if_valid_rejects_narrower_cached_scope PASSED [ 55%]
+tests/tests_for_oauth_service.py::test_get_access_token_does_not_reuse_api_token_for_admin_mode PASSED [ 56%]
+tests/tests_for_oauth_service.py::test_get_access_token_reuses_cache_that_already_has_admin_mode PASSED [ 57%]
+tests/tests_for_oauth_service.py::test_get_access_token_rejects_a_grant_missing_the_requested_scope PASSED [ 58%]
+tests/tests_for_packages_service.py::test_upload_generic_package_url_shape PASSED [ 58%]
+tests/tests_for_packages_service.py::test_download_generic_package PASSED [ 59%]
+tests/tests_for_packages_service.py::test_list_packages PASSED           [ 60%]
+tests/tests_for_repo_files_service.py::test_get_file_url_encoded PASSED  [ 61%]
+tests/tests_for_repo_files_service.py::test_download_file_writes_to_dest PASSED [ 61%]
+tests/tests_for_repo_files_service.py::test_download_directory_walks_tree PASSED [ 62%]
+tests/tests_for_sync_cli.py::test_missing_repo_errors PASSED             [ 63%]
+tests/tests_for_sync_cli.py::test_missing_client_id_errors PASSED        [ 63%]
+tests/tests_for_sync_cli.py::test_success_prints_path_and_forwards_args PASSED [ 64%]
+tests/tests_for_sync_cli.py::test_reads_config_from_env PASSED           [ 65%]
+tests/tests_for_sync_cli.py::test_oauth_error_returns_one PASSED         [ 66%]
+tests/tests_for_sync_cli.py::test_sync_error_returns_one PASSED          [ 66%]
+tests/tests_for_sync_cli.py::test_bad_redirect_port_errors PASSED        [ 67%]
+tests/tests_for_users_service.py::test_assert_admin_projection_accepts_admin_row PASSED [ 68%]
+tests/tests_for_users_service.py::test_assert_admin_projection_names_the_missing_fields PASSED [ 69%]
+tests/tests_for_users_service.py::test_list_users_returns_admin_fields PASSED [ 69%]
+tests/tests_for_users_service.py::test_list_users_raises_without_admin_mode PASSED [ 70%]
+tests/tests_for_users_service.py::test_list_users_sends_only_true_filters PASSED [ 71%]
+tests/tests_for_users_service.py::test_list_external_users_filters_on_the_flag_not_the_query_param PASSED [ 72%]
+tests/tests_for_users_service.py::test_list_external_users_can_include_bots PASSED [ 72%]
+tests/tests_for_users_service.py::test_get_user_requires_admin_projection PASSED [ 73%]
+tests/tests_for_users_service.py::test_update_user_sends_external_as_a_json_boolean PASSED [ 74%]
+tests/tests_for_users_service.py::test_update_user_merges_extra_fields PASSED [ 75%]
+tests/tests_for_users_service.py::test_update_user_refuses_an_empty_payload PASSED [ 75%]
+tests/tests_for_users_service.py::test_update_user_leaves_external_alone_when_not_given PASSED [ 76%]
+tests/tests_for_users_service.py::test_update_user_raises_when_the_change_was_dropped PASSED [ 77%]
+tests/tests_for_users_service.py::test_update_user_requires_admin_projection_on_the_response PASSED [ 77%]
+tests/tests_for_users_service.py::test_update_user_encodes_the_path_segment PASSED [ 78%]
+tests/tests_for_users_service.py::test_set_user_external_defaults_to_marking_external PASSED [ 79%]
+tests/tests_for_users_service.py::test_set_user_external_can_clear_the_flag PASSED [ 80%]
+tests/tests_for_work_items_service.py::test_make_work_item_gid_passthrough_and_coerce PASSED [ 80%]
+tests/tests_for_work_items_service.py::test_work_item_from_node_flattens_widgets PASSED [ 81%]
+tests/tests_for_work_items_service.py::test_graphql_raises_on_errors PASSED [ 82%]
+tests/tests_for_work_items_service.py::test_paginate_graphql_follows_end_cursor PASSED [ 83%]
+tests/tests_for_work_items_service.py::test_get_work_item_by_global_id PASSED [ 83%]
+tests/tests_for_work_items_service.py::test_get_work_item_by_project_path_and_iid_uses_namespace_lookup PASSED [ 84%]
+tests/tests_for_work_items_service.py::test_get_work_item_omits_the_status_widget_by_default PASSED [ 85%]
+tests/tests_for_work_items_service.py::test_get_work_item_include_status_selects_the_widget_and_lifts_it PASSED [ 86%]
+tests/tests_for_work_items_service.py::test_get_work_item_missing_raises PASSED [ 86%]
+tests/tests_for_work_items_service.py::test_get_work_item_status_by_project_path_and_iid PASSED [ 87%]
+tests/tests_for_work_items_service.py::test_get_work_item_status_by_global_id_skips_the_iid_lookup PASSED [ 88%]
 tests/tests_for_work_items_service.py::test_get_work_item_status_returns_none_when_no_status_is_assigned PASSED [ 88%]
-tests/tests_for_work_items_service.py::test_get_work_item_status_missing_item_raises PASSED [ 88%]
-tests/tests_for_work_items_service.py::test_search_work_items_paginates_and_translates_state PASSED [ 89%]
-tests/tests_for_work_items_service.py::test_search_work_items_group_scope_uses_group_field PASSED [ 90%]
+tests/tests_for_work_items_service.py::test_get_work_item_status_missing_item_raises PASSED [ 89%]
+tests/tests_for_work_items_service.py::test_search_work_items_paginates_and_translates_state PASSED [ 90%]
+tests/tests_for_work_items_service.py::test_search_work_items_group_scope_uses_group_field PASSED [ 91%]
 tests/tests_for_work_items_service.py::test_search_work_items_include_status_selects_the_widget PASSED [ 91%]
 tests/tests_for_work_items_service.py::test_search_work_items_requires_one_scope PASSED [ 92%]
-tests/tests_for_work_items_service.py::test_set_work_item_state_closes_via_workItemUpdate PASSED [ 92%]
-tests/tests_for_work_items_service.py::test_set_work_item_state_mutation_errors_raise PASSED [ 93%]
+tests/tests_for_work_items_service.py::test_set_work_item_state_closes_via_workItemUpdate PASSED [ 93%]
+tests/tests_for_work_items_service.py::test_set_work_item_state_mutation_errors_raise PASSED [ 94%]
 tests/tests_for_work_items_service.py::test_list_work_item_notes_filters_system_notes PASSED [ 94%]
 tests/tests_for_work_items_service.py::test_comment_on_work_item_creates_note PASSED [ 95%]
 tests/tests_for_work_items_service.py::test_reply_to_work_item_discussion_threads_via_discussion_id PASSED [ 96%]
-tests/tests_for_work_items_service.py::test_set_work_item_labels_add_passes_addLabelIds PASSED [ 96%]
+tests/tests_for_work_items_service.py::test_set_work_item_labels_add_passes_addLabelIds PASSED [ 97%]
 tests/tests_for_work_items_service.py::test_set_work_item_labels_remove_passes_removeLabelIds PASSED [ 97%]
 tests/tests_for_work_items_service.py::test_list_labels_for_project_includes_ancestor_groups PASSED [ 98%]
 tests/tests_for_work_items_service.py::test_create_label_passes_project_path_color_and_description PASSED [ 99%]
 tests/tests_for_work_items_service.py::test_create_label_group_scope_passes_group_path PASSED [100%]
 
-============================= 127 passed in 2.72s ==============================
+============================= 136 passed in 2.68s ==============================

{pjdev_gitlab-5.3.0 → pjdev_gitlab-5.4.0}/tests/tests_for_users_service.py

@@ -1,3 +1,5 @@
+import json
+
 import httpx
 import pytest
 import respx
@@ -99,3 +101,90 @@ async def test_get_user_requires_admin_projection():
     )
     with pytest.raises(AdminModeRequired):
         await users_service.get_user(7)
+
+
+@respx.mock
+async def test_update_user_sends_external_as_a_json_boolean():
+    """The string "true" is a query-parameter quirk; a body takes a real bool."""
+    route = respx.put("https://gitlab.example.com/api/v4/users/7").mock(
+        return_value=httpx.Response(200, json=ADMIN_ROW)
+    )
+    user = await users_service.update_user(7, external=True)
+    assert json.loads(route.calls.last.request.content) == {"external": True}
+    assert user.external is True
+
+
+@respx.mock
+async def test_update_user_merges_extra_fields():
+    route = respx.put("https://gitlab.example.com/api/v4/users/7").mock(
+        return_value=httpx.Response(200, json={**ADMIN_ROW, "name": "Renamed"})
+    )
+    await users_service.update_user(7, external=True, extra_fields={"name": "Renamed"})
+    assert json.loads(route.calls.last.request.content) == {
+        "name": "Renamed",
+        "external": True,
+    }
+
+
+async def test_update_user_refuses_an_empty_payload():
+    """An empty PUT would report success while changing nothing."""
+    with pytest.raises(ValueError):
+        await users_service.update_user(7)
+
+
+@respx.mock
+async def test_update_user_leaves_external_alone_when_not_given():
+    route = respx.put("https://gitlab.example.com/api/v4/users/7").mock(
+        return_value=httpx.Response(200, json=ADMIN_ROW)
+    )
+    await users_service.update_user(7, extra_fields={"name": "Renamed"})
+    assert "external" not in json.loads(route.calls.last.request.content)
+
+
+@respx.mock
+async def test_update_user_raises_when_the_change_was_dropped():
+    """200 with the flag unchanged -- what GitLab does for an administrator."""
+    respx.put("https://gitlab.example.com/api/v4/users/7").mock(
+        return_value=httpx.Response(200, json={**ADMIN_ROW, "external": False})
+    )
+    with pytest.raises(users_service.UserUpdateNotApplied) as excinfo:
+        await users_service.update_user(7, external=True)
+    assert "administrator" in str(excinfo.value)
+
+
+@respx.mock
+async def test_update_user_requires_admin_projection_on_the_response():
+    respx.put("https://gitlab.example.com/api/v4/users/7").mock(
+        return_value=httpx.Response(200, json=PUBLIC_ROW)
+    )
+    with pytest.raises(AdminModeRequired):
+        await users_service.update_user(7, external=True)
+
+
+@respx.mock
+async def test_update_user_encodes_the_path_segment():
+    route = respx.put("https://gitlab.example.com/api/v4/users/user%2Fname").mock(
+        return_value=httpx.Response(200, json=ADMIN_ROW)
+    )
+    await users_service.update_user("user/name", external=True)
+    assert route.called
+
+
+@respx.mock
+async def test_set_user_external_defaults_to_marking_external():
+    route = respx.put("https://gitlab.example.com/api/v4/users/7").mock(
+        return_value=httpx.Response(200, json=ADMIN_ROW)
+    )
+    user = await users_service.set_user_external(7)
+    assert json.loads(route.calls.last.request.content) == {"external": True}
+    assert user.external is True
+
+
+@respx.mock
+async def test_set_user_external_can_clear_the_flag():
+    route = respx.put("https://gitlab.example.com/api/v4/users/7").mock(
+        return_value=httpx.Response(200, json={**ADMIN_ROW, "external": False})
+    )
+    user = await users_service.set_user_external(7, False)
+    assert json.loads(route.calls.last.request.content) == {"external": False}
+    assert user.external is False