pioreactor-precision-temperature-plugin 0.2.7__tar.gz → 0.2.9__tar.gz

{pioreactor_precision_temperature_plugin-0.2.7/pioreactor_precision_temperature_plugin.egg-info → pioreactor_precision_temperature_plugin-0.2.9}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pioreactor-precision-temperature-plugin
-Version: 0.2.7
+Version: 0.2.9
 Summary: Precision temperature automation for Pioreactor using FIR + MLX90632
 Home-page: https://github.com/Pioreactor/pioreactor-precision-temperature-plugin
 Author: Cam Davidson-Pilon

{pioreactor_precision_temperature_plugin-0.2.7 → pioreactor_precision_temperature_plugin-0.2.9}/pioreactor_precision_temperature_plugin/adafruit_mlx90632.py

@@ -119,7 +119,8 @@ class MLX90632:
         except Exception as exc:
             raise RuntimeError(
                 "Failed to initialize MLX90632 I2C device. "
-                "Expected a Blinka-compatible I2C bus from board.I2C()."
+                f"address=0x{address:02X}, i2c_bus_type={type(i2c_bus).__name__}, "
+                f"original_error={type(exc).__name__}: {exc}"
             ) from exc
 
         # Initialize temperature history

{pioreactor_precision_temperature_plugin-0.2.7 → pioreactor_precision_temperature_plugin-0.2.9}/pioreactor_precision_temperature_plugin/fir_temperature_automation.py

@@ -71,6 +71,7 @@ STABILIZATION_MAX_SLOPE_C_PER_MIN = 0.02
 STABILIZATION_WINDOW_S = 2.0 * 60
 STABILIZATION_SLOPE_SAMPLE_DELAY_S = 4.1
 STABILIZATION_TIMEOUT_S = 90 * 60
+DANGER_ZONE_DUTY_CYCLE_REDUCTION_FACTOR = 0.9965
 
 available_temperature_automations: dict[str, type["TemperatureAutomationJobFIR"]] = {}
 
@@ -238,6 +239,12 @@ class TemperatureAutomationJobFIR(AutomationJob):
         except Exception as e:
             raise exc.HardwareNotFoundError(f"Unable to import MLX90632 dependencies: {e}")
 
+        if not hardware.is_i2c_device_present(address):
+            raise exc.HardwareNotFoundError(
+                f"MLX90632 not found at address 0x{address:02X} on I2C bus. "
+                "Check mlx_address and sensor wiring."
+            )
+
         i2c = busio.I2C(hardware.get_scl_pin(), hardware.get_sda_pin())
         sensor = adafruit_mlx90632.MLX90632(i2c, address=address)
         with suppress(Exception):
@@ -359,9 +366,9 @@ class TemperatureAutomationJobFIR(AutomationJob):
 
         elif temp > self.MAX_TEMP_TO_REDUCE_HEATING:
             self.logger.debug(
-                f"Temperature of heating surface exceeded {self.MAX_TEMP_TO_REDUCE_HEATING}℃ (currently {temp}℃). Reducing heater by 10%."
+                f"Temperature of heating surface exceeded {self.MAX_TEMP_TO_REDUCE_HEATING}℃ (currently {temp}℃). Reducing heater slightly."
             )
-            self._update_heater(self.heater_duty_cycle * 0.9)
+            self._update_heater(self.heater_duty_cycle * DANGER_ZONE_DUTY_CYCLE_REDUCTION_FACTOR)
 
         return temp
 

{pioreactor_precision_temperature_plugin-0.2.7 → pioreactor_precision_temperature_plugin-0.2.9/pioreactor_precision_temperature_plugin.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pioreactor-precision-temperature-plugin
-Version: 0.2.7
+Version: 0.2.9
 Summary: Precision temperature automation for Pioreactor using FIR + MLX90632
 Home-page: https://github.com/Pioreactor/pioreactor-precision-temperature-plugin
 Author: Cam Davidson-Pilon

{pioreactor_precision_temperature_plugin-0.2.7 → pioreactor_precision_temperature_plugin-0.2.9}/setup.py

@@ -4,7 +4,7 @@ from setuptools import setup
 
 setup(
     name="pioreactor-precision-temperature-plugin",
-    version="0.2.7",
+    version="0.2.9",
     python_requires=">=3.13,<3.14",
     license_files=("LICENSE.txt",),
     description="Precision temperature automation for Pioreactor using FIR + MLX90632",

{pioreactor_precision_temperature_plugin-0.2.7 → pioreactor_precision_temperature_plugin-0.2.9}/tests/test_fir_temperature_automation.py

@@ -111,6 +111,7 @@ def test_setup_mlx_driver_uses_busio_i2c(
     monkeypatch.setattr(fta.whoami, "is_testing_env", lambda: False)
     monkeypatch.setattr(fta.hardware, "get_scl_pin", lambda: 11)
     monkeypatch.setattr(fta.hardware, "get_sda_pin", lambda: 13)
+    monkeypatch.setattr(fta.hardware, "is_i2c_device_present", lambda _address: True)
     monkeypatch.setitem(sys.modules, "busio", FakeBusIOModule())
     monkeypatch.setattr(plugin_pkg, "adafruit_mlx90632", FakeMLXModule, raising=False)
 
@@ -123,6 +124,40 @@ def test_setup_mlx_driver_uses_busio_i2c(
     assert sensor.refresh_rate == FakeMLXModule.REFRESH_1HZ
 
 
+def test_setup_mlx_driver_raises_clear_error_when_address_missing(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    import pioreactor_precision_temperature_plugin as plugin_pkg
+    from pioreactor import exc as pr_exc
+
+    class FakeBusIOModule:
+        @staticmethod
+        def I2C(_scl: int, _sda: int) -> object:
+            return object()
+
+    class FakeMLXModule:
+        MODE_CONTINUOUS = 3
+        REFRESH_1HZ = 1
+
+        class MLX90632:
+            def __init__(self, _i2c_bus: object, _address: int) -> None:
+                raise AssertionError("should not attempt MLX init when address is missing")
+
+    monkeypatch.setattr(fta.whoami, "is_testing_env", lambda: False)
+    monkeypatch.setattr(fta.hardware, "get_scl_pin", lambda: 11)
+    monkeypatch.setattr(fta.hardware, "get_sda_pin", lambda: 13)
+    monkeypatch.setattr(fta.hardware, "is_i2c_device_present", lambda _address: False)
+    monkeypatch.setitem(sys.modules, "busio", FakeBusIOModule())
+    monkeypatch.setattr(plugin_pkg, "adafruit_mlx90632", FakeMLXModule, raising=False)
+
+    job: Any = object.__new__(fta.TemperatureAutomationJobFIR)
+
+    with pytest.raises(pr_exc.HardwareNotFoundError) as e:
+        job._setup_mlx_driver(address=0x3A)
+
+    assert "MLX90632 not found at address 0x3A" in str(e.value)
+
+
 def test_update_volume_from_mqtt_ignores_invalid_payloads() -> None:
     job: Any = object.__new__(fta.TemperatureAutomationJobFIR)
     job._volume_ml = 25.0
@@ -377,6 +412,36 @@ def test_update_heater_respects_pwm_lock() -> None:
     assert calls == [50.0]
 
 
+def test_check_if_exceeds_max_temp_reduces_heater_gently_in_danger_zone(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.setattr(
+        fta,
+        "get_pioreactor_model",
+        lambda: SimpleNamespace(
+            max_temp_to_reduce_heating=50.0,
+            max_temp_to_disable_heating=60.0,
+            max_temp_to_shutdown=70.0,
+        ),
+    )
+
+    job: Any = object.__new__(fta.TemperatureAutomationJobFIR)
+    job.heater_duty_cycle = 80.0
+    job.logger = SimpleNamespace(debug=lambda *_args, **_kwargs: None)
+    reductions: list[float] = []
+
+    def fake_update_heater(new_dc: float) -> bool:
+        reductions.append(new_dc)
+        return True
+
+    job._update_heater = fake_update_heater
+
+    observed_temp = job._check_if_exceeds_max_temp(55.0)
+
+    assert observed_temp == pytest.approx(55.0)
+    assert reductions == [pytest.approx(80.0 * fta.DANGER_ZONE_DUTY_CYCLE_REDUCTION_FACTOR)]
+
+
 def test_bias_trim_probe_step_ui_uses_store_estimator(monkeypatch: pytest.MonkeyPatch) -> None:
     base = SimpleNamespace(
         estimator_name="baseline-estimator",