phystack-hub-client 6.18.1__tar.gz → 6.18.2__tar.gz

{phystack_hub_client-6.18.1 → phystack_hub_client-6.18.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: phystack-hub-client
-Version: 6.18.1
+Version: 6.18.2
 Summary: Python client for PhyHub - events, actions, DataChannel, and MediaStream
 Project-URL: Homepage, https://github.com/phystack/phystack-pypi
 Project-URL: Documentation, https://docs.phystack.com

{phystack_hub_client-6.18.1 → phystack_hub_client-6.18.2}/pyproject.toml

@@ -7,7 +7,7 @@ name = "phystack-hub-client"
 # Fixed version group with the Node hub-client (@phystack/hub-client in
 # phystack/ps-platform): both clients implement the same twin/WebRTC contract
 # and are released together under the same version.
-version = "6.18.1"
+version = "6.18.2"
 description = "Python client for PhyHub - events, actions, DataChannel, and MediaStream"
 readme = "README.md"
 license = "MIT"

{phystack_hub_client-6.18.1 → phystack_hub_client-6.18.2}/src/phystack/hub_client/client.py

@@ -365,8 +365,18 @@ class PhyHubClient:
 
         self._connection.on(self.EVENTS.TWIN_MESSAGE, on_twin_message)
 
-        def on_twin_updated(payload: dict[str, Any]) -> None:
-            """Handle twin property update events."""
+        def on_twin_updated(payload: dict[str, Any], *_extra: Any) -> None:
+            """Handle twin property update events.
+
+            ``*_extra`` absorbs any trailing positional argument the server
+            appends to the ``twinUpdated`` emit. Some phyhub builds send twin
+            lifecycle events with a second positional arg (event metadata);
+            JS clients silently ignore it, but python-socketio passes every
+            positional arg through, so a strict ``(payload)`` signature raises
+            "takes 1 positional argument but 2 were given" and DROPS EVERY twin
+            update — the device stops seeing settings/desired-property changes
+            until restarted. Matches the tolerant ``on_twin_message`` sibling.
+            """
             twin_data = payload.get("data") or payload
             twin_id = payload.get("twinId") or (twin_data.get("id") if isinstance(twin_data, dict) else None)
 

{phystack_hub_client-6.18.1 → phystack_hub_client-6.18.2}/src/phystack/hub_client/cloud_twins.py

@@ -83,15 +83,23 @@ class CloudTwinStore:
 
     # --- lifecycle events ---
 
-    def apply_created(self, payload: CloudTwinLifecycleEvent) -> None:
+    # ``*_extra`` on these three absorbs any trailing positional arg the
+    # server appends to a twin lifecycle emit. They are registered directly
+    # as socket.io handlers (PhyHubClient cloud-app mode), so a strict
+    # ``(payload)`` signature would raise "takes 1 positional argument but 2
+    # were given" and silently drop every cloud-twin update — the same defect
+    # fixed in PhyHubClient.on_twin_updated. Direct internal callers still
+    # pass a single argument.
+
+    def apply_created(self, payload: CloudTwinLifecycleEvent, *_extra: Any) -> None:
         """Apply a ``twinCreated`` event and notify ``on_created`` listeners."""
         self._apply(_KIND_CREATED, payload)
 
-    def apply_updated(self, payload: CloudTwinLifecycleEvent) -> None:
+    def apply_updated(self, payload: CloudTwinLifecycleEvent, *_extra: Any) -> None:
         """Apply a ``twinUpdated`` event and notify ``on_updated`` listeners."""
         self._apply(_KIND_UPDATED, payload)
 
-    def apply_deleted(self, payload: CloudTwinLifecycleEvent) -> None:
+    def apply_deleted(self, payload: CloudTwinLifecycleEvent, *_extra: Any) -> None:
         """Apply a ``twinDeleted`` event and notify ``on_deleted`` listeners."""
         self._apply(_KIND_DELETED, payload)
 

{phystack_hub_client-6.18.1 → phystack_hub_client-6.18.2}/tests/test_client_integration.py

@@ -12,6 +12,7 @@ class FakeConnection:
         self.emitted: list[tuple[str, dict[str, Any]]] = []
         self.device_id = "device-1"
         self.ack_response: Optional[dict[str, Any]] = {"status": "success"}
+        self.handlers: dict[str, Any] = {}
 
     @property
     def is_connected(self) -> bool:
@@ -22,7 +23,7 @@ class FakeConnection:
         return True
 
     def on(self, event: str, handler: Any) -> None:
-        return None
+        self.handlers[event] = handler
 
     async def emit(
         self, method: str, payload: Any = None, callback: bool = False
@@ -95,6 +96,35 @@ async def test_device_status_cached_for_ten_seconds() -> None:
     assert status_calls.count("getDeviceStatus") == 1
 
 
+def test_twin_updated_handler_tolerates_trailing_positional_arg() -> None:
+    """Regression: some phyhub builds emit `twinUpdated` with a second
+    positional arg. python-socketio forwards every positional arg, so a
+    strict `(payload)` handler raised "takes 1 positional argument but 2 were
+    given" and dropped every twin update fleet-wide (edge apps stopped seeing
+    settings changes until restarted). The handler must accept and ignore the
+    extra arg the way JS clients do."""
+    client, connection = make_client()
+    client._setup_socket_listeners()
+
+    on_twin_updated = connection.handlers["twinUpdated"]
+    received: list[dict[str, Any]] = []
+    # Register the listener directly to keep the test on the handler's arity,
+    # not the subscribe machinery (`on_twin_update` spawns an async task).
+    client._twin_update_listeners["twin-x"] = {lambda data: received.append(data)}
+
+    payload = {
+        "twinId": "twin-x",
+        "data": {"id": "twin-x", "properties": {"desired": {"volume": 5}}},
+    }
+
+    # One positional arg (phyhub master) — the baseline that already worked.
+    on_twin_updated(payload)
+    # Two positional args (the QA build that triggered the crash) — must not raise.
+    on_twin_updated(payload, {"eventId": "evt-1"})
+
+    assert received == [payload["data"], payload["data"]]
+
+
 def test_public_exports_importable() -> None:
     import phystack.hub_client as hub_client