pgwidgets-js 0.3.2__tar.gz → 0.3.4__tar.gz

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pgwidgets-js
-Version: 0.3.2
+Version: 0.3.4
 Summary: pgwidgets JavaScript widget library — static assets for use with Python servers
 Author: PGWidgets Developers
 License: BSD-3-Clause
@@ -26,7 +26,7 @@ Requires-Dist: pytest; extra == "test"
 Dynamic: license-file
 
 <p align="center">
-  <img src="pgwidgets_js/static/icons/pgwidgets-logo.png" alt="pgwidgets logo" width="300">
+  <img src="pgwidgets_js/static/icons/pgwidgets-logo.png" alt="pgwidgets logo" width="500">
 </p>
 
 <p align="center">

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/README.md

@@ -1,5 +1,5 @@
 <p align="center">
-  <img src="pgwidgets_js/static/icons/pgwidgets-logo.png" alt="pgwidgets logo" width="300">
+  <img src="pgwidgets_js/static/icons/pgwidgets-logo.png" alt="pgwidgets logo" width="500">
 </p>
 
 <p align="center">

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/docs/WhatsNew.rst

@@ -1,6 +1,120 @@
 What's New
 ==========
 
+Recent changes — since ``v0.3.3``
+---------------------------------
+
+TextSource: text no longer clipped when scrolling long files
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+A ``TextSource`` holding more than a screenful of text showed only the
+first screen -- the scrollbar reported the full length, but scrolling
+past the first page revealed blank space.  The edit area is now laid out
+so it grows to the full content height, and the widget scrolls through
+all of it.
+
+TextSource: fonts, hover tooltips, and scroll helpers
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+``set_font(family, size)`` sets the editor font.  Hover tooltips can be
+enabled with ``set_tooltips_enabled(True)``: while enabled the widget
+fires a ``tooltip`` callback carrying the line, column and text under the
+pointer, leaving the host to decide what (if anything) to display.  New
+scroll helpers address the buffer by offset (used by ``scroll_to_ref``
+and the remote-driver scroll methods), and ``set_wrap`` now also accepts
+a boolean.
+
+TextSource: selection and tag-region queries
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Four query methods now match Ginga's qt/gtk ``TextSource``:
+``has_selection()``; ``get_selection_bounds()`` returning the selected
+``[start, end]`` refs (or ``None``); ``get_tag_region(name)`` returning a
+tag's overall span; and ``get_tag_regions(name)`` returning one
+``[start, end]`` pair per contiguous run of the tag.  They are declared in
+the widget spec, so the Python proxy -- and thus Ginga's pgw
+``TextSource`` -- can call them.
+
+New widget: Separator
+~~~~~~~~~~~~~~~~~~~~~
+
+``Separator`` is a thin horizontal or vertical rule for visually
+dividing a layout.
+
+Button: per-button hover highlight (``set_hover``)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+``set_hover(bg, fg)`` mirrors the qt/gtk backends' per-button hover:
+while the pointer is over the button its colors switch to the supplied
+values and revert on mouse-out.  Passing ``(None, None)`` clears it.  It
+is a setter, so it round-trips and replays on browser reconnect (like
+``set_color``).
+
+ButtonBox: ``min_button_width`` option
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+A ``ButtonBox`` already sizes its buttons to the widest member; the new
+``min_button_width`` constructor option sets a floor so buttons never
+render narrower than the given width.
+
+Dialog: ``set_title``, and correct content-area handling
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+``set_title`` is now callable on a ``Dialog`` across all wrappers;
+previously the method was undeclared on the ``Dialog`` spec and raised
+``AttributeError``.  Also, ``remove_all`` / ``remove_widget`` /
+``get_children`` / ``num_children`` now target the dialog's content area,
+matching ``add_widget``.  Previously ``remove_all`` tore out the whole
+content-plus-buttons layout, so a rebuilt dialog (e.g. a ``MessageDialog``
+re-showing its message) could leave its content orphaned and blank.
+
+TableView: ``set_row_spacing`` / ``set_column_spacing``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The Python proxy for ``TableView`` now exposes ``set_row_spacing`` and
+``set_column_spacing`` (already implemented by its ``TreeView`` base), so
+cell spacing can be set on a ``TableView``.
+
+Recent changes — since ``v0.3.2``
+---------------------------------
+
+MDIWidget: new and raised sub-windows come to the top
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Raising a sub-window (including the implicit raise when one is created)
+now sets its ``z-index`` to one above the current maximum, rather than to
+the sub-window count.  The count could drift below the live z-indices
+(after closing windows, or repeated raise/lower), which previously left a
+freshly created window stacked *underneath* existing ones and hidden.
+
+TextArea: scrollbars, and ``set_limit`` is a history limit
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Scrollbars now appear correctly for an over-full ``TextArea``.  Also,
+``set_limit(n)`` now bounds the *retained* text to the last ``n`` lines
+(a scrollback/history limit, trimming the oldest lines as new text is
+appended) instead of setting the number of visible rows.
+
+Pyodide: keyword args for positional constructor parameters
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+In the in-situ (Pyodide) backend, constructing a widget with keyword
+arguments that name positional constructor parameters -- e.g.
+``Dialog(title=..., buttons=...)`` -- now fills those constructor slots,
+matching the sync backend.  Previously such kwargs fell through to
+``set_<name>`` setter dispatch and raised when no such setter existed, so
+affected widgets (e.g. ``Dialog``) could not be constructed in-situ.
+
+Pyodide: widgets expose their definition for ``has_callback``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+In-situ widget classes now carry their definition, so ``has_callback(name)``
+reports the callbacks a widget *declares* (e.g. ``page-switch`` /
+``page-close``), matching the sync backend.  Host code that wires a callback
+only ``if widget.has_callback(name)`` -- such as a workspace connecting
+``page-close`` -- now works in-situ; previously that gate returned ``False``
+and the callback was never connected.
+
 Recent changes — since ``v0.3.0``
 ---------------------------------
 

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pgwidgets",
-  "version": "0.3.2",
+  "version": "0.3.4",
   "description": "A native JavaScript widget library with Qt/GTK-style layout and controls",
   "type": "module",
   "main": "Widgets.js",

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/pgwidgets_js/defs.py

@@ -109,7 +109,7 @@ WIDGETS = {
     "ButtonBox": {
         "base": "container",
         "args": [],
-        "options": ["orientation", "halign"],
+        "options": ["orientation", "halign", "min_button_width"],
         "methods": {
             "add_widget": ["child", "stretch"],
             "insert_widget": ["index", "child", "stretch"],
@@ -179,6 +179,17 @@ WIDGETS = {
         "callbacks": [],
     },
 
+    "Separator": {
+        # A thin horizontal or vertical rule (like an HTML <hr>).
+        "base": "widget",
+        "args": ["orientation"],
+        "options": [],
+        "methods": {
+            "set_orientation": ["orientation"],
+        },
+        "callbacks": [],
+    },
+
     "Expander": {
         # JS Expander extends ContainerWidget (single child via set_widget),
         # so it needs the container method set (get_children, num_children,
@@ -366,6 +377,8 @@ WIDGETS = {
             "set_position": ["x", "y"],
             "popup": ["x", "y"],
             "set_modal": ["tf"],
+            # inherited from TopLevel on the JS side (Dialog extends TopLevel)
+            "set_title": ["title"],
         },
         "callbacks": [*CONTAINER_CALLBACKS, "activated", "move", "close"],
     },
@@ -409,6 +422,7 @@ WIDGETS = {
             "set_icon": ["url", "size"],
             "get_icon": [],
             "set_color": ["bg", "fg"],
+            "set_hover": ["bg", "fg"],
         },
         "callbacks": ["activated"],
     },
@@ -547,10 +561,14 @@ WIDGETS = {
             "set_wrap": ["mode"],
             "set_line_numbers": ["tf"],
             "set_icon_gutter": ["tf"],
+            "set_font": ["family", "size"],
+            "set_tooltips_enabled": ["tf"],
             "set_icon": ["ref", "icon_url"],
             "get_cursor": [],
             "set_cursor": ["ref"],
             "get_selection_range": [],
+            "has_selection": [],
+            "get_selection_bounds": [],
             "set_selection_range": ["start_ref", "end_ref"],
             # Tags
             "create_tag": ["name", "attrs"],
@@ -560,6 +578,8 @@ WIDGETS = {
             "remove_tag": ["name", "start_ref", "end_ref"],
             "get_tags_at": ["ref"],
             "get_tags_range": ["start_ref", "end_ref"],
+            "get_tag_region": ["name"],
+            "get_tag_regions": ["name"],
             # Live refs
             "create_ref": ["offset", "gravity"],
             "remove_ref": ["ref"],
@@ -594,7 +614,7 @@ WIDGETS = {
             "get_scroll_position": [],
         },
         "callbacks": ["changed", "cursor_moved", "line_clicked",
-                      "icon_clicked", "scrolled"],
+                      "icon_clicked", "scrolled", "tooltip"],
     },
 
     # A live position handle into a TextSource buffer.  Extends the
@@ -830,6 +850,8 @@ WIDGETS = {
             "select_all": ["state"],
             "set_column_width": ["col_index", "width"],
             "set_optimal_column_widths": [],
+            "set_row_spacing": ["px"],
+            "set_column_spacing": ["px"],
             "sort_by_column": ["col_index", "ascending"],
             "scroll_to_path": ["path"],
             "scroll_to_end": [],

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/pgwidgets_js/pyodide/widget.py

@@ -108,10 +108,23 @@ class Widget:
         pos_names = defn.get("args", [])
         opt_names = defn.get("options", [])
 
-        # Build JS constructor args
-        js_args = list(args[:len(pos_names)])
+        # Build JS constructor args.  Fill the declared positional slots
+        # from positional args first, then from any same-named keyword
+        # arg (e.g. ``Dialog(title=..., buttons=...)``); unfilled slots
+        # are ``None`` placeholders.  Without the kwarg mapping such a
+        # kwarg would be mistaken for a ``set_<name>`` setter call and
+        # fail when no such setter exists.
+        js_args = []
+        for i, name in enumerate(pos_names):
+            if i < len(args):
+                js_args.append(args[i])
+            elif name in kwargs:
+                js_args.append(kwargs.pop(name))
+            else:
+                js_args.append(None)
 
-        # Remaining positional args become options
+        # Remaining positional args (beyond the declared slots) become
+        # options, in declared order.
         for i, val in enumerate(args[len(pos_names):]):
             if i < len(opt_names):
                 kwargs[opt_names[i]] = val
@@ -125,10 +138,16 @@ class Widget:
             else:
                 setter_kwargs[k] = v
 
-        # Convert args and build options object
+        # Convert args and build options object.  Keep the positional
+        # slots when an options dict follows (so it lands after the last
+        # positional arg, not in one); otherwise trim trailing None
+        # placeholders.
         converted_args = [_to_js_val(a) for a in js_args]
         if options:
             converted_args.append(_to_js_val(options))
+        else:
+            while converted_args and converted_args[-1] is None:
+                converted_args.pop()
 
         # Construct the JS widget
         js_class = getattr(Widgets, js_class_name)
@@ -342,6 +361,11 @@ def build_widget_class(js_class, defn):
         Widget.__init__(self, js_class, *args, **kwargs)
     attrs["__init__"] = __init__
 
+    # expose the definition so callers can introspect declared callbacks
+    # (mirrors the sync backend): ginga's has_callback() consults
+    # ``_defn["callbacks"]`` to decide whether to wire e.g. 'page-close'
+    attrs["_defn"] = defn
+
     cls = type(js_class, (Widget,), attrs)
     # register so widgets returned from JS calls can be wrapped in their
     # proper subclass (see _from_js_val)

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/pgwidgets_js/static/Widgets.js

@@ -33,6 +33,7 @@ import {ToggleButton} from "./modules/ToggleButton.js";
 import {RadioButton} from "./modules/RadioButton.js";
 import {ProgressBar} from "./modules/ProgressBar.js";
 import {Frame} from "./modules/Frame.js";
+import {Separator} from "./modules/Separator.js";
 import {FixedLayout} from "./modules/FixedLayout.js";
 import {GridBox} from "./modules/GridBox.js";
 import {Image} from "./modules/Image.js";
@@ -61,7 +62,7 @@ const Widgets = {Callback, Widget, ContainerWidget, Box, VBox, HBox, ButtonBox,
                  TopLevel, AbstractScrollArea, ScrollArea, MDIWidget, Splitter, TabWidget,
                  StackWidget, Expander, Page, Text, Label, StatusBar, TextArea, TextSource,
                  TextBufferRef,
-                 Frame, FixedLayout, GridBox, Button, ToggleButton, CheckBox,
+                 Frame, Separator, FixedLayout, GridBox, Button, ToggleButton, CheckBox,
                  RadioButton, ComboBox, ComboBoxNative, TextEntry,
                  Slider, Canvas, SpinBox, ProgressBar, Image, Dial,
                  MenuBar, Menu, MenuAction, ToolBar, ToolBarAction,

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/pgwidgets_js/static/css/TextSource.css

@@ -29,6 +29,14 @@
     grid-column: 1;
     display: flex;
     flex-direction: row;
+    /* Top-align children so the edit wrap grows to its full content
+       height instead of being stretched (and clipped) to the visible
+       height.  With the default `stretch`, `.textsource-edit-wrap`
+       (overflow: hidden) gets capped at the viewport height and clips
+       the text to one screenful, while the number gutter (overflow
+       visible) still reports the full height -- so the scrollbar looks
+       right but scrolling reveals blank space. */
+    align-items: flex-start;
     overflow-y: auto;
     overflow-x: hidden;
     min-height: 0;
@@ -47,6 +55,8 @@
     background: #f4f4f4;
     border-right: 1px solid #e0e0e0;
     user-select: none;
+    /* fill the viewport height for short documents (see .textsource-main) */
+    min-height: 100%;
 }
 
 .textsource-icon-cell {
@@ -75,6 +85,8 @@
     font-size: 12px;
     text-align: right;
     user-select: none;
+    /* fill the viewport height for short documents (see .textsource-main) */
+    min-height: 100%;
 }
 
 .textsource-line-number {
@@ -88,6 +100,12 @@
     flex: 1 1 auto;
     position: relative;
     overflow: hidden;
+    /* Fill the viewport height for short documents (children are
+       top-aligned in .textsource-main, so without this the box would
+       shrink to its content height). For tall documents the box grows
+       past this to its full content height, letting .textsource-main
+       be the single vertical scroller. */
+    min-height: 100%;
     min-width: 0;
     /* hide native horizontal scrollbar; we use ScrollBar widget */
     scrollbar-width: none;

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/pgwidgets_js/static/modules/Box.js

@@ -214,6 +214,9 @@ class ButtonBox extends Box {
     constructor(options = { orientation: 'horizontal' }) {
         super(options);
         this._halign = this.get_option(options, 'halign', 'center');
+        // optional lower bound: buttons are never narrower than this, even
+        // if the widest button's natural size is smaller
+        this._minButtonWidth = this.get_option(options, 'min_button_width', null);
         this._applyAlign();
 
     }
@@ -281,8 +284,9 @@ class ButtonBox extends Box {
                 let w = elt.getBoundingClientRect().width;
                 if (w > maxW) maxW = w;
             }
-            if (maxW > 0) {
-                let px = Math.ceil(maxW) + 'px';
+            let target = Math.max(Math.ceil(maxW), this._minButtonWidth || 0);
+            if (target > 0) {
+                let px = target + 'px';
                 for (let child of this.children) {
                     let elt = child.get_element();
                     elt.style.minWidth = px;

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/pgwidgets_js/static/modules/Button.js

@@ -35,6 +35,11 @@ class Button extends Widget {
 
         this.element.onclick = () => this._cb_redirect('clicked');
         this.enable_callback('activated');
+
+        // hover highlight colors (see set_hover); null = no hover override
+        this._hoverBg = null;
+        this._hoverFg = null;
+        this._hoverInstalled = false;
     }
 
     /**
@@ -114,6 +119,58 @@ class Button extends Widget {
         }
     }
 
+    /**
+     * Give this button a hover highlight: while the pointer is over the
+     * button its background/foreground switch to the supplied colors,
+     * reverting on mouse-out.  Mirrors the qt/gtk backends' per-button
+     * hover.  Pass ``(null, null)`` or empty strings to clear it.
+     *
+     * Implemented with mouseenter/mouseleave that swap (and restore) the
+     * inline style, because an inline base background set via set_color
+     * would otherwise win over a CSS ``:hover`` rule.
+     *
+     * @param {string|null} [bg=null] - Hover background CSS color.
+     * @param {string|null} [fg=null] - Hover foreground (text) CSS color.
+     */
+    set_hover(bg=null, fg=null) {
+        this._hoverBg = (bg === '') ? null : bg;
+        this._hoverFg = (fg === '') ? null : fg;
+        if (!this._hoverInstalled) {
+            this._hoverInstalled = true;
+            this.element.addEventListener('mouseenter',
+                                          () => this._applyHover());
+            this.element.addEventListener('mouseleave',
+                                          () => this._restoreHover());
+        }
+    }
+
+    _applyHover() {
+        if (this._hoverBg === null && this._hoverFg === null) {
+            return;
+        }
+        // remember whatever inline colors are in effect (e.g. a base color
+        // from set_color, or '' for the default look) so we can restore them
+        this._savedBg = this.element.style.background;
+        this._savedFg = this.element.style.color;
+        if (this._hoverBg !== null) {
+            this.element.style.background = this._hoverBg;
+        }
+        if (this._hoverFg !== null) {
+            this.element.style.color = this._hoverFg;
+        }
+    }
+
+    _restoreHover() {
+        if (this._savedBg !== undefined) {
+            this.element.style.background = this._savedBg;
+            this._savedBg = undefined;
+        }
+        if (this._savedFg !== undefined) {
+            this.element.style.color = this._savedFg;
+            this._savedFg = undefined;
+        }
+    }
+
     _cb_redirect(action) {
         if (action === 'clicked') {
             this.make_callback('activated');

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/pgwidgets_js/static/modules/Dialog.js

@@ -149,6 +149,42 @@ class Dialog extends TopLevel {
         this._contentArea.set_spacing(gap);
     }
 
+    /**
+     * Removes a widget from the dialog's content area.
+     * @param {Widget} child - The widget to remove.
+     * @param {boolean} [destroy=false] - If true, also destroy the child.
+     */
+    remove_widget(child, destroy = false) {
+        this._contentArea.remove_widget(child, destroy);
+    }
+
+    /**
+     * Removes all widgets from the dialog's content area, leaving the
+     * button bar intact.  (The base implementation would clear the
+     * dialog's own children -- the content area + button bar -- which
+     * detaches the layout; delegate here to match add_widget().)
+     * @param {boolean} [destroy=false] - If true, also destroy each child.
+     */
+    remove_all(destroy = false) {
+        this._contentArea.remove_all(destroy);
+    }
+
+    /**
+     * Returns the content area's child widgets.
+     * @returns {Widget[]} The children array.
+     */
+    get_children() {
+        return this._contentArea.get_children();
+    }
+
+    /**
+     * Returns the number of widgets in the dialog's content area.
+     * @returns {number} The child count.
+     */
+    num_children() {
+        return this._contentArea.num_children();
+    }
+
     /**
      * Adds a button widget to the dialog's button bar.
      * Clicking the button fires the dialog's 'activated' callback

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/pgwidgets_js/static/modules/MDIWidget.js

@@ -437,16 +437,19 @@ class MDISubWindow extends ContainerWidget {
     
     /** Raises the sub-window to the top of the z-order. */
     raise_() {
-        let num_children = this.mdi_widget.children.length;
-        this.element.style.zIndex = num_children;
+        // Place this window above all others.  Use (max existing z)+1
+        // rather than children.length: the z-indices can drift above the
+        // child count (e.g. after closing windows or repeated raise/lower),
+        // which previously left a freshly added/raised window stacked
+        // *under* existing ones, hiding it.
+        let maxZ = 0;
         for (let subwin of this.mdi_widget.children) {
-            if (subwin != this) {
-                let win_elt = subwin.get_element();
-                if (win_elt.style.zIndex == num_children) {
-                    win_elt.style.zIndex--;
-                }
+            if (subwin !== this) {
+                let z = parseInt(subwin.get_element().style.zIndex, 10) || 0;
+                if (z > maxZ) maxZ = z;
             }
         }
+        this.element.style.zIndex = maxZ + 1;
 
         this.mdi_widget._refreshActiveSubWindow();
         this.mdi_widget.make_callback('page-switch', this.get_child());

pgwidgets_js-0.3.4/pgwidgets_js/static/modules/Separator.js

@@ -0,0 +1,55 @@
+"use_strict";
+
+import {Widget} from "./Widget.js";
+
+/**
+ * A thin separator rule (like an HTML <hr>).  Rendered as a 1px border on
+ * one edge of a zero-thickness div so it takes essentially no space along
+ * its thin axis while stretching along the other.
+ * @extends Widget
+ */
+class Separator extends Widget {
+
+    /**
+     * @param {string} [orientation='horizontal'] - 'horizontal' or 'vertical'.
+     * @param {Object} [options]
+     */
+    constructor(orientation='horizontal', options={}) {
+        super();
+        // orientation may arrive positionally or in the options dict
+        if (orientation != null && typeof orientation === 'object') {
+            options = orientation;
+            orientation = null;
+        }
+        this._orientation = orientation
+            || this.get_option(options, 'orientation', 'horizontal');
+
+        this.element = document.createElement('div');
+        this.element.className = 'separator-widget';
+        this._applyOrientation();
+
+        super.init_style();
+    }
+
+    _applyOrientation() {
+        let s = this.element.style;
+        s.borderTop = s.borderLeft = '';
+        s.width = s.height = '';
+        if (this._orientation === 'vertical') {
+            s.width = '0px';
+            s.height = '100%';
+            s.borderLeft = '1px solid #888';
+        } else {
+            s.height = '0px';
+            s.width = '100%';
+            s.borderTop = '1px solid #888';
+        }
+    }
+
+    set_orientation(orientation) {
+        this._orientation = orientation || 'horizontal';
+        this._applyOrientation();
+    }
+}
+
+export { Separator };

{pgwidgets_js-0.3.2 → pgwidgets_js-0.3.4}/pgwidgets_js/static/modules/TextArea.js

@@ -35,6 +35,10 @@ class TextArea extends Widget {
 
         this._scrollTimer = null;
         this._scrollReady = false;
+        // history limit: max number of lines retained (null = unlimited).
+        // NOTE: this caps the *content*, not the display height -- the
+        // textarea is sized by its container (grid cell) and scrolls.
+        this._limit = null;
 
         super.init_style();
 
@@ -88,6 +92,7 @@ class TextArea extends Widget {
 
     set_text(text) {
         this._textarea.value = text;
+        this._enforce_limit();
         this._syncScrollbars();
     }
 
@@ -97,9 +102,20 @@ class TextArea extends Widget {
 
     append_text(text) {
         this._textarea.value += text;
+        this._enforce_limit();
         this._syncScrollbars();
     }
 
+    /** Trim the buffer to the configured line limit (oldest dropped). */
+    _enforce_limit() {
+        if (!this._limit) return;
+        let lines = this._textarea.value.split('\n');
+        if (lines.length > this._limit) {
+            this._textarea.value = lines.slice(lines.length - this._limit)
+                                        .join('\n');
+        }
+    }
+
     clear() {
         this._textarea.value = '';
         this._syncScrollbars();
@@ -115,7 +131,14 @@ class TextArea extends Widget {
     }
 
     set_limit(numlines) {
-        this._textarea.rows = numlines;
+        // History limit: the maximum number of lines retained in the
+        // buffer (oldest dropped when exceeded).  This is NOT the display
+        // height -- the textarea is sized by its container and scrolls --
+        // so we must not touch ``rows`` (doing so would inflate the
+        // textarea to ``numlines`` tall and defeat scrolling).
+        this._limit = (numlines && numlines > 0) ? numlines : null;
+        this._enforce_limit();
+        this._syncScrollbars();
     }
 
     // -----------------------------------------------------------------