pgwidgets-js 0.3.1__tar.gz → 0.3.2__tar.gz

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pgwidgets-js
-Version: 0.3.1
+Version: 0.3.2
 Summary: pgwidgets JavaScript widget library — static assets for use with Python servers
 Author: PGWidgets Developers
 License: BSD-3-Clause

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/docs/WhatsNew.rst

@@ -4,6 +4,62 @@ What's New
 Recent changes — since ``v0.3.0``
 ---------------------------------
 
+Containers report their children: ``get_children``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+More widgets are now treated as containers and expose the full
+container method set (``get_children`` / ``num_children`` /
+``remove`` / ``remove_widget`` / ``remove_all``):
+
+* ``Frame``, ``Expander``, ``TopLevel`` and ``Page`` -- single-child
+  containers (one child via ``set_widget``); ``get_children()``
+  returns a 0- or 1-element list.
+* ``Menu``, ``MenuBar`` and ``ToolBar`` -- these now extend
+  ``ContainerWidget`` and route their item additions
+  (``add_name`` / ``add_menu`` / ``add_action`` / ``add_widget``)
+  through ``add_child``, so the menu actions / submenus / toolbar
+  items they hold are reported by ``get_children()``.  Separators
+  and spacers (which are not widgets) are excluded.
+
+This matches the behaviour generic code expects of any container.
+
+ScrollArea: content fills the viewport
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The scroll content wrapper is now a flex column.  A child that opts
+to fill (e.g. via ``set_expanding`` or a ``Box`` stretch factor) now
+fills the viewport when its content is smaller, while still growing
+and scrolling when the content exceeds it.  A child with no expand
+policy keeps its natural size (top-aligned), exactly as before.
+
+TreeView / TableView: ``set_row_spacing`` / ``set_column_spacing``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Two new methods set the vertical (row) and horizontal (column) cell
+padding, driving the ``--tv-row-pad`` / ``--tv-col-pad`` CSS variables
+that ``.treeview-cell`` consumes (defaults ``2px`` / ``6px``).
+``set_row_spacing`` additionally relaxes the fixed row ``min-height``
+(``--tv-row-minheight``) so rows can tighten to their content +
+padding instead of being held at the 24px floor.
+
+``open-url``: open a link in the user's browser
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+A new remote-protocol message type, ``open-url``, opens a URL in the
+connected browser (``window.open(url, "_blank", "noopener")``) -- so
+host-side code can open a link in the *user's* browser rather than on
+the machine running Python.  (Note: a popup blocker may suppress it
+if the user-activation from the originating click has lapsed.)
+
+ProgressBar: visible height inside a vertical box
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The progress bar now carries a ``min-height`` so it stays visible
+when packed in a vertical ``Box``.  (Its fill / label are absolutely
+positioned, and a vertical ``Box`` forces inline ``height: auto`` on
+children, which previously collapsed the bar to zero height --
+leaving only the border line.)
+
 Custom fonts: ``register-font`` / ``set-default-font``
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/docs/widgets/display.rst

@@ -396,6 +396,10 @@ supplies no value for it, so most interiors need no
      - Set column width.
    * - ``set_optimal_column_widths()``
      - Auto-size all columns.
+   * - ``set_row_spacing(px)`` / ``set_column_spacing(px)``
+     - Set the vertical (row) / horizontal (column) cell padding in
+       pixels.  ``set_row_spacing(0)`` also relaxes the row min-height
+       floor, giving tight rows.
    * - ``set_show_grid(tf)`` / ``set_show_row_numbers(tf)`` / ``set_sortable(tf)``
      - Toggle grid lines, row numbers, and click-to-sort.
    * - ``set_column_editable(col_key, tf)``

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/docs/widgets/layout.rst

@@ -8,7 +8,8 @@ TopLevel
 
 The root-level container widget. Uses absolute positioning and attaches
 to the document body. Typically the outermost widget in a pgwidgets
-application.
+application.  A single-child container: ``get_children()`` returns its
+0- or 1-element child list.
 
 **Constructor:** ``new Widgets.TopLevel({title, icon, resizable,
 moveable, closeable, minimizable, maximizable, lowerable,
@@ -463,6 +464,15 @@ ScrollArea
 
 Scrollable viewport wrapping a single child widget.
 
+If the child opts to fill (via ``set_expanding`` or a ``Box`` stretch
+factor) it fills the viewport when its content is smaller than the
+viewport, and grows (and scrolls) when the content is larger.  A child
+with no expand policy keeps its natural size, top-aligned.
+
+Like the other single-child containers (:ref:`widget-frame`,
+:ref:`widget-expander`, :ref:`widget-toplevel`), ``ScrollArea`` is a
+container: ``get_children()`` returns its 0- or 1-element child list.
+
 **Constructor:** ``new Widgets.ScrollArea({hscrollbar, vscrollbar})``
 
 **Options:**
@@ -488,7 +498,8 @@ Scrollable viewport wrapping a single child widget.
 Frame
 -----
 
-Titled border container for grouping widgets.
+Titled border container for grouping widgets.  A single-child container:
+``get_children()`` returns its 0- or 1-element child list.
 
 **Constructor:** ``new Widgets.Frame({title})``
 
@@ -521,7 +532,8 @@ Titled border container for grouping widgets.
 Expander
 --------
 
-Collapsible section with a clickable header.
+Collapsible section with a clickable header.  A single-child container:
+``get_children()`` returns its 0- or 1-element child list.
 
 **Constructor:** ``new Widgets.Expander({title, collapsible, shadow})``
 

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/docs/widgets/menus.rst

@@ -1,6 +1,13 @@
 Menu & Toolbar Widgets
 ======================
 
+``MenuBar``, ``Menu`` and ``ToolBar`` are container widgets: the menu
+actions, submenus and toolbar items they hold (added via ``add_name`` /
+``add_menu`` / ``add_action`` / ``add_widget``) are reported by the
+standard container API -- ``get_children()`` / ``num_children()`` /
+``remove(...)``.  Separators and spacers are not widgets and are not
+included.
+
 .. _widget-menubar:
 
 MenuBar

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pgwidgets",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "A native JavaScript widget library with Qt/GTK-style layout and controls",
   "type": "module",
   "main": "Widgets.js",

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/defs.py

@@ -37,6 +37,7 @@ WIDGET_METHODS = {
     "get_enabled": [],
     "set_tooltip": ["msg"],
     "get_tooltip": [],
+    "is_container": [],
     "set_allow_text_selection": ["tf"],
     "show": [],
     "hide": [],
@@ -163,7 +164,10 @@ WIDGETS = {
     },
 
     "Frame": {
-        "base": "widget",
+        # JS Frame extends ContainerWidget (single child via set_widget),
+        # so it needs the container method set (get_children, num_children,
+        # remove*).  get_children() returns a 0- or 1-element list.
+        "base": "container",
         "args": [],
         "options": ["title"],
         "methods": {
@@ -176,7 +180,10 @@ WIDGETS = {
     },
 
     "Expander": {
-        "base": "widget",
+        # JS Expander extends ContainerWidget (single child via set_widget),
+        # so it needs the container method set (get_children, num_children,
+        # remove*).  get_children() returns a 0- or 1-element list.
+        "base": "container",
         "args": [],
         "options": ["title", "collapsible", "shadow", "bg_color"],
         "methods": {
@@ -189,7 +196,11 @@ WIDGETS = {
     },
 
     "AbstractScrollArea": {
-        "base": "widget",
+        # JS AbstractScrollArea extends ContainerWidget (holds a single
+        # child via set_widget), so it needs the container method set
+        # (get_children, num_children, remove*) -- callers like ginga's
+        # Desktop iterate get_children() on it.
+        "base": "container",
         "args": [],
         "options": ["thickness"],
         "methods": {
@@ -204,7 +215,8 @@ WIDGETS = {
     },
 
     "ScrollArea": {
-        "base": "widget",
+        # extends AbstractScrollArea -> ContainerWidget; see note above.
+        "base": "container",
         "args": [],
         "options": ["hscrollbar", "vscrollbar", "thickness"],
         "methods": {
@@ -305,7 +317,10 @@ WIDGETS = {
     # -- Top-level windows --
 
     "TopLevel": {
-        "base": "widget",
+        # JS TopLevel extends ContainerWidget; container method set needed
+        # (get_children, num_children, remove*) -- get_children() returns a
+        # 0- or 1-element list (single child via set_widget).
+        "base": "container",
         "args": [],
         "options": ["resizable", "title", "icon", "moveable", "closeable",
                     "minimizable", "maximizable", "lowerable", "shadeable"],
@@ -327,7 +342,10 @@ WIDGETS = {
     },
 
     "Page": {
-        "base": "widget",
+        # JS Page extends ContainerWidget; container method set needed
+        # (get_children, num_children, remove*) -- get_children() returns a
+        # 0- or 1-element list (single child via set_widget).
+        "base": "container",
         "args": [],
         "options": [],
         "methods": {
@@ -745,6 +763,8 @@ WIDGETS = {
             "collapse_item": ["path"],
             "get_selected": [],
             "get_subtree": ["status"],
+            "set_row_spacing": ["px"],
+            "set_column_spacing": ["px"],
             "set_selected": ["paths"],
             "clear_selection": [],
             "select_path": ["path", "state"],
@@ -963,7 +983,7 @@ WIDGETS = {
     # -- Menus & Toolbars --
 
     "MenuBar": {
-        "base": "widget",
+        "base": "container",
         "args": [],
         "options": [],
         "methods": {
@@ -975,7 +995,7 @@ WIDGETS = {
     },
 
     "Menu": {
-        "base": "widget",
+        "base": "container",
         "args": [],
         "options": [],
         "methods": {
@@ -1006,7 +1026,7 @@ WIDGETS = {
     },
 
     "ToolBar": {
-        "base": "widget",
+        "base": "container",
         "args": [],
         "options": ["orientation"],
         "methods": {

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/pyodide/widget.py

@@ -9,6 +9,36 @@ from js import Object, Widgets
 from pgwidgets_js.defs import (WIDGETS, WIDGET_METHODS, CONTAINER_METHODS,
                                 CALLBACK_METHODS)
 
+# Registry of built widget subclasses, keyed by JS class name.  Populated
+# by build_widget_class().  Used by _from_js_val() so that a widget
+# *returned* from a JS call is wrapped in its proper subclass (with the
+# full method set) rather than a bare Widget shell.
+_WIDGET_CLASSES = {}
+
+# Registry of live widget *instances*, keyed by their JS ``wid``.
+# Populated in Widget.__init__ and consulted by _from_js_val so that a
+# widget crossing back from JS (e.g. the child delivered to a
+# ``page-switch`` callback) resolves to its *original* Python wrapper --
+# preserving object identity and any subclass mix-ins (e.g. Ginga's
+# WidgetMixin, which adds ``extdata``).  Mirrors the wid->widget map the
+# websocket backend keeps.  Entries are removed in destroy().
+_WIDGET_INSTANCES = {}
+
+
+def _wid_key(js_obj):
+    """Return a stable dict key for a JS widget's ``wid`` (or None)."""
+    try:
+        wid = js_obj.wid
+    except Exception:
+        return None
+    if wid is None:
+        return None
+    # normalize numeric wids (JS numbers may arrive as float)
+    try:
+        return int(wid)
+    except (TypeError, ValueError):
+        return wid
+
 
 def _to_js_val(val):
     """Convert a Python value to a JS-compatible value.
@@ -35,14 +65,30 @@ def _from_js_val(val):
     JS Widget instances are wrapped in a Python Widget shell."""
     if val is None or val is Widgets:
         return val
+    # Newer Pyodide maps JS ``null`` (and ``undefined``) to a ``JsNull``
+    # sentinel rather than Python ``None``.  Normalize it so that callers'
+    # ``x is None`` checks work (e.g. Menu.get_menu returning null).
+    if type(val).__name__ in ('JsNull', 'JsUndefined'):
+        return None
     # Detect JS Callback/Widget objects (they have 'add_callback' and 'wid')
     if hasattr(val, 'add_callback') and hasattr(val, 'wid'):
-        wrapper = object.__new__(Widget)
-        wrapper._js = val
+        # If this widget already has a Python wrapper (it was created on
+        # the Python side), return that original object so identity and
+        # subclass mix-ins (e.g. Ginga's WidgetMixin / extdata) survive
+        # the round-trip through JS.
+        existing = _WIDGET_INSTANCES.get(_wid_key(val))
+        if existing is not None:
+            return existing
+        # Otherwise (a widget created purely in JS): wrap in the proper
+        # built subclass when known, else fall back to a bare Widget.
         try:
-            wrapper._js_class_name = val.constructor.name
+            js_class_name = val.constructor.name
         except Exception:
-            wrapper._js_class_name = 'Widget'
+            js_class_name = 'Widget'
+        cls = _WIDGET_CLASSES.get(js_class_name, Widget)
+        wrapper = object.__new__(cls)
+        wrapper._js = val
+        wrapper._js_class_name = js_class_name
         wrapper._proxies = []
         return wrapper
     # Check if it's a JsProxy with .to_py()
@@ -90,6 +136,12 @@ class Widget:
         self._js_class_name = js_class_name
         self._proxies = []  # prevent GC of callback proxies
 
+        # Register so this widget resolves back to *this* object when it
+        # crosses the JS->Python boundary in a callback (see _from_js_val).
+        key = _wid_key(self._js)
+        if key is not None:
+            _WIDGET_INSTANCES[key] = self
+
         # Apply remaining kwargs as setter calls
         for k, v in setter_kwargs.items():
             setter = f"set_{k}"
@@ -114,6 +166,10 @@ class Widget:
             handler(*py_args, *extra_args, **extra_kwargs)
         proxy = create_proxy(wrapper)
         self._proxies.append(proxy)
+        # enable_callback first (mirrors the websocket RemoteInterface
+        # path): besides registering the action it auto-wires DOM
+        # listeners for drag/drop callbacks (see Widget.enable_callback).
+        self._js.enable_callback(action)
         self._js.add_callback(action, proxy)
 
     def add_callback(self, action, handler, *extra_args, **extra_kwargs):
@@ -124,6 +180,10 @@ class Widget:
             handler(self, *py_args, *extra_args, **extra_kwargs)
         proxy = create_proxy(wrapper)
         self._proxies.append(proxy)
+        # enable_callback first (mirrors the websocket RemoteInterface
+        # path): besides registering the action it auto-wires DOM
+        # listeners for drag/drop callbacks (see Widget.enable_callback).
+        self._js.enable_callback(action)
         self._js.add_callback(action, proxy)
 
     # -- Common Widget methods --
@@ -164,6 +224,14 @@ class Widget:
     def is_visible(self):
         return self._call("is_visible")
 
+    def destroy(self):
+        # drop our identity-registry entry, then destroy the JS widget
+        try:
+            _WIDGET_INSTANCES.pop(_wid_key(self._js), None)
+        except Exception:
+            pass
+        self._call("destroy")
+
     def __repr__(self):
         return f"<{self._js_class_name}>"
 
@@ -211,6 +279,17 @@ def _make_method(method_name, param_names=()):
     return method
 
 
+# Ensure the base Widget class implements *every* common widget method
+# declared in WIDGET_METHODS, not just the hand-written subset above.
+# This matters because widgets *returned* from a JS call may be wrapped
+# in a bare Widget shell (see _from_js_val) when their JS constructor
+# name does not match a built subclass (e.g. a minified CDN bundle); the
+# bare shell must still expose set_tooltip, set_min_size, set_focus, etc.
+for _mname, _params in WIDGET_METHODS.items():
+    if not hasattr(Widget, _mname):
+        setattr(Widget, _mname, _make_method(_mname, _params))
+
+
 # Pyodide-specific overrides for methods whose Python-friendly
 # signature differs from the underlying JS method, or that need
 # special argument conversion.  Maps (js_class, method_name)
@@ -264,6 +343,9 @@ def build_widget_class(js_class, defn):
     attrs["__init__"] = __init__
 
     cls = type(js_class, (Widget,), attrs)
+    # register so widgets returned from JS calls can be wrapped in their
+    # proper subclass (see _from_js_val)
+    _WIDGET_CLASSES[js_class] = cls
     return cls
 
 

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/static/css/ProgressBar.css

@@ -2,6 +2,13 @@
     position: relative;
     width: 100%;
     height: 24px;
+    /* The fill/label children are absolutely positioned (out of flow),
+       so the element has no intrinsic content height.  In a vertical
+       Box, the layout forces inline ``height: auto`` on children, which
+       would collapse this to 0.  ``min-height`` survives that override
+       (and the Box strips it only for stretch>0 children that should be
+       free to shrink), keeping the bar visible. */
+    min-height: 24px;
     background-color: #ddd;
     border: 1px solid #aaa;
     border-radius: 3px;

pgwidgets_js-0.3.2/pgwidgets_js/static/css/ScrollArea.css

@@ -0,0 +1,23 @@
+/*
+ * ScrollArea widget styles (extends AbstractScrollArea)
+ */
+.scrollarea-viewport {
+    overflow: hidden;
+}
+
+.scrollarea-content {
+    /* flex column so a child that opts to fill (set_expanding -> flex:1)
+       fills the viewport when its content is smaller, while still growing
+       (and scrolling) when the content exceeds the viewport.  A child
+       without an expand policy keeps its natural size (top-aligned), as
+       before.  min-width/min-height:100% keep the content at least
+       viewport-sized; width:max-content lets it grow for wide content
+       (horizontal scroll); the column height is content-driven, floored
+       at the viewport by min-height. */
+    display: flex;
+    flex-direction: column;
+    width: max-content;
+    min-width: 100%;
+    min-height: 100%;
+    box-sizing: border-box;
+}

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/static/css/TreeView.css

@@ -151,7 +151,9 @@
 .treeview-row {
     display: grid;
     align-items: center;
-    min-height: 24px;
+    /* default 24px floor; set_row_spacing() relaxes this (to 0) so rows
+       can tighten to their content + cell padding. */
+    min-height: var(--tv-row-minheight, 24px);
     cursor: default;
     border-bottom: 1px solid #f0f0f0;
 }
@@ -199,7 +201,9 @@
 /* ── Cell ───────────────────────────────────────────── */
 
 .treeview-cell {
-    padding: 2px 6px;
+    /* vertical/horizontal padding overridable via set_row_spacing() /
+       set_column_spacing() (the --tv-row-pad / --tv-col-pad vars). */
+    padding: var(--tv-row-pad, 2px) var(--tv-col-pad, 6px);
     overflow: hidden;
     text-overflow: ellipsis;
     white-space: nowrap;

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/static/modules/Menu.js

@@ -1,14 +1,14 @@
 "use_strict";
 
-import {Widget} from "./Widget.js";
+import {ContainerWidget} from "./Widget.js";
 import {MenuAction} from "./MenuAction.js";
 
 /**
  * A popup menu widget containing menu actions, checkboxes, separators,
  * and submenus arranged in a vertical panel.
- * @extends Widget
+ * @extends ContainerWidget
  */
-class Menu extends Widget {
+class Menu extends ContainerWidget {
 
     /**
      * Creates a new Menu widget.
@@ -23,7 +23,8 @@ class Menu extends Widget {
         }
         this.element.className = 'menu-widget';
 
-        this._items = [];
+        // child widgets (actions + submenus) are tracked in
+        // ContainerWidget.children; _menus maps submenu name -> Menu
         this._menus = {};
 
         // auto-hide when a menu action is selected (for popup menus)
@@ -38,7 +39,7 @@ class Menu extends Widget {
      * @param {Widget} child - The widget to add (e.g. MenuAction, CheckBox).
      */
     add_widget(child) {
-        this._items.push(child);
+        this.add_child(child);
         this.element.appendChild(child.get_element());
     }
 
@@ -94,7 +95,7 @@ class Menu extends Widget {
             }
         });
 
-        this._items.push(menu);
+        this.add_child(menu);
         this._menus[name] = menu;
         this.element.appendChild(item);
         return menu;

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/static/modules/MenuBar.js

@@ -1,14 +1,14 @@
 "use_strict";
 
-import {Widget} from "./Widget.js";
+import {ContainerWidget} from "./Widget.js";
 import {Menu} from "./Menu.js";
 
 /**
  * A horizontal menu bar widget. Menus are added by name and pop up
  * when the user clicks the corresponding label on the bar.
- * @extends Widget
+ * @extends ContainerWidget
  */
-class MenuBar extends Widget {
+class MenuBar extends ContainerWidget {
 
     /**
      * Creates a new MenuBar widget.
@@ -116,6 +116,9 @@ class MenuBar extends Widget {
 
         this.element.appendChild(container);
         this._menus[name] = { menu, button };
+        // track the menu as a child so get_children() works (the menu's
+        // DOM lives in document.body, not inside the menubar element)
+        this.add_child(menu);
     }
 
     /**

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/static/modules/RemoteInterface.js

@@ -403,6 +403,8 @@ class RemoteInterface {
                 return this._handleRegisterFont(msg);
             case "set-default-font":
                 return this._handleSetDefaultFont(msg);
+            case "open-url":
+                return this._handleOpenUrl(msg);
             default:
                 return {type: "error", id: msg.id,
                         error: "Unknown message type: " + msg.type};
@@ -1015,6 +1017,19 @@ class RemoteInterface {
         return {type: "result", id: msg.id};
     }
 
+    /**
+     * Opens a URL in the user's browser (a new tab/window).
+     * Note: this is a server-initiated open, so a popup blocker may
+     * suppress it if the user-activation from the originating click has
+     * already lapsed.  ``noopener`` keeps the new tab from accessing
+     * this window.
+     * @private
+     */
+    _handleOpenUrl(msg) {
+        window.open(msg.url, "_blank", "noopener");
+        return {type: "result", id: msg.id};
+    }
+
     /**
      * Recursively resolves widget references in an arguments array.
      * Objects with a __wid__ key are replaced with the actual widget.

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/static/modules/ToolBar.js

@@ -1,15 +1,15 @@
 "use_strict";
 
-import {Widget} from "./Widget.js";
+import {ContainerWidget} from "./Widget.js";
 import {ToolBarAction} from "./ToolBarAction.js";
 
 /**
  * A toolbar widget that arranges actions and other widgets in a
  * horizontal or vertical strip. Supports buttons, toggle actions,
  * separators, and spacers.
- * @extends Widget
+ * @extends ContainerWidget
  */
-class ToolBar extends Widget {
+class ToolBar extends ContainerWidget {
 
     /**
      * Creates a new ToolBar widget.
@@ -39,6 +39,7 @@ class ToolBar extends Widget {
      * @param {Widget} child - The widget to add.
      */
     add_widget(child) {
+        this.add_child(child);
         let elt = child.get_element();
         elt.classList.add('toolbar-child');
         this.element.appendChild(elt);

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/static/modules/ToolBarAction.js

@@ -55,7 +55,12 @@ class ToolBarAction extends Widget {
 
         let icon_url = this.get_option(options, 'icon_url', null);
         let iconsize = this.get_option(options, 'iconsize', null);
-        if (icon_url !== null) {
+        // Truthy check (not ``!== null``): an unset icon may arrive as
+        // null (JSON, websocket backend) or undefined (to_js(None) in the
+        // in-situ/pyodide backend) or ''.  Only create the <img> for a
+        // real URL, otherwise an empty <img src="undefined"> shows as a
+        // broken-image "dot".
+        if (icon_url) {
             this.set_icon(icon_url, iconsize);
         }
 

{pgwidgets_js-0.3.1 → pgwidgets_js-0.3.2}/pgwidgets_js/static/modules/TreeView.js

@@ -2365,6 +2365,29 @@ class TreeView extends Widget {
         return span;
     }
 
+    /**
+     * Set the vertical spacing of rows (the vertical padding inside each
+     * cell, in pixels).  Drives the ``--tv-row-pad`` CSS variable that the
+     * stylesheet applies to ``.treeview-cell``.
+     * @param {number} px - Vertical cell padding in pixels.
+     */
+    set_row_spacing(px) {
+        this.element.style.setProperty('--tv-row-pad', px + 'px');
+        // Also relax the fixed row min-height floor so the row can tighten
+        // to its content + padding; otherwise the default 24px floor leaves
+        // a visible gap when the padding is small.
+        this.element.style.setProperty('--tv-row-minheight', '0px');
+    }
+
+    /**
+     * Set the horizontal spacing of columns (the horizontal padding inside
+     * each cell, in pixels).  Drives the ``--tv-col-pad`` CSS variable.
+     * @param {number} px - Horizontal cell padding in pixels.
+     */
+    set_column_spacing(px) {
+        this.element.style.setProperty('--tv-col-pad', px + 'px');
+    }
+
     set_show_grid(tf) {
         this._showGrid = !!tf;
         this.element.classList.toggle('treeview-grid', this._showGrid);