pgvector-haystack 6.5.0__tar.gz → 6.6.1__tar.gz

{pgvector_haystack-6.5.0 → pgvector_haystack-6.6.1}/CHANGELOG.md

@@ -1,5 +1,33 @@
 # Changelog
 
+## [integrations/pgvector-v6.6.0] - 2026-08-26
+
+### 🐛 Bug Fixes
+
+- PGVector adding optional parameter `filters` to `get_metadata_field_unique_values()` (#3735)
+- Standardize license files (#3771)
+
+### 🧪 Testing
+
+- `PGVectorDocumentStore` removing duplicated tests already covered by haystack Mixin tests (#3783)
+
+### 🧹 Chores
+
+- Re-standardize READMEs (#3768)
+
+
+## [integrations/pgvector-v6.5.0] - 2026-08-03
+
+### 🚀 Features
+
+- Add array_contains and array_overlaps operators to pgvector filters (#3459)
+
+### 🐛 Bug Fixes
+
+- Fix new issues raised by ruff 0.16.0 (#3670)
+- `PGVectorDocumentStore` get_metadata_field_unique_values setting list of values to return to `Any` (#3709)
+
+
 ## [integrations/pgvector-v6.4.1] - 2026-07-23
 
 ### 🐛 Bug Fixes
@@ -135,9 +163,14 @@
 
 ### 🧹 Chores
 
-- Remove black (#1985)
 - Pgvector - update docker image in examples (#1995)
 
+## [integrations/pgvector-v5.2.0] - 2025-06-26
+
+### 🧹 Chores
+
+- Remove black (#1985)
+
 
 ## [integrations/pgvector-v3.4.1] - 2025-06-20
 
@@ -241,48 +274,75 @@
 
 ### 🚀 Features
 
-- Add filter_policy to pgvector integration (#820)
 - Add schema support to pgvector document store. (#1095)
 - Pgvector - recreate the connection if it is no longer valid (#1202)
 
-### 🐛 Bug Fixes
-
-- `PgVector` - Fallback to default filter policy when deserializing retrievers without the init parameter (#900)
-
 ### 📚 Documentation
 
 - Explain different connection string formats in the docstring (#1132)
 
+### ⚙️ CI
+
+- Adopt uv as installer (#1142)
+
+### 🧹 Chores
+
+- Update changelog after removing legacy filters (#1083)
+- Update ruff linting scripts and settings (#1105)
+
+## [integrations/pgvector-v1.0.0] - 2024-09-12
+
 ### 🧪 Testing
 
 - Do not retry tests in `hatch run test` command (#954)
 
+### 🧹 Chores
+
+- PgVector - remove legacy filter support (#1068)
+
+### 🌀 Miscellaneous
+
+- Chore: Update pgvector test for the new `apply_filter_policy` usage (#970)
+- Chore: pgvector ruff update, don't ruff tests (#984)
+
+## [integrations/pgvector-v0.5.1] - 2024-07-17
+
+### 🐛 Bug Fixes
+
+- `PgVector` - Fallback to default filter policy when deserializing retrievers without the init parameter (#900)
+
+## [integrations/pgvector-v0.5.0] - 2024-07-15
+
+### 🚀 Features
+
+- Add filter_policy to pgvector integration (#820)
+
 ### ⚙️ CI
 
 - Retry tests to reduce flakyness (#836)
-- Adopt uv as installer (#1142)
 
 ### 🧹 Chores
 
 - Update ruff invocation to include check parameter (#853)
-- PgVector - remove legacy filter support (#1068)
-- Update changelog after removing legacy filters (#1083)
-- Update ruff linting scripts and settings (#1105)
 
 ### 🌀 Miscellaneous
 
 - Ci: install `pytest-rerunfailures` where needed; add retry config to `test-cov` script (#845)
 - Chore: Minor retriever pydoc fix (#884)
-- Chore: Update pgvector test for the new `apply_filter_policy` usage (#970)
-- Chore: pgvector ruff update, don't ruff tests (#984)
 
 ## [integrations/pgvector-v0.4.0] - 2024-06-20
 
 ### 🚀 Features
 
-- Defer the database connection to when it's needed (#773)
 - Add customizable index names for pgvector (#818)
 
+
+## [integrations/pgvector-v0.3.0] - 2024-05-30
+
+### 🚀 Features
+
+- Defer the database connection to when it's needed (#773)
+
 ### 🌀 Miscellaneous
 
 - Docs: add missing api references (#728)
@@ -316,6 +376,14 @@
 
 ## [integrations/pgvector-v0.1.0] - 2024-02-14
 
+### 🌀 Miscellaneous
+
+- Pgvector: generate API docs (#325)
+- Pgvector: add an example (#334)
+- Adopt `Secret` to pgvector (#402)
+
+## [integrations/pgvector-v0.0.1] - 2024-02-02
+
 ### 🐛 Bug Fixes
 
 - Pgvector: fix linting (#328)
@@ -326,8 +394,5 @@
 - Pgvector - filters (#257)
 - Pgvector - embedding retrieval (#298)
 - Pgvector - Embedding Retriever (#320)
-- Pgvector: generate API docs (#325)
-- Pgvector: add an example (#334)
-- Adopt `Secret` to pgvector (#402)
 
 <!-- generated by git-cliff -->

{pgvector_haystack-6.5.0 → pgvector_haystack-6.6.1}/LICENSE.txt

@@ -58,7 +58,7 @@ APPENDIX: How to apply the Apache License to your work.
 
 To apply the Apache License to your work, attach the following boilerplate notice, with the fields enclosed by brackets "[]" replaced with your own identifying information. (Don't include the brackets!)  The text should be enclosed in the appropriate comment syntax for the file format. We also recommend that a file or class name and description of purpose be included on the same "printed page" as the copyright notice for easier identification within third-party archives.
 
-Copyright [yyyy] [name of copyright owner]
+Copyright 2023-present deepset GmbH
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

{pgvector_haystack-6.5.0 → pgvector_haystack-6.6.1}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.4
+Metadata-Version: 2.5
 Name: pgvector-haystack
-Version: 6.5.0
+Version: 6.6.1
 Summary: An integration of pgvector (vector search extension for Postgres) with Haystack
 Project-URL: Source, https://github.com/deepset-ai/haystack-core-integrations
 Project-URL: Documentation, https://github.com/deepset-ai/haystack-core-integrations/blob/main/integrations/pgvector/README.md
@@ -34,6 +34,8 @@ Description-Content-Type: text/markdown
 
 ---
 
+## Contributing
+
 Refer to the general [Contribution Guidelines](https://github.com/deepset-ai/haystack-core-integrations/blob/main/CONTRIBUTING.md).
 
 To run integration tests locally, you need to have a PostgreSQL DB running with the `pgvector` extension.

{pgvector_haystack-6.5.0 → pgvector_haystack-6.6.1}/README.md

@@ -8,6 +8,8 @@
 
 ---
 
+## Contributing
+
 Refer to the general [Contribution Guidelines](https://github.com/deepset-ai/haystack-core-integrations/blob/main/CONTRIBUTING.md).
 
 To run integration tests locally, you need to have a PostgreSQL DB running with the `pgvector` extension.

{pgvector_haystack-6.5.0 → pgvector_haystack-6.6.1}/src/haystack_integrations/document_stores/pgvector/document_store.py

@@ -923,7 +923,7 @@ class PgvectorDocumentStore:
             )
             raise DocumentStoreError(error_msg) from e
 
-        # get the number of the inserted documents, inspired by psycopg3 docs
+        # executemany(returning=True) yields one result set per document, so walk them all with nextset()
         # https://www.psycopg.org/psycopg3/docs/api/cursors.html#psycopg.Cursor.executemany
         written_docs = 0
         while True:
@@ -980,9 +980,14 @@ class PgvectorDocumentStore:
             )
             raise DocumentStoreError(error_msg) from e
 
+        # executemany(returning=True) yields one result set per document, so walk them all with nextset()
+        # https://www.psycopg.org/psycopg3/docs/api/cursors.html#psycopg.Cursor.executemany
         written_docs = 0
-        async for _ in self._async_cursor:
-            written_docs += 1
+        while True:
+            if await self._async_cursor.fetchone():
+                written_docs += 1
+            if not self._async_cursor.nextset():
+                break
 
         return written_docs
 
@@ -1926,7 +1931,12 @@ class PgvectorDocumentStore:
         return {"min": min_value, "max": max_value}
 
     def _build_unique_values_queries(
-        self, normalized_field: str, search_term: str | None, from_: int, size: int
+        self,
+        normalized_field: str,
+        search_term: str | None,
+        from_: int,
+        size: int,
+        filters: dict[str, Any] | None = None,
     ) -> tuple[Composed, Composed, tuple]:
         """
         Builds SQL queries for getting unique metadata field values.
@@ -1936,6 +1946,7 @@ class PgvectorDocumentStore:
             against the metadata field's own value.
         :param from_: The offset for pagination (0-based).
         :param size: The number of unique values to return.
+        :param filters: Optional filters to restrict the documents considered.
         :returns: A tuple containing (count_query, select_query, params).
         """
         field_literal = SQLLiteral(normalized_field)
@@ -1944,6 +1955,9 @@ class PgvectorDocumentStore:
         # Use the `->` (jsonb) operator rather than `->>` (text) so DISTINCT/ORDER BY operate on the
         # value's original JSON type (numbers sort numerically, not lexicographically) and psycopg
         # decodes the result to its native Python type instead of a string.
+        #
+        # Not fixable here: JSONB equality treats a whole-number float (1.0) as identical to a
+        # numerically equal int (1), so DISTINCT still collapses them - see this method's docstring.
         sql_select = SQL("SELECT DISTINCT meta->{} AS value").format(field_literal)
         sql_from = SQL(" FROM {schema_name}.{table_name}").format(
             schema_name=Identifier(self.schema_name), table_name=Identifier(self.table_name)
@@ -1951,10 +1965,16 @@ class PgvectorDocumentStore:
         sql_where = SQL(" WHERE meta->>{} IS NOT NULL").format(field_literal)
 
         params: tuple = ()
+        if filters:
+            _validate_filters(filters)
+            filters_where_clause, filters_params = _convert_filters_to_where_clause_and_params(filters, operator="AND")
+            sql_where += filters_where_clause
+            params += filters_params
+
         if search_term:
             # Case-insensitive substring match against the metadata field's own (text) value.
             sql_where += SQL(" AND meta->>{} ILIKE %s").format(field_literal)
-            params = (f"%{search_term}%",)
+            params += (f"%{search_term}%",)
 
         # count query
         sql_count = SQL("SELECT COUNT(DISTINCT meta->{} ) AS total").format(field_literal)
@@ -1984,22 +2004,36 @@ class PgvectorDocumentStore:
         return unique_values, total_count
 
     def get_metadata_field_unique_values(
-        self, metadata_field: str, search_term: str | None = None, from_: int = 0, size: int = 10
+        self,
+        metadata_field: str,
+        search_term: str | None = None,
+        from_: int = 0,
+        size: int = 10,
+        filters: dict[str, Any] | None = None,
     ) -> tuple[list[Any], int]:
         """
         Returns unique values for a given metadata field, optionally filtered by a search term.
 
+        **Note**: values of different JSON type categories are kept distinct - a string, a number and
+        a boolean never collapse into each other, even when they share a textual form (e.g. the string
+        `"1"` and the number `1`). One exception: the ``meta`` column is JSONB, whose equality treats a
+        whole-number float (`1.0`) as identical to a numerically equal int (`1`), so those two collapse
+        into a single value. Floats with a fractional part (e.g. `1.5`) are unaffected.
+
         :param metadata_field: The name of the metadata field. Can include or omit the "meta." prefix.
         :param search_term: Optional search term to filter unique values by a case-insensitive substring
             match against the metadata field's own value. If None, all values are considered.
         :param from_: The offset for pagination (0-based).
         :param size: The number of unique values to return.
+        :param filters: Optional filters to restrict the documents considered.
         :returns: A tuple containing:
             - A list of unique values in their original type
             - The total count of unique values
         """
         normalized_field = PgvectorDocumentStore._normalize_metadata_field_name(metadata_field)
-        sql_count, sql_query, params = self._build_unique_values_queries(normalized_field, search_term, from_, size)
+        sql_count, sql_query, params = self._build_unique_values_queries(
+            normalized_field, search_term, from_, size, filters
+        )
 
         self._ensure_db_setup()
         assert self._dict_cursor is not None
@@ -2022,22 +2056,36 @@ class PgvectorDocumentStore:
         return PgvectorDocumentStore._process_unique_values_result(count_result, records)
 
     async def get_metadata_field_unique_values_async(
-        self, metadata_field: str, search_term: str | None = None, from_: int = 0, size: int = 10
+        self,
+        metadata_field: str,
+        search_term: str | None = None,
+        from_: int = 0,
+        size: int = 10,
+        filters: dict[str, Any] | None = None,
     ) -> tuple[list[Any], int]:
         """
         Asynchronously returns unique values for a given metadata field, optionally filtered by a search term.
 
+        **Note**: values of different JSON type categories are kept distinct - a string, a number and
+        a boolean never collapse into each other, even when they share a textual form (e.g. the string
+        `"1"` and the number `1`). One exception: the ``meta`` column is JSONB, whose equality treats a
+        whole-number float (`1.0`) as identical to a numerically equal int (`1`), so those two collapse
+        into a single value. Floats with a fractional part (e.g. `1.5`) are unaffected.
+
         :param metadata_field: The name of the metadata field. Can include or omit the "meta." prefix.
         :param search_term: Optional search term to filter unique values by a case-insensitive substring
             match against the metadata field's own value. If None, all values are considered.
         :param from_: The offset for pagination (0-based).
         :param size: The number of unique values to return.
+        :param filters: Optional filters to restrict the documents considered.
         :returns: A tuple containing:
             - A list of unique values in their original type
             - The total count of unique values
         """
         normalized_field = PgvectorDocumentStore._normalize_metadata_field_name(metadata_field)
-        sql_count, sql_query, params = self._build_unique_values_queries(normalized_field, search_term, from_, size)
+        sql_count, sql_query, params = self._build_unique_values_queries(
+            normalized_field, search_term, from_, size, filters
+        )
 
         await self._ensure_db_setup_async()
         assert self._async_dict_cursor is not None

{pgvector_haystack-6.5.0 → pgvector_haystack-6.6.1}/src/haystack_integrations/document_stores/pgvector/filters.py

@@ -71,6 +71,10 @@ def _parse_logical_condition(condition: dict[str, Any]) -> tuple[Composed, list[
         msg = f"Unknown logical operator '{operator}'. Valid operators are: 'AND', 'OR'"
         raise FilterError(msg)
 
+    if not condition["conditions"]:
+        msg = f"'conditions' must not be empty in {condition}"
+        raise FilterError(msg)
+
     # logical conditions can be nested, so we need to parse them recursively
     conditions = []
     for c in condition["conditions"]:

{pgvector_haystack-6.5.0 → pgvector_haystack-6.6.1}/tests/test_document_store.py

@@ -66,6 +66,55 @@ class TestDocumentStore(
         with pytest.raises(DuplicateDocumentError):
             document_store.write_documents(docs, DuplicatePolicy.FAIL)
 
+    def test_write_documents_counts_every_document(self, document_store: PgvectorDocumentStore):
+        docs = [Document(id="1"), Document(id="2"), Document(id="3")]
+        assert document_store.write_documents(docs) == 3
+
+    def test_write_documents_skip_counts_only_new_documents(self, document_store: PgvectorDocumentStore):
+        document_store.write_documents([Document(id="1")])
+        docs = [Document(id="1"), Document(id="2"), Document(id="3")]
+        assert document_store.write_documents(docs, DuplicatePolicy.SKIP) == 2
+
+    def test_write_documents_overwrite_counts_every_document(self, document_store: PgvectorDocumentStore):
+        document_store.write_documents([Document(id="1", content="old")])
+        docs = [Document(id="1", content="new"), Document(id="2"), Document(id="3")]
+        assert document_store.write_documents(docs, DuplicatePolicy.OVERWRITE) == 3
+
+    def test_get_metadata_field_unique_values_distinct_types(self, document_store: PgvectorDocumentStore):
+        """
+        Override: the base mixin test stores int, float, str and bool under the *same* metadata field
+        name and expects all four back as distinct values. This store's ``meta`` column is JSONB, and
+        PostgreSQL's JSONB equality treats a whole-number float (e.g. 1.0) and a numerically equal int
+        (1) as the same value, so ``SELECT DISTINCT meta->'field'`` collapses them regardless of which
+        other values share that field.
+
+        This adapts the same intent - int, float, str and bool must come back as distinct, unmangled
+        types via get_metadata_field_unique_values() - using one field per type instead of one shared
+        field, which is what this store can actually support.
+
+        The float value is a non-whole number (1.5, not 1.0): a whole-number float would still collapse
+        with an int under PostgreSQL's JSONB numeric equality even in its own field, so a fractional
+        value is used to sidestep that ambiguity entirely.
+        """
+        docs = [
+            Document(content="Doc 1", meta={"priority_int": 1}),
+            Document(content="Doc 2", meta={"priority_str": "1"}),
+            Document(content="Doc 3", meta={"priority_float": 1.5}),
+            Document(content="Doc 4", meta={"priority_bool": True}),
+        ]
+        document_store.write_documents(docs)
+
+        int_values, int_count = document_store.get_metadata_field_unique_values(metadata_field="priority_int")
+        str_values, str_count = document_store.get_metadata_field_unique_values(metadata_field="priority_str")
+        float_values, float_count = document_store.get_metadata_field_unique_values(metadata_field="priority_float")
+        bool_values, bool_count = document_store.get_metadata_field_unique_values(metadata_field="priority_bool")
+
+        assert (int_count, str_count, float_count, bool_count) == (1, 1, 1, 1)
+        assert int_values == [1] and type(int_values[0]) is int
+        assert str_values == ["1"] and type(str_values[0]) is str
+        assert float_values == [1.5] and type(float_values[0]) is float
+        assert bool_values == [True] and type(bool_values[0]) is bool
+
     def test_write_blob(self, document_store: PgvectorDocumentStore):
         bytestream = ByteStream(b"test", meta={"meta_key": "meta_value"}, mime_type="mime_type")
         docs = [Document(id="1", blob=bytestream)]
@@ -596,172 +645,30 @@ def test_get_metadata_field_min_max(document_store: PgvectorDocumentStore):
 
 
 @pytest.mark.integration
-def test_get_metadata_field_unique_values(document_store: PgvectorDocumentStore):
-    # Test with string values
+def test_get_metadata_field_unique_values_pagination_edge_cases(document_store: PgvectorDocumentStore):
+    """
+    Edge cases not covered by the shared GetMetadataFieldUniqueValuesTest mixin's pagination test:
+    size larger than the total count, from_ beyond the total count, and single-item-per-page paging.
+    """
     docs = [
-        Document(content="Python programming", meta={"category": "A", "language": "Python"}),
-        Document(content="Java programming", meta={"category": "B", "language": "Java"}),
-        Document(content="Python scripting", meta={"category": "A", "language": "Python"}),
-        Document(content="JavaScript development", meta={"category": "C", "language": "JavaScript"}),
-        Document(content="Python data science", meta={"category": "A", "language": "Python"}),
-        Document(content="Java backend", meta={"category": "B", "language": "Java"}),
+        Document(content="Python programming", meta={"category": "A"}),
+        Document(content="Java programming", meta={"category": "B"}),
+        Document(content="JavaScript development", meta={"category": "C"}),
     ]
     document_store.write_documents(docs)
 
-    # Test getting all unique values without search term
-    unique_values, total_count = document_store.get_metadata_field_unique_values("meta.category", None, 0, 10)
-    assert set(unique_values) == {"A", "B", "C"}
-    assert total_count == 3
-
-    # Test with "meta." prefix
-    unique_languages, total_languages = document_store.get_metadata_field_unique_values("meta.language", None, 0, 10)
-    assert set(unique_languages) == {"Python", "Java", "JavaScript"}
-    assert total_languages == 3
-
-    # Test pagination - first page
-    unique_values_page1, total_count_page1 = document_store.get_metadata_field_unique_values(
-        "meta.category", None, 0, 2
-    )
-    assert len(unique_values_page1) == 2
-    assert all(val in ["A", "B", "C"] for val in unique_values_page1)
-    assert total_count_page1 == 3
-
-    # Test pagination - second page
-    unique_values_page2, total_count_page2 = document_store.get_metadata_field_unique_values(
-        "meta.category", None, 2, 2
-    )
-    assert len(unique_values_page2) == 1
-    assert unique_values_page2[0] in ["A", "B", "C"]
-    assert total_count_page2 == 3
-
-    # Test pagination - verify pages don't overlap
-    assert not set(unique_values_page1).intersection(set(unique_values_page2))
-
-    # Test pagination - verify all values are covered
-    all_values = set(unique_values_page1) | set(unique_values_page2)
-    assert all_values == {"A", "B", "C"}
-
-    # Test pagination - size larger than total count
     unique_values_large, total_large = document_store.get_metadata_field_unique_values("meta.category", None, 0, 100)
-    assert len(unique_values_large) == 3
     assert set(unique_values_large) == {"A", "B", "C"}
     assert total_large == 3
 
-    # Test pagination - from_ beyond total count (should return empty)
     unique_values_beyond, total_beyond = document_store.get_metadata_field_unique_values("meta.category", None, 10, 10)
     assert len(unique_values_beyond) == 0
     assert total_beyond == 3
 
-    # Test pagination - single item per page
     unique_values_single1, _ = document_store.get_metadata_field_unique_values("meta.category", None, 0, 1)
     unique_values_single2, _ = document_store.get_metadata_field_unique_values("meta.category", None, 1, 1)
     unique_values_single3, _ = document_store.get_metadata_field_unique_values("meta.category", None, 2, 1)
     assert len(unique_values_single1) == 1
     assert len(unique_values_single2) == 1
     assert len(unique_values_single3) == 1
-    # All three pages should be different
     assert len(set(unique_values_single1 + unique_values_single2 + unique_values_single3)) == 3
-
-    # Test with search term - case-insensitive substring match against the metadata field's OWN value
-    # (not against document content).
-    unique_values_filtered, total_filtered = document_store.get_metadata_field_unique_values(
-        "meta.language", "Python", 0, 10
-    )
-    assert set(unique_values_filtered) == {"Python"}
-    assert total_filtered == 1
-
-    # Case-insensitivity: lowercase search term should still match "Python"
-    unique_values_lower, total_lower = document_store.get_metadata_field_unique_values("meta.language", "python", 0, 10)
-    assert set(unique_values_lower) == {"Python"}
-    assert total_lower == 1
-
-    # Substring matching: "Java" is a substring of both "Java" and "JavaScript"
-    unique_values_java, total_java = document_store.get_metadata_field_unique_values("meta.language", "Java", 0, 10)
-    assert set(unique_values_java) == {"Java", "JavaScript"}
-    assert total_java == 2
-
-    # Substring matching in the middle/end of a value
-    unique_values_script, total_script = document_store.get_metadata_field_unique_values(
-        "meta.language", "Script", 0, 10
-    )
-    assert set(unique_values_script) == {"JavaScript"}
-    assert total_script == 1
-
-    # Test pagination with search term
-    unique_values_search_page1, total_search = document_store.get_metadata_field_unique_values(
-        "meta.language", "Python", 0, 1
-    )
-    assert len(unique_values_search_page1) == 1
-    assert unique_values_search_page1[0] == "Python"
-    assert total_search == 1
-
-    # Test pagination with search term - beyond results
-    unique_values_search_empty, total_search_empty = document_store.get_metadata_field_unique_values(
-        "meta.language", "Python", 10, 10
-    )
-    assert len(unique_values_search_empty) == 0
-    assert total_search_empty == 1
-
-    # Test that search_term matches metadata VALUE, not content
-    content_vs_metadata_docs = [
-        Document(content="This document mentions Python explicitly", meta={"topic": "cooking"}),
-        Document(content="Unrelated content about recipes", meta={"topic": "python-tutorial"}),
-    ]
-    document_store.write_documents(content_vs_metadata_docs)
-
-    unique_topics, total_topics = document_store.get_metadata_field_unique_values("meta.topic", "python", 0, 10)
-    assert set(unique_topics) == {"python-tutorial"}
-    assert total_topics == 1
-
-    # Test with integer values
-    int_docs = [
-        Document(content="Doc 1", meta={"priority": 1}),
-        Document(content="Doc 2", meta={"priority": 2}),
-        Document(content="Doc 3", meta={"priority": 1}),
-        Document(content="Doc 4", meta={"priority": 3}),
-    ]
-    document_store.write_documents(int_docs)
-    unique_priorities, total_priorities = document_store.get_metadata_field_unique_values("meta.priority", None, 0, 10)
-    assert set(unique_priorities) == {1, 2, 3}
-    assert total_priorities == 3
-
-    # Test with search term on integer field - substring match against the field's own (stringified)
-    # value, e.g. "Doc 1" (content) no longer matches; "1" (the value itself) does. The returned
-    # values themselves keep their original type (int here), only the match is textual.
-    unique_priorities_filtered, total_priorities_filtered = document_store.get_metadata_field_unique_values(
-        "meta.priority", "1", 0, 10
-    )
-    assert set(unique_priorities_filtered) == {1}
-    assert total_priorities_filtered == 1
-
-
-@pytest.mark.integration
-def test_get_metadata_field_unique_values_no_search_term(document_store: PgvectorDocumentStore):
-    docs = [
-        Document(content="mentions tsvector and content in the body", meta={"category": "A"}),
-        Document(content="another document", meta={"category": "B"}),
-    ]
-    document_store.write_documents(docs)
-
-    values, total = document_store.get_metadata_field_unique_values("meta.category")
-
-    assert set(values) == {"A", "B"}
-    assert total == 2
-
-
-@pytest.mark.integration
-def test_get_metadata_field_unique_values_search_term_matches_field_value_not_content(
-    document_store: PgvectorDocumentStore,
-):
-    docs = [
-        # "python" appears in the content but NOT in the category value -> must be EXCLUDED
-        Document(content="Python programming guide", meta={"category": "Backend"}),
-        # "python" appears in the category value but NOT in the content -> must be INCLUDED
-        Document(content="General purpose scripting language", meta={"category": "Python-based"}),
-    ]
-    document_store.write_documents(docs)
-
-    values, total = document_store.get_metadata_field_unique_values("meta.category", search_term="python")
-
-    assert values == ["Python-based"]
-    assert total == 1

{pgvector_haystack-6.5.0 → pgvector_haystack-6.6.1}/tests/test_document_store_async.py

@@ -71,6 +71,63 @@ class TestDocumentStoreAsync(
         with pytest.raises(DuplicateDocumentError):
             await document_store.write_documents_async(docs, DuplicatePolicy.FAIL)
 
+    async def test_write_documents_async_counts_every_document(self, document_store: PgvectorDocumentStore):
+        docs = [Document(id="1"), Document(id="2"), Document(id="3")]
+        assert await document_store.write_documents_async(docs) == 3
+
+    async def test_write_documents_async_skip_counts_only_new_documents(self, document_store: PgvectorDocumentStore):
+        await document_store.write_documents_async([Document(id="1")])
+        docs = [Document(id="1"), Document(id="2"), Document(id="3")]
+        assert await document_store.write_documents_async(docs, DuplicatePolicy.SKIP) == 2
+
+    async def test_write_documents_async_overwrite_counts_every_document(self, document_store: PgvectorDocumentStore):
+        await document_store.write_documents_async([Document(id="1", content="old")])
+        docs = [Document(id="1", content="new"), Document(id="2"), Document(id="3")]
+        assert await document_store.write_documents_async(docs, DuplicatePolicy.OVERWRITE) == 3
+
+    async def test_get_metadata_field_unique_values_distinct_types_async(self, document_store: PgvectorDocumentStore):
+        """
+        Override: the base mixin test stores int, float, str and bool under the *same* metadata field
+        name and expects all four back as distinct values. This store's ``meta`` column is JSONB, and
+        PostgreSQL's JSONB equality treats a whole-number float (e.g. 1.0) and a numerically equal int
+        (1) as the same value, so ``SELECT DISTINCT meta->'field'`` collapses them regardless of which
+        other values share that field.
+
+        This adapts the same intent - int, float, str and bool must come back as distinct, unmangled
+        types via get_metadata_field_unique_values_async() - using one field per type instead of one
+        shared field, which is what this store can actually support.
+
+        The float value is a non-whole number (1.5, not 1.0): a whole-number float would still collapse
+        with an int under PostgreSQL's JSONB numeric equality even in its own field, so a fractional
+        value is used to sidestep that ambiguity entirely.
+        """
+        docs = [
+            Document(content="Doc 1", meta={"priority_int": 1}),
+            Document(content="Doc 2", meta={"priority_str": "1"}),
+            Document(content="Doc 3", meta={"priority_float": 1.5}),
+            Document(content="Doc 4", meta={"priority_bool": True}),
+        ]
+        await document_store.write_documents_async(docs)
+
+        int_values, int_count = await document_store.get_metadata_field_unique_values_async(
+            metadata_field="priority_int"
+        )
+        str_values, str_count = await document_store.get_metadata_field_unique_values_async(
+            metadata_field="priority_str"
+        )
+        float_values, float_count = await document_store.get_metadata_field_unique_values_async(
+            metadata_field="priority_float"
+        )
+        bool_values, bool_count = await document_store.get_metadata_field_unique_values_async(
+            metadata_field="priority_bool"
+        )
+
+        assert (int_count, str_count, float_count, bool_count) == (1, 1, 1, 1)
+        assert int_values == [1] and type(int_values[0]) is int
+        assert str_values == ["1"] and type(str_values[0]) is str
+        assert float_values == [1.5] and type(float_values[0]) is float
+        assert bool_values == [True] and type(bool_values[0]) is bool
+
     async def test_count_not_empty_async(self, document_store: PgvectorDocumentStore):
         """Override: mixin method is missing 'self', causing fixture injection to fail."""
         await document_store.write_documents_async(
@@ -124,22 +181,6 @@ class TestDocumentStoreAsync(
                 filters={"field": "meta.category", "operator": "==", "value": "A"}, meta={}
             )
 
-    async def test_get_metadata_field_unique_values_async_preserves_non_string_types(
-        self, document_store: PgvectorDocumentStore
-    ):
-        """Non-string metadata values (e.g. ints) are returned in their original type, not stringified."""
-        docs = [
-            Document(content="Doc 1", meta={"priority": 1}),
-            Document(content="Doc 2", meta={"priority": 2}),
-            Document(content="Doc 3", meta={"priority": 1}),
-        ]
-        await document_store.write_documents_async(docs)
-
-        values, total = await document_store.get_metadata_field_unique_values_async("meta.priority")
-
-        assert set(values) == {1, 2}
-        assert total == 2
-
     async def test_delete_table_async_first_call(self, document_store: PgvectorDocumentStore):
         """
         Test that delete_table_async can be executed as the initial operation on the Document Store

{pgvector_haystack-6.5.0 → pgvector_haystack-6.6.1}/tests/test_filters.py

@@ -483,3 +483,21 @@ def test_validate_filters():
     invalid_filters = {"field": "meta.number", "value": "100"}
     with pytest.raises(ValueError):
         _validate_filters(invalid_filters)
+
+
+@pytest.mark.parametrize("operator", ["AND", "OR"])
+def test_logical_condition_empty_conditions_raises(operator):
+    with pytest.raises(FilterError):
+        _parse_logical_condition({"operator": operator, "conditions": []})
+
+
+def test_logical_condition_nested_empty_conditions_raises():
+    filters = {
+        "operator": "AND",
+        "conditions": [
+            {"field": "meta.type", "operator": "==", "value": "article"},
+            {"operator": "OR", "conditions": []},
+        ],
+    }
+    with pytest.raises(FilterError):
+        _convert_filters_to_where_clause_and_params(filters)