perspective-python 3.0.2__tar.gz → 3.0.3__tar.gz

{perspective_python-3.0.2 → perspective_python-3.0.3}/Cargo.lock

@@ -278,9 +278,9 @@ checksum = "1fd0f2584146f6f2ef48085050886acf353beff7305ebd1ae69500e27c67f64b"
 
 [[package]]
 name = "bytes"
-version = "1.6.0"
+version = "1.7.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "514de17de45fdb8dc022b1a7975556c53c86f9f0aa5f534b98977b171857c2c9"
+checksum = "8318a53db07bb3f8dca91a600466bdb3f2eaadeedfdbcf02e1accbad9271ba50"
 
 [[package]]
 name = "cc"
@@ -1783,7 +1783,7 @@ checksum = "e3148f5046208a5d56bcfc03053e3ca6334e51da8dfb19b6cdc8b306fae3283e"
 
 [[package]]
 name = "perspective"
-version = "3.0.2"
+version = "3.0.3"
 dependencies = [
  "async-lock",
  "axum",
@@ -1823,7 +1823,7 @@ dependencies = [
 
 [[package]]
 name = "perspective-client"
-version = "3.0.2"
+version = "3.0.3"
 dependencies = [
  "async-lock",
  "futures",
@@ -1845,7 +1845,7 @@ dependencies = [
 
 [[package]]
 name = "perspective-js"
-version = "3.0.2"
+version = "3.0.3"
 dependencies = [
  "anyhow",
  "base64 0.13.1",
@@ -1874,7 +1874,7 @@ dependencies = [
 
 [[package]]
 name = "perspective-lint"
-version = "3.0.2"
+version = "3.0.3"
 dependencies = [
  "glob",
  "yew-fmt",
@@ -1882,15 +1882,15 @@ dependencies = [
 
 [[package]]
 name = "perspective-python"
-version = "3.0.2"
+version = "3.0.3"
 dependencies = [
  "async-lock",
  "cmake",
- "cxx-build",
  "extend",
  "futures",
  "num_cpus",
  "perspective-client",
+ "perspective-server",
  "pollster",
  "pyo3",
  "pyo3-build-config 0.20.3",
@@ -1902,14 +1902,13 @@ dependencies = [
 
 [[package]]
 name = "perspective-server"
-version = "3.0.2"
+version = "3.0.3"
 dependencies = [
  "async-lock",
  "base64 0.22.1",
  "cmake",
- "cxx",
- "cxx-build",
  "futures",
+ "link-cplusplus",
  "num_cpus",
  "perspective-client",
  "regex",
@@ -1918,7 +1917,7 @@ dependencies = [
 
 [[package]]
 name = "perspective-viewer"
-version = "3.0.2"
+version = "3.0.3"
 dependencies = [
  "anyhow",
  "async-lock",

{perspective_python-3.0.2 → perspective_python-3.0.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: perspective-python
-Version: 3.0.2
+Version: 3.0.3
 Classifier: Development Status :: 5 - Production/Stable
 Classifier: Programming Language :: Rust
 Classifier: Programming Language :: Python :: Implementation :: CPython

{perspective_python-3.0.2 → perspective_python-3.0.3}/perspective/__init__.py

@@ -10,7 +10,7 @@
 #  ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
 #  ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
 
-__version__ = "3.0.2"
+__version__ = "3.0.3"
 __all__ = [
     "_jupyter_labextension_paths",
     "PerspectiveError",
@@ -30,12 +30,13 @@ from .perspective import (
     Table,
     View,
     ProxySession,
+    PySyncServer,
 )
 
 from .widget import PerspectiveWidget
 from .viewer import PerspectiveViewer
 
-from .psp_cffi import ServerBase
+# from .psp_cffi import ServerBase
 
 try:
     from .handlers import PerspectiveTornadoHandler
@@ -47,7 +48,7 @@ def default_loop_cb(fn, *args, **kwargs):
     return fn(*args, **kwargs)
 
 
-class Server(ServerBase):
+class Server(PySyncServer):
     def set_threadpool_size(self, n_cpus):
         pass
 

{perspective_python-3.0.2 → perspective_python-3.0.3}/pyproject.toml

@@ -37,7 +37,7 @@ dependencies = ["Jinja2>=2.0,<4", "ipywidgets>=7.5.1,<9"]
 
 [tool.maturin]
 module-name = "perspective"
-data = "perspective_python-3.0.2.data"
+data = "perspective_python-3.0.3.data"
 features = ["pyo3/extension-module"]
 include = [
     { path = "perspective/*libpsp.so", format = "wheel" },

{perspective_python-3.0.2 → perspective_python-3.0.3}/rust/perspective-client/Cargo.toml

@@ -12,7 +12,7 @@
 
 [package]
 name = "perspective-client"
-version = "3.0.2"
+version = "3.0.3"
 authors = ["Andrew Stein <steinlink@gmail.com>"]
 edition = "2021"
 description = "A data visualization and analytics component, especially well-suited for large and/or streaming datasets."

{perspective_python-3.0.2 → perspective_python-3.0.3}/rust/perspective-client/src/rust/config/plugin.rs

@@ -46,9 +46,11 @@ pub struct DefaultStyleAttributes {
     pub bool: serde_json::Value,
 }
 
-/// The data needed to populate a column's settings. These are typically default
-/// values, a listing of possible values, or other basic configuration settings
-/// for the plugin. This is the result of calling plugin.plugin_attributes
+/// The data needed to populate a column's settings.
+///
+/// These are typically default values, a listing of possible values, or other
+/// basic configuration settings for the plugin. This is the result of calling
+/// plugin.plugin_attributes
 #[derive(Serialize, Deserialize, Debug, Clone, PartialEq)]
 pub struct PluginAttributes {
     pub symbol: Option<SymbolAttributes>,
@@ -64,4 +66,4 @@ pub struct PluginConfig {
     /// Refers to the currently active columns. Maps name to configuration.
     #[serde(default)]
     pub columns: HashMap<String, serde_json::Value>,
-}
+}

{perspective_python-3.0.2 → perspective_python-3.0.3}/rust/perspective-client/src/rust/session.rs

@@ -22,12 +22,12 @@ use crate::{Client, ClientError};
 #[cfg(doc)]
 use crate::{Table, View};
 
-/// The server-side representation of a connection to a
-/// [`Client`]. For each [`Client`] that
-/// wants to connect to a `perspective_server::Server`, a dedicated [`Session`]
-/// must be created. The [`Session`] handles routing messages emitted by the
-/// `perspective_server::Server`ve_server::Server`, as well as owning any
-/// resources the [`Client`] may request.
+/// The server-side representation of a connection to a [`Client`].
+///
+/// For each [`Client`] that wants to connect to a `perspective_server::Server`,
+/// a dedicated [`Session`] must be created. The [`Session`] handles routing
+/// messages emitted by the `perspective_server::Server`ve_server::Server`, as
+/// well as owning any resources the [`Client`] may request.
 pub trait Session<E> {
     /// Handle an incoming request from the [`Client`]. Calling
     /// [`Session::handle_request`] will result in the `send_response` parameter

{perspective_python-3.0.2 → perspective_python-3.0.3}/rust/perspective-client/src/rust/table.rs

@@ -32,9 +32,7 @@ use crate::view::View;
 pub type Schema = HashMap<String, ColumnType>;
 
 /// Options which impact the behavior of [`Client::table`], as well as
-/// subsequent calls to [`Table::update`], even though this latter method
-/// itself does not take [`TableInitOptions`] as an argument, since this
-/// parameter is fixed at creation.
+/// subsequent calls to [`Table::update`].
 #[derive(Clone, Debug, Default, Serialize, Deserialize, TS)]
 pub struct TableInitOptions {
     #[serde(default)]

{perspective_python-3.0.2 → perspective_python-3.0.3}/rust/perspective-python/Cargo.toml

@@ -12,7 +12,7 @@
 
 [package]
 name = "perspective-python"
-version = "3.0.2"
+version = "3.0.3"
 edition = "2021"
 description = "A data visualization and analytics component, especially well-suited for large and/or streaming datasets."
 repository = "https://github.com/finos/perspective"
@@ -20,18 +20,16 @@ license = "Apache-2.0"
 homepage = "https://perspective.finos.org"
 authors = ["Andrew Stein <steinlink@gmail.com>"]
 keywords = []
-build = "build/main.rs"
+build = "build.rs"
 include = [
     "bench/**/*.py",
-    "build/**/*",
+    "build.rs",
     "./Cargo.toml",
     "./package.json",
     "perspective/**/*.py",
     "./pyproject.toml",
     "src/**/*.rs",
     "docs/**/*",
-    "cpp/**/*",
-    "cmake/**/*",
 ]
 
 [package.metadata.docs.rs]
@@ -39,14 +37,15 @@ rustdoc-args = ["--html-in-header", "docs/index.html"]
 
 [features]
 default = []
-sdist = []
-external-cpp = ["perspective-client/external-proto"]
+external-cpp = [
+    "perspective-client/external-proto",
+    "perspective-server/external-cpp",
+]
 
 [lib]
 crate-type = ["cdylib"]
 
 [build-dependencies]
-cxx-build = "1.0.115"
 cmake = "0.1.50"
 num_cpus = "^1.16.0"
 pyo3-build-config = "0.20.2"
@@ -54,8 +53,8 @@ python-config-rs = "0.1.2"
 
 [dependencies]
 async-lock = "2.5.0"
-perspective-client = { version = "3.0.2", path = "../perspective-client" }
-# perspective-server = { version = "3.0.2", path = "../perspective-server" }
+perspective-client = { version = "3.0.3", path = "../perspective-client" }
+perspective-server = { version = "3.0.3", path = "../perspective-server" }
 pollster = "0.3.0"
 extend = "1.1.2"
 futures = "0.3.28"

perspective_python-3.0.3/rust/perspective-python/build.rs

@@ -0,0 +1,31 @@
+// ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
+// ┃ ██████ ██████ ██████       █      █      █      █      █ █▄  ▀███ █       ┃
+// ┃ ▄▄▄▄▄█ █▄▄▄▄▄ ▄▄▄▄▄█  ▀▀▀▀▀█▀▀▀▀▀ █ ▀▀▀▀▀█ ████████▌▐███ ███▄  ▀█ █ ▀▀▀▀▀ ┃
+// ┃ █▀▀▀▀▀ █▀▀▀▀▀ █▀██▀▀ ▄▄▄▄▄ █ ▄▄▄▄▄█ ▄▄▄▄▄█ ████████▌▐███ █████▄   █ ▄▄▄▄▄ ┃
+// ┃ █      ██████ █  ▀█▄       █ ██████      █      ███▌▐███ ███████▄ █       ┃
+// ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
+// ┃ Copyright (c) 2017, the Perspective Authors.                              ┃
+// ┃ ╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌ ┃
+// ┃ This file is part of the Perspective library, distributed under the terms ┃
+// ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
+// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
+
+use std::error::Error;
+
+fn main() -> Result<(), Box<dyn Error>> {
+    pyo3_build_config::add_extension_module_link_args();
+
+    // Pass the `perspective_client` links metadata flag so that the `inherit_docs`
+    // macro can find the path to the docs.
+    println!(
+        "cargo:rustc-env=PERSPECTIVE_CLIENT_DOCS_PATH={}",
+        std::env::var("DEP_PERSPECTIVE_CLIENT_DOCS_PATH").unwrap()
+    );
+
+    if std::option_env!("PSP_DISABLE_CPP").is_some() {
+        return Ok(());
+    }
+
+    std::env::set_var("CARGO_FEATURE_PYTHON", "1");
+    Ok(())
+}

{perspective_python-3.0.2 → perspective_python-3.0.3}/rust/perspective-python/perspective/__init__.py

@@ -10,7 +10,7 @@
 #  ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
 #  ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
 
-__version__ = "3.0.2"
+__version__ = "3.0.3"
 __all__ = [
     "_jupyter_labextension_paths",
     "PerspectiveError",
@@ -30,12 +30,13 @@ from .perspective import (
     Table,
     View,
     ProxySession,
+    PySyncServer,
 )
 
 from .widget import PerspectiveWidget
 from .viewer import PerspectiveViewer
 
-from .psp_cffi import ServerBase
+# from .psp_cffi import ServerBase
 
 try:
     from .handlers import PerspectiveTornadoHandler
@@ -47,7 +48,7 @@ def default_loop_cb(fn, *args, **kwargs):
     return fn(*args, **kwargs)
 
 
-class Server(ServerBase):
+class Server(PySyncServer):
     def set_threadpool_size(self, n_cpus):
         pass
 

{perspective_python-3.0.2 → perspective_python-3.0.3}/rust/perspective-python/src/client/client_sync.rs

@@ -217,7 +217,6 @@ impl Table {
 
     #[doc = crate::inherit_docs!("table/size.md")]
     pub fn size(&self, py: Python<'_>) -> PyResult<usize> {
-        tracing::error!("WIP");
         self.0.size().py_block_on(py)
     }
 

{perspective_python-3.0.2 → perspective_python-3.0.3}/rust/perspective-python/src/lib.rs

@@ -14,7 +14,7 @@
 #![warn(unstable_features)]
 
 mod client;
-// mod server;
+mod server;
 
 pub use client::client_sync::{Client, ProxySession, Table, View};
 use pyo3::prelude::*;
@@ -50,8 +50,8 @@ fn init_tracing() {
 fn perspective(py: Python, m: &Bound<PyModule>) -> PyResult<()> {
     init_tracing();
     m.add_class::<client::client_sync::Client>()?;
-    // m.add_class::<server::PySyncServer>()?;
-    // m.add_class::<server::PySyncSession>()?;
+    m.add_class::<server::PySyncServer>()?;
+    m.add_class::<server::PySyncSession>()?;
     m.add_class::<client::client_sync::Table>()?;
     m.add_class::<client::client_sync::View>()?;
     m.add_class::<client::client_sync::ProxySession>()?;

perspective_python-3.0.3/rust/perspective-server/Cargo.toml

@@ -0,0 +1,57 @@
+#  ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
+#  ┃ ██████ ██████ ██████       █      █      █      █      █ █▄  ▀███ █       ┃
+#  ┃ ▄▄▄▄▄█ █▄▄▄▄▄ ▄▄▄▄▄█  ▀▀▀▀▀█▀▀▀▀▀ █ ▀▀▀▀▀█ ████████▌▐███ ███▄  ▀█ █ ▀▀▀▀▀ ┃
+#  ┃ █▀▀▀▀▀ █▀▀▀▀▀ █▀██▀▀ ▄▄▄▄▄ █ ▄▄▄▄▄█ ▄▄▄▄▄█ ████████▌▐███ █████▄   █ ▄▄▄▄▄ ┃
+#  ┃ █      ██████ █  ▀█▄       █ ██████      █      ███▌▐███ ███████▄ █       ┃
+#  ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
+#  ┃ Copyright (c) 2017, the Perspective Authors.                              ┃
+#  ┃ ╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌ ┃
+#  ┃ This file is part of the Perspective library, distributed under the terms ┃
+#  ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
+#  ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
+
+[package]
+name = "perspective-server"
+version = "3.0.3"
+authors = ["Andrew Stein <steinlink@gmail.com>"]
+edition = "2021"
+description = "A data visualization and analytics component, especially well-suited for large and/or streaming datasets."
+repository = "https://github.com/finos/perspective"
+license = "Apache-2.0"
+homepage = "https://perspective.finos.org"
+keywords = []
+build = "build/main.rs"
+include = [
+    "src/**/*",
+    "build/**/*",
+    "include/**/*",
+    "cpp/**/*",
+    "docs/**/*",
+    "cmake/**/*",
+    "Cargo.toml",
+]
+
+[features]
+default = ["python"]
+external-cpp = []
+wasm-exceptions = []
+python = []
+export-cpp-only = []
+no-build-cpp = []
+
+[build-dependencies]
+cmake = "0.1.50"
+num_cpus = "^1.15.0"
+regex = "~1"
+base64 = ">=0.22.1"
+
+[dependencies]
+link-cplusplus = "1.0.9"
+perspective-client = { version = "3.0.3", path = "../perspective-client" }
+async-lock = "2.5.0"
+tracing = { version = ">=0.1.36" }
+futures = "0.3"
+
+[lib]
+crate-type = ["rlib"]
+path = "src/lib.rs"

perspective_python-3.0.3/rust/perspective-server/build/main.rs

@@ -0,0 +1,41 @@
+// ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
+// ┃ ██████ ██████ ██████       █      █      █      █      █ █▄  ▀███ █       ┃
+// ┃ ▄▄▄▄▄█ █▄▄▄▄▄ ▄▄▄▄▄█  ▀▀▀▀▀█▀▀▀▀▀ █ ▀▀▀▀▀█ ████████▌▐███ ███▄  ▀█ █ ▀▀▀▀▀ ┃
+// ┃ █▀▀▀▀▀ █▀▀▀▀▀ █▀██▀▀ ▄▄▄▄▄ █ ▄▄▄▄▄█ ▄▄▄▄▄█ ████████▌▐███ █████▄   █ ▄▄▄▄▄ ┃
+// ┃ █      ██████ █  ▀█▄       █ ██████      █      ███▌▐███ ███████▄ █       ┃
+// ┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┫
+// ┃ Copyright (c) 2017, the Perspective Authors.                              ┃
+// ┃ ╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌ ┃
+// ┃ This file is part of the Perspective library, distributed under the terms ┃
+// ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
+// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
+
+mod psp;
+
+use std::fs;
+
+use base64::prelude::*;
+use regex::{Captures, Regex};
+
+fn main() -> Result<(), std::io::Error> {
+    let markdown = fs::read_to_string("./docs/lib.md")?;
+    let markdown = Regex::new("<img src=\"(.+?)\"")
+        .expect("regex")
+        .replace_all(markdown.as_str(), |caps: &Captures| {
+            let x = &caps[1];
+            let svg = fs::read_to_string(format!("./docs/{}", x)).expect("svg");
+            format!(
+                "<img src=\"data:image/svg+xml;base64,{}\"",
+                base64::prelude::BASE64_STANDARD.encode(svg)
+            )
+        });
+
+    std::fs::write("docs/lib_gen.md", markdown.as_ref())?;
+    if std::option_env!("PSP_DISABLE_CPP").is_none() {
+        if let Some(artifact_dir) = psp::cmake_build()? {
+            psp::cmake_link_deps(&artifact_dir)?;
+        }
+    }
+
+    Ok(())
+}

{perspective_python-3.0.2/rust/perspective-python → perspective_python-3.0.3/rust/perspective-server}/build/psp.rs

@@ -10,8 +10,6 @@
 // ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
 // ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
 
-// DO NOT EDIT THIS WITHOUT UPDATING rust/perspective-server/build/psp.rs
-
 use std::collections::HashSet;
 use std::path::{Path, PathBuf};
 use std::{fs, io};
@@ -46,7 +44,6 @@ pub fn cmake_build() -> Result<Option<PathBuf>, std::io::Error> {
         let root_dir = Path::new(root_dir_env.as_str());
         copy_dir_all(Path::join(root_dir, "cpp"), "cpp", &HashSet::from(["dist"]))?;
         copy_dir_all(Path::join(root_dir, "cmake"), "cmake", &HashSet::new())?;
-
         println!(
             "cargo:rerun-if-changed={}/cpp/perspective",
             root_dir.display()
@@ -118,46 +115,22 @@ pub fn cmake_build() -> Result<Option<PathBuf>, std::io::Error> {
     Ok(Some(artifact_dir))
 }
 
-#[allow(dead_code)]
 pub fn cmake_link_deps(cmake_build_dir: &Path) -> Result<(), std::io::Error> {
     println!(
         "cargo:rustc-link-search=native={}/build",
         cmake_build_dir.display()
     );
 
+    // println!("cargo:warning=MESSAGE {}/build", cmake_build_dir.display());
     println!("cargo:rustc-link-lib=static=psp");
     link_cmake_static_archives(cmake_build_dir)?;
     println!("cargo:rerun-if-changed=cpp/perspective");
     Ok(())
 }
 
-#[allow(dead_code)]
-pub fn cxx_bridge_build() {
-    println!("cargo:warning=MESSAGE Building cxx");
-    let mut compiler = cxx_build::bridge("src/ffi.rs");
-    compiler
-        .file("src/server.cpp")
-        .include("include")
-        .include("cpp/perspective/src/include")
-        .std("c++17");
-    // .flag("-fexceptions") // TODO not needed?
-
-    if cfg!(windows) {
-        compiler.flag_if_supported("/c");
-    } else {
-        compiler.static_flag(true);
-    }
-
-    compiler.compile("perspective");
-
-    println!("cargo:rerun-if-changed=include/server.h");
-    println!("cargo:rerun-if-changed=src/server.cpp");
-    println!("cargo:rerun-if-changed=src/lib.rs");
-}
-
 /// Walk the cmake output path and emit link instructions for all archives.
 /// TODO Can this be faster pls?
-#[allow(dead_code)]
+/// TODO update apparently not https://github.com/rust-lang/cmake-rs/issues/149
 pub fn link_cmake_static_archives(dir: &Path) -> Result<(), std::io::Error> {
     if dir.is_dir() {
         for entry in fs::read_dir(dir)? {
@@ -178,7 +151,7 @@ pub fn link_cmake_static_archives(dir: &Path) -> Result<(), std::io::Error> {
                         stem.expect("bad")[3..].to_string()
                     };
 
-                    // println!("cargo:warning=MESSAGE static link {}", a);
+                    // println!("cargo:warning=MESSAGE static link {} {}", a, dir.display());
                     println!("cargo:rustc-link-search=native={}", dir.display());
                     println!("cargo:rustc-link-lib=static={}", a);
                 }