perfact-api-pd-fastapi 1.17__tar.gz → 1.18__tar.gz

{perfact_api_pd_fastapi-1.17 → perfact_api_pd_fastapi-1.18}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: perfact-api-pd-fastapi
-Version: 1.17
+Version: 1.18
 Summary: PerFact API - SQLAlchemy+FastAPI pd apis package
 Author-email: Viktor Dick <viktor.dick@perfact.de>
 License-Expression: GPL-2.0-or-later

{perfact_api_pd_fastapi-1.17 → perfact_api_pd_fastapi-1.18}/src/perfact/api/pd_fastapi/grafana.py

@@ -1,6 +1,6 @@
 from collections.abc import Callable
 from dataclasses import dataclass
-from typing import Any, Sequence
+from typing import Any, Literal, Sequence
 
 from fastapi import HTTPException, status
 from perfact.api.base import AuthInfo, VisibilityPolicy, VisibilityPolicyRegistry
@@ -120,7 +120,11 @@ class ToolDowntimePayload(BaseModel):
     ``top_n`` is bounded to [1, _TOOL_DOWNTIME_MAX_TOP_N]. The id filters and
     ``sort`` are normalized through the same tolerant parsing the raw handler
     used, so an "All"/cleared template variable ('', [] or the unresolved
-    ``$__all``) still means "no filter".
+    ``$__all``) still means "no filter" / the default.
+
+    ``sort_by`` picks the metric that ranks the top-N tools and orders the
+    output: ``"duration"`` (default, total downtime) or ``"quantity"``
+    (incident count). It is strict: any other value is rejected.
     """
 
     model_config = ConfigDict(populate_by_name=True)
@@ -134,6 +138,7 @@ class ToolDowntimePayload(BaseModel):
     pdtooltype_ids: list[int] = Field(default_factory=list, alias="pdtooltype")
     pdtool_ids: list[int] = Field(default_factory=list, alias="pdtool")
     sort: str = "desc"
+    sort_by: Literal["duration", "quantity"] = "duration"
 
     @field_validator("plant_tssm_ids", "pdtooltype_ids", "pdtool_ids", mode="before")
     @classmethod
@@ -194,6 +199,7 @@ def _tool_downtime_handler(
         pdtooltype_ids=payload.pdtooltype_ids,
         pdtool_ids=pdtool_ids,
         sort=payload.sort,
+        sort_by=payload.sort_by,
     )
     return tool_downtime_grafana_resp(rows, target.refId)
 

{perfact_api_pd_fastapi-1.17 → perfact_api_pd_fastapi-1.18}/src/perfact_api_pd_fastapi.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: perfact-api-pd-fastapi
-Version: 1.17
+Version: 1.18
 Summary: PerFact API - SQLAlchemy+FastAPI pd apis package
 Author-email: Viktor Dick <viktor.dick@perfact.de>
 License-Expression: GPL-2.0-or-later

perfact_api_pd_fastapi-1.18/src/perfact_api_pd_fastapi.egg-info/scm_version.json

@@ -0,0 +1,8 @@
+{
+  "tag": "1.18",
+  "distance": 0,
+  "node": "g9f0dd07206a5739cc8062f22dc81bb453502b68f",
+  "dirty": false,
+  "branch": "HEAD",
+  "node_date": "2026-10-29"
+}

{perfact_api_pd_fastapi-1.17 → perfact_api_pd_fastapi-1.18}/tests/test_grafana.py

@@ -242,6 +242,29 @@ def test_tool_downtime_handler_happy_path(monkeypatch: pytest.MonkeyPatch) -> No
     assert captured["pdtool_ids"] == [5]
 
 
+@pytest.mark.parametrize(
+    "payload, expected",
+    [
+        ({"sort_by": "quantity"}, "quantity"),
+        ({"sort_by": "duration"}, "duration"),
+        ({}, "duration"),  # absent -> default
+    ],
+)
+def test_tool_downtime_payload_sort_by(payload, expected) -> None:
+    assert grafana.ToolDowntimePayload.model_validate(payload).sort_by == expected
+
+
+@pytest.mark.parametrize("value", ["bogus", "", "QUANTITY", None, 1])
+def test_tool_downtime_handler_rejects_invalid_sort_by(value) -> None:
+    target = Target(target="pd.kpi.tool_downtime", payload={"sort_by": value})
+    query = QueryRequest.model_validate({})
+
+    with pytest.raises(HTTPException) as exc:
+        grafana._tool_downtime_handler(Mock(), _auth(), Mock(), target, query)
+
+    assert exc.value.status_code == 400
+
+
 def test_tool_downtime_handler_scopes_to_pdtool_visibility(
     monkeypatch: pytest.MonkeyPatch,
 ) -> None:

perfact_api_pd_fastapi-1.17/src/perfact_api_pd_fastapi.egg-info/scm_version.json

@@ -1,8 +0,0 @@
-{
-  "tag": "1.17",
-  "distance": 0,
-  "node": "g8b87d7e61610a913ae8a0c293f8f86e5524b5745",
-  "dirty": false,
-  "branch": "HEAD",
-  "node_date": "2026-10-09"
-}