pdfdancer-client-python 0.2.28__tar.gz → 0.2.29__tar.gz

{pdfdancer_client_python-0.2.28 → pdfdancer_client_python-0.2.29}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pdfdancer-client-python
-Version: 0.2.28
+Version: 0.2.29
 Summary: Python client for PDFDancer API
 Author-email: "The Famous Cat Ltd." <hi@thefamouscat.com>
 License: 

{pdfdancer_client_python-0.2.28 → pdfdancer_client_python-0.2.29}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "pdfdancer-client-python"
-version = "0.2.28"
+version = "0.2.29"
 description = "Python client for PDFDancer API"
 readme = "README.md"
 authors = [

{pdfdancer_client_python-0.2.28 → pdfdancer_client_python-0.2.29}/src/pdfdancer/types.py

@@ -160,14 +160,14 @@ class BaseTextEdit:
 
 class TextLineEdit(BaseTextEdit):
     def apply(self) -> bool:
-        # Text lines don't support line spacing - ignore if set
+        # Line spacing is NOT supported for text lines - fail hard
         if self._line_spacing is not None:
-            print(
-                "WARNING: Line spacing is not supported for text lines and will be ignored",
-                file=sys.stderr,
+            raise UnsupportedOperation(
+                "Line spacing changes are not supported for individual text lines. "
+                "Line spacing can only be modified on paragraphs, not individual text lines."
             )
 
-        # Simple text-only change
+        # If only text changed (no font, color, or position), use simple text modification
         only_text_changed = (
             self._new_text is not None
             and self._font_name is None
@@ -185,7 +185,7 @@ class TextLineEdit(BaseTextEdit):
                 print(f"WARNING: {result.warning}", file=sys.stderr)
             return result
 
-        # Position-only change (move operation)
+        # If only position changed (move operation)
         only_move = (
             self._position is not None
             and self._new_text is None
@@ -216,15 +216,54 @@ class TextLineEdit(BaseTextEdit):
             result = self._target_obj._client._move(self._object_ref, position)
             return result
 
-        # Text lines with font/color styling changes are not supported by the PDF API
-        # Text lines are components of paragraphs and can only have their text modified
-        # or be moved, but not have their styling changed independently
-        raise UnsupportedOperation(
-            "Text lines can only have their text content modified or be moved. "
-            "Font and color changes are not supported for individual text lines. "
-            "To modify text styling, please modify the parent paragraph instead."
+        # For font/color changes or combined operations, use TextLineBuilder
+        # This ensures proper handling of font/color fallbacks just like ParagraphEditSession
+        from .text_line_builder import TextLineBuilder
+
+        builder = TextLineBuilder.from_object_ref(
+            self._target_obj._client, self._object_ref
         )
 
+        # Apply modifications to builder
+        # IMPORTANT: Always explicitly set text to ensure it's preserved
+        if self._new_text is not None:
+            builder.text(self._new_text)
+        elif hasattr(self._object_ref, "text") and self._object_ref.text:
+            # Preserve original text when only changing font/color/position
+            builder.text(self._object_ref.text)
+
+        # IMPORTANT: Always explicitly set font to ensure it's preserved
+        if self._font_name is not None and self._font_size is not None:
+            builder.font(self._font_name, self._font_size)
+        elif hasattr(self._object_ref, "font_name") and hasattr(self._object_ref, "font_size"):
+            if self._object_ref.font_name and self._object_ref.font_size:
+                # Preserve original font when only changing color/position
+                builder.font(self._object_ref.font_name, self._object_ref.font_size)
+
+        if self._color is not None:
+            builder.color(self._color)
+        if self._position is not None:
+            x = self._position.x()
+            y = self._position.y()
+            if x is None or y is None:
+                raise ValidationException("Position must have x and y coordinates")
+            page_index = (
+                self._object_ref.position.page_index
+                if self._object_ref.position
+                else None
+            )
+            if page_index is None:
+                raise ValidationException(
+                    "Text line position must include a page index"
+                )
+            builder.at(page_index, x, y)
+
+        # Use builder's modify method which handles all the complexity
+        result = builder.modify(self._object_ref)
+        if result.warning:
+            print(f"WARNING: {result.warning}", file=sys.stderr)
+        return result
+
 
 class ParagraphObject(PDFObjectBase):
     """Represents a paragraph text block inside a PDF page."""

{pdfdancer_client_python-0.2.28 → pdfdancer_client_python-0.2.29}/src/pdfdancer_client_python.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pdfdancer-client-python
-Version: 0.2.28
+Version: 0.2.29
 Summary: Python client for PDFDancer API
 Author-email: "The Famous Cat Ltd." <hi@thefamouscat.com>
 License: 

{pdfdancer_client_python-0.2.28 → pdfdancer_client_python-0.2.29}/tests/e2e/test_text_line_edit.py

@@ -1,7 +1,7 @@
 import pytest
-
 from pdfdancer import Color
 from pdfdancer.pdfdancer_v1 import PDFDancer
+
 from tests.e2e import _require_env_and_fixture
 from tests.e2e.pdf_assertions import PDFAssertions
 
@@ -15,8 +15,8 @@ def test_text_line_edit_text_only():
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
 
@@ -34,49 +34,45 @@ def test_text_line_edit_text_only():
 
 
 def test_text_line_edit_font_only():
-    """Test that text line font-only changes raise UnsupportedOperation"""
+    """Test text line font-only changes"""
     base_url, token, pdf_path = _require_env_and_fixture("Showcase.pdf")
 
     with PDFDancer.open(pdf_path, token=token, base_url=base_url) as pdf:
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
+        original_text = text_line.text
 
-        # Font changes on text lines should raise UnsupportedOperation
-        from pdfdancer.types import UnsupportedOperation
+        # Font changes on text lines should work
+        with text_line.edit() as editor:
+            editor.font("Helvetica", 28)
 
-        with pytest.raises(
-            UnsupportedOperation, match="Font and color changes are not supported"
-        ):
-            with text_line.edit() as editor:
-                editor.font("Helvetica", 28)
+        # Verify the text still exists (font changed but text preserved)
+        PDFAssertions(pdf).assert_textline_exists(original_text)
 
 
 def test_text_line_edit_color_only():
-    """Test that text line color-only changes raise UnsupportedOperation"""
+    """Test text line color-only changes"""
     base_url, token, pdf_path = _require_env_and_fixture("Showcase.pdf")
 
     with PDFDancer.open(pdf_path, token=token, base_url=base_url) as pdf:
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
+        original_text = text_line.text
 
-        # Color changes on text lines should raise UnsupportedOperation
-        from pdfdancer.types import UnsupportedOperation
+        # Color changes on text lines should work
+        with text_line.edit() as editor:
+            editor.color(Color(0, 255, 0))
 
-        with pytest.raises(
-            UnsupportedOperation, match="Font and color changes are not supported"
-        ):
-            with text_line.edit() as editor:
-                editor.color(Color(0, 255, 0))
+        # Verify the text still exists (color changed but text preserved)
+        PDFAssertions(pdf).assert_textline_exists(original_text)
 
 
 def test_text_line_edit_move_only():
@@ -87,8 +83,7 @@ def test_text_line_edit_move_only():
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
 
@@ -108,100 +103,105 @@ def test_text_line_edit_move_only():
 
 
 def test_text_line_edit_text_and_font():
-    """Test that text+font changes raise UnsupportedOperation"""
+    """Test text+font changes work together"""
     base_url, token, pdf_path = _require_env_and_fixture("Showcase.pdf")
 
     with PDFDancer.open(pdf_path, token=token, base_url=base_url) as pdf:
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
 
-        # Text + Font changes should raise UnsupportedOperation
-        from pdfdancer.types import UnsupportedOperation
+        # Text + Font changes should work
+        with text_line.edit() as editor:
+            editor.replace("New Text Here")
+            editor.font("Helvetica", 16)
 
-        with pytest.raises(
-            UnsupportedOperation, match="Font and color changes are not supported"
-        ):
-            with text_line.edit() as editor:
-                editor.replace("New Text Here")
-                editor.font("Helvetica", 16)
+        # Verify the new text exists
+        (
+            PDFAssertions(pdf)
+            .assert_textline_exists("New Text Here")
+            .assert_textline_does_not_exist(
+                "This is regular Sans text showing alignment and styles."
+            )
+        )
 
 
 def test_text_line_edit_all_properties():
-    """Test that combined property changes raise UnsupportedOperation"""
+    """Test that combined property changes work (except line spacing)"""
     base_url, token, pdf_path = _require_env_and_fixture("Showcase.pdf")
 
     with PDFDancer.open(pdf_path, token=token, base_url=base_url) as pdf:
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
 
-        # Combined changes including font/color should raise UnsupportedOperation
-        from pdfdancer.types import UnsupportedOperation
+        # Combined changes including font/color/position should work
+        with text_line.edit() as editor:
+            editor.replace("Fully Modified")
+            editor.font("Helvetica", 18)
+            editor.color(Color(255, 0, 0))
+            editor.move_to(100, 200)
 
-        with pytest.raises(
-            UnsupportedOperation, match="Font and color changes are not supported"
-        ):
-            with text_line.edit() as editor:
-                editor.replace("Fully Modified")
-                editor.font("Helvetica", 18)
-                editor.color(Color(255, 0, 0))
-                editor.move_to(100, 200)
+        # Verify the modified text exists
+        PDFAssertions(pdf).assert_textline_exists("Fully Modified")
 
 
-def test_text_line_edit_line_spacing_ignored():
-    """Test that line spacing is ignored for text lines with a warning"""
+def test_text_line_edit_line_spacing_fails():
+    """Test that line spacing changes fail hard for text lines"""
     base_url, token, pdf_path = _require_env_and_fixture("Showcase.pdf")
 
     with PDFDancer.open(pdf_path, token=token, base_url=base_url) as pdf:
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
 
-        # Line spacing should be ignored with a warning
-        with text_line.edit() as editor:
-            editor.line_spacing(2.0)  # This should be ignored
-            editor.replace("Text with ignored spacing")
+        # Line spacing should raise UnsupportedOperation
+        from pdfdancer.types import UnsupportedOperation
 
-        # Verify the text was changed
-        PDFAssertions(pdf).assert_textline_exists("Text with ignored spacing")
+        with pytest.raises(
+                UnsupportedOperation,
+                match="Line spacing changes are not supported for individual text lines",
+        ):
+            with text_line.edit() as editor:
+                editor.line_spacing(2.0)
+                editor.replace("Text with spacing")
 
 
 def test_text_line_edit_chaining():
-    """Test that chained font/color changes raise UnsupportedOperation"""
+    """Test that chained font/color changes work"""
     base_url, token, pdf_path = _require_env_and_fixture("Showcase.pdf")
 
     with PDFDancer.open(pdf_path, token=token, base_url=base_url) as pdf:
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
 
-        # Chained font/color changes should raise UnsupportedOperation
-        from pdfdancer.types import UnsupportedOperation
+        # Chained font/color changes should work
+        with text_line.edit() as editor:
+            editor.replace("Chained Edits").font("Helvetica", 15).color(
+                Color(128, 128, 128)
+            )
 
-        with pytest.raises(
-            UnsupportedOperation, match="Font and color changes are not supported"
-        ):
-            with text_line.edit() as editor:
-                editor.replace("Chained Edits").font("Helvetica", 15).color(
-                    Color(128, 128, 128)
-                )
+        # Verify the new text exists
+        (
+            PDFAssertions(pdf)
+            .assert_textline_exists("Chained Edits")
+            .assert_textline_does_not_exist(
+                "This is regular Sans text showing alignment and styles."
+            )
+        )
 
 
 def test_text_line_edit_with_exception_no_apply():
@@ -212,8 +212,7 @@ def test_text_line_edit_with_exception_no_apply():
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
 
@@ -238,8 +237,7 @@ def test_text_line_edit_multiple_sequential():
         text_lines = pdf.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
         with text_line.edit() as editor:
@@ -270,8 +268,7 @@ def test_text_line_edit_vs_manual_apply():
         text_lines = pdf1.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]
 
@@ -285,8 +282,7 @@ def test_text_line_edit_vs_manual_apply():
         text_lines = pdf2.page(0).select_text_lines_starting_with(
             "This is regular Sans text showing alignment and styles."
         )
-        if not text_lines:
-            pytest.skip("Required text line not found in test PDF")
+        assert len(text_lines) >= 1
 
         text_line = text_lines[0]