passagemath-flint 10.5.40__tar.gz → 10.5.41__tar.gz

{passagemath_flint-10.5.40 → passagemath_flint-10.5.41}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: passagemath-flint
-Version: 10.5.40
+Version: 10.5.41
 Summary: passagemath: Fast computations with MPFI and FLINT
 Author-email: The Sage Developers <sage-support@googlegroups.com>
 Maintainer: Matthias Köppe, passagemath contributors
@@ -28,8 +28,8 @@ Classifier: Programming Language :: Python :: Implementation :: CPython
 Classifier: Topic :: Scientific/Engineering :: Mathematics
 Requires-Python: <3.14,>=3.9
 Description-Content-Type: text/x-rst
-Requires-Dist: passagemath-categories~=10.5.40.0
-Requires-Dist: passagemath-ntl~=10.5.40.0
+Requires-Dist: passagemath-categories~=10.5.41.0
+Requires-Dist: passagemath-ntl~=10.5.41.0
 Requires-Dist: numpy>=1.19
 Requires-Dist: numpy>=1.22.4
 Provides-Extra: test

passagemath_flint-10.5.41/VERSION.txt

@@ -0,0 +1 @@
+10.5.41

{passagemath_flint-10.5.40 → passagemath_flint-10.5.41}/passagemath_flint.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: passagemath-flint
-Version: 10.5.40
+Version: 10.5.41
 Summary: passagemath: Fast computations with MPFI and FLINT
 Author-email: The Sage Developers <sage-support@googlegroups.com>
 Maintainer: Matthias Köppe, passagemath contributors
@@ -28,8 +28,8 @@ Classifier: Programming Language :: Python :: Implementation :: CPython
 Classifier: Topic :: Scientific/Engineering :: Mathematics
 Requires-Python: <3.14,>=3.9
 Description-Content-Type: text/x-rst
-Requires-Dist: passagemath-categories~=10.5.40.0
-Requires-Dist: passagemath-ntl~=10.5.40.0
+Requires-Dist: passagemath-categories~=10.5.41.0
+Requires-Dist: passagemath-ntl~=10.5.41.0
 Requires-Dist: numpy>=1.19
 Requires-Dist: numpy>=1.22.4
 Provides-Extra: test

{passagemath_flint-10.5.40 → passagemath_flint-10.5.41}/passagemath_flint.egg-info/requires.txt

@@ -1,5 +1,5 @@
-passagemath-categories~=10.5.40.0
-passagemath-ntl~=10.5.40.0
+passagemath-categories~=10.5.41.0
+passagemath-ntl~=10.5.41.0
 numpy>=1.19
 numpy>=1.22.4
 

{passagemath_flint-10.5.40 → passagemath_flint-10.5.41}/pyproject.toml

@@ -4,16 +4,16 @@
 # sage_conf is needed for library name of the flint library.
 requires = [
     'setuptools >= 77.0.0',
-    'passagemath-setup ~= 10.5.40.0',
-    'passagemath-conf ~= 10.5.40.0',
+    'passagemath-setup ~= 10.5.41.0',
+    'passagemath-conf ~= 10.5.41.0',
     'numpy >=1.19', 'numpy >=1.22.4',
-    'passagemath-environment ~= 10.5.40.0',
-    'passagemath-categories ~= 10.5.40.0',
-    'passagemath-modules ~= 10.5.40.0',
-    'passagemath-ntl ~= 10.5.40.0',
+    'passagemath-environment ~= 10.5.41.0',
+    'passagemath-categories ~= 10.5.41.0',
+    'passagemath-modules ~= 10.5.41.0',
+    'passagemath-ntl ~= 10.5.41.0',
     'cython >=3.0, != 3.0.3, <4.0', 'cython >=3.0.8,<3.1.0',
     'gmpy2 ~=2.1.b999',
-    'cysignals ==1.12.0rc2',
+    'cysignals >=1.11.2, != 1.12.0',
     'pkgconfig',
 ]
 build-backend = "setuptools.build_meta"
@@ -22,8 +22,8 @@ build-backend = "setuptools.build_meta"
 name = "passagemath-flint"
 description = "passagemath: Fast computations with MPFI and FLINT"
 dependencies = [
-    'passagemath-categories ~= 10.5.40.0',
-    'passagemath-ntl ~= 10.5.40.0',
+    'passagemath-categories ~= 10.5.41.0',
+    'passagemath-ntl ~= 10.5.41.0',
     'numpy >=1.19', 'numpy >=1.22.4',
 ]
 dynamic = ["version"]

{passagemath_flint-10.5.40 → passagemath_flint-10.5.41}/sage/rings/number_field/S_unit_solver.py

@@ -13,10 +13,10 @@ EXAMPLES::
     sage: x = polygen(ZZ, 'x')
     sage: K.<xi> = NumberField(x^2 + x + 1)
     sage: S = K.primes_above(3)
-    sage: expected = [((0, 1), (4, 0), xi + 2, -xi - 1),
-    ....:             ((1, -1), (0, -1), 1/3*xi + 2/3, -1/3*xi + 1/3),
+    sage: expected = [((4, 1), (4, 0), xi + 2, -xi - 1),
+    ....:             ((3, -1), (2, -1), 1/3*xi + 2/3, -1/3*xi + 1/3),
     ....:             ((1, 0), (5, 0), xi + 1, -xi),
-    ....:             ((2, 0), (5, 1), xi, -xi + 1)]
+    ....:             ((2, 0), (3, 1), xi, -xi + 1)]
     sage: sols = solve_S_unit_equation(K, S, 200)
     sage: eq_up_to_order(sols, expected)
     True
@@ -1382,7 +1382,7 @@ def defining_polynomial_for_Kp(prime, prec=106):
         sage: from sage.rings.number_field.S_unit_solver import defining_polynomial_for_Kp
         sage: K.<a> = QuadraticField(2)
         sage: p2 = K.prime_above(7); p2
-        Fractional ideal (-2*a + 1)
+        Fractional ideal (2*a - 1)
         sage: defining_polynomial_for_Kp(p2, 10)
         x + 266983762
 
@@ -1449,7 +1449,7 @@ def embedding_to_Kp(a, prime, prec):
         sage: from sage.rings.number_field.S_unit_solver import embedding_to_Kp
         sage: K.<a> = QuadraticField(17)
         sage: p = K.prime_above(13); p
-        Fractional ideal (-a + 2)
+        Fractional ideal (a - 2)
         sage: embedding_to_Kp(a-3, p, 15)
         -20542890112375827
 
@@ -1792,10 +1792,10 @@ def sieve_ordering(SUK, q):
          Residue field of Fractional ideal (2*xi + 1))
 
         sage: sieve_data[2]
-        ([18, 12, 16, 8], [18, 16, 10, 4], [18, 10, 12, 10])
+        ([18, 9, 16, 8], [18, 7, 10, 4], [18, 3, 12, 10])
 
         sage: sieve_data[3]
-        (648, 2916, 3888)
+        (972, 972, 3888)
     """
 
     K = SUK.number_field()
@@ -2171,23 +2171,23 @@ def construct_complement_dictionaries(split_primes_list, SUK, verbose=False):
         sage: SUK = K.S_unit_group(S=K.primes_above(H))
         sage: split_primes_list = [3, 7]
         sage: actual = construct_complement_dictionaries(split_primes_list, SUK)
-        sage: expected = {3: {(0, 1, 0): [(1, 0, 0), (0, 1, 0)],
-        ....:                 (1, 0, 0): [(1, 0, 0), (0, 1, 0)]},
-        ....:             7: {(0, 1, 0): [(1, 0, 0), (1, 4, 4), (1, 2, 2)],
+        sage: expected = {3: {(0, 1, 0): [(0, 1, 0), (1, 0, 0)],
+        ....:                 (1, 0, 0): [(0, 1, 0), (1, 0, 0)]},
+        ....:             7: {(0, 1, 0): [(1, 0, 0), (1, 2, 2), (1, 4, 4)],
         ....:                 (0, 1, 2): [(0, 1, 2), (0, 3, 4), (0, 5, 0)],
-        ....:                 (0, 3, 2): [(1, 0, 0), (1, 4, 4), (1, 2, 2)],
+        ....:                 (0, 3, 2): [(1, 0, 0), (1, 2, 2), (1, 4, 4)],
         ....:                 (0, 3, 4): [(0, 1, 2), (0, 3, 4), (0, 5, 0)],
         ....:                 (0, 5, 0): [(0, 1, 2), (0, 3, 4), (0, 5, 0)],
-        ....:                 (0, 5, 4): [(1, 0, 0), (1, 4, 4), (1, 2, 2)],
-        ....:                 (1, 0, 0): [(0, 5, 4), (0, 3, 2), (0, 1, 0)],
-        ....:                 (1, 0, 2): [(1, 0, 4), (1, 4, 2), (1, 2, 0)],
-        ....:                 (1, 0, 4): [(1, 2, 4), (1, 4, 0), (1, 0, 2)],
-        ....:                 (1, 2, 0): [(1, 2, 4), (1, 4, 0), (1, 0, 2)],
-        ....:                 (1, 2, 2): [(0, 5, 4), (0, 3, 2), (0, 1, 0)],
-        ....:                 (1, 2, 4): [(1, 0, 4), (1, 4, 2), (1, 2, 0)],
-        ....:                 (1, 4, 0): [(1, 0, 4), (1, 4, 2), (1, 2, 0)],
-        ....:                 (1, 4, 2): [(1, 2, 4), (1, 4, 0), (1, 0, 2)],
-        ....:                 (1, 4, 4): [(0, 5, 4), (0, 3, 2), (0, 1, 0)]}}
+        ....:                 (0, 5, 4): [(1, 0, 0), (1, 2, 2), (1, 4, 4)],
+        ....:                 (1, 0, 0): [(0, 1, 0), (0, 3, 2), (0, 5, 4)],
+        ....:                 (1, 0, 2): [(1, 0, 4), (1, 2, 0), (1, 4, 2)],
+        ....:                 (1, 0, 4): [(1, 0, 2), (1, 2, 4), (1, 4, 0)],
+        ....:                 (1, 2, 0): [(1, 0, 2), (1, 2, 4), (1, 4, 0)],
+        ....:                 (1, 2, 2): [(0, 1, 0), (0, 3, 2), (0, 5, 4)],
+        ....:                 (1, 2, 4): [(1, 0, 4), (1, 2, 0), (1, 4, 2)],
+        ....:                 (1, 4, 0): [(1, 0, 4), (1, 2, 0), (1, 4, 2)],
+        ....:                 (1, 4, 2): [(1, 0, 2), (1, 2, 4), (1, 4, 0)],
+        ....:                 (1, 4, 4): [(0, 1, 0), (0, 3, 2), (0, 5, 4)]}}
         sage: all(set(actual[p][vec]) == set(expected[p][vec])
         ....:     for p in [3, 7] for vec in expected[p])
         True
@@ -2694,9 +2694,9 @@ def sieve_below_bound(K, S, bound=10, bump=10, split_primes_list=[], verbose=Fal
         sage: SUK = UnitGroup(K, S=tuple(K.primes_above(3)))
         sage: S = SUK.primes()
         sage: sols = sieve_below_bound(K, S, 10)
-        sage: expected = [((1, -1), (0, -1), 1/3*xi + 2/3, -1/3*xi + 1/3),
-        ....:             ((0, 1), (4, 0), xi + 2, -xi - 1),
-        ....:             ((2, 0), (5, 1), xi, -xi + 1),
+        sage: expected = [((3, -1), (2, -1), 1/3*xi + 2/3, -1/3*xi + 1/3),
+        ....:             ((4, 1), (4, 0), xi + 2, -xi - 1),
+        ....:             ((2, 0), (3, 1), xi, -xi + 1),
         ....:             ((1, 0), (5, 0), xi + 1, -xi)]
         sage: eq_up_to_order(sols, expected)
         True
@@ -2759,10 +2759,10 @@ def solve_S_unit_equation(K, S, prec=106, include_exponents=True, include_bound=
         sage: K.<xi> = NumberField(x^2 + x + 1)
         sage: S = K.primes_above(3)
         sage: sols = solve_S_unit_equation(K, S, 200)
-        sage: expected = [((0, 1), (4, 0), xi + 2, -xi - 1),
-        ....:             ((1, -1), (0, -1), 1/3*xi + 2/3, -1/3*xi + 1/3),
+        sage: expected = [((4, 1), (4, 0), xi + 2, -xi - 1),
+        ....:             ((3, -1), (2, -1), 1/3*xi + 2/3, -1/3*xi + 1/3),
         ....:             ((1, 0), (5, 0), xi + 1, -xi),
-        ....:             ((2, 0), (5, 1), xi, -xi + 1)]
+        ....:             ((2, 0), (3, 1), xi, -xi + 1)]
         sage: eq_up_to_order(sols, expected)
         True
 
@@ -2770,7 +2770,7 @@ def solve_S_unit_equation(K, S, prec=106, include_exponents=True, include_bound=
 
         sage: solutions, bound = solve_S_unit_equation(K, S, 100, include_bound=True)
         sage: bound
-        7
+        6
 
     You can omit the exponent vectors::
 

{passagemath_flint-10.5.40 → passagemath_flint-10.5.41}/sage/rings/number_field/bdd_height.py

@@ -237,7 +237,8 @@ def bdd_norm_pr_ideal_gens(K, norm_list):
         sage: from sage.rings.number_field.bdd_height import bdd_norm_pr_ideal_gens
         sage: K.<g> = QuadraticField(123)
         sage: bdd_norm_pr_ideal_gens(K, range(5))
-        {0: [0], 1: [1], 2: [g + 11], 3: [], 4: [2]}
+        {0: [0], 1: [1], 2: [g + 11], 3: [], 4: [2]}  # 64-bit
+        {0: [0], 1: [1], 2: [g - 11], 3: [], 4: [2]}  # 32-bit
 
     ::
 

{passagemath_flint-10.5.40 → passagemath_flint-10.5.41}/sage/rings/number_field/class_group.py

@@ -526,9 +526,9 @@ class ClassGroup(AbelianGroupWithValues_class):
             Class group of order 68 with structure C34 x C2 of Number Field
             in a with defining polynomial x^2 + x + 23899
             sage: C.gens()
-            (Fractional ideal class (7, a + 5), Fractional ideal class (5, a + 3))
+            (Fractional ideal class (83, a + 21), Fractional ideal class (15, a + 8))
             sage: C.gens_ideals()
-            (Fractional ideal (7, a + 5), Fractional ideal (5, a + 3))
+            (Fractional ideal (83, a + 21), Fractional ideal (15, a + 8))
         """
         return self.gens_values()
 

{passagemath_flint-10.5.40 → passagemath_flint-10.5.41}/sage/rings/number_field/galois_group.py

@@ -995,9 +995,11 @@ class GaloisGroup_v2(GaloisGroup_perm):
             sage: x = polygen(ZZ, 'x')
             sage: K.<b> = NumberField(x^4 - 2*x^2 + 2, 'a').galois_closure()
             sage: G = K.galois_group()
-            sage: [G.artin_symbol(P) for P in K.primes_above(7)]  # random (see remark in primes_above)
-            [(1,4)(2,3)(5,8)(6,7), (1,4)(2,3)(5,8)(6,7),
-             (1,5)(2,6)(3,7)(4,8), (1,5)(2,6)(3,7)(4,8)]
+            sage: sorted([G.artin_symbol(P) for P in K.primes_above(7)])
+            [(1,4)(2,3)(5,8)(6,7),
+             (1,4)(2,3)(5,8)(6,7),
+             (1,5)(2,6)(3,7)(4,8),
+             (1,5)(2,6)(3,7)(4,8)]
             sage: G.artin_symbol(17)
             Traceback (most recent call last):
             ...

{passagemath_flint-10.5.40 → passagemath_flint-10.5.41}/sage/rings/number_field/number_field.py

@@ -3624,7 +3624,7 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: L.<b> = K.extension(x^2 - 3, x^2 + 1)
             sage: M.<c> = L.extension(x^2 + 1)
             sage: L.ideal(K.ideal(2, a))
-            Fractional ideal (a)
+            Fractional ideal (-a)
             sage: M.ideal(K.ideal(2, a)) == M.ideal(a*(b - c)/2)
             True
 
@@ -3667,35 +3667,37 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             ....:     print(n)
             ....:     for I in sorted(d[n]):
             ....:         print(I)
-            1
-            Fractional ideal (1)
-            2
-            Fractional ideal (2, 1/2*a - 1/2)
-            Fractional ideal (2, 1/2*a + 1/2)
-            3
-            Fractional ideal (3, 1/2*a - 1/2)
-            Fractional ideal (3, 1/2*a + 1/2)
-            4
-            Fractional ideal (2)
-            Fractional ideal (4, 1/2*a + 3/2)
-            Fractional ideal (4, 1/2*a + 5/2)
-            5
-            6
-            Fractional ideal (1/2*a - 1/2)
-            Fractional ideal (1/2*a + 1/2)
-            Fractional ideal (6, 1/2*a + 5/2)
-            Fractional ideal (6, 1/2*a + 7/2)
-            7
-            8
-            Fractional ideal (4, a - 1)
-            Fractional ideal (4, a + 1)
-            Fractional ideal (1/2*a + 3/2)
-            Fractional ideal (1/2*a - 3/2)
-            9
-            Fractional ideal (3)
-            Fractional ideal (9, 1/2*a + 7/2)
-            Fractional ideal (9, 1/2*a + 11/2)
-            10
+                1
+                Fractional ideal (1)
+                2
+                Fractional ideal (2, 1/2*a - 1/2)
+                Fractional ideal (2, 1/2*a + 1/2)
+                3
+                Fractional ideal (3, 1/2*a - 1/2)
+                Fractional ideal (3, 1/2*a + 1/2)
+                4
+                Fractional ideal (2)
+                Fractional ideal (4, 1/2*a + 3/2)
+                Fractional ideal (4, 1/2*a + 5/2)
+                5
+                6
+                Fractional ideal (-1/2*a + 1/2)
+                Fractional ideal (1/2*a + 1/2)
+                Fractional ideal (6, 1/2*a + 5/2)
+                Fractional ideal (6, 1/2*a + 7/2)
+                7
+                8
+                Fractional ideal (4, a - 1)
+                Fractional ideal (4, a + 1)
+                Fractional ideal (-1/2*a - 3/2)
+                Fractional ideal (1/2*a - 3/2)
+                9
+                Fractional ideal (3)
+                Fractional ideal (9, 1/2*a + 7/2)
+                Fractional ideal (9, 1/2*a + 11/2)
+                10
+            sage: [[I.norm() for I in sorted(d[n])] for n in d]
+                [[1], [2, 2], [3, 3], [4, 4, 4], [], [6, 6, 6, 6], [], [8, 8, 8, 8], [9, 9, 9], []]
         """
         hnf_ideals = self.pari_nf().ideallist(bound)
         d = {}
@@ -3926,8 +3928,10 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
 
             sage: K.<i> = QuadraticField(-1)
             sage: K.primes_of_bounded_norm(10)
-            [Fractional ideal (i + 1), Fractional ideal (-i - 2),
-             Fractional ideal (2*i + 1), Fractional ideal (3)]
+            [Fractional ideal (i - 1),
+             Fractional ideal (2*i - 1),
+             Fractional ideal (-2*i - 1),
+             Fractional ideal (3)]
             sage: K.primes_of_bounded_norm(1)
             []
             sage: x = polygen(QQ, 'x')
@@ -3936,10 +3940,10 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: P
             [Fractional ideal (a),
              Fractional ideal (a + 1),
-             Fractional ideal (-a^2 - 1),
+             Fractional ideal (a^2 + 1),
              Fractional ideal (a^2 + a - 1),
              Fractional ideal (2*a + 1),
-             Fractional ideal (-2*a^2 - a - 1),
+             Fractional ideal (2*a^2 + a + 1),
              Fractional ideal (a^2 - 2*a - 1),
              Fractional ideal (a + 3)]
             sage: [p.norm() for p in P]
@@ -3989,10 +3993,10 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: K.<i> = QuadraticField(-1)
             sage: it = K.primes_of_bounded_norm_iter(10)
             sage: list(it)
-            [Fractional ideal (i + 1),
+            [Fractional ideal (i - 1),
              Fractional ideal (3),
-             Fractional ideal (-i - 2),
-             Fractional ideal (2*i + 1)]
+             Fractional ideal (2*i - 1),
+             Fractional ideal (-2*i - 1)]
             sage: list(K.primes_of_bounded_norm_iter(1))
             []
         """
@@ -4317,7 +4321,7 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: k.<a> = NumberField(x^4 - 3/2*x + 5/3); k
             Number Field in a with defining polynomial x^4 - 3/2*x + 5/3
             sage: k.pari_nf()
-            [y^4 - 324*y + 2160, [0, 2], 48918708, 216, ..., [36, 36*y, y^3 + 6*y^2 - 252, 6*y^2], [1, 0, 0, 252; 0, 1, 0, 0; 0, 0, 0, 36; 0, 0, 6, -36], [1, 0, 0, 0, 0, 0, -18, 42, 0, -18, -46, -60, 0, 42, -60, -60; 0, 1, 0, 0, 1, 0, 2, 0, 0, 2, -11, -1, 0, 0, -1, 9; 0, 0, 1, 0, 0, 0, 6, 6, 1, 6, -5, 0, 0, 6, 0, 0; 0, 0, 0, 1, 0, 6, -6, -6, 0, -6, -1, 2, 1, -6, 2, 0]]
+            [y^4 - 324*y + 2160, [0, 2], 48918708, 216, ..., [36, 36*y, y^3 + 6*y^2 - 252, -6*y^2], [1, 0, 0, 252; 0, 1, 0, 0; 0, 0, 0, 36; 0, 0, -6, 36], [1, 0, 0, 0, 0, 0, -18, -42, 0, -18, -46, 60, 0, -42, 60, -60; 0, 1, 0, 0, 1, 0, 2, 0, 0, 2, -11, 1, 0, 0, 1, 9; 0, 0, 1, 0, 0, 0, 6, -6, 1, 6, -5, 0, 0, -6, 0, 0; 0, 0, 0, 1, 0, -6, 6, -6, 0, 6, 1, 2, 1, -6, 2, 0]]
             sage: pari(k)
             [y^4 - 324*y + 2160, [0, 2], 48918708, 216, ...]
             sage: gp(k)
@@ -4444,10 +4448,14 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             bnf = self._pari_bnf
         except AttributeError:
             f = self.pari_polynomial("y")
+            _saved_rand = pari.getrand()
+            # make this deterministic, it affects printing of ideals
+            pari.setrand(1)
             if units:
                 self._pari_bnf = f.bnfinit(1)
             else:
                 self._pari_bnf = f.bnfinit()
+            pari.setrand(_saved_rand)
             bnf = self._pari_bnf
         # Certify if needed
         if proof and not getattr(self, "_pari_bnf_certified", False):
@@ -4807,7 +4815,7 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
              1/13*a^2 + 7/13*a - 332/13,
              -1/13*a^2 + 6/13*a + 345/13,
              -1,
-             -2/13*a^2 - 1/13*a + 755/13]
+             1/13*a^2 - 19/13*a - 7/13]
             sage: units[5] in (1/13*a^2 - 19/13*a - 7/13, 1/13*a^2 + 20/13*a - 7/13)
             True
             sage: len(units) == 6
@@ -4818,7 +4826,8 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
 
             sage: K.<a> = NumberField(2*x^2 - 1/3)
             sage: K._S_class_group_and_units(tuple(K.primes_above(2) + K.primes_above(3)))
-            ([6*a + 2, 6*a + 3, -1, -12*a + 5], [])
+            ([6*a + 2, -6*a + 3, -1, -12*a - 5], [])  # 64-bit
+            ([6*a + 2, -6*a - 3, -1, -12*a - 5], [])  # 32-bit
         """
         K_pari = self.pari_bnf(proof=proof)
         S_pari = [p.pari_prime() for p in sorted(set(S))]
@@ -4996,7 +5005,7 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
              1/13*a^2 + 7/13*a - 332/13,
              -1/13*a^2 + 6/13*a + 345/13,
              -1,
-             -2/13*a^2 - 1/13*a + 755/13]
+             1/13*a^2 - 19/13*a - 7/13]
             sage: gens[5] in (1/13*a^2 - 19/13*a - 7/13, 1/13*a^2 + 20/13*a - 7/13)
             True
             sage: gens[6] in (-1/13*a^2 + 45/13*a - 97/13, 1/13*a^2 - 45/13*a + 97/13)
@@ -5160,9 +5169,7 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
 
             sage: [K.ideal(g).factor() for g in gens]
             [(Fractional ideal (2, a + 1)) * (Fractional ideal (3, a + 1)),
-             Fractional ideal (a),
-             (Fractional ideal (2, a + 1))^2,
-             1]
+             Fractional ideal (-a), (Fractional ideal (2, a + 1))^2, 1]
 
             sage: toKS2(10)
             (0, 0, 1, 1)
@@ -5640,7 +5647,7 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: k.<a> = NumberField(x^2 + 23)
             sage: d = k.different()
             sage: d
-            Fractional ideal (-a)
+            Fractional ideal (a)
             sage: d.norm()
             23
             sage: k.disc()
@@ -5760,7 +5767,7 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: K.elements_of_norm(3)
             []
             sage: K.elements_of_norm(50)
-            [-a - 7, 5*a - 5, 7*a + 1]
+            [7*a - 1, 5*a - 5, -7*a - 1]
 
         TESTS:
 
@@ -5872,10 +5879,9 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: K.factor(1/3)
             (Fractional ideal (3))^-1
             sage: K.factor(1+a)
-            Fractional ideal (a + 1)
+            Fractional ideal (a - 1)
             sage: K.factor(1+a/5)
-            (Fractional ideal (a + 1)) * (Fractional ideal (-a - 2))^-1
-              * (Fractional ideal (2*a + 1))^-1 * (Fractional ideal (-2*a + 3))
+            (Fractional ideal (a - 1)) * (Fractional ideal (2*a - 1))^-1 * (Fractional ideal (-2*a - 1))^-1 * (Fractional ideal (3*a + 2))
 
         An example over a relative number field::
 
@@ -5908,9 +5914,9 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: (fi, fj) = f[::]
             sage: (fi[1], fj[1])
             (1, 1)
-            sage: fi[0] == L.fractional_ideal(1/2*a*b - a + 1/2)
+            sage: fi[0] == L.fractional_ideal(-1/2*a*b - a + 1/2)
             True
-            sage: fj[0] == L.fractional_ideal(-1/2*a*b - a + 1/2)
+            sage: fj[0] == L.fractional_ideal(1/2*a*b - a + 1/2)
             True
         """
         return self.ideal(n).factor()
@@ -6524,13 +6530,15 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
         # the inner product on the Minkowski embedding, which is
         # faster than computing all the conjugates, etc ...
 
+        # flag to disable FLATTER, which is much more unstable than fplll
+        flag = 1 if pari.version() >= (2,17) else 0
         if self.is_totally_real():
             from sage.matrix.constructor import matrix
             M = matrix(ZZ, d, d, [[(x*y).trace() for x in ZK] for y in ZK])
-            T = pari(M).qflllgram()
+            T = pari(M).qflllgram(flag=flag)
         else:
             M = self.minkowski_embedding(ZK, prec=prec)
-            T = pari(M).qflll()
+            T = pari(M).qflll(flag=flag)
 
         return [sum([ZZ(T[i][j]) * ZK[j] for j in range(d)]) for i in range(d)]
 
@@ -7108,14 +7116,14 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: K.units(proof=True)  # takes forever, not tested
             ...
             sage: K.units(proof=False)  # result not independently verified
-            (-a^9 - a + 1,
+            (a^9 + a - 1,
+             -a^15 + a^12 - a^10 + a^9 + 2*a^8 - 3*a^7 - a^6 + 3*a^5 - a^4 - 4*a^3 + 3*a^2 + 2*a - 2,
+             a^15 + a^14 + a^13 + a^12 + a^10 - a^7 - a^6 - a^2 - 1,
+             2*a^16 - 3*a^15 + 3*a^14 - 3*a^13 + 3*a^12 - a^11 + a^9 - 3*a^8 + 4*a^7 - 5*a^6 + 6*a^5 - 4*a^4 + 3*a^3 - 2*a^2 - 2*a + 4,
              -a^16 + a^15 - a^14 + a^12 - a^11 + a^10 + a^8 - a^7 + 2*a^6 - a^4 + 3*a^3 - 2*a^2 + 2*a - 1,
-             2*a^16 - a^14 - a^13 + 3*a^12 - 2*a^10 + a^9 + 3*a^8 - 3*a^6 + 3*a^5 + 3*a^4 - 2*a^3 - 2*a^2 + 3*a + 4,
-             a^15 + a^14 + 2*a^11 + a^10 - a^9 + a^8 + 2*a^7 - a^5 + 2*a^3 - a^2 - 3*a + 1,
-             -a^16 - a^15 - a^14 - a^13 - a^12 - a^11 - a^10 - a^9 - a^8 - a^7 - a^6 - a^5 - a^4 - a^3 - a^2 + 2,
-             -2*a^16 + 3*a^15 - 3*a^14 + 3*a^13 - 3*a^12 + a^11 - a^9 + 3*a^8 - 4*a^7 + 5*a^6 - 6*a^5 + 4*a^4 - 3*a^3 + 2*a^2 + 2*a - 4,
-             a^15 - a^12 + a^10 - a^9 - 2*a^8 + 3*a^7 + a^6 - 3*a^5 + a^4 + 4*a^3 - 3*a^2 - 2*a + 2,
-             2*a^16 + a^15 - a^11 - 3*a^10 - 4*a^9 - 4*a^8 - 4*a^7 - 5*a^6 - 7*a^5 - 8*a^4 - 6*a^3 - 5*a^2 - 6*a - 7)
+             a^16 - 2*a^15 - 2*a^13 - a^12 - a^11 - 2*a^10 + a^9 - 2*a^8 + 2*a^7 - 3*a^6 - 3*a^4 - 2*a^3 - a^2 - 4*a + 2,
+             -a^15 - a^14 - 2*a^11 - a^10 + a^9 - a^8 - 2*a^7 + a^5 - 2*a^3 + a^2 + 3*a - 1,
+             -3*a^16 - 3*a^15 - 3*a^14 - 3*a^13 - 3*a^12 - 2*a^11 - 2*a^10 - 2*a^9 - a^8 + a^7 + 2*a^6 + 3*a^5 + 3*a^4 + 4*a^3 + 6*a^2 + 8*a + 8)
 
         TESTS:
 
@@ -7124,7 +7132,7 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
 
             sage: K.<a> = NumberField(1/2*x^2 - 1/6)
             sage: K.units()
-            (3*a - 2,)
+            (3*a + 2,)
         """
         proof = proof_flag(proof)
 
@@ -7206,14 +7214,14 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             (u0, u1, u2, u3, u4, u5, u6, u7, u8)
             sage: U.gens_values()  # result not independently verified
             [-1,
-             -a^9 - a + 1,
+             a^9 + a - 1,
+             -a^15 + a^12 - a^10 + a^9 + 2*a^8 - 3*a^7 - a^6 + 3*a^5 - a^4 - 4*a^3 + 3*a^2 + 2*a - 2,
+             a^15 + a^14 + a^13 + a^12 + a^10 - a^7 - a^6 - a^2 - 1,
+             2*a^16 - 3*a^15 + 3*a^14 - 3*a^13 + 3*a^12 - a^11 + a^9 - 3*a^8 + 4*a^7 - 5*a^6 + 6*a^5 - 4*a^4 + 3*a^3 - 2*a^2 - 2*a + 4,
              -a^16 + a^15 - a^14 + a^12 - a^11 + a^10 + a^8 - a^7 + 2*a^6 - a^4 + 3*a^3 - 2*a^2 + 2*a - 1,
-             2*a^16 - a^14 - a^13 + 3*a^12 - 2*a^10 + a^9 + 3*a^8 - 3*a^6 + 3*a^5 + 3*a^4 - 2*a^3 - 2*a^2 + 3*a + 4,
-             a^15 + a^14 + 2*a^11 + a^10 - a^9 + a^8 + 2*a^7 - a^5 + 2*a^3 - a^2 - 3*a + 1,
-             -a^16 - a^15 - a^14 - a^13 - a^12 - a^11 - a^10 - a^9 - a^8 - a^7 - a^6 - a^5 - a^4 - a^3 - a^2 + 2,
-             -2*a^16 + 3*a^15 - 3*a^14 + 3*a^13 - 3*a^12 + a^11 - a^9 + 3*a^8 - 4*a^7 + 5*a^6 - 6*a^5 + 4*a^4 - 3*a^3 + 2*a^2 + 2*a - 4,
-             a^15 - a^12 + a^10 - a^9 - 2*a^8 + 3*a^7 + a^6 - 3*a^5 + a^4 + 4*a^3 - 3*a^2 - 2*a + 2,
-             2*a^16 + a^15 - a^11 - 3*a^10 - 4*a^9 - 4*a^8 - 4*a^7 - 5*a^6 - 7*a^5 - 8*a^4 - 6*a^3 - 5*a^2 - 6*a - 7]
+             a^16 - 2*a^15 - 2*a^13 - a^12 - a^11 - 2*a^10 + a^9 - 2*a^8 + 2*a^7 - 3*a^6 - 3*a^4 - 2*a^3 - a^2 - 4*a + 2,
+             -a^15 - a^14 - 2*a^11 - a^10 + a^9 - a^8 - 2*a^7 + a^5 - 2*a^3 + a^2 + 3*a - 1,
+             -3*a^16 - 3*a^15 - 3*a^14 - 3*a^13 - 3*a^12 - 2*a^11 - 2*a^10 - 2*a^9 - a^8 + a^7 + 2*a^6 + 3*a^5 + 3*a^4 + 4*a^3 + 6*a^2 + 8*a + 8]
         """
         proof = proof_flag(proof)
 
@@ -7262,8 +7270,8 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: U = K.S_unit_group(S=a); U
             S-unit group with structure C10 x Z x Z x Z of
              Number Field in a with defining polynomial x^4 - 10*x^3 + 100*x^2 - 375*x + 1375
-             with S = (Fractional ideal (5, 1/275*a^3 + 4/55*a^2 - 5/11*a + 5),
-                       Fractional ideal (11, 1/275*a^3 + 4/55*a^2 - 5/11*a + 9))
+             with S = (Fractional ideal (5, -7/275*a^3 + 1/11*a^2 - 9/11*a),
+                       Fractional ideal (11, -7/275*a^3 + 1/11*a^2 - 9/11*a + 3))
             sage: U.gens()
             (u0, u1, u2, u3)
             sage: U.gens_values()  # random
@@ -7274,8 +7282,8 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: [u.multiplicative_order() for u in U.gens()]
             [10, +Infinity, +Infinity, +Infinity]
             sage: U.primes()
-            (Fractional ideal (5, 1/275*a^3 + 4/55*a^2 - 5/11*a + 5),
-             Fractional ideal (11, 1/275*a^3 + 4/55*a^2 - 5/11*a + 9))
+            (Fractional ideal (5, -7/275*a^3 + 1/11*a^2 - 9/11*a),
+             Fractional ideal (11, -7/275*a^3 + 1/11*a^2 - 9/11*a + 3))
 
         With the default value of `S`, the S-unit group is the same as
         the global unit group::
@@ -7428,7 +7436,7 @@ class NumberField_generic(WithEqualityById, number_field_base.NumberField):
             sage: # needs fpylll sage.rings.padics sage.symbolic
             sage: solutions, bound = K.S_unit_solutions(S, prec=100, include_bound=True)
             sage: bound
-            7
+            6
         """
         from .S_unit_solver import solve_S_unit_equation
         return solve_S_unit_equation(self, S, prec, include_exponents, include_bound, proof)
@@ -8786,10 +8794,40 @@ class NumberField_absolute(NumberField_generic):
         polynomials are supported (:issue:`252`)::
 
             sage: K.<a> = NumberField(2*x^4 + 6*x^2 + 1/2)
-            sage: K
-            Number Field in a with defining polynomial 2*x^4 + 6*x^2 + 1/2
-            sage: sorted([F.discriminant() for F, _, _ in K.subfields()])
-            [-8, -4, 1, 8, 256]
+            sage: K.subfields()
+            [(Number Field in a0 with defining polynomial x,
+              Ring morphism:
+                From: Number Field in a0 with defining polynomial x
+                To:   Number Field in a with defining polynomial 2*x^4 + 6*x^2 + 1/2
+                Defn: 0 |--> 0,
+              None),
+             (Number Field in a1 with defining polynomial x^2 - 2,
+              Ring morphism:
+                From: Number Field in a1 with defining polynomial x^2 - 2
+                To:   Number Field in a with defining polynomial 2*x^4 + 6*x^2 + 1/2
+                Defn: a1 |--> -a^2 - 3/2,
+              None),
+             (Number Field in a2 with defining polynomial x^2 + 4,
+              Ring morphism:
+                From: Number Field in a2 with defining polynomial x^2 + 4
+                To:   Number Field in a with defining polynomial 2*x^4 + 6*x^2 + 1/2
+                Defn: a2 |--> 2*a^3 + 7*a,
+              None),
+             (Number Field in a3 with defining polynomial x^2 + 2,
+              Ring morphism:
+                From: Number Field in a3 with defining polynomial x^2 + 2
+                To:   Number Field in a with defining polynomial 2*x^4 + 6*x^2 + 1/2
+                Defn: a3 |--> -2*a^3 - 5*a,
+              None),
+             (Number Field in a4 with defining polynomial x^4 + 1,
+              Ring morphism:
+                From: Number Field in a4 with defining polynomial x^4 + 1
+                To:   Number Field in a with defining polynomial 2*x^4 + 6*x^2 + 1/2
+                Defn: a4 |--> -a^3 - 1/2*a^2 - 5/2*a - 3/4,
+              Ring morphism:
+                From: Number Field in a with defining polynomial 2*x^4 + 6*x^2 + 1/2
+                To:   Number Field in a4 with defining polynomial x^4 + 1
+                Defn: a |--> 1/2*a4^3 + a4^2 + 1/2*a4)]
         """
         return self._subfields_helper(degree=degree, name=name,
                                       both_maps=True, optimize=False)