pactkit 2.3.3__tar.gz → 2.3.5__tar.gz

{pactkit-2.3.3 → pactkit-2.3.5}/.opencode/pactkit.yaml

@@ -2,7 +2,7 @@
 # Edit this file to customize which components are deployed.
 # Remove items from a list to disable them. Default: all enabled.
 
-version: "2.3.3"
+version: "2.3.4"
 stack: python
 root: .
 developer: "slim"

{pactkit-2.3.3 → pactkit-2.3.5}/CHANGELOG.md

@@ -4,6 +4,20 @@ All notable changes to PactKit will be documented in this file.
 
 Format follows [Keep a Changelog](https://keepachangelog.com/).
 
+## [2.3.5] - 2026-03-23
+
+### Fixed
+- **W007 RFC 2119 Detection** — W007 now detects all RFC 2119 keywords (MUST, SHOULD, MAY, SHALL, REQUIRED, RECOMMENDED, OPTIONAL) using canonical `SPEC_RFC_KEYWORDS` from schemas.py, instead of hardcoding only SHOULD.
+
+## [2.3.4] - 2026-03-23
+
+### Added
+- **Spec Lint W007 — Req-AC Coverage** (STORY-slim-024) — New warning rule fires when `### R{N}:` requirements are not referenced by any `### AC{M}:` body. Helps catch SHOULD requirements that get overlooked. Message includes `(SHOULD)` indicator for unreferenced SHOULD requirements.
+
+### Fixed
+- **E2E Config Fields** — `api_spec` and `compose_file` now included in `generate_default_yaml()` output (were commented out, breaking roundtrip tests).
+- **Test Fixtures** — Updated test fixtures to include `e2e` section after HOTFIX-slim-025 added new fields.
+
 ## [2.3.3] - 2026-03-23
 
 ### Added

{pactkit-2.3.3 → pactkit-2.3.5}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pactkit
-Version: 2.3.3
+Version: 2.3.5
 Summary: Spec-driven agentic DevOps toolkit for AI coding assistants
 Project-URL: Homepage, https://pactkit.dev
 Project-URL: Repository, https://github.com/pactkit/pactkit

{pactkit-2.3.3 → pactkit-2.3.5}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "pactkit"
-version = "2.3.3"
+version = "2.3.5"
 description = "Spec-driven agentic DevOps toolkit for AI coding assistants"
 readme = "README.md"
 license = "MIT"

{pactkit-2.3.3 → pactkit-2.3.5}/src/pactkit/__init__.py

@@ -1,3 +1,3 @@
 """PactKit - Spec-driven agentic DevOps toolkit."""
 
-__version__ = "2.3.3"
+__version__ = "2.3.5"

{pactkit-2.3.3 → pactkit-2.3.5}/src/pactkit/config.py

@@ -172,6 +172,8 @@ def get_default_config() -> dict:
             "blocking": False,
             "test_dir": "tests/e2e",
             "env_file": ".env.test",
+            "api_spec": "",  # HOTFIX-slim-025: OpenAPI spec for frontend/backend E2E
+            "compose_file": "docker-compose.test.yml",  # HOTFIX-slim-025: for fullstack E2E
         },
         "done": {
             "lesson_quality_threshold": 15,
@@ -830,6 +832,17 @@ def validate_config(config: dict) -> None:
             warnings.warn(
                 f"e2e.env_file should be a string, got {type(e2e_env_file).__name__}"
             )
+        # HOTFIX-slim-025: validate api_spec and compose_file
+        e2e_api_spec = e2e.get("api_spec")
+        if e2e_api_spec is not None and not isinstance(e2e_api_spec, str):
+            warnings.warn(
+                f"e2e.api_spec should be a string, got {type(e2e_api_spec).__name__}"
+            )
+        e2e_compose_file = e2e.get("compose_file")
+        if e2e_compose_file is not None and not isinstance(e2e_compose_file, str):
+            warnings.warn(
+                f"e2e.compose_file should be a string, got {type(e2e_compose_file).__name__}"
+            )
 
     # enterprise section (STORY-047) — accepted without warnings
     # multi_agent field (STORY-046) — accepted without warnings
@@ -945,6 +958,8 @@ def generate_default_yaml() -> str:
     lines.append(f"  blocking: {'true' if e2e.get('blocking') else 'false'}")
     lines.append(f"  test_dir: {e2e.get('test_dir', 'tests/e2e')}")
     lines.append(f"  env_file: {e2e.get('env_file', '.env.test')}")
+    lines.append(f"  api_spec: \"{e2e.get('api_spec', '')}\"  # OpenAPI spec path for frontend/backend")
+    lines.append(f"  compose_file: {e2e.get('compose_file', 'docker-compose.test.yml')}  # for fullstack")
 
     # Write command_models section (STORY-073)
     cmd_models = cfg.get("command_models", {})

{pactkit-2.3.3 → pactkit-2.3.5}/src/pactkit/skills/spec_linter.py

@@ -23,6 +23,7 @@ try:
         SPEC_REQUIRED_METADATA_FIELDS,
         SPEC_REQUIRED_SECTIONS,
         SPEC_REQUIREMENT_PATTERN,
+        SPEC_RFC_KEYWORDS,
         SPEC_RFC_PATTERN,
         SPEC_VALID_STATUSES,
     )
@@ -34,6 +35,7 @@ except ImportError:
     SPEC_REQUIREMENT_PATTERN = r"### R\d+[:\s]"
     SPEC_AC_PATTERN = r"### AC\d+[:\s]|### Scenario\s+\d+[:\s]"
     SPEC_GIVEN_WHEN_THEN = ("Given", "When", "Then")
+    SPEC_RFC_KEYWORDS = ("MUST", "SHOULD", "MAY", "SHALL", "REQUIRED", "RECOMMENDED", "OPTIONAL")
     SPEC_RFC_PATTERN = re.compile(r"\b(MUST|SHOULD|MAY|SHALL|REQUIRED|RECOMMENDED|OPTIONAL)\b")
     SPEC_VALID_STATUSES = ("Draft", "In Progress", "Done")
 
@@ -197,6 +199,54 @@ def _check_acceptance_criteria(text: str, result: LintResult) -> None:
 
 _PIPE_TABLE_ROW = re.compile(r"^\|.+\|.+\|", re.MULTILINE)
 
+# STORY-slim-024: R{N} ID extraction pattern
+_REQ_ID_PATTERN = re.compile(r"###\s+(R\d+)[:\s]", re.MULTILINE)
+
+
+def _extract_requirement_ids(req_section: str) -> dict[str, str]:
+    """Extract R{N} IDs and their body text from Requirements section.
+
+    Returns dict mapping R{N} (e.g., "R1") to the requirement body text.
+    """
+    result: dict[str, str] = {}
+    # Find all ### R{N}: headers
+    matches = list(_REQ_ID_PATTERN.finditer(req_section))
+    for i, m in enumerate(matches):
+        req_id = m.group(1).upper()  # Normalize to uppercase (R1, R2, etc.)
+        # Body is from end of this header to start of next (or end of section)
+        start = m.end()
+        end = matches[i + 1].start() if i + 1 < len(matches) else len(req_section)
+        body = req_section[start:end].strip()
+        result[req_id] = body
+    return result
+
+
+def _check_req_ac_coverage(text: str, result: LintResult) -> None:
+    """W007 — Check that all R{N} are referenced by at least one AC."""
+    req_section = _section_text(text, "Requirements")
+    ac_section = _section_text(text, "Acceptance Criteria")
+
+    if req_section is None or ac_section is None:
+        return  # Missing sections are handled by E003/E005
+
+    # Extract all R{N} IDs and their bodies
+    req_map = _extract_requirement_ids(req_section)
+    if not req_map:
+        return  # No requirements found (handled by E004)
+
+    # Check each R{N} for coverage in AC section
+    ac_lower = ac_section.lower()
+    for req_id, req_body in req_map.items():
+        # Case-insensitive search for R{N} as word boundary
+        if req_id.lower() not in ac_lower:
+            # Detect RFC 2119 keyword in requirement body (use canonical list from schemas)
+            req_upper = req_body.upper()
+            found_keyword = next((kw for kw in SPEC_RFC_KEYWORDS if kw in req_upper), None)
+            emphasis = f" ({found_keyword})" if found_keyword else ""
+            result.warnings.append(
+                LintIssue("W007", f"Requirement {req_id} has no corresponding AC reference{emphasis}")
+            )
+
 
 def _check_implementation_steps(text: str, result: LintResult) -> None:
     """W005 — Implementation Steps table format validation (STORY-055)."""
@@ -254,6 +304,7 @@ def validate_spec(spec_path: str) -> LintResult:
     _check_acceptance_criteria(text, result)
     _check_optional_sections(text, result)
     _check_implementation_steps(text, result)
+    _check_req_ac_coverage(text, result)  # STORY-slim-024: W007
     return result
 
 

{pactkit-2.3.3 → pactkit-2.3.5}/tests/unit/test_config.py

@@ -247,16 +247,16 @@ class TestCommonModeRemoved:
         test_dir = Path(__file__).resolve().parent
         assert not (test_dir / "test_common_user.py").exists()
 
-    def test_cli_no_mode_flag(self):
-
-        # Verify --mode is not in the CLI by checking the source
+    def test_cli_no_common_mode_flag(self):
+        # Verify common_user mode is not in the CLI
+        # Note: --mode exists for visualize (HOTFIX-slim-023), but common_user is removed
         import inspect
 
         from pactkit.cli import main
 
         source = inspect.getsource(main)
-        assert "--mode" not in source
         assert "common_user" not in source
+        assert "common-user" not in source
 
 
 # ===========================================================================

{pactkit-2.3.3 → pactkit-2.3.5}/tests/unit/test_config_auto_merge.py

@@ -281,6 +281,8 @@ class TestBackwardCompatibility:
             'hooks': {'pre_commit_lint': False, 'post_test_coverage': False, 'pre_push_check': False},
             'lint_blocking': False,
             'auto_fix': False,
+            'e2e': {'type': 'none', 'blocking': False, 'test_dir': 'tests/e2e', 'env_file': '.env.test',
+                    'api_spec': '', 'compose_file': 'docker-compose.test.yml'},
             'venv': {'auto_detect': True},
             'release': {'github_release': False},
             'regression': {'strategy': 'impact', 'max_impact_tests': 50},
@@ -402,6 +404,8 @@ class TestDeployerIntegration:
             'hooks': {'pre_commit_lint': False, 'post_test_coverage': False, 'pre_push_check': False},
             'lint_blocking': False,
             'auto_fix': False,
+            'e2e': {'type': 'none', 'blocking': False, 'test_dir': 'tests/e2e', 'env_file': '.env.test',
+                    'api_spec': '', 'compose_file': 'docker-compose.test.yml'},
             'venv': {'auto_detect': True},
             'release': {'github_release': False},
             'regression': {'strategy': 'impact', 'max_impact_tests': 50},

{pactkit-2.3.3 → pactkit-2.3.5}/tests/unit/test_story033_config_backfill.py

@@ -220,6 +220,7 @@ class TestAC4BackfillReport:
             'issue_tracker:\n  provider: none\n'
             'lint_blocking: false\n'
             'auto_fix: false\n'
+            'e2e:\n  type: none\n'
             'venv:\n  auto_detect: true\n'
             'release:\n  github_release: false\n'
             'regression:\n  strategy: impact\n  max_impact_tests: 50\n'
@@ -236,8 +237,8 @@ class TestAC4BackfillReport:
         yaml_path.write_text('stack: python\nversion: "1.2.0"\nroot: .\n')
         result = auto_merge_config_file(yaml_path)
         section_reports = [r for r in result if r.startswith('section:')]
-        # 4 list-type (agents, commands, skills, rules) + 10 non-list (ci, issue_tracker, hooks, lint_blocking, auto_fix, venv, release, regression, check, done)
-        assert len(section_reports) == 14
+        # 4 list-type (agents, commands, skills, rules) + 11 non-list (ci, issue_tracker, hooks, lint_blocking, auto_fix, e2e, venv, release, regression, check, done)
+        assert len(section_reports) == 15
 
 
 # ===========================================================================

{pactkit-2.3.3 → pactkit-2.3.5}/tests/unit/test_story042_spec_linter.py

@@ -35,9 +35,9 @@ This requirement MUST be satisfied.
 
 ## Acceptance Criteria
 
-### AC1: Happy Path
+### AC1: Happy Path (R1)
 **Given** a valid input
-**When** the action is taken
+**When** R1 action is taken
 **Then** the result is correct
 
 ## Out of Scope
@@ -184,7 +184,7 @@ class TestE005AcceptanceCriteria:
 class TestE006ACSubsections:
     def test_no_AC_subsection_raises_E006(self, tmp_path):
         content = MINIMAL_VALID_SPEC.replace(
-            "### AC1: Happy Path\n**Given** a valid input\n**When** the action is taken\n**Then** the result is correct\n",
+            "### AC1: Happy Path (R1)\n**Given** a valid input\n**When** R1 action is taken\n**Then** the result is correct\n",
             "Just some text.\n"
         )
         spec = write_spec(tmp_path, content)
@@ -194,8 +194,8 @@ class TestE006ACSubsections:
 
     def test_scenario_prefix_accepted_no_E006(self, tmp_path):
         content = MINIMAL_VALID_SPEC.replace(
-            "### AC1: Happy Path\n**Given** a valid input\n**When** the action is taken\n**Then** the result is correct\n",
-            "### Scenario 1: Happy Path\n**Given** a valid input\n**When** the action is taken\n**Then** the result is correct\n"
+            "### AC1: Happy Path (R1)\n**Given** a valid input\n**When** R1 action is taken\n**Then** the result is correct\n",
+            "### Scenario 1: Happy Path (R1)\n**Given** a valid input\n**When** R1 action is taken\n**Then** the result is correct\n"
         )
         spec = write_spec(tmp_path, content)
         result = validate_spec(str(spec))
@@ -216,8 +216,8 @@ class TestE006ACSubsections:
 class TestE007GivenWhenThen:
     def test_missing_given_raises_E007(self, tmp_path):
         content = MINIMAL_VALID_SPEC.replace(
-            "**Given** a valid input\n**When** the action is taken\n**Then** the result is correct\n",
-            "**When** the action is taken\n**Then** the result is correct\n"
+            "**Given** a valid input\n**When** R1 action is taken\n**Then** the result is correct\n",
+            "**When** R1 action is taken\n**Then** the result is correct\n"
         )
         spec = write_spec(tmp_path, content)
         result = validate_spec(str(spec))
@@ -226,8 +226,8 @@ class TestE007GivenWhenThen:
 
     def test_missing_when_raises_E007(self, tmp_path):
         content = MINIMAL_VALID_SPEC.replace(
-            "**Given** a valid input\n**When** the action is taken\n**Then** the result is correct\n",
-            "**Given** a valid input\n**Then** the result is correct\n"
+            "**Given** a valid input\n**When** R1 action is taken\n**Then** the result is correct\n",
+            "**Given** a valid input\n**Then** R1 result is correct\n"
         )
         spec = write_spec(tmp_path, content)
         result = validate_spec(str(spec))
@@ -236,8 +236,8 @@ class TestE007GivenWhenThen:
 
     def test_missing_then_raises_E007(self, tmp_path):
         content = MINIMAL_VALID_SPEC.replace(
-            "**Given** a valid input\n**When** the action is taken\n**Then** the result is correct\n",
-            "**Given** a valid input\n**When** the action is taken\n"
+            "**Given** a valid input\n**When** R1 action is taken\n**Then** the result is correct\n",
+            "**Given** a valid input\n**When** R1 action is taken\n"
         )
         spec = write_spec(tmp_path, content)
         result = validate_spec(str(spec))
@@ -246,8 +246,8 @@ class TestE007GivenWhenThen:
 
     def test_case_insensitive_keywords_no_E007(self, tmp_path):
         content = MINIMAL_VALID_SPEC.replace(
-            "**Given** a valid input\n**When** the action is taken\n**Then** the result is correct\n",
-            "given a valid input\nwhen the action is taken\nthen the result is correct\n"
+            "**Given** a valid input\n**When** R1 action is taken\n**Then** the result is correct\n",
+            "given a valid input\nwhen R1 action is taken\nthen the result is correct\n"
         )
         spec = write_spec(tmp_path, content)
         result = validate_spec(str(spec))

{pactkit-2.3.3 → pactkit-2.3.5}/tests/unit/test_story_slim022.py

@@ -71,6 +71,8 @@ class TestR2DefaultConfig:
             "blocking": False,
             "test_dir": "tests/e2e",
             "env_file": ".env.test",
+            "api_spec": "",  # HOTFIX-slim-025
+            "compose_file": "docker-compose.test.yml",  # HOTFIX-slim-025
         }
 
 

pactkit-2.3.5/tests/unit/test_story_slim024.py

@@ -0,0 +1,283 @@
+"""Tests for STORY-slim-024: Spec Lint W007 — Requirement-AC Coverage Check."""
+
+import tempfile
+
+from pactkit.skills.spec_linter import validate_spec
+
+
+class TestAC1W007FiresOnUnreferencedRN:
+    """AC1: W007 fires when R{N} is not referenced by any AC."""
+
+    def test_unreferenced_r3_triggers_w007(self):
+        """R3 not referenced in any AC should trigger W007."""
+        spec = """\
+| Field | Value |
+|-------|-------|
+| ID | TEST-001 |
+| Status | Draft |
+| Priority | P2 |
+| Release | 1.0.0 |
+
+## Background
+Test background.
+
+## Requirements
+
+### R1: First requirement
+Something MUST happen.
+
+### R2: Second requirement
+Something SHOULD happen.
+
+### R3: Third requirement
+Something MAY happen.
+
+## Acceptance Criteria
+
+### AC1: Test R1
+Given a condition
+When R1 is tested
+Then it passes
+
+### AC2: Test R2
+Given another condition
+When R2 is verified
+Then it works
+"""
+        with tempfile.NamedTemporaryFile(mode="w", suffix=".md", delete=False) as f:
+            f.write(spec)
+            f.flush()
+            result = validate_spec(f.name)
+
+        w007_warnings = [w for w in result.warnings if w.rule_id == "W007"]
+        assert len(w007_warnings) == 1
+        assert "R3" in w007_warnings[0].message
+
+
+class TestAC2NoW007WhenAllCovered:
+    """AC2: No W007 when all R{N} are covered by AC."""
+
+    def test_all_covered_no_w007(self):
+        """When every R{N} is referenced, no W007 should be emitted."""
+        spec = """\
+| Field | Value |
+|-------|-------|
+| ID | TEST-002 |
+| Status | Draft |
+| Priority | P2 |
+| Release | 1.0.0 |
+
+## Background
+Test background.
+
+## Requirements
+
+### R1: First requirement
+Something MUST happen.
+
+### R2: Second requirement
+Something SHOULD happen.
+
+## Acceptance Criteria
+
+### AC1: Test R1 and R2
+Given a condition
+When R1 is tested and R2 is verified
+Then both pass
+"""
+        with tempfile.NamedTemporaryFile(mode="w", suffix=".md", delete=False) as f:
+            f.write(spec)
+            f.flush()
+            result = validate_spec(f.name)
+
+        w007_warnings = [w for w in result.warnings if w.rule_id == "W007"]
+        assert len(w007_warnings) == 0
+
+
+class TestAC3CaseInsensitiveMatching:
+    """AC3: R{N} matching should be case insensitive."""
+
+    def test_lowercase_r1_is_covered(self):
+        """'r1' in AC body should count as coverage for R1."""
+        spec = """\
+| Field | Value |
+|-------|-------|
+| ID | TEST-003 |
+| Status | Draft |
+| Priority | P2 |
+| Release | 1.0.0 |
+
+## Background
+Test background.
+
+## Requirements
+
+### R1: First requirement
+Something MUST happen.
+
+## Acceptance Criteria
+
+### AC1: Test lowercase reference
+Given a condition
+When r1 is tested (lowercase)
+Then it passes
+"""
+        with tempfile.NamedTemporaryFile(mode="w", suffix=".md", delete=False) as f:
+            f.write(spec)
+            f.flush()
+            result = validate_spec(f.name)
+
+        w007_warnings = [w for w in result.warnings if w.rule_id == "W007"]
+        assert len(w007_warnings) == 0
+
+
+class TestAC4W007DoesNotBlock:
+    """AC4: W007 is a warning, does not cause lint failure."""
+
+    def test_w007_does_not_fail(self):
+        """Spec with only W007 should still pass (warnings don't block)."""
+        spec = """\
+| Field | Value |
+|-------|-------|
+| ID | TEST-004 |
+| Status | Draft |
+| Priority | P2 |
+| Release | 1.0.0 |
+
+## Background
+Test background.
+
+## Requirements
+
+### R1: First requirement
+Something MUST happen.
+
+## Acceptance Criteria
+
+### AC1: Test something else
+Given a condition
+When something is tested
+Then it passes
+"""
+        with tempfile.NamedTemporaryFile(mode="w", suffix=".md", delete=False) as f:
+            f.write(spec)
+            f.flush()
+            result = validate_spec(f.name)
+
+        # W007 should be emitted (R1 not referenced)
+        w007_warnings = [w for w in result.warnings if w.rule_id == "W007"]
+        assert len(w007_warnings) == 1
+        # But result should still pass (warnings don't block)
+        assert result.passed is True
+
+
+class TestAC5RFC2119Emphasis:
+    """AC5: W007 message should indicate RFC 2119 keyword in unreferenced req."""
+
+    def test_should_indicator_in_message(self):
+        """Uncovered SHOULD requirement should have (SHOULD) in warning message."""
+        spec = """\
+| Field | Value |
+|-------|-------|
+| ID | TEST-005 |
+| Status | Draft |
+| Priority | P2 |
+| Release | 1.0.0 |
+
+## Background
+Test background.
+
+## Requirements
+
+### R1: First requirement
+Something MUST happen.
+
+### R2: Second requirement
+Something SHOULD happen but might be forgotten.
+
+## Acceptance Criteria
+
+### AC1: Test R1 only
+Given a condition
+When R1 is tested
+Then it passes
+"""
+        with tempfile.NamedTemporaryFile(mode="w", suffix=".md", delete=False) as f:
+            f.write(spec)
+            f.flush()
+            result = validate_spec(f.name)
+
+        w007_warnings = [w for w in result.warnings if w.rule_id == "W007"]
+        assert len(w007_warnings) == 1
+        assert "R2" in w007_warnings[0].message
+        assert "(SHOULD)" in w007_warnings[0].message
+
+    def test_must_indicator_in_message(self):
+        """Uncovered MUST requirement should have (MUST) in warning message."""
+        spec = """\
+| Field | Value |
+|-------|-------|
+| ID | TEST-006 |
+| Status | Draft |
+| Priority | P2 |
+| Release | 1.0.0 |
+
+## Background
+Test background.
+
+## Requirements
+
+### R1: First requirement
+Something MUST be implemented.
+
+## Acceptance Criteria
+
+### AC1: Test something else
+Given a condition
+When something unrelated is tested
+Then it passes
+"""
+        with tempfile.NamedTemporaryFile(mode="w", suffix=".md", delete=False) as f:
+            f.write(spec)
+            f.flush()
+            result = validate_spec(f.name)
+
+        w007_warnings = [w for w in result.warnings if w.rule_id == "W007"]
+        assert len(w007_warnings) == 1
+        assert "R1" in w007_warnings[0].message
+        assert "(MUST)" in w007_warnings[0].message
+
+    def test_may_indicator_in_message(self):
+        """Uncovered MAY requirement should have (MAY) in warning message."""
+        spec = """\
+| Field | Value |
+|-------|-------|
+| ID | TEST-007 |
+| Status | Draft |
+| Priority | P2 |
+| Release | 1.0.0 |
+
+## Background
+Test background.
+
+## Requirements
+
+### R1: Optional feature
+Something MAY be implemented optionally.
+
+## Acceptance Criteria
+
+### AC1: Test something else
+Given a condition
+When something unrelated is tested
+Then it passes
+"""
+        with tempfile.NamedTemporaryFile(mode="w", suffix=".md", delete=False) as f:
+            f.write(spec)
+            f.flush()
+            result = validate_spec(f.name)
+
+        w007_warnings = [w for w in result.warnings if w.rule_id == "W007"]
+        assert len(w007_warnings) == 1
+        assert "R1" in w007_warnings[0].message
+        assert "(MAY)" in w007_warnings[0].message