pactkit 2.10.2__tar.gz → 2.10.3__tar.gz

{pactkit-2.10.2 → pactkit-2.10.3}/.opencode/pactkit.yaml

@@ -2,7 +2,7 @@
 # Edit this file to customize which components are deployed.
 # Remove items from a list to disable them. Default: all enabled.
 
-version: "2.10.2"
+version: "2.10.3"
 stack: python
 root: .
 developer: "slim"

{pactkit-2.10.2 → pactkit-2.10.3}/CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to PactKit will be documented in this file.
 
 Format follows [Keep a Changelog](https://keepachangelog.com/).
 
+## [2.10.3] - 2026-04-20
+
+### Fixed
+- **Protected parent dirs in `pactkit clean`** — `rglob("dist")` was matching `node_modules/*/dist`, destroying npm dependency internals. Added `_inside_protected()` guard for `node_modules/` and `.git/`; explicit path patterns (e.g., `node_modules/.cache`) now use direct matching instead of rglob.
+
 ## [2.10.2] - 2026-04-20
 
 ### Added

{pactkit-2.10.2 → pactkit-2.10.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pactkit
-Version: 2.10.2
+Version: 2.10.3
 Summary: Spec-driven agentic DevOps toolkit for AI coding assistants
 Project-URL: Homepage, https://pactkit.dev
 Project-URL: Repository, https://github.com/pactkit/pactkit-public

{pactkit-2.10.2 → pactkit-2.10.3}/docs/architecture/governance/archive/lessons_archive_202603.md

@@ -46,3 +46,4 @@
 | 2026-03-24 | Plan Phase 3.2a scaffold-first: replaced AI freeform Write with {SCAFFOLD_CMD} create_spec + Read + Edit in src/pactkit/prompts/commands.py. Removed 3 inline format examples (~240 chars). Pre-existing tests (test_bug034, test_story055_commands, test_story_slim019) needed updates for new checkpoint wording. | src/pactkit/prompts/commands.py:Phase3.2a |
 | 2026-03-24 | spec_linter.py _check_acceptance_criteria: per-subsection GWT check must use raw_text (with code blocks) not stripped text, because specs legitimately wrap Gherkin in fenced blocks | spec_linter.py:_check_acceptance_criteria |
 | 2026-03-24 | Standalone scripts (visualize.py) need try/except ImportError guards for yaml.safe_load when reading pactkit.yaml — they cannot import from pactkit library | visualize.py:_load_scan_excludes |
+| 2026-03-24 | Inline data in standalone scripts must have canonical-source comments pointing to the library module (e.g. _STACK_MARKERS → cleaners.py, _LANG_FILE_EXT → workflows.py) per Architecture Principle 1 | visualize.py:_STACK_MARKERS |

{pactkit-2.10.2 → pactkit-2.10.3}/docs/architecture/governance/lessons.md

@@ -2,7 +2,6 @@
 
 | Date | Lesson | Context |
 |------|--------|---------|
-| 2026-03-24 | Inline data in standalone scripts must have canonical-source comments pointing to the library module (e.g. _STACK_MARKERS → cleaners.py, _LANG_FILE_EXT → workflows.py) per Architecture Principle 1 | visualize.py:_STACK_MARKERS |
 | 2026-03-24 | Worktree isolation diverges from working-tree: verify visualize.py _scan_files() signature is preserved across stories to avoid breaking callers | visualize.py:_scan_files |
 | 2026-03-24 | Extracting _detect_stack() from _detect_file_ext() enables both file discovery and test mapping to share stack detection — DRY refactoring | visualize.py:_detect_stack |
 | 2026-03-24 | Standalone skill scripts using exec() require all imports in _SHARED_HEADER; new stdlib imports (dataclass) must be added to skills/__init__.py _SHARED_HEADER, not just the standalone header section | skills/__init__.py:_SHARED_HEADER |
@@ -53,3 +52,4 @@
 | 2026-04-17 | Dual-anchor pattern: declare principle in RULES_MODULES['core'] (01-core-protocol.md), detail in dedicated module (11-pdca-nudge.md). Prevents attention dilution when rules/ has 10+ files — Core Protocol acts as behavioral constitution anchor. | src/pactkit/prompts/rules.py:RULES_MODULES |
 | 2026-04-18 | Version comparison guards must use semantic (tuple) comparison, not string equality — string != treats 2.10.1 != 2.5.0 without direction, giving wrong upgrade advice | guards.py:check_version_mismatch |
 | 2026-04-20 | Plugin deployer (_deploy_commands in deployer.py:952-954) uses _rewrite_skills_prefix instead of _render_prompt, keeping raw placeholders like {BOARD_CMD} — not a deploy drift bug but by-design template behavior | src/pactkit/generators/deployer.py:_deploy_commands |
+| 2026-04-20 | pactkit clean rglob patterns must exclude protected parent dirs (node_modules, .git) — recursive pattern matching deletes dependency internals | cleaners.py:_inside_protected |

{pactkit-2.10.2 → pactkit-2.10.3}/docs/architecture/governance/rules.md

@@ -15,7 +15,7 @@
 
 ## Invariants
 
-1. All 3752+ tests must pass before any commit to `main`.
+1. All 3755+ tests must pass before any commit to `main`.
 2. Specs (`docs/specs/`) are the source of truth — code conforms to specs, not the reverse.
 3. CLI entry point is `pactkit` via `src/pactkit/cli.py:main`.
 4. No runtime dependencies beyond `pyyaml`.

{pactkit-2.10.2 → pactkit-2.10.3}/docs/product/context.md

@@ -1,5 +1,5 @@
 # Project Context (Auto-generated)
-> Last updated: 2026-04-20T10:21:11+08:00 by pactkit context
+> Last updated: 2026-04-20T15:24:48+08:00 by pactkit context
 
 ## Sprint Status
 Backlog: 0 | In Progress: 0 | Done: 0 stories
@@ -15,11 +15,11 @@ develop
 * main
 
 ## Key Decisions
-- Weighted hotspot formula (complexity 25% + docstring 15% + smells 15% + layers 10% + test 20% + blast 15%) gives meaningful scores across different project profiles; _generate_suggested_tasks auto-scaffolds BUG/HOTFIX specs with Done-completed filter for idempotency
 - Dual-dimension audit (config+code 50/50) gives accurate project health picture; scanning ~/.claude/ global config catches harness setup invisible at project level
 - Dual-anchor pattern: declare principle in RULES_MODULES['core'] (01-core-protocol.md), detail in dedicated module (11-pdca-nudge.md). Prevents attention dilution when rules/ has 10+ files — Core Protocol acts as behavioral constitution anchor.
 - Version comparison guards must use semantic (tuple) comparison, not string equality — string != treats 2.10.1 != 2.5.0 without direction, giving wrong upgrade advice
 - Plugin deployer (_deploy_commands in deployer.py:952-954) uses _rewrite_skills_prefix instead of _render_prompt, keeping raw placeholders like {BOARD_CMD} — not a deploy drift bug but by-design template behavior
+- pactkit clean rglob patterns must exclude protected parent dirs (node_modules, .git) — recursive pattern matching deletes dependency internals
 
 ## Next Recommended Action
 `/project-design`

{pactkit-2.10.2 → pactkit-2.10.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "pactkit"
-version = "2.10.2"
+version = "2.10.3"
 description = "Spec-driven agentic DevOps toolkit for AI coding assistants"
 readme = "README.md"
 license = "MIT"

{pactkit-2.10.2 → pactkit-2.10.3}/src/pactkit/__init__.py

@@ -1,3 +1,3 @@
 """PactKit - Spec-driven agentic DevOps toolkit."""
 
-__version__ = "2.10.2"
+__version__ = "2.10.3"

{pactkit-2.10.2 → pactkit-2.10.3}/src/pactkit/cleaners.py

@@ -15,6 +15,9 @@ _CLEANUP_PATTERNS: dict[str, list[str]] = {
     "java": ["target/", "build/", ".gradle/"],
 }
 
+# Directories whose contents must never be cleaned by rglob patterns
+_PROTECTED_PARENTS = {"node_modules", ".git"}
+
 # Stack detection markers (ordered by priority)
 _STACK_MARKERS: list[tuple[str, str]] = [
     ("pyproject.toml", "python"),
@@ -27,6 +30,12 @@ _STACK_MARKERS: list[tuple[str, str]] = [
 ]
 
 
+def _inside_protected(path: Path, project_root: Path) -> bool:
+    """Return True if path is inside a protected parent directory."""
+    rel = path.relative_to(project_root)
+    return bool(_PROTECTED_PARENTS & set(rel.parts[:-1]))
+
+
 def detect_stacks(project_root: Path) -> list[str]:
     """Detect all project stacks from marker files.
 
@@ -84,9 +93,21 @@ def clean_artifacts(
     removed: list[Path] = []
 
     for pattern in patterns:
-        if "*" in pattern:
+        if "/" in pattern:
+            # Explicit path (e.g., "node_modules/.cache") — match directly
+            target = project_root / pattern
+            if target.exists():
+                removed.append(target)
+                if not dry_run:
+                    if target.is_dir():
+                        shutil.rmtree(target)
+                    else:
+                        target.unlink()
+        elif "*" in pattern:
             # Glob pattern (e.g., "*.pyc")
             for match in project_root.rglob(pattern):
+                if _inside_protected(match, project_root):
+                    continue
                 removed.append(match)
                 if not dry_run:
                     if match.is_dir():
@@ -94,9 +115,11 @@ def clean_artifacts(
                     else:
                         match.unlink()
         else:
-            # Directory or file name (e.g., "__pycache__", ".pytest_cache")
+            # Directory or file name (e.g., "__pycache__", "dist")
             clean_name = pattern.rstrip("/")
             for match in project_root.rglob(clean_name):
+                if _inside_protected(match, project_root):
+                    continue
                 removed.append(match)
                 if not dry_run:
                     if match.is_dir():

{pactkit-2.10.2 → pactkit-2.10.3}/tests/unit/test_story_slim014_clean.py

@@ -87,3 +87,47 @@ class TestCleanArtifacts:
 
         removed = clean_artifacts(tmp_path, stack="auto")
         assert len(removed) >= 1
+
+    def test_clean_node_skips_dist_inside_node_modules(self, tmp_path):
+        """dist inside node_modules must NOT be deleted."""
+        (tmp_path / "package.json").write_text("{}")
+        # Create a dependency with dist/
+        dep_dist = tmp_path / "node_modules" / "some-pkg" / "dist"
+        dep_dist.mkdir(parents=True)
+        (dep_dist / "index.js").write_text("module.exports = {}")
+        # Create a project-level dist/ that SHOULD be cleaned
+        proj_dist = tmp_path / "dist"
+        proj_dist.mkdir()
+        (proj_dist / "bundle.js").write_text("")
+
+        removed = clean_artifacts(tmp_path, stack="node")
+        assert proj_dist not in list(tmp_path.iterdir())
+        assert dep_dist.exists(), "node_modules/*/dist must survive clean"
+
+    def test_clean_node_modules_cache_still_cleaned(self, tmp_path):
+        """node_modules/.cache is explicitly targeted and should be cleaned."""
+        (tmp_path / "package.json").write_text("{}")
+        nm_cache = tmp_path / "node_modules" / ".cache"
+        nm_cache.mkdir(parents=True)
+        (nm_cache / "babel").mkdir()
+        (nm_cache / "babel" / "data.json").write_text("{}")
+
+        removed = clean_artifacts(tmp_path, stack="node")
+        assert any("node_modules/.cache" in str(p) for p in removed)
+        assert not nm_cache.exists()
+
+    def test_clean_skips_pyc_inside_node_modules(self, tmp_path):
+        """Glob patterns (*.pyc) must not match inside node_modules."""
+        (tmp_path / "pyproject.toml").write_text("[project]")
+        # A .pyc in node_modules (unlikely but possible in hybrid projects)
+        nm_pyc = tmp_path / "node_modules" / "weird" / "file.pyc"
+        nm_pyc.parent.mkdir(parents=True)
+        nm_pyc.write_text("")
+        # A normal .pyc that should be cleaned
+        normal_pyc = tmp_path / "src" / "mod.pyc"
+        normal_pyc.parent.mkdir(parents=True)
+        normal_pyc.write_text("")
+
+        removed = clean_artifacts(tmp_path, stack="python")
+        assert not normal_pyc.exists(), "src/*.pyc should be cleaned"
+        assert nm_pyc.exists(), "node_modules/**/*.pyc must survive clean"