paasta-tools 1.21.2__tar.gz → 1.21.3__tar.gz

paasta_tools-1.21.3/PKG-INFO

@@ -0,0 +1,73 @@
+Metadata-Version: 2.1
+Name: paasta-tools
+Version: 1.21.3
+Summary: Tools for Yelps SOA infrastructure
+Author: Compute Infrastructure @ Yelp
+Author-email: compute-infra@yelp.com
+Provides: paasta_tools
+Requires-Python: >=3.8.0
+License-File: LICENSE
+Requires-Dist: a-sync>=0.5.0
+Requires-Dist: aiohttp>=3.5.4
+Requires-Dist: argcomplete>=0.8.1
+Requires-Dist: boto
+Requires-Dist: boto3
+Requires-Dist: boto3-type-annotations
+Requires-Dist: botocore
+Requires-Dist: bravado>=10.2.0
+Requires-Dist: certifi
+Requires-Dist: choice>=0.1
+Requires-Dist: containerd
+Requires-Dist: cookiecutter>=1.4.0
+Requires-Dist: croniter
+Requires-Dist: docker
+Requires-Dist: dulwich>=0.17.3
+Requires-Dist: ephemeral-port-reserve>=1.0.1
+Requires-Dist: graphviz
+Requires-Dist: grpcio
+Requires-Dist: gunicorn
+Requires-Dist: humanfriendly
+Requires-Dist: humanize>=0.5.1
+Requires-Dist: inotify>=0.2.8
+Requires-Dist: ipaddress>=1.0.22
+Requires-Dist: isodate>=0.7.2
+Requires-Dist: jsonschema[format]
+Requires-Dist: kazoo>=2.0.0
+Requires-Dist: kubernetes<26.0.0,>=18.20.0
+Requires-Dist: ldap3
+Requires-Dist: manhole
+Requires-Dist: mypy-extensions>=0.3.0
+Requires-Dist: nats-py
+Requires-Dist: nulltype
+Requires-Dist: objgraph
+Requires-Dist: ply
+Requires-Dist: progressbar2>=3.10.0
+Requires-Dist: prometheus-client
+Requires-Dist: pymesos>=0.2.0
+Requires-Dist: pyramid>=1.8
+Requires-Dist: pyramid-swagger>=2.3.0
+Requires-Dist: pysensu-yelp>=0.3.4
+Requires-Dist: PyStaticConfiguration
+Requires-Dist: python-crontab>=2.1.1
+Requires-Dist: python-dateutil>=2.4.0
+Requires-Dist: python-iptables
+Requires-Dist: pytimeparse>=1.1.0
+Requires-Dist: pytz>=2014.10
+Requires-Dist: requests<2.32.0,>=2.18.4
+Requires-Dist: requests-cache>=0.4.10
+Requires-Dist: retry
+Requires-Dist: ruamel.yaml
+Requires-Dist: sensu-plugin
+Requires-Dist: service-configuration-lib>=3.2.0
+Requires-Dist: signalfx
+Requires-Dist: slackclient>=1.2.1
+Requires-Dist: sticht>=1.1.0
+Requires-Dist: syslogmp
+Requires-Dist: task-processing
+Requires-Dist: thriftpy2
+Requires-Dist: transitions
+Requires-Dist: typing-extensions
+Requires-Dist: tzlocal
+Requires-Dist: urllib3
+Requires-Dist: utaw>=0.2.0
+Requires-Dist: wsgicors

{paasta-tools-1.21.2 → paasta_tools-1.21.3}/README.md

@@ -44,7 +44,7 @@ is a heavily customised version of SmartStack and Envoy, allows many systems at
 to communicate with PaaSTA services and each other.
 
 On the other hand, requiring lots of components, means lots of infrastructure to
-setup before PaaSTA can work effectively! Realistacally, running PaaSTA outside of Yelp
+setup before PaaSTA can work effectively! Realistically, running PaaSTA outside of Yelp
 would not be sensible, because in addition to the integrations mentioned above we also
 have strong opinions encoded in other tooling that you would need to replicate. Nevertheless,
 we code PaaSTA in the open because we think it is useful to share our approach and hope that

{paasta-tools-1.21.2 → paasta_tools-1.21.3}/paasta_tools/__init__.py

@@ -17,4 +17,4 @@
 # setup phase, the dependencies may not exist on disk yet.
 #
 # Don't bump version manually. See `make release` docs in ./Makefile
-__version__ = "1.21.2"
+__version__ = "1.21.3"

{paasta-tools-1.21.2 → paasta_tools-1.21.3}/paasta_tools/cli/utils.py

@@ -1097,7 +1097,9 @@ def get_paasta_oapi_client_with_auth(
     )
 
 
-def run_interactive_cli(cmd: str, shell: str = "bash", term: str = "xterm-256color"):
+def run_interactive_cli(
+    cmd: str, shell: str = "/bin/bash", term: str = "xterm-256color"
+):
     """Runs interactive command in a pseudo terminal, handling terminal size management
 
     :param str cmd: shell command
@@ -1105,6 +1107,8 @@ def run_interactive_cli(cmd: str, shell: str = "bash", term: str = "xterm-256col
     :param str term: terminal type
     """
     cols, rows = shutil.get_terminal_size()
+    if not os.path.isabs(shell):
+        shell = shutil.which(shell)
     wrapped_cmd = (
         f"export SHELL={shell};"
         f"export TERM={term};"

paasta_tools-1.21.3/paasta_tools.egg-info/PKG-INFO

@@ -0,0 +1,73 @@
+Metadata-Version: 2.1
+Name: paasta-tools
+Version: 1.21.3
+Summary: Tools for Yelps SOA infrastructure
+Author: Compute Infrastructure @ Yelp
+Author-email: compute-infra@yelp.com
+Provides: paasta_tools
+Requires-Python: >=3.8.0
+License-File: LICENSE
+Requires-Dist: a-sync>=0.5.0
+Requires-Dist: aiohttp>=3.5.4
+Requires-Dist: argcomplete>=0.8.1
+Requires-Dist: boto
+Requires-Dist: boto3
+Requires-Dist: boto3-type-annotations
+Requires-Dist: botocore
+Requires-Dist: bravado>=10.2.0
+Requires-Dist: certifi
+Requires-Dist: choice>=0.1
+Requires-Dist: containerd
+Requires-Dist: cookiecutter>=1.4.0
+Requires-Dist: croniter
+Requires-Dist: docker
+Requires-Dist: dulwich>=0.17.3
+Requires-Dist: ephemeral-port-reserve>=1.0.1
+Requires-Dist: graphviz
+Requires-Dist: grpcio
+Requires-Dist: gunicorn
+Requires-Dist: humanfriendly
+Requires-Dist: humanize>=0.5.1
+Requires-Dist: inotify>=0.2.8
+Requires-Dist: ipaddress>=1.0.22
+Requires-Dist: isodate>=0.7.2
+Requires-Dist: jsonschema[format]
+Requires-Dist: kazoo>=2.0.0
+Requires-Dist: kubernetes<26.0.0,>=18.20.0
+Requires-Dist: ldap3
+Requires-Dist: manhole
+Requires-Dist: mypy-extensions>=0.3.0
+Requires-Dist: nats-py
+Requires-Dist: nulltype
+Requires-Dist: objgraph
+Requires-Dist: ply
+Requires-Dist: progressbar2>=3.10.0
+Requires-Dist: prometheus-client
+Requires-Dist: pymesos>=0.2.0
+Requires-Dist: pyramid>=1.8
+Requires-Dist: pyramid-swagger>=2.3.0
+Requires-Dist: pysensu-yelp>=0.3.4
+Requires-Dist: PyStaticConfiguration
+Requires-Dist: python-crontab>=2.1.1
+Requires-Dist: python-dateutil>=2.4.0
+Requires-Dist: python-iptables
+Requires-Dist: pytimeparse>=1.1.0
+Requires-Dist: pytz>=2014.10
+Requires-Dist: requests<2.32.0,>=2.18.4
+Requires-Dist: requests-cache>=0.4.10
+Requires-Dist: retry
+Requires-Dist: ruamel.yaml
+Requires-Dist: sensu-plugin
+Requires-Dist: service-configuration-lib>=3.2.0
+Requires-Dist: signalfx
+Requires-Dist: slackclient>=1.2.1
+Requires-Dist: sticht>=1.1.0
+Requires-Dist: syslogmp
+Requires-Dist: task-processing
+Requires-Dist: thriftpy2
+Requires-Dist: transitions
+Requires-Dist: typing-extensions
+Requires-Dist: tzlocal
+Requires-Dist: urllib3
+Requires-Dist: utaw>=0.2.0
+Requires-Dist: wsgicors

{paasta-tools-1.21.2 → paasta_tools-1.21.3}/paasta_tools.egg-info/SOURCES.txt

@@ -299,4 +299,55 @@ paasta_tools/secret_providers/vault.py
 paasta_tools/tron/__init__.py
 paasta_tools/tron/client.py
 paasta_tools/tron/tron_command_context.py
-paasta_tools/tron/tron_timeutils.py
+paasta_tools/tron/tron_timeutils.py
+tests/test_adhoc_tools.py
+tests/test_apply_external_resources.py
+tests/test_async_utils.py
+tests/test_bounce_lib.py
+tests/test_check_flink_services_health.py
+tests/test_check_kubernetes_services_replication.py
+tests/test_check_oom_events.py
+tests/test_check_service_replication_tools.py
+tests/test_check_spark_jobs.py
+tests/test_cleanup_kubernetes_jobs.py
+tests/test_config_utils.py
+tests/test_delete_kubernetes_deployments.py
+tests/test_deployment_utils.py
+tests/test_docker_wrapper.py
+tests/test_drain_lib.py
+tests/test_eks_tools.py
+tests/test_envoy_tools.py
+tests/test_firewall.py
+tests/test_firewall_logging.py
+tests/test_firewall_update.py
+tests/test_flink_tools.py
+tests/test_flinkeks_tools.py
+tests/test_generate_authenticating_services.py
+tests/test_generate_deployments_for_service.py
+tests/test_generate_services_file.py
+tests/test_generate_services_yaml.py
+tests/test_hacheck.py
+tests/test_iptables.py
+tests/test_kubernetes_tools.py
+tests/test_list_kubernetes_service_instances.py
+tests/test_long_running_service_tools.py
+tests/test_mac_address.py
+tests/test_mesos_tools.py
+tests/test_monitoring_tools.py
+tests/test_nrtsearchserviceseks_tools.py
+tests/test_oom_logger.py
+tests/test_paasta_execute_docker_command.py
+tests/test_paasta_service_config_loader.py
+tests/test_puppet_service_tools.py
+tests/test_remote_git.py
+tests/test_secret_tools.py
+tests/test_setup_istio_mesh.py
+tests/test_setup_kubernetes_cr.py
+tests/test_setup_kubernetes_job.py
+tests/test_setup_prometheus_adapter_config.py
+tests/test_slack.py
+tests/test_smartstack_tools.py
+tests/test_spark_tools.py
+tests/test_task_processing.py
+tests/test_tron_tools.py
+tests/test_utils.py

{paasta-tools-1.21.2 → paasta_tools-1.21.3}/paasta_tools.egg-info/entry_points.txt

@@ -18,4 +18,3 @@ paasta_setup_tron_namespace = paasta_tools.setup_tron_namespace:main
 
 [paste.app_factory]
 paasta-api-config = paasta_tools.api.api:make_app
-

paasta_tools-1.21.3/tests/test_adhoc_tools.py

@@ -0,0 +1,66 @@
+# Copyright 2015-2016 Yelp Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+import mock
+
+from paasta_tools import adhoc_tools
+from paasta_tools.utils import DeploymentsJsonV2
+from paasta_tools.utils import NoConfigurationForServiceError
+
+
+def test_get_default_interactive_config():
+    with mock.patch(
+        "paasta_tools.adhoc_tools.load_adhoc_job_config", autospec=True
+    ) as mock_load_adhoc_job_config:
+        mock_load_adhoc_job_config.return_value = adhoc_tools.AdhocJobConfig(
+            service="fake_service",
+            instance="interactive",
+            cluster="fake_cluster",
+            config_dict={},
+            branch_dict={"deploy_group": "fake_deploy_group"},
+        )
+        result = adhoc_tools.get_default_interactive_config(
+            "fake_service", "fake_cluster", "/fake/soa/dir", load_deployments=False
+        )
+        assert result.get_cpus() == 4
+        assert result.get_mem() == 10240
+        assert result.get_disk() == 1024
+
+
+def test_get_default_interactive_config_reads_from_tty():
+    with mock.patch(
+        "paasta_tools.adhoc_tools.prompt_pick_one", autospec=True
+    ) as mock_prompt_pick_one, mock.patch(
+        "paasta_tools.adhoc_tools.load_adhoc_job_config", autospec=True
+    ) as mock_load_adhoc_job_config, mock.patch(
+        "paasta_tools.adhoc_tools.load_v2_deployments_json", autospec=True
+    ) as mock_load_deployments_json:
+        mock_prompt_pick_one.return_value = "fake_deploygroup"
+        mock_load_adhoc_job_config.side_effect = NoConfigurationForServiceError
+        mock_load_deployments_json.return_value = DeploymentsJsonV2(
+            service="fake-service",
+            config_dict={
+                "deployments": {
+                    "fake_deploygroup": {
+                        "docker_image": mock.sentinel.docker_image,
+                        "git_sha": mock.sentinel.git_sha,
+                    }
+                },
+                "controls": {},
+            },
+        )
+        result = adhoc_tools.get_default_interactive_config(
+            "fake_service", "fake_cluster", "/fake/soa/dir", load_deployments=True
+        )
+        assert result.get_deploy_group() == "fake_deploygroup"
+        assert result.get_docker_image() == mock.sentinel.docker_image

paasta_tools-1.21.3/tests/test_apply_external_resources.py

@@ -0,0 +1,159 @@
+import os
+from subprocess import CalledProcessError
+
+import mock
+import pytest
+
+from paasta_tools.apply_external_resources import main
+
+
+@pytest.fixture
+def mock_run():
+    with mock.patch(
+        "paasta_tools.apply_external_resources.run", autospec=True
+    ) as mock_runner:
+        yield mock_runner
+
+
+@pytest.fixture(autouse=True)
+def setup_external_files(fs):
+    fs.create_file(
+        "/external_resources/00-common/10-foo/10-deployment.yaml",
+        contents="foo: bar",
+    )
+    fs.create_file(
+        "/external_resources/00-common/10-foo/20-service.yaml",
+        contents="fizz: buzz",
+    )
+    fs.create_file(
+        "/external_resources/20-common/10-foo/20-deployment.yaml",
+        contents="baz: biz",
+    )
+    fs.create_file(
+        "/external_resources/.applied/00-common/10-foo/10-deployment.yaml",
+        contents="foo: bar",
+    )
+    fs.create_file(
+        "/external_resources/.applied/00-common/10-foo/20-service.yaml",
+        contents="fizz: buzz",
+    )
+    fs.create_file(
+        "/external_resources/.applied/20-common/10-foo/20-deployment.yaml",
+        contents="baz: biz",
+    )
+
+
+def test_no_changes(mock_run):
+    assert main("/external_resources") == 0
+    assert mock_run.call_count == 0
+
+
+def test_resources_added_in_order(mock_run, fs):
+    fs.create_file(
+        "/external_resources/00-common/10-foo/30-hpa.yaml",
+        contents="blah: blah",
+    )
+    fs.create_file(
+        "/external_resources/00-common/10-foo/40-service.yaml",
+        contents="blah: blah",
+    )
+    fs.create_file(
+        "/external_resources/00-common/30-foo/10-deployment.yaml",
+        contents="blah: blah",
+    )
+    assert main("/external_resources") == 0
+    assert mock_run.call_args_list == [
+        mock.call(
+            [
+                "kubectl",
+                "apply",
+                "-f",
+                "/external_resources/00-common/10-foo/30-hpa.yaml",
+            ],
+            check=True,
+        ),
+        mock.call(
+            [
+                "kubectl",
+                "apply",
+                "-f",
+                "/external_resources/00-common/10-foo/40-service.yaml",
+            ],
+            check=True,
+        ),
+        mock.call(
+            [
+                "kubectl",
+                "apply",
+                "-f",
+                "/external_resources/00-common/30-foo/10-deployment.yaml",
+            ],
+            check=True,
+        ),
+    ]
+    assert os.path.exists("/external_resources/.applied/00-common/10-foo/30-hpa.yaml")
+    assert os.path.exists(
+        "/external_resources/.applied/00-common/10-foo/40-service.yaml"
+    )
+    assert os.path.exists(
+        "/external_resources/.applied/00-common/30-foo/10-deployment.yaml"
+    )
+
+
+def test_resources_deleted_in_reverse_order(mock_run, fs):
+    fs.create_file(
+        "/external_resources/.applied/00-common/10-foo/30-hpa.yaml",
+        contents="blah: blah",
+    )
+    fs.create_file(
+        "/external_resources/.applied/00-common/10-foo/40-service.yaml",
+        contents="blah: blah",
+    )
+    assert main("/external_resources") == 0
+    assert mock_run.call_args_list == [
+        mock.call(
+            [
+                "kubectl",
+                "delete",
+                "--ignore-not-found=true",
+                "-f",
+                "/external_resources/.applied/00-common/10-foo/40-service.yaml",
+            ],
+            check=True,
+        ),
+        mock.call(
+            [
+                "kubectl",
+                "delete",
+                "--ignore-not-found=true",
+                "-f",
+                "/external_resources/.applied/00-common/10-foo/30-hpa.yaml",
+            ],
+            check=True,
+        ),
+    ]
+    assert not os.path.exists(
+        "/external_resources/.applied/00-common/10-foo/30-hpa.yaml"
+    )
+    assert not os.path.exists(
+        "/external_resources/.applied/00-common/10-foo/40-service.yaml"
+    )
+
+
+def test_kubectl_fails(mock_run, fs):
+    mock_run.side_effect = [CalledProcessError(cmd="kubectl", returncode=1), None]
+    fs.create_file(
+        "/external_resources/00-common/10-foo/30-hpa.yaml",
+        contents="blah: blah",
+    )
+    fs.create_file(
+        "/external_resources/00-common/10-foo/40-service.yaml",
+        contents="blah: blah",
+    )
+    assert main("/external_resources") == 1
+    assert not os.path.exists(
+        "/external_resources/.applied/00-common/10-foo/30-hpa.yaml"
+    )
+    assert os.path.exists(
+        "/external_resources/.applied/00-common/10-foo/40-service.yaml"
+    )

paasta_tools-1.21.3/tests/test_async_utils.py

@@ -0,0 +1,201 @@
+import asyncio
+import functools
+import weakref
+from collections import defaultdict
+
+import mock
+import pytest
+
+from paasta_tools.async_utils import async_ttl_cache
+
+
+@pytest.mark.asyncio
+async def test_async_ttl_cache_hit():
+    return_values = iter(range(10))
+
+    @async_ttl_cache(ttl=None)
+    async def range_coroutine():
+        return next(return_values)
+
+    assert await range_coroutine() == await range_coroutine()
+
+
+@pytest.mark.asyncio
+async def test_async_ttl_cache_miss():
+    return_values = iter(range(10))
+
+    @async_ttl_cache(ttl=0)
+    async def range_coroutine():
+        return next(return_values)
+
+    assert await range_coroutine() != await range_coroutine()
+
+
+@pytest.mark.asyncio
+async def test_async_ttl_cache_doesnt_cache_failures():
+    flaky_error_raiser = mock.Mock(side_effect=[Exception, None])
+
+    @async_ttl_cache(ttl=None)
+    async def flaky_coroutine():
+        return flaky_error_raiser()
+
+    with pytest.raises(Exception):
+        await flaky_coroutine()
+
+    # if we were caching failures, this would fail
+    assert await flaky_coroutine() is None
+
+
+class DataHolder:
+    def __init__(self, value):
+        self.value = value
+
+
+@pytest.mark.asyncio
+async def test_async_ttl_cache_returns_in_flight_future():
+    return_values = iter(range(10))
+    event = asyncio.Event()
+    condition = asyncio.Condition()
+    num_waiting_coroutines = DataHolder(value=0)
+
+    # Wait until we have enough coroutines waiting to return a result.  This
+    # ensures that dependent coroutines have a chance to get a future out of
+    # the cache
+    @async_ttl_cache(ttl=0)
+    async def range_coroutine():
+        await event.wait()
+        return next(return_values)
+
+    # Wait until we have enough coroutines waiting on range_coroutine, then
+    # wake range_coroutine
+    async def event_setter():
+        async with condition:
+            while num_waiting_coroutines.value != 2:
+                await condition.wait()
+            event.set()
+
+    # Keep track of how many waiting range_coroutines we have to ensure both
+    # have had a chance to get the in-flight future out of the cache.  This has
+    # to be separate from range_coroutine since we only end up with one
+    # invocation of that method due to caching.  It also has to be separate
+    # from event_setter to ensure that the event is not set until both
+    # coroutines are waiting.
+    async def cache_waiter():
+        async with condition:
+            num_waiting_coroutines.value += 1
+            condition.notify_all()
+        return await range_coroutine()
+
+    event_setter_future = asyncio.ensure_future(event_setter())
+    future1 = asyncio.ensure_future(cache_waiter())
+    future2 = asyncio.ensure_future(cache_waiter())
+    await asyncio.wait([event_setter_future, future1, future2])
+
+    assert future1.result() == future2.result() == 0
+
+
+@pytest.mark.asyncio
+async def test_async_ttl_cache_dont_overwrite_new_cache_entry():
+    """Make sure that we don't overwrite a new cache entry that was placed
+    while we were waiting to handle the result of a previously cached future
+    """
+    range_continue_event = asyncio.Event()
+    update_cache_event = asyncio.Event()
+    return_values = iter(range(10))
+
+    # Wait until awaiter has had a chance to get the in-flight future out of
+    # the cache, then signal to the cache_updater to replace the cached future
+    # before returning.  Because cache_updater is signalled first, it will
+    # replace the previously cached future before async_ttl_cache decides
+    # whether save the result of that future in the cache
+    async def range_coroutine():
+        await range_continue_event.wait()
+        update_cache_event.set()
+        return next(return_values)
+
+    range_coroutine_future = asyncio.ensure_future(range_coroutine())
+    cache_key = functools._make_key((), {}, typed=False)
+    cache = {cache_key: (range_coroutine_future, float("Inf"))}
+
+    cached_range_coroutine = async_ttl_cache(cache=cache, ttl=0)(range_coroutine)
+
+    new_range_coroutine_future = asyncio.ensure_future(range_coroutine())
+
+    async def awaiter():
+        range_continue_event.set()
+        await cached_range_coroutine()
+
+    async def cache_updater():
+        await update_cache_event.wait()
+        cache[cache_key] = (new_range_coroutine_future, float("Inf"))
+
+    await asyncio.gather(awaiter(), cache_updater())
+    assert cache[cache_key] == (new_range_coroutine_future, float("Inf"))
+
+
+@pytest.mark.asyncio
+async def test_async_ttl_cache_recover_if_cache_entry_removed():
+    """Ensure we handle the case where we encounter an exception in the cached
+    future but another coroutine awaiting the same future ran first and alraedy
+    deleted the cache entry"""
+    range_continue_event = asyncio.Event()
+    num_awaiters_awaiting = DataHolder(value=0)
+
+    class TestException(Exception):
+        pass
+
+    async def range_coroutine():
+        await range_continue_event.wait()
+        raise TestException
+
+    range_coroutine_future = asyncio.ensure_future(range_coroutine())
+    cache_key = functools._make_key((), {}, typed=False)
+    cache = {cache_key: (range_coroutine_future, float("Inf"))}
+
+    cached_range_coroutine = async_ttl_cache(cache=cache, ttl=0)(range_coroutine)
+
+    async def awaiter():
+        num_awaiters_awaiting.value += 1
+        if num_awaiters_awaiting.value == 2:
+            range_continue_event.set()
+
+        try:
+            await cached_range_coroutine()
+        except TestException:
+            pass
+
+    # should not raise a KeyError!
+    await asyncio.gather(awaiter(), awaiter())
+
+
+@pytest.mark.asyncio
+async def test_async_ttl_cache_for_class_members_doesnt_leak_mem():
+    """Ensure that we aren't leaking memory"""
+
+    x = 42
+    instance_caches = defaultdict(dict)
+
+    class TestClass:
+        @async_ttl_cache(ttl=None, cleanup_self=True, cache=instance_caches)
+        async def f(self):
+            return x
+
+    o1 = TestClass()
+    w1 = weakref.ref(o1)
+    assert w1() is not None
+    assert await o1.f() == x
+    assert len(instance_caches) == 1
+    assert list(instance_caches.keys())[0]() == o1
+    del o1
+    assert len(instance_caches) == 0
+    assert w1() is None
+
+    o2, o3, o4 = TestClass(), TestClass(), TestClass()
+    assert await o2.f() == x
+    assert await o3.f() == x
+    assert await o4.f() == x
+    assert len(instance_caches) == 3
+    del o2, o4
+    assert len(instance_caches) == 1
+    del o3
+    assert len(instance_caches) == 0