paasta-tools 1.17.1__tar.gz → 1.18.0__tar.gz

{paasta-tools-1.17.1/paasta_tools.egg-info → paasta-tools-1.18.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 1.2
 Name: paasta-tools
-Version: 1.17.1
+Version: 1.18.0
 Summary: Tools for Yelps SOA infrastructure
 Home-page: UNKNOWN
 Author: Compute Infrastructure @ Yelp

{paasta-tools-1.17.1 → paasta-tools-1.18.0}/paasta_tools/__init__.py

@@ -17,4 +17,4 @@
 # setup phase, the dependencies may not exist on disk yet.
 #
 # Don't bump version manually. See `make release` docs in ./Makefile
-__version__ = "1.17.1"
+__version__ = "1.18.0"

{paasta-tools-1.17.1 → paasta-tools-1.18.0}/paasta_tools/cli/cmds/remote_run.py

@@ -13,6 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 import argparse
+import shutil
 import time
 
 from paasta_tools.cli.utils import get_paasta_oapi_api_clustername
@@ -29,7 +30,7 @@ from paasta_tools.utils import SystemPaastaConfig
 
 
 KUBECTL_CMD_TEMPLATE = (
-    "kubectl-eks-{cluster} --token {token} exec -it -n {namespace} {pod} -- /bin/bash"
+    "{kubectl_wrapper} --token {token} exec -it -n {namespace} {pod} -- /bin/bash"
 )
 
 
@@ -89,8 +90,11 @@ def paasta_remote_run_start(
         args.service, args.instance, user
     )
 
+    kubectl_wrapper = f"kubectl-eks-{args.cluster}"
+    if not shutil.which(kubectl_wrapper):
+        kubectl_wrapper = f"kubectl-{args.cluster}"
     exec_command = KUBECTL_CMD_TEMPLATE.format(
-        cluster=args.cluster,
+        kubectl_wrapper=kubectl_wrapper,
         namespace=poll_response.namespace,
         pod=poll_response.pod_name,
         token=token_response.token,

{paasta-tools-1.17.1 → paasta-tools-1.18.0}/paasta_tools/cli/schemas/eks_schema.json

@@ -837,6 +837,9 @@
                 "routable_ip": {
                     "type": "boolean"
                 },
+                "enable_aws_lb_readiness_gate": {
+                    "type": "boolean"
+                },
                 "lifecycle": {
                     "type": "object",
                     "properties": {

{paasta-tools-1.17.1 → paasta-tools-1.18.0}/paasta_tools/cli/schemas/kubernetes_schema.json

@@ -837,6 +837,9 @@
                 "routable_ip": {
                     "type": "boolean"
                 },
+                "enable_aws_lb_readiness_gate": {
+                    "type": "boolean"
+                },
                 "lifecycle": {
                     "type": "object",
                     "properties": {

{paasta-tools-1.17.1 → paasta-tools-1.18.0}/paasta_tools/kubernetes/remote_run.py

@@ -374,7 +374,11 @@ def create_pod_scoped_role(
             labels={POD_OWNER_LABEL: user},
         ),
     )
-    kube_client.rbac.create_namespaced_role(namespace=namespace, body=role)
+    try:
+        kube_client.rbac.create_namespaced_role(namespace=namespace, body=role)
+    except ApiException as e:
+        if e.status != 409:
+            raise
     return role_name
 
 
@@ -411,10 +415,14 @@ def bind_role_to_service_account(
             ),
         ],
     )
-    kube_client.rbac.create_namespaced_role_binding(
-        namespace=namespace,
-        body=role_binding,
-    )
+    try:
+        kube_client.rbac.create_namespaced_role_binding(
+            namespace=namespace,
+            body=role_binding,
+        )
+    except ApiException as e:
+        if e.status != 409:
+            raise
 
 
 def get_remote_run_roles(kube_client: KubeClient, namespace: str) -> List[V1Role]:

{paasta-tools-1.17.1 → paasta-tools-1.18.0}/paasta_tools/kubernetes_tools.py

@@ -374,6 +374,7 @@ KubePodLabels = TypedDict(
         "paasta.yelp.com/weight": str,
         "yelp.com/owner": str,
         "paasta.yelp.com/managed": str,
+        "elbv2.k8s.aws/pod-readiness-gate-inject": str,
     },
     total=False,
 )
@@ -439,6 +440,7 @@ class KubernetesDeploymentConfigDict(LongRunningServiceConfigDict, total=False):
     crypto_keys: CryptoKeyConfig
     datastore_credentials: DatastoreCredentialsConfig
     topology_spread_constraints: List[TopologySpreadConstraintDict]
+    enable_aws_lb_readiness_gate: bool
 
 
 def load_kubernetes_service_config_no_cache(
@@ -2216,6 +2218,9 @@ class KubernetesDeploymentConfig(LongRunningServiceConfig):
             return "true"
         return "false"
 
+    def should_enable_aws_lb_readiness_gate(self) -> bool:
+        return self.config_dict.get("enable_aws_lb_readiness_gate", False)
+
     def get_pod_template_spec(
         self,
         git_sha: str,
@@ -2398,6 +2403,13 @@ class KubernetesDeploymentConfig(LongRunningServiceConfig):
             labels["paasta.yelp.com/deploy_group"] = self.get_deploy_group()
             labels["paasta.yelp.com/scrape_gunicorn_prometheus"] = "true"
 
+        # the default AWS LB Controller behavior is to enable this by-namespace
+        # ...but that's kinda annoying to do in a toggleable way - so let's instead
+        # toggle based on pod labels (which of course, will require changing the controller
+        # settings :p)
+        if self.should_enable_aws_lb_readiness_gate():
+            labels["elbv2.k8s.aws/pod-readiness-gate-inject"] = "enabled"
+
         return V1PodTemplateSpec(
             metadata=V1ObjectMeta(
                 labels=labels,

{paasta-tools-1.17.1 → paasta-tools-1.18.0/paasta_tools.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 1.2
 Name: paasta-tools
-Version: 1.17.1
+Version: 1.18.0
 Summary: Tools for Yelps SOA infrastructure
 Home-page: UNKNOWN
 Author: Compute Infrastructure @ Yelp