overkill 0.8.2__tar.gz → 0.8.3__tar.gz

{overkill-0.8.2 → overkill-0.8.3}/PKG-INFO

@@ -1,6 +1,6 @@
-Metadata-Version: 2.4
+Metadata-Version: 2.5
 Name: overkill
-Version: 0.8.2
+Version: 0.8.3
 Summary: AI-powered code review loop — automates Codex/Gemini review + Claude fix cycles
 Project-URL: Repository, https://github.com/modocai/mr-overkill
 Project-URL: Issues, https://github.com/modocai/mr-overkill/issues

{overkill-0.8.2 → overkill-0.8.3}/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "overkill"
-version = "0.8.2"
+version = "0.8.3"
 description = "AI-powered code review loop — automates Codex/Gemini review + Claude fix cycles"
 readme = "README.md"
 license = { text = "MIT" }

{overkill-0.8.2 → overkill-0.8.3}/src/mr_overkill/self_review.py

@@ -278,14 +278,22 @@ def _generate_diff(
         check=False,
     )
 
+    # Paths go in argv after ``--``: unlike add/reset, ``git diff`` has no
+    # --pathspec-from-file option and exits 129 on it, which would silently
+    # write an empty diff and skip the self-review for every iteration.
     result = subprocess.run(
-        ["git", "diff", "HEAD", "--pathspec-from-file=-"],
-        input=pathspec,
+        ["git", "diff", "HEAD", "--", *changed_files],
         cwd=cwd,
         capture_output=True,
         text=True,
         check=False,
     )
+    if result.returncode != 0:
+        logger.warning(
+            "git diff failed (exit %d): %s",
+            result.returncode,
+            result.stderr.strip(),
+        )
     output.write_text(result.stdout, encoding="utf-8")
 
     # Undo intent-to-add

{overkill-0.8.2 → overkill-0.8.3}/tests/test_self_review.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 import json
+import subprocess
 from pathlib import Path
 from unittest.mock import MagicMock, patch
 
@@ -10,6 +11,7 @@ from mr_overkill.models import WorktreeSnapshot
 from mr_overkill.self_review import (
     _FIX_NITS_GUIDELINES,
     _compute_fingerprint,
+    _generate_diff,
     self_review_subloop,
 )
 
@@ -449,3 +451,61 @@ class TestFixNitsGuidelines:
 
         assert len(captured_prompt) == 1
         assert "Fix nits" not in captured_prompt[0]
+
+
+class TestGenerateDiff:
+    """Exercise _generate_diff against a real git repo.
+
+    Every other test in this module patches _generate_diff out, so the real
+    command line was never run: it passed --pathspec-from-file to ``git diff``,
+    which rejects the option, and the discarded stderr turned that into an
+    empty diff that skipped the self-review on every iteration.
+    """
+
+    def test_modified_tracked_file(self, tmp_git_repo: Path) -> None:
+        (tmp_git_repo / "README.md").write_text("# test\nsecond line\n")
+        output = tmp_git_repo / "out.diff"
+
+        _generate_diff(["README.md"], output, tmp_git_repo)
+
+        diff = output.read_text()
+        assert "+second line" in diff
+        assert "a/README.md" in diff
+
+    def test_untracked_file_included(self, tmp_git_repo: Path) -> None:
+        (tmp_git_repo / "new.py").write_text("print('hi')\n")
+        output = tmp_git_repo / "out.diff"
+
+        _generate_diff(["new.py"], output, tmp_git_repo)
+
+        assert "+print('hi')" in output.read_text()
+
+    def test_intent_to_add_is_undone(self, tmp_git_repo: Path) -> None:
+        """The untracked file must be left unstaged for the later commit step."""
+        (tmp_git_repo / "new.py").write_text("print('hi')\n")
+
+        _generate_diff(["new.py"], tmp_git_repo / "out.diff", tmp_git_repo)
+
+        staged = subprocess.run(
+            ["git", "diff", "--cached", "--name-only"],
+            cwd=tmp_git_repo,
+            capture_output=True,
+            text=True,
+            check=True,
+        )
+        assert staged.stdout.strip() == ""
+
+    def test_path_with_spaces(self, tmp_git_repo: Path) -> None:
+        (tmp_git_repo / "my file.txt").write_text("content\n")
+        output = tmp_git_repo / "out.diff"
+
+        _generate_diff(["my file.txt"], output, tmp_git_repo)
+
+        assert "+content" in output.read_text()
+
+    def test_no_changed_files_writes_empty(self, tmp_git_repo: Path) -> None:
+        output = tmp_git_repo / "out.diff"
+
+        _generate_diff([], output, tmp_git_repo)
+
+        assert output.read_text() == ""

{overkill-0.8.2 → overkill-0.8.3}/uv.lock

@@ -247,7 +247,7 @@ wheels = [
 
 [[package]]
 name = "overkill"
-version = "0.8.2"
+version = "0.8.3"
 source = { editable = "." }
 
 [package.dev-dependencies]