otrs-somconnexio 0.7.2__tar.gz → 0.8.0__tar.gz

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: otrs_somconnexio
-Version: 0.7.2
+Version: 0.8.0
 Summary: Python package for Somconnexio data syncing in OTRS
 Home-page: https://gitlab.com/coopdevs/otrs_somconnexio
 Author: Coopdevs

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/otrs_somconnexio/otrs_models/fiber_dynamic_fields.py

@@ -11,7 +11,6 @@ class FiberDynamicFields(InternetDynamicFields):
         return [
             self._df_previous_contract_pon(),
             self._df_previous_contract_fiber_speed(),
-            self._activation_notes(),
             self._df_mobile_pack_contracts(),
             self._df_all_grouped_SIMS_recieved(),
             self._df_has_previous_owner_with_mobile_pack_contracts(),
@@ -19,11 +18,6 @@ class FiberDynamicFields(InternetDynamicFields):
             self._keep_landline_number(),
         ]
 
-    def _activation_notes(self):
-        return DynamicField(
-            name="consideracionsActivacio2", value=self.service_data.activation_notes
-        )
-
     def _df_previous_contract_pon(self):
         return DynamicField(
             name="ponAntic", value=self.service_data.previous_contract_pon

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/otrs_somconnexio/otrs_models/mobile_dynamic_fields.py

@@ -19,7 +19,6 @@ class MobileDynamicFields(ProvisionDynamicFields):
             self._sim_received(),
             self._sim_delivery_tracking_code(),
             self._send_sim_type(),
-            self._activation_notes(),
             self._delivery_street(),
             self._delivery_zip_code(),
             self._delivery_city(),
@@ -54,11 +53,6 @@ class MobileDynamicFields(ProvisionDynamicFields):
             name="dniTitularAnterior", value=self.service_data.previous_owner_vat
         )
 
-    def _activation_notes(self):
-        return DynamicField(
-            name="consideracionsActivacio", value=self.service_data.activation_notes
-        )
-
     def _sim_received(self):
         sim_recieved = "1" if self.service_data.has_sim else "0"
         return DynamicField("SIMrebuda", sim_recieved)

otrs_somconnexio-0.8.0/otrs_somconnexio/otrs_models/provision_article.py

@@ -0,0 +1,9 @@
+# coding: utf-8
+from otrs_somconnexio.otrs_models.abstract_article import AbstractArticle
+
+
+class ProvisionArticle(AbstractArticle):
+    def __init__(self, subject, notes=""):
+        self.subject = subject
+        self.isVisibleForCustomer = "0" if notes else "1"
+        self.body = notes

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/otrs_somconnexio/otrs_models/provision_dynamic_fields.py

@@ -32,6 +32,7 @@ class ProvisionDynamicFields:
             self._order_id(),
             self._confirmed_documentation(),
             self._notes(),
+            self._activation_notes(),
         ]
         dynamic_fields += self._build_specific_dynamic_fields()
 
@@ -122,3 +123,8 @@ class ProvisionDynamicFields:
         return DynamicField(
             name="consideracionsGenerals", value=self.service_data.notes
         )
+
+    def _activation_notes(self):
+        return DynamicField(
+            name="consideracionsActivacio", value=self.service_data.activation_notes
+        )

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/otrs_somconnexio/otrs_models/provision_ticket.py

@@ -1,6 +1,6 @@
 # coding: utf-8
-from pyotrs.lib import Ticket
-
+import base64
+from pyotrs.lib import Attachment, Ticket
 from otrs_somconnexio.client import OTRSClient
 from otrs_somconnexio.otrs_models.provision_article import ProvisionArticle
 from otrs_somconnexio.services.get_ticket_title import GetTicketTitle
@@ -11,8 +11,12 @@ class ProvisionTicket:
         self.responsible_data = responsible_data
 
     def create(self):
+        new_ticket = self._build_ticket()
         self.otrs_ticket = OTRSClient().create_otrs_process_ticket(
-            self._build_ticket(), self._build_article(), self._build_dynamic_fields()
+            new_ticket,
+            article=self._build_article(),
+            dynamic_fields=self._build_dynamic_fields(),
+            attachments=self._build_attachments(),
         )
 
     @property
@@ -24,11 +28,7 @@ class ProvisionTicket:
         return self.otrs_ticket.number
 
     def _build_ticket(self):
-        title = GetTicketTitle(
-            self.service_data.technology,
-            self.service_data.order_id,
-            self.service_type(),
-        ).build()
+        title = self._ticket_title()
         return Ticket(
             {
                 "Title": title,
@@ -44,13 +44,40 @@ class ProvisionTicket:
             }
         )
 
+    def _get_article_subject(self):
+        return self._ticket_title()
+
+    def _get_article_notes(self):
+        return self.service_data.notes
+
     def _build_article(self):
         provision_article = ProvisionArticle(
+            self._get_article_subject(),
+            self._get_article_notes(),
+        )
+        return provision_article.call()
+
+    def _ticket_title(self):
+        return GetTicketTitle(
             self.service_data.technology,
             self.service_data.order_id,
             self.service_type(),
-        )
-        return provision_article.call()
+        ).build()
+
+    def _build_attachments(self):
+        docs = self._files_to_attach()
+        if not docs:
+            return []
+        return [
+            Attachment.create_basic(
+                Content=base64.b64encode(bytes(doc["Content"], "utf-8")).decode(
+                    "utf-8"
+                ),
+                Filename=doc["Filename"],
+                ContentType=doc.get("ContentType", "text/plain"),
+            )
+            for doc in docs
+        ]
 
     def _ticket_type(self):
         return self.otrs_configuration.type
@@ -90,3 +117,9 @@ class ProvisionTicket:
             return self.responsible_data.email
         else:
             return False
+
+    def _files_to_attach(self):
+        """Override to attach files to the ticket.
+        Format: [{"Filename": "file.txt", "Content": "file content", "ContentType": "text/plain"}, ...]
+        """
+        return []

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/otrs_somconnexio/otrs_models/switchboard_header_data.py

@@ -8,6 +8,8 @@ class SwitchboardHeaderData:
         contact_phone,
         sales_team,
         technology,
+        lead_line_data,
+        agent_data,
         notes="",
     ):
         self.order_id = order_id
@@ -15,4 +17,6 @@ class SwitchboardHeaderData:
         self.contact_phone = contact_phone
         self.sales_team = sales_team
         self.technology = technology
+        self.lead_line_data = lead_line_data
+        self.agent_data = agent_data
         self.notes = notes

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/otrs_somconnexio/otrs_models/switchboard_header_dynamic_fields.py

@@ -76,5 +76,5 @@ class SwitchboardHeaderDynamicFields:
 
     def _notes(self):
         return DynamicField(
-            name="consideracionsActivacio3", value=self.service_data.notes
+            name="consideracionsActivacio", value=self.service_data.notes
         )

otrs_somconnexio-0.8.0/otrs_somconnexio/otrs_models/switchboard_header_ticket.py

@@ -0,0 +1,88 @@
+# coding: utf-8
+from tabulate import tabulate
+from itertools import groupby
+from otrs_somconnexio.otrs_models.provision_ticket import ProvisionTicket
+from otrs_somconnexio.otrs_models.switchboard_header_dynamic_fields import (
+    SwitchboardHeaderDynamicFields,
+)
+from otrs_somconnexio.otrs_models.configurations.provision.switchboard_ticket import (
+    SwitchboardTicketConfiguration,
+)
+
+
+class SwitchboardHeaderTicket(ProvisionTicket):
+    def __init__(self, service_data, customer_data, responsible_data):
+        super(SwitchboardHeaderTicket, self).__init__(responsible_data)
+        self.service_data = service_data
+        self.customer_data = customer_data
+        self.otrs_configuration = SwitchboardTicketConfiguration()
+
+    def service_type(self):
+        return "switchboard_header"
+
+    def _build_dynamic_fields(self):
+        return SwitchboardHeaderDynamicFields(
+            self.service_data,
+            self.customer_data,
+            self._ticket_process_id(),
+            self._ticket_activity_id(),
+        ).all()
+
+    def _ticket_title(self):
+        return "Provisió centraleta virtual (CV) → Capçalera"
+
+    def _files_to_attach(self):
+        formatted_agent_data = self._format_agent_data()
+
+        attachments = []
+
+        if formatted_agent_data:
+            attachments.append(
+                {
+                    "Filename": "importació_agents_operator_{}.txt".format(
+                        self.service_data.order_id
+                    ),
+                    "Content": formatted_agent_data,
+                }
+            )
+
+        return attachments
+
+    def _get_article_notes(self):
+        return self._format_lead_line_data()
+
+    def _format_lead_line_data(self):
+        """Format lead line data for tsv table attachment."""
+        lead_line_data = self.service_data.lead_line_data
+        if not lead_line_data:
+            return ""
+
+        lead_table_data = list(zip(*lead_line_data.values()))
+        headers = lead_line_data.keys()
+        lead_lines_table = tabulate(lead_table_data, headers, tablefmt="csv")
+
+        return lead_lines_table
+
+    def _format_agent_data(self):
+        """Format agent data for operator import attachment.
+        Sorted by product, grouped by product.
+        """
+        agent_data = self.service_data.agent_data
+        if not agent_data:
+            return ""
+
+        sorted_agents = sorted(agent_data, key=lambda d: d["product"])
+
+        pin = "2424"
+        agents_info = []
+        for product, agents in groupby(sorted_agents, key=lambda ag: ag["product"]):
+            agents_info.append(f"{product}:")
+
+            for agent in agents:
+                agents_info.append(
+                    f"{agent['extension']}\t{agent['agent_name']}\t{pin}\t{agent['agent_name']}\t{agent['agent_email']}"  # noqa E501
+                )
+
+            agents_info.append("")
+
+        return "\n".join(agents_info)

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/otrs_somconnexio/otrs_models/switchboard_ticket.py

@@ -25,3 +25,11 @@ class SwitchboardTicket(ProvisionTicket):
             self._ticket_process_id(),
             self._ticket_activity_id(),
         ).all()
+
+    def _ticket_title(self):
+        if self.service_data.landline:
+            return "Alta número de fix (CV)"
+        elif self.service_data.mobile_phone_number:
+            return "Alta mòbil agent (CV)"
+        else:
+            return "Provisió centraleta virtual (CV)"

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/otrs_somconnexio.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: otrs-somconnexio
-Version: 0.7.2
+Version: 0.8.0
 Summary: Python package for Somconnexio data syncing in OTRS
 Home-page: https://gitlab.com/coopdevs/otrs_somconnexio
 Author: Coopdevs

otrs_somconnexio-0.8.0/otrs_somconnexio.egg-info/requires.txt

@@ -0,0 +1,4 @@
+pyotrs==0.12.7
+future==0.18.2
+tabulate==0.9.0
+more-itertools==10.0.0

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/setup.py

@@ -5,7 +5,7 @@ with open("README.md") as f:
     README = f.read()
 
 
-VERSION = "0.7.2"
+VERSION = "0.8.0"
 
 setup(
     name="otrs_somconnexio",
@@ -19,7 +19,12 @@ setup(
     packages=find_packages(exclude=("tests", "docs")),
     include_package_data=True,
     zip_safe=False,
-    install_requires=["pyotrs==0.12.7", "future==0.18.2"],
+    install_requires=[
+        "pyotrs==0.12.7",
+        "future==0.18.2",
+        "tabulate==0.9.0",
+        "more-itertools==10.0.0",
+    ],
     test_suite="unittest2.collector",
     tests_require=["unittest2", "mock", "factory_boy", "ipdb"],
     classifiers=[

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_adsl_dynamic_fields.py

@@ -41,6 +41,7 @@ class ADSLDynamicFieldsTestCase(unittest.TestCase):
                 "previous_contract_address",
                 "previous_contract_phone",
                 "notes",
+                "activation_notes",
                 "adsl_coverage",
                 "mm_fiber_coverage",
                 "asociatel_fiber_coverage",

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_adsl_ticket.py

@@ -9,11 +9,10 @@ from otrs_somconnexio.otrs_models.configurations.provision.adsl_ticket import (
 
 
 class ADSLTicketTestCase(unittest.TestCase):
-
     @patch("otrs_somconnexio.otrs_models.provision_ticket.Ticket")
     def test_build_ticket(self, MockTicket):
         customer_data = Mock(spec=["id"])
-        service_data = Mock(spec=["order_id", "technology"])
+        service_data = Mock(spec=["order_id", "technology", "notes"])
         expected_ticket_arguments = {
             "Title": "Ticket#{} - Només ADSL".format(service_data.order_id),
             "Type": ADSLTicketConfiguration.type,
@@ -31,18 +30,19 @@ class ADSLTicketTestCase(unittest.TestCase):
         MockTicket.assert_called_with(expected_ticket_arguments)
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
-    def test_build_article(self, MockInternetArticle):
+    def test_build_article(self, MockProvisionArticle):
         customer_data = Mock(spec=[])
-        service_data = Mock(spec=["order_id", "technology"])
+        service_data = Mock(spec=["order_id", "technology", "notes"])
 
-        mock_mobile_article = MockInternetArticle.return_value
+        mock_adsl_article = MockProvisionArticle.return_value
 
-        ADSLTicket(service_data, customer_data, None)._build_article()
+        ticket = ADSLTicket(service_data, customer_data, None)
+        ticket._build_article()
 
-        MockInternetArticle.assert_called_with(
-            service_data.technology, service_data.order_id, "adsl"
+        MockProvisionArticle.assert_called_once_with(
+            ticket._ticket_title(), service_data.notes
         )
-        mock_mobile_article.call.assert_called_once()
+        mock_adsl_article.call.assert_called_once()
 
     @patch("otrs_somconnexio.otrs_models.adsl_ticket.ADSLDynamicFields")
     def test_build_dynamic_fields(self, MockADSLDynamicFields):
@@ -97,6 +97,7 @@ class ADSLTicketTestCase(unittest.TestCase):
                 "shipment_zip",
                 "shipment_subdivision",
                 "notes",
+                "activation_notes",
                 "adsl_coverage",
                 "mm_fiber_coverage",
                 "asociatel_fiber_coverage",

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_fiber_dynamic_fields.py

@@ -652,7 +652,8 @@ class FiberDynamicFieldsTestCase(unittest.TestCase):
 
         dynamic_fields_dct = dynamic_fields_to_dct(dynamic_fields)
         self.assertEqual(
-            dynamic_fields_dct["consideracionsActivacio2"], "text text text"
+            dynamic_fields_dct["consideracionsActivacio"],
+            self.service_data.activation_notes,
         )
 
     def test_mobile_pack_contracts_field(self):

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_fiber_ticket.py

@@ -15,7 +15,7 @@ class FiberTicketTestCase(unittest.TestCase):
     @patch("otrs_somconnexio.otrs_models.provision_ticket.Ticket")
     def test_build_ticket(self, MockTicket):
         customer_data = Mock(spec=["id"])
-        service_data = Mock(spec=["order_id", "technology"])
+        service_data = Mock(spec=["order_id", "technology", "notes"])
 
         expected_ticket_arguments = {
             "Title": "Ticket#{} - Només fibra".format(service_data.order_id),
@@ -36,7 +36,7 @@ class FiberTicketTestCase(unittest.TestCase):
     @patch("otrs_somconnexio.otrs_models.provision_ticket.Ticket")
     def test_build_ticket_mixed(self, MockTicket):
         customer_data = Mock(spec=["id"])
-        service_data = Mock(spec=["order_id", "technology"])
+        service_data = Mock(spec=["order_id", "technology", "notes"])
         service_data.technology = "Mixta"
         expected_ticket_arguments = {
             "Title": "Ticket#{} - Fibra mixta".format(service_data.order_id),
@@ -55,16 +55,17 @@ class FiberTicketTestCase(unittest.TestCase):
         MockTicket.assert_called_with(expected_ticket_arguments)
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
-    def test_build_article(self, MockInternetArticle):
+    def test_build_article(self, MockProvisionArticle):
         customer_data = Mock(spec=[])
-        service_data = Mock(spec=["order_id", "technology"])
+        service_data = Mock(spec=["order_id", "technology", "notes"])
 
-        mock_mobile_article = MockInternetArticle.return_value
+        mock_mobile_article = MockProvisionArticle.return_value
 
-        FiberTicket(service_data, customer_data, self.responsible_data)._build_article()
+        ticket = FiberTicket(service_data, customer_data, self.responsible_data)
+        ticket._build_article()
 
-        MockInternetArticle.assert_called_with(
-            service_data.technology, service_data.order_id, "fiber"
+        MockProvisionArticle.assert_called_once_with(
+            ticket._ticket_title(), service_data.notes
         )
         mock_mobile_article.call.assert_called_once()
 
@@ -162,3 +163,12 @@ class FiberTicketTestCase(unittest.TestCase):
         self.assertEqual(
             ticket.otrs_configuration.service, "Banda Ancha::Fibra::Provisió Fibra"
         )
+
+    def test_files_to_attach_no_attachments(self):
+        customer_data = Mock()
+        service_data = Mock()
+
+        ticket = FiberTicket(service_data, customer_data, self.responsible_data)
+        attachments = ticket._files_to_attach()
+
+        self.assertFalse(attachments)

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_mobile_ticket.py

@@ -38,17 +38,18 @@ class MobileTicketTestCase(unittest.TestCase):
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
     def test_build_article(self, MockProvisionArticle):
-        mobile_data = Mock(spec=["order_id", "technology"])
+        mobile_data = Mock(spec=["order_id", "technology", "notes"])
         mobile_data.order_id = 123
 
         customer_data = Mock(spec=["order_id"])
 
         mock_mobile_article = MockProvisionArticle.return_value
 
-        MobileTicket(mobile_data, customer_data, self.responsible_data)._build_article()
+        ticket = MobileTicket(mobile_data, customer_data, self.responsible_data)
+        ticket._build_article()
 
-        MockProvisionArticle.assert_called_with(
-            mobile_data.technology, mobile_data.order_id, "mobile"
+        MockProvisionArticle.assert_called_once_with(
+            ticket._ticket_title(), mobile_data.notes
         )
         mock_mobile_article.call.assert_called_once()
 
@@ -138,3 +139,12 @@ class MobileTicketTestCase(unittest.TestCase):
 
         self.assertEqual(ticket.id, 123)
         self.assertEqual(ticket.number, "#123")
+
+    def test_files_to_attach_no_attachments(self):
+        customer_data = Mock()
+        service_data = Mock()
+
+        ticket = MobileTicket(service_data, customer_data, self.responsible_data)
+        attachments = ticket._files_to_attach()
+
+        self.assertFalse(attachments)

otrs_somconnexio-0.8.0/tests/otrs_models/test_provision_article.py

@@ -0,0 +1,32 @@
+# coding: utf-8
+import unittest
+from mock import patch
+
+from otrs_somconnexio.otrs_models.provision_article import ProvisionArticle
+
+
+class ProvisionArticleTestCase(unittest.TestCase):
+    @patch("otrs_somconnexio.otrs_models.abstract_article.Article")
+    def test_call_with_notes(self, MockArticle):
+        subject = "test subject"
+        notes = "test notes"
+        expected_article_arguments = {
+            "Subject": subject,
+            "Body": notes,
+            "ContentType": "text/plain; charset=utf8",
+            "IsVisibleForCustomer": "0",
+        }
+        ProvisionArticle(subject=subject, notes=notes).call()
+        MockArticle.assert_called_once_with(expected_article_arguments)
+
+    @patch("otrs_somconnexio.otrs_models.abstract_article.Article")
+    def test_call_without_notes(self, MockArticle):
+        subject = "test subject"
+        expected_article_arguments = {
+            "Subject": subject,
+            "Body": "",
+            "ContentType": "text/plain; charset=utf8",
+            "IsVisibleForCustomer": "1",
+        }
+        ProvisionArticle(subject=subject, notes="").call()
+        MockArticle.assert_called_once_with(expected_article_arguments)

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_router_4G_dynamic_fields.py

@@ -40,6 +40,7 @@ class Router4GDynamicFieldsTestCase(unittest.TestCase):
                 "previous_owner_name",
                 "previous_owner_surname",
                 "notes",
+                "activation_notes",
                 "adsl_coverage",
                 "mm_fiber_coverage",
                 "asociatel_fiber_coverage",
@@ -400,6 +401,22 @@ class Router4GDynamicFieldsTestCase(unittest.TestCase):
         dynamic_fields_dct = dynamic_fields_to_dct(dynamic_fields)
         self.assertEqual(dynamic_fields_dct["provinciaEnviament"], "Subdivision")
 
+    def test_activation_notes_field(self):
+        self.service_data.activation_notes = "text text text"
+
+        dynamic_fields = Router4GDynamicFields(
+            self.service_data,
+            self.customer_data,
+            self.router_4G_otrs_process_id,
+            self.router_4G_otrs_activity_id,
+        ).all()
+
+        dynamic_fields_dct = dynamic_fields_to_dct(dynamic_fields)
+        self.assertEqual(
+            dynamic_fields_dct["consideracionsActivacio"],
+            self.service_data.activation_notes,
+        )
+
     def test_owner_vat_field(self):
         self.service_data.previous_owner_vat = "12345M"
 

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_router_4G_ticket.py

@@ -15,7 +15,7 @@ class Router4GTicketTestCase(unittest.TestCase):
     @patch("otrs_somconnexio.otrs_models.provision_ticket.Ticket")
     def test_build_ticket(self, MockTicket):
         customer_data = Mock(spec=["id"])
-        service_data = Mock(spec=["order_id", "technology"])
+        service_data = Mock(spec=["order_id", "technology", "notes"])
 
         expected_ticket_arguments = {
             "Title": "Ticket#{} - Només 4G".format(service_data.order_id),
@@ -36,20 +36,19 @@ class Router4GTicketTestCase(unittest.TestCase):
         MockTicket.assert_called_with(expected_ticket_arguments)
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
-    def test_build_article(self, MockInternetArticle):
+    def test_build_article(self, MockProvisionArticle):
         customer_data = Mock(spec=[])
-        service_data = Mock(spec=["order_id", "technology"])
+        service_data = Mock(spec=["order_id", "technology", "notes"])
 
-        mock_internet_article = MockInternetArticle.return_value
+        mock_provision_article = MockProvisionArticle.return_value
 
-        Router4GTicket(
-            service_data, customer_data, self.responsible_data
-        )._build_article()
+        ticket = Router4GTicket(service_data, customer_data, self.responsible_data)
+        ticket._build_article()
 
-        MockInternetArticle.assert_called_with(
-            service_data.technology, service_data.order_id, "4G"
+        MockProvisionArticle.assert_called_once_with(
+            ticket._ticket_title(), service_data.notes
         )
-        mock_internet_article.call.assert_called_once()
+        mock_provision_article.call.assert_called_once()
 
     @patch("otrs_somconnexio.otrs_models.router_4G_ticket.Router4GDynamicFields")
     def test_build_dynamic_fields(self, MockRouter4GDynamicFields):
@@ -106,6 +105,7 @@ class Router4GTicketTestCase(unittest.TestCase):
                 "shipment_zip",
                 "shipment_subdivision",
                 "notes",
+                "activation_notes",
                 "adsl_coverage",
                 "mm_fiber_coverage",
                 "asociatel_fiber_coverage",
@@ -132,3 +132,12 @@ class Router4GTicketTestCase(unittest.TestCase):
 
         self.assertEqual(ticket.id, 123)
         self.assertEqual(ticket.number, "#123")
+
+    def test_files_to_attach_no_attachments(self):
+        customer_data = Mock()
+        service_data = Mock()
+
+        ticket = Router4GTicket(service_data, customer_data, self.responsible_data)
+        attachments = ticket._files_to_attach()
+
+        self.assertFalse(attachments)

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_switchboard_dynamic_fields.py

@@ -45,7 +45,8 @@ class SwitchboardDynamicFieldsTestCase(unittest.TestCase):
             shipment_subdivision=faker.state(),
             additional_products="A,B,C",
             confirmed_documentation=faker.boolean(),
-            notes=faker.word(),
+            notes=faker.text(),
+            activation_notes=faker.text(),
         )
 
         self.switchboard_otrs_process_id = faker.uuid4()
@@ -188,3 +189,9 @@ class SwitchboardDynamicFieldsTestCase(unittest.TestCase):
             self.dynamic_fields_dct["consideracionsGenerals"],
             self.service_data.notes,
         )
+
+    def test_activation_notes_field(self):
+        self.assertEqual(
+            self.dynamic_fields_dct["consideracionsActivacio"],
+            self.service_data.activation_notes,
+        )

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_switchboard_header_data.py

@@ -10,6 +10,8 @@ class SwitchboardHeaderDataTestCase(unittest.TestCase):
             order_id=123,
             contact_phone="666666661",
             email="test@test.com",
+            agent_data=[],
+            lead_line_data={},
             sales_team="residential",
             technology="switchboard",
             notes="Notes",

{otrs_somconnexio-0.7.2 → otrs_somconnexio-0.8.0}/tests/otrs_models/test_switchboard_header_dynamic_fields.py

@@ -114,6 +114,6 @@ class SwitchboardHeaderDynamicFieldsTestCase(unittest.TestCase):
 
     def test_notes_field(self):
         self.assertEqual(
-            self.dynamic_fields_dct["consideracionsActivacio3"],
+            self.dynamic_fields_dct["consideracionsActivacio"],
             self.service_data.notes,
         )