otrs-somconnexio 0.7.0__tar.gz → 0.7.1__tar.gz

{otrs_somconnexio-0.7.0 → otrs_somconnexio-0.7.1}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: otrs_somconnexio
-Version: 0.7.0
+Version: 0.7.1
 Summary: Python package for Somconnexio data syncing in OTRS
 Home-page: https://gitlab.com/coopdevs/otrs_somconnexio
 Author: Coopdevs

{otrs_somconnexio-0.7.0 → otrs_somconnexio-0.7.1}/otrs_somconnexio/otrs_models/provision_ticket.py

@@ -87,4 +87,7 @@ class ProvisionTicket:
         return self.customer_data.id
 
     def _responsible_email(self):
-        return self.responsible_data.email
+        if hasattr(self.responsible_data, "email"):
+            return self.responsible_data.email
+        else:
+            return False

{otrs_somconnexio-0.7.0 → otrs_somconnexio-0.7.1}/otrs_somconnexio/otrs_models/ticket_factory.py

@@ -14,7 +14,7 @@ class TicketFactory(object):
     the service of the EticomContract.
     """
 
-    def __init__(self, service_data, customer_data, responsible_data):
+    def __init__(self, service_data, customer_data, responsible_data=None):
         self.service_data = service_data
         self.customer_data = customer_data
         self.responsible_data = responsible_data

{otrs_somconnexio-0.7.0 → otrs_somconnexio-0.7.1}/otrs_somconnexio.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: otrs-somconnexio
-Version: 0.7.0
+Version: 0.7.1
 Summary: Python package for Somconnexio data syncing in OTRS
 Home-page: https://gitlab.com/coopdevs/otrs_somconnexio
 Author: Coopdevs

{otrs_somconnexio-0.7.0 → otrs_somconnexio-0.7.1}/setup.py

@@ -5,7 +5,7 @@ with open("README.md") as f:
     README = f.read()
 
 
-VERSION = "0.7.0"
+VERSION = "0.7.1"
 
 setup(
     name="otrs_somconnexio",

{otrs_somconnexio-0.7.0 → otrs_somconnexio-0.7.1}/tests/otrs_models/test_adsl_ticket.py

@@ -9,8 +9,6 @@ from otrs_somconnexio.otrs_models.configurations.provision.adsl_ticket import (
 
 
 class ADSLTicketTestCase(unittest.TestCase):
-    def setUp(self):
-        self.responsible_data = Mock(spec=["email"])
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.Ticket")
     def test_build_ticket(self, MockTicket):
@@ -26,10 +24,10 @@ class ADSLTicketTestCase(unittest.TestCase):
             "Priority": ADSLTicketConfiguration.priority,
             "CustomerUser": customer_data.id,
             "CustomerID": customer_data.id,
-            "Responsible": self.responsible_data.email,
+            "Responsible": False,
         }
 
-        ADSLTicket(service_data, customer_data, self.responsible_data)._build_ticket()
+        ADSLTicket(service_data, customer_data, None)._build_ticket()
         MockTicket.assert_called_with(expected_ticket_arguments)
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
@@ -39,7 +37,7 @@ class ADSLTicketTestCase(unittest.TestCase):
 
         mock_mobile_article = MockInternetArticle.return_value
 
-        ADSLTicket(service_data, customer_data, self.responsible_data)._build_article()
+        ADSLTicket(service_data, customer_data, None)._build_article()
 
         MockInternetArticle.assert_called_with(
             service_data.technology, service_data.order_id, "adsl", service_data.notes
@@ -53,9 +51,7 @@ class ADSLTicketTestCase(unittest.TestCase):
 
         mock_adsl_dynamic_fields = MockADSLDynamicFields.return_value
 
-        ADSLTicket(
-            service_data, customer_data, self.responsible_data
-        )._build_dynamic_fields()
+        ADSLTicket(service_data, customer_data, None)._build_dynamic_fields()
 
         MockADSLDynamicFields.assert_called_with(
             service_data,
@@ -115,14 +111,13 @@ class ADSLTicketTestCase(unittest.TestCase):
                 "confirmed_documentation",
             ]
         )
-        self.responsible_data = Mock(spec=["email"])
 
         mock_otrs_client = Mock(spec=["create_otrs_process_ticket"])
         mock_otrs_client.create_otrs_process_ticket.return_value.id = 123
         mock_otrs_client.create_otrs_process_ticket.return_value.number = "#123"
         MockOTRSClient.return_value = mock_otrs_client
 
-        ticket = ADSLTicket(service_data, customer_data, self.responsible_data)
+        ticket = ADSLTicket(service_data, customer_data, None)
         ticket.create()
 
         mock_otrs_client.create_otrs_process_ticket.assert_called_once()

{otrs_somconnexio-0.7.0 → otrs_somconnexio-0.7.1}/tests/otrs_models/test_ticket_factory.py

@@ -88,6 +88,18 @@ class TicketFactoryTestCase(unittest.TestCase):
             responsible_data=self.responsible_data,
         )
 
+    @patch("otrs_somconnexio.otrs_models.ticket_factory.FiberTicket")
+    def test_build_fibre_ticket_without_responsible(self, MockFiberTicket):
+        self.service_data.service_type = "fiber"
+
+        TicketFactory(self.service_data, self.customer_data).build()
+
+        MockFiberTicket.assert_called_once_with(
+            service_data=self.service_data,
+            customer_data=self.customer_data,
+            responsible_data=None,
+        )
+
     def test_build_service_not_allowed_error(self):
         self.service_data.service_type = ""