orbi-cli 0.7.6__tar.gz → 0.7.7__tar.gz

{orbi_cli-0.7.6/src/orbi_cli.egg-info → orbi_cli-0.7.7}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: orbi-cli
-Version: 0.7.6
+Version: 0.7.7
 Summary: Orbi — local AI development worker: claims GitHub Issues, runs Pi in isolated worktrees, and delivers PRs (GitHub Issues + labels are the only state store).
 Author: xqliu
 License-Expression: AGPL-3.0-only OR LicenseRef-Sustainable-Use-1.0

{orbi_cli-0.7.6 → orbi_cli-0.7.7}/pyproject.toml

@@ -44,7 +44,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "orbi-cli"
-version = "0.7.6"
+version = "0.7.7"
 description = "Orbi — local AI development worker: claims GitHub Issues, runs Pi in isolated worktrees, and delivers PRs (GitHub Issues + labels are the only state store)."
 readme = "README.md"
 requires-python = ">=3.14"

{orbi_cli-0.7.6 → orbi_cli-0.7.7}/src/orbi/__init__.py

@@ -18,4 +18,4 @@ the package would shadow the installed package for every process with
 the checkout root on sys.path. The direct-execution compatibility entry
 is `python3 -m orbi.cli` (development path only).
 """
-__version__ = "0.7.6"
+__version__ = "0.7.7"

{orbi_cli-0.7.6 → orbi_cli-0.7.7}/src/orbi/failure.py

@@ -257,6 +257,11 @@ PROVIDER_AUTH_WORDS = ("unauthorized", "forbidden", "api key")
 # (Issue #1465): its 401 shapes, its rejected-key sentences and
 # `unauthorized`; `forbidden` stays in `PROVIDER_AUTH_WORDS` for
 # `pi_process`'s own startup classifier, which is not this regex.
+# `api key` is the provider's own missing/rejected-key sentence ("No API
+# key found for provider …"), the marker `PROVIDER_AUTH_WORDS` still
+# lists; only `incorrect api key` survived #1762, so the plain sentence
+# regressed to `unclassified` (Issue #1768). An argv word cannot carry
+# it — the space keeps it out of a branch, label or check name.
 _CREDENTIAL_MISSING_RE = re.compile(
     r"bad credentials"
     r"|(?:http|status)\s+401\b"
@@ -265,7 +270,7 @@ _CREDENTIAL_MISSING_RE = re.compile(
     # relabelled as a credential problem (Issue #1465).
     r"|(?:^|[\s\"'(])401:"
     r"|authentication (?:failed|required|fails)"
-    r"|incorrect api key"
+    r"|api key"
     r"|unauthorized",
     re.IGNORECASE,
 )
@@ -289,9 +294,11 @@ _WORKFLOW_PERMISSION_RE = re.compile(
 # sentence differs by whether a delivery PR already exists.
 _WORKFLOW_PERMISSION_CAUSE_KEY = "failure.workflow_cause"
 # The remaining text-only transient markers: network-level failures and
-# GitHub's own server sentences. This set names no timeout — a GitHub
-# request reports its status, and a real transport timeout IS a
-# `subprocess.TimeoutExpired` (Issue #1760).
+# GitHub's own server sentences. This set names no timeout: a timeout is
+# decided by `subprocess.TimeoutExpired` or, for a source that gives no
+# status and no type, by `_TEXT_TIMEOUT_RE` below. A GitHub request that
+# received a response reports its status and never reads that wording; a
+# status-less gh transport failure is the one exception (Issue #1768).
 _GITHUB_TRANSIENT_RE = re.compile(
     r"http 5\d\d|http 429|rate limit|"
     r"something went wrong while executing your query|"
@@ -310,11 +317,23 @@ def _timeout_is_text_only(error: BaseException | None) -> bool:
     """Whether only the failure's text can say it was a timeout.
 
     `subprocess.TimeoutExpired` IS a timeout (decided by type) and a
-    GitHub request reports its status, so neither reads the wording; a
-    non-gh subprocess (Pi, `git fetch`/`git push`) has only its output.
+    GitHub request that received a response reports its status, so
+    neither reads the wording; a non-gh subprocess (Pi, `git
+    fetch`/`git push`) has only its output. gh's own transport can fail
+    before any response exists — a TLS handshake timeout exits 1 with no
+    status and no `TimeoutExpired` (cli/cli#1761) — so a structured gh
+    failure that reports NO status keeps the wording as its only signal
+    (Issue #1768). A response status, when present, still wins.
     """
     command = getattr(error, "cmd", None)
-    return isinstance(command, list) and command[:1] != ["gh"]
+    if not isinstance(command, list):
+        return False
+    if command[:1] != ["gh"]:
+        return True
+    return (
+        isinstance(error, gh_response.GitHubRequestFailed)
+        and error.status is None
+    )
 
 
 # reason_code -> (action_code, retry_safe). `retry_safe` is whether a

{orbi_cli-0.7.6 → orbi_cli-0.7.7}/src/orbi/release.py

@@ -717,12 +717,15 @@ def check_release_gates(repo: str, release_commit: str,
 
     A real `gh` failure (auth, rate limit, API error) propagates
     unchanged — a gate that cannot be checked is a failed gate. The one
-    exception is GitHub's HTTP 403 for the check-runs query (read from the
-    response status, never from the output text): it is reported as a
-    missing Checks:read credential permission so the blocked release is
-    actionable. A wait budget that runs out raises
-    `failure.ReleaseGateWaitTimeout`, which the blocked comment reports as
-    a human decision rather than a transient failure (Issue #1760).
+    exception is GitHub's HTTP 403 **with quota left** for the check-runs
+    query (read from the response status, never from the output text): it
+    is reported as a missing Checks:read credential permission so the
+    blocked release is actionable. A rate-limited 403 (no quota left) is
+    a transient GitHub failure and propagates unchanged, so it requeues
+    instead of asking for a credential repair (Issue #1768). A wait budget
+    that runs out raises `failure.ReleaseGateWaitTimeout`, which the
+    blocked comment reports as a human decision rather than a transient
+    failure (Issue #1760).
     """
     evidence: list[str] = []
     open_deliveries: set[int] = set()
@@ -774,8 +777,11 @@ def check_release_gates(repo: str, release_commit: str,
         except subprocess.CalledProcessError as error:
             # The response status — not the output text — tells a missing
             # Checks:read permission from every other read failure
-            # (Issue #1760).
-            if gh_response.status_of(error) == 403:
+            # (Issue #1760). A rate-limited 403 is GitHub's own limit, not
+            # a permission: it propagates unchanged and classifies as the
+            # transient failure that requeues (Issue #1768).
+            if (gh_response.status_of(error) == 403
+                    and not gh_response.transient(error)):
                 # Its own type: the status meaning travels on the type
                 # while the reader-facing sentence names the missing
                 # scope, so classification never reads the words

{orbi_cli-0.7.6 → orbi_cli-0.7.7/src/orbi_cli.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: orbi-cli
-Version: 0.7.6
+Version: 0.7.7
 Summary: Orbi — local AI development worker: claims GitHub Issues, runs Pi in isolated worktrees, and delivers PRs (GitHub Issues + labels are the only state store).
 Author: xqliu
 License-Expression: AGPL-3.0-only OR LicenseRef-Sustainable-Use-1.0

{orbi_cli-0.7.6 → orbi_cli-0.7.7}/tests/test_bootstrap_release.py

@@ -1057,6 +1057,22 @@ def test_check_release_gates_reports_missing_checks_permission(monkeypatch):
         release.check_release_gates("o/r", "abc123", 99)
 
 
+def test_rate_limited_check_runs_read_stays_transient(monkeypatch):
+    """A rate-limited 403 on the check-runs read is GitHub's rate limit, not
+    a missing permission: it propagates unwrapped and classifies as a
+    transient failure that requeues (Issue #1768). The status and the
+    `X-Ratelimit-Remaining: 0` header — not the output text — say so."""
+    make_gate_gh(monkeypatch, check_runs_failure=(403, 0))
+    monkeypatch.setattr(runner.time, "sleep", lambda _s: None)
+    with pytest.raises(Exception) as raised:
+        release.check_release_gates("o/r", "abc", 1)
+    assert not isinstance(raised.value, failure.GitHubPermissionDenied)
+    result = failure.classify(str(raised.value), error=raised.value)
+    assert result.reason_code == "github_transient"
+    assert result.action_code == "requeue"
+    assert result.retry_safe is True
+
+
 def test_check_release_gates_reraises_real_gh_failure(monkeypatch):
     make_gate_gh(monkeypatch, check_runs=None)
     with pytest.raises(subprocess.CalledProcessError):

{orbi_cli-0.7.6 → orbi_cli-0.7.7}/tests/test_failure.py

@@ -1271,3 +1271,43 @@ def test_release_failure_comment_classifies_a_gate_wait_timeout_as_blocked():
     assert record is not None
     assert record.reason_code == "human_decision_required"
     assert record.action_code == "decide"
+
+
+# --------------------------------------------------------------------------
+# Issue #1768: the three #1762 review regressions keep their classification
+# --------------------------------------------------------------------------
+
+def test_pi_no_api_key_found_is_a_credential_problem():
+    """The provider's own missing-key sentence is `credential_missing`: the
+    marker `PROVIDER_AUTH_WORDS` still lists was dropped from the text
+    classifier by #1762 and comes back here (Issue #1768).
+
+    The marker cannot be forged by a command's argv: it contains a space,
+    so no branch, label or check name can carry it (the #1760 concern)."""
+    result = failure.classify(
+        "Pi session failed: No API key found for provider deepseek")
+    assert result.reason_code == "credential_missing"
+    assert result.action_code == "check_credentials"
+    assert result.retry_safe is False
+
+
+def test_gh_tls_handshake_timeout_is_transient():
+    """gh's own transport can fail before any response exists: a TLS
+    handshake timeout exits 1 with no status and no `TimeoutExpired`
+    (cli/cli#1761), so the wording is the only signal there is
+    (Issue #1768). A response status, when present, still wins."""
+    from orbi import gh_response
+
+    error = gh_response.GitHubRequestFailed(
+        1, ["gh", "api", "repos/o/r/issues"],
+        stderr='Post "https://api.github.com/graphql": net/http: '
+               "TLS handshake timeout",
+        status=None,
+    )
+    result = failure.classify(
+        "gh api repos/o/r/issues failed: net/http: TLS handshake timeout",
+        error=error,
+    )
+    assert result.reason_code == "github_transient"
+    assert result.action_code == "requeue"
+    assert result.retry_safe is True