openscad-cpp-evaluator 1.37.0__tar.gz → 1.37.2__tar.gz

{openscad_cpp_evaluator-1.37.0 → openscad_cpp_evaluator-1.37.2}/CLAUDE.md

@@ -507,6 +507,30 @@ Requires the same toolchain as `openscad_cpp_parser`: CMake ≥3.24, a C++20 com
 (macOS: `brew install bison`, the submodule's own CMakeLists auto-detects Homebrew's), Flex.
 GoogleTest is fetched automatically via `FetchContent`.
 
+### Building offline (Flathub)
+
+Every dependency is a `FetchContent` download pinned to a tag, commit or checksummed tarball --
+**keep it that way**: an unpinned `master` makes two builds of one tag differ and rules out a
+build that lists its sources by checksum. A build with no network (Flathub's) hands each one in as
+a source directory and forbids downloading:
+
+```bash
+cmake -S . -B build -DFETCHCONTENT_FULLY_DISCONNECTED=ON -DBUILD_TESTING=OFF \
+  -DFETCHCONTENT_SOURCE_DIR_MANIFOLD=...      -DFETCHCONTENT_SOURCE_DIR_CLIPPER2=... \
+  -DFETCHCONTENT_SOURCE_DIR_BOOST_CONFIG=...  -DFETCHCONTENT_SOURCE_DIR_BOOST_POLYGON=... \
+  -DFETCHCONTENT_SOURCE_DIR_FREETYPE=...      -DFETCHCONTENT_SOURCE_DIR_HARFBUZZ=... \
+  -DFETCHCONTENT_SOURCE_DIR_STB=...           -DFETCHCONTENT_SOURCE_DIR_CPP_LINENOISE=... \
+  -DFETCHCONTENT_SOURCE_DIR_NLOHMANN_JSON=...
+```
+
+That is the whole list for a wheel build (tests off; GoogleTest is the only other download, and
+TBB only with `MANIFOLD_PAR`). Clipper2 is Manifold's own download, pinned in Manifold's
+`cmake/manifoldDeps.cmake`; nlohmann_json is the parser's. FetchContent skips `PATCH_COMMAND` for a
+supplied source, so the root `CMakeLists.txt` runs `cmake/patch_manifold.cmake` itself when
+`FETCHCONTENT_SOURCE_DIR_MANIFOLD` is set -- otherwise an offline build would quietly ship the heap
+overflow that patch fixes. Verified 2026-10-06: a fully disconnected configure + build produced the
+Python module and CLI, and rendered text (freetype + harfbuzz).
+
 Run a single test binary or filter:
 
 ```bash

{openscad_cpp_evaluator-1.37.0 → openscad_cpp_evaluator-1.37.2}/CMakeLists.txt

@@ -141,6 +141,16 @@ FetchContent_Declare(
   # CsgLeafNode::Compose -- see cmake/patch_manifold.cmake.
   PATCH_COMMAND ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_SOURCE_DIR}/cmake/patch_manifold.cmake
 )
+# FetchContent runs PATCH_COMMAND only for a source it downloads itself, so
+# a build handed Manifold's source (FETCHCONTENT_SOURCE_DIR_MANIFOLD, as an
+# offline Flatpak build does) would otherwise compile it unpatched. The
+# script is idempotent, so running it here too is safe.
+if(FETCHCONTENT_SOURCE_DIR_MANIFOLD)
+  execute_process(
+    COMMAND ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_SOURCE_DIR}/cmake/patch_manifold.cmake
+    WORKING_DIRECTORY ${FETCHCONTENT_SOURCE_DIR_MANIFOLD}
+    COMMAND_ERROR_IS_FATAL ANY)
+endif()
 FetchContent_MakeAvailable(manifold)
 
 # Boost.Polygon's Voronoi diagram builder, for roof()'s general (multi-
@@ -158,7 +168,13 @@ FetchContent_MakeAvailable(boost_config boost_polygon)
 # path, not add_subdirectory/MakeAvailable's target machinery. (It used to
 # supply stb_truetype.h for the font backend too; FreeType/HarfBuzz below
 # replaced that.)
-FetchContent_Declare(stb GIT_REPOSITORY https://github.com/nothings/stb.git GIT_TAG master GIT_SHALLOW TRUE)
+#
+# Pinned to a commit, as everything here is: stb has no releases, and
+# following master made two builds of the same tag differ, which also rules
+# out an offline (Flathub) build listing its sources by checksum.
+FetchContent_Declare(stb
+  URL https://github.com/nothings/stb/archive/2c980bb59875b0d32144a71867fbdebb2f77cd20.tar.gz
+  URL_HASH SHA256=9a955b1b49a4410088a2e0ee2a9c057c3c907d0c1d75454144cb980aca0ba515)
 FetchContent_MakeAvailable(stb)
 
 # FreeType (glyph outlines + face metrics) and HarfBuzz (shaping), the two
@@ -221,7 +237,10 @@ FetchContent_MakeAvailable(harfbuzz)
 # `CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR`, so FetchContent_
 # MakeAvailable here only exposes its `linenoise` INTERFACE target, matching
 # the existing MANIFOLD_TEST-override pattern's intent for free.
-FetchContent_Declare(cpp_linenoise GIT_REPOSITORY https://github.com/yhirose/cpp-linenoise.git GIT_TAG master GIT_SHALLOW TRUE)
+# Pinned to a commit for the same reason as stb: no releases.
+FetchContent_Declare(cpp_linenoise
+  URL https://github.com/yhirose/cpp-linenoise/archive/b0e8b88f53be0de26252180b1b959c6dd67ec4a9.tar.gz
+  URL_HASH SHA256=e3e67ea401a9e6e19c300f025c51faab197b83254c83e6bef8ef452ee184548b)
 FetchContent_MakeAvailable(cpp_linenoise)
 
 # Embeds the bundled default font's (resources/fonts/) raw bytes into a

{openscad_cpp_evaluator-1.37.0 → openscad_cpp_evaluator-1.37.2}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openscad_cpp_evaluator
-Version: 1.37.0
+Version: 1.37.2
 Summary: C++ OpenSCAD evaluator with Python bindings
 Author: NeuSCAD Contributors
 License-Expression: MIT

{openscad_cpp_evaluator-1.37.0 → openscad_cpp_evaluator-1.37.2}/external/openscad_cpp_parser/src/grammar/lexer.l

@@ -72,11 +72,19 @@ const std::unordered_map<std::string, KeywordFactory>& keywordTable() {
 %x INCFILE
 
 IDENT   \$?[_A-Za-z][A-Za-z0-9_]*
+UTF8CH  [\xc2-\xdf][\x80-\xbf]|[\xe0-\xef][\x80-\xbf]{2}|[\xf0-\xf4][\x80-\xbf]{3}
 NUMLIT  0[xX][0-9A-Fa-f]+|[0-9]+([.][0-9]*)?([eE][+-]?[0-9]+)?|[.][0-9]+([eE][+-]?[0-9]+)?
 
 %%
 
 [ \t\r\n]+              { /* skip whitespace */ }
+\xc2\xa0|\xef\xbb\xbf|\xa0 {
+    // Also whitespace, as in OpenSCAD's lexer.l: U+00A0 NO-BREAK SPACE
+    // (C2 A0), which Qt's editor silently turns into a space -- so a file
+    // holding one parsed in the editor and failed from the command line --
+    // U+FEFF (EF BB BF, a byte-order mark, anywhere in the file) and a bare
+    // A0, Latin-1's no-break space.
+}
 "//"[^\n]*               { /* skip line comment */ }
 "/*"([^*]|\*+[^*/])*\*+"/" { /* skip block comment */ }
 
@@ -162,9 +170,21 @@ NUMLIT  0[xX][0-9A-Fa-f]+|[0-9]+([.][0-9]*)?([eE][+-]?[0-9]+)?|[.][0-9]+([eE][+-
 ">" { return yy::parser::make_GTOP(driver.currentTokenLoc()); }
 "#" { return yy::parser::make_HASHOP(driver.currentTokenLoc()); }
 
-. {
+{UTF8CH} {
+    // A whole character, so the message stays valid UTF-8: quoting just its
+    // first byte made a message no consumer could decode.
     driver.reportError(driver.currentTokenLoc(), std::string("unexpected character '") + yytext + "'");
 }
+. {
+    // A byte that starts no valid UTF-8 character: named, not quoted.
+    std::string shown(yytext);
+    const auto byte = static_cast<unsigned char>(yytext[0]);
+    if (byte >= 0x80 || byte < 0x20) {
+        static const char hex[] = "0123456789ABCDEF";
+        shown = std::string("\\x") + hex[byte >> 4] + hex[byte & 0xF];
+    }
+    driver.reportError(driver.currentTokenLoc(), "unexpected character '" + shown + "'");
+}
 
 <<EOF>> { return yy::parser::make_YYEOF(driver.currentTokenLoc()); }
 

{openscad_cpp_evaluator-1.37.0 → openscad_cpp_evaluator-1.37.2}/external/openscad_cpp_parser/tests/test_lexical.cpp

@@ -473,3 +473,30 @@ TEST(LexicalStrings, BackslashNewlineStillAdvancesTheLineNumber) {
     EXPECT_EQ(ast[0]->position().line, 1);
     EXPECT_EQ(ast[1]->position().line, 3) << "the continuation consumed a line";
 }
+
+// As in OpenSCAD's lexer: U+00A0, U+FEFF and a bare Latin-1 A0 are whitespace.
+TEST(LexicalWhitespace, NoBreakSpaceByteOrderMarkAndLatin1A0) {
+    for (const char* ws : {"\xc2\xa0", "\xef\xbb\xbf", "\xa0"}) {
+        auto ast = parseSrc(std::string(ws) + "a" + ws + "=" + ws + "1;" + ws + "\nb = 2;");
+        ASSERT_EQ(ast.size(), 2u);
+        EXPECT_EQ(ast[1]->position().line, 2);
+    }
+}
+
+// The message quotes a whole character, and names a byte that starts none,
+// so it is always valid UTF-8.
+TEST(LexicalWhitespace, UnexpectedCharacterMessageIsValidUtf8) {
+    const std::pair<const char*, const char*> cases[] = {
+        {"a = 1 \xc3\xa9;", "unexpected character '\xc3\xa9'"},
+        {"a = 1 \xc2;", "unexpected character '\\xC2'"},
+        {"a = 1 \xff;", "unexpected character '\\xFF'"},
+    };
+    for (const auto& [src, want] : cases) {
+        try {
+            parseSrc(src);
+            FAIL() << "expected a parse error for " << src;
+        } catch (const ParseError& e) {
+            EXPECT_NE(std::string(e.what()).find(want), std::string::npos) << e.what();
+        }
+    }
+}

{openscad_cpp_evaluator-1.37.0 → openscad_cpp_evaluator-1.37.2}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "scikit_build_core.build"
 
 [project]
 name = "openscad_cpp_evaluator"
-version = "1.37.0"
+version = "1.37.2"
 description = "C++ OpenSCAD evaluator with Python bindings"
 readme = "README.md"
 requires-python = ">=3.12"

{openscad_cpp_evaluator-1.37.0 → openscad_cpp_evaluator-1.37.2}/tests/test_python_bindings.py

@@ -1259,6 +1259,24 @@ def test_a_cancel_signal_stops_a_silent_script_from_another_thread(tmp_path):
     assert time.perf_counter() - t0 < 5
 
 
+def test_no_break_space_in_code_is_whitespace_and_errors_stay_decodable(tmp_path):
+    """U+00A0 and U+FEFF in code are whitespace, as in OpenSCAD (BelfrySCAD#679),
+    and a parse error naming a non-ASCII character reaches Python as a
+    readable EvalError -- it was `nanobind::str(): conversion error`, since
+    the message quoted the character's first byte alone."""
+    import pytest
+    from openscad_cpp_evaluator import Evaluator, EvalError
+
+    ok = tmp_path / "nbsp.scad"
+    ok.write_bytes(b"\xef\xbb\xbfcube(1);\xc2\xa0\nsphere(\xc2\xa02);\n")
+    Evaluator(echo_fn=lambda _m: None).evaluate(str(ok), {})
+
+    bad = tmp_path / "bad.scad"
+    bad.write_bytes("cube(1) \u00e9;\n".encode("utf-8"))
+    with pytest.raises(EvalError, match="unexpected character '\u00e9'"):
+        Evaluator(echo_fn=lambda _m: None).evaluate(str(bad), {})
+
+
 def main():
     """`python tests/test_python_bindings.py` -- how cibuildwheel runs this
     file -- runs the whole file under pytest. It used to loop over the test_

{openscad_cpp_evaluator-1.37.0 → openscad_cpp_evaluator-1.37.2}/uv.lock

@@ -55,7 +55,7 @@ wheels = [
 
 [[package]]
 name = "openscad-cpp-evaluator"
-version = "1.37.0"
+version = "1.37.2"
 source = { editable = "." }
 dependencies = [
     { name = "numpy" },