openrewrite-migrate-python 0.14.0.dev20260904181306__tar.gz → 0.14.0.dev20260905202841__tar.gz

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openrewrite-migrate-python
-Version: 0.14.0.dev20260904181306
+Version: 0.14.0.dev20260905202841
 Summary: OpenRewrite recipes for migrating Python codebases to newer Python versions.
 Author-email: "Moderne Inc." <support@moderne.io>
 License: Moderne Proprietary

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/pyproject.toml

@@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta"
 [project]
 name = "openrewrite-migrate-python"
 description = "OpenRewrite recipes for migrating Python codebases to newer Python versions."
-version = "0.14.0.dev20260904181306"  # Updated dynamically during release
+version = "0.14.0.dev20260905202841"  # Updated dynamically during release
 authors = [{ name = "Moderne Inc.", email = "support@moderne.io" }]
 license = { text = "Moderne Proprietary" }
 readme = "README.md"

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/_markers.py

@@ -15,8 +15,13 @@ def mark_deprecated(tree: Any, message: str, detail: Optional[str] = None) -> An
     output but surfaces as a warning diagnostic in the tooling.
     """
     full_message = f"{message}: {detail}" if detail else message
-    warn_marker = MarkupWarn(random_id(), full_message)
     current_markers = tree.markers
-    new_markers_list = list(current_markers.markers) + [warn_marker]
-    new_markers = Markers(current_markers.id, new_markers_list)
-    return tree.replace(_markers=new_markers)
+    # A run re-applies the recipe to its own output until nothing changes, so a tree already
+    # carrying this warning has to come back unchanged for the run to converge.
+    if any(
+        isinstance(m, MarkupWarn) and m.message == full_message
+        for m in current_markers.markers
+    ):
+        return tree
+    new_markers_list = list(current_markers.markers) + [MarkupWarn(random_id(), full_message)]
+    return tree.replace(_markers=Markers(current_markers.id, new_markers_list))

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/array_deprecations.py

@@ -14,7 +14,7 @@ from rewrite import ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
-from rewrite.python.preconditions import uses_method
+from rewrite.python.preconditions import uses_import, uses_method
 from rewrite.python.visitor import PythonVisitor
 from rewrite.java.tree import Identifier, MethodInvocation
 
@@ -81,7 +81,10 @@ class ReplaceArrayTostring(Recipe):
                 new_name = method.name.replace(_simple_name="tobytes")
                 return method.replace(_name=new_name)
 
-        return Preconditions.check(uses_method("*..* tostring(..)"), Visitor())
+        return Preconditions.check(
+            Preconditions.and_(uses_import("array"), uses_method("*..* tostring(..)")),
+            Visitor(),
+        )
 
 
 @categorize(_Python314)
@@ -137,4 +140,7 @@ class ReplaceArrayFromstring(Recipe):
                 new_name = method.name.replace(_simple_name="frombytes")
                 return method.replace(_name=new_name)
 
-        return Preconditions.check(uses_method("*..* fromstring(..)"), Visitor())
+        return Preconditions.check(
+            Preconditions.and_(uses_import("array"), uses_method("*..* fromstring(..)")),
+            Visitor(),
+        )

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/cgi_parse_deprecations.py

@@ -136,7 +136,7 @@ class ReplaceCgiParseQs(Recipe):
                 new_padded = old_padded.replace(_element=new_select)
                 return method.padding.replace(_select=new_padded)
 
-        return Preconditions.check(uses_method("*..* parse_qs(..)"), Visitor())
+        return Preconditions.check(uses_method("cgi parse_qs(..)"), Visitor())
 
 
 @categorize(_Python38)
@@ -202,4 +202,4 @@ class ReplaceCgiParseQsl(Recipe):
                 new_padded = old_padded.replace(_element=new_select)
                 return method.padding.replace(_select=new_padded)
 
-        return Preconditions.check(uses_method("*..* parse_qsl(..)"), Visitor())
+        return Preconditions.check(uses_method("cgi parse_qsl(..)"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/configparser_deprecations.py

@@ -12,12 +12,15 @@ See: https://docs.python.org/3/library/configparser.html
 
 from typing import Any, Optional
 
-from rewrite import ExecutionContext, Recipe, TreeVisitor
+from rewrite import Cursor, ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
+from rewrite.python.preconditions import uses_import, uses_method
+from rewrite.python.scope_utils import LocalBindings
 from rewrite.python.visitor import PythonVisitor
-from rewrite.java.tree import Identifier, FieldAccess, MethodInvocation
+from rewrite.python.tree import CompilationUnit
+from rewrite.java.tree import Identifier, FieldAccess, J, MethodInvocation
 
 # Define category path: Python > Migrate > Python 3.12
 _Python312 = [
@@ -34,7 +37,18 @@ _Python313 = [
 ]
 
 
-def _is_configparser_attribute(field_access: FieldAccess, attr_name: str) -> bool:
+def _names_the_module(node: Any, locals_: LocalBindings, cursor: Cursor) -> bool:
+    """Whether ``node`` is the `configparser` module rather than something else holding the name."""
+    return (
+        isinstance(node, Identifier)
+        and node.simple_name == "configparser"
+        and not locals_.is_bound(cursor, "configparser")
+    )
+
+
+def _is_configparser_attribute(
+    field_access: FieldAccess, attr_name: str, locals_: LocalBindings, cursor: Cursor
+) -> bool:
     """
     Check if this is a configparser.attr_name access.
 
@@ -47,12 +61,7 @@ def _is_configparser_attribute(field_access: FieldAccess, attr_name: str) -> boo
     if field_access.name.simple_name != attr_name:
         return False
 
-    # Check if the target is 'configparser'
-    target = field_access.target
-    if isinstance(target, Identifier) and target.simple_name == "configparser":
-        return True
-
-    return False
+    return _names_the_module(field_access.target, locals_, cursor)
 
 
 def _replace_configparser_attribute(field_access: FieldAccess, new_name: str) -> FieldAccess:
@@ -99,7 +108,9 @@ def _rename_method(method: MethodInvocation, new_name: str) -> MethodInvocation:
     return method.replace(_name=new_identifier)
 
 
-def _is_configparser_constructor(method: MethodInvocation, class_name: str) -> bool:
+def _is_configparser_constructor(
+    method: MethodInvocation, class_name: str, locals_: LocalBindings, cursor: Cursor
+) -> bool:
     """
     Check if this is a configparser.ClassName() constructor call.
 
@@ -112,11 +123,7 @@ def _is_configparser_constructor(method: MethodInvocation, class_name: str) -> b
     if method.name.simple_name != class_name:
         return False
 
-    # Check if the select is 'configparser'
-    select = method.select
-    if select is None:
-        return False
-    if isinstance(select, Identifier) and select.simple_name == "configparser":
+    if _names_the_module(method.select, locals_, cursor):
         return True
 
     return False
@@ -158,13 +165,23 @@ class ReplaceConfigparserSafeConfigParser(Recipe):
 
     def editor(self) -> TreeVisitor[Any, ExecutionContext]:
         class Visitor(PythonVisitor[ExecutionContext]):
+            def __init__(self) -> None:
+                super().__init__()
+                self._locals = LocalBindings()
+
+            def visit_compilation_unit(self, cu: CompilationUnit, p: ExecutionContext) -> J:
+                self._locals = LocalBindings()
+                return super().visit_compilation_unit(cu, p)
+
             def visit_method_invocation(
                 self, method: MethodInvocation, p: ExecutionContext
             ) -> Optional[MethodInvocation]:
                 method = super().visit_method_invocation(method, p)
 
                 # Handle configparser.SafeConfigParser() constructor calls
-                if _is_configparser_constructor(method, "SafeConfigParser"):
+                if _is_configparser_constructor(
+                    method, "SafeConfigParser", self._locals, self.cursor
+                ):
                     return _rename_method(method, "ConfigParser")
 
                 return method
@@ -175,12 +192,14 @@ class ReplaceConfigparserSafeConfigParser(Recipe):
                 field_access = super().visit_field_access(field_access, p)
 
                 # Handle configparser.SafeConfigParser as a value (without calling)
-                if _is_configparser_attribute(field_access, "SafeConfigParser"):
+                if _is_configparser_attribute(
+                    field_access, "SafeConfigParser", self._locals, self.cursor
+                ):
                     return _replace_configparser_attribute(field_access, "ConfigParser")
 
                 return field_access
 
-        return Visitor()
+        return Preconditions.check(uses_import("configparser"), Visitor())
 
 
 @categorize(_Python313)
@@ -232,4 +251,4 @@ class ReplaceConfigparserReadfp(Recipe):
 
                 return method
 
-        return Visitor()
+        return Preconditions.check(uses_method("configparser.*ConfigParser readfp(..)"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/distutils_migrations.py

@@ -24,10 +24,13 @@ from rewrite.python.preconditions import uses_import
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
+from rewrite.python.import_utils import get_name_string, get_qualid_name
 from rewrite.python.visitor import PythonVisitor
 from rewrite.python.tree import MultiImport
 from ._markers import mark_deprecated
 
+_DEPRECATED_CLASSES = frozenset({"LooseVersion", "StrictVersion"})
+
 # Define category path: Python > Migrate > Python 3.12
 _Python312 = [
     *Python,
@@ -95,21 +98,18 @@ class ReplaceDistutilsVersion(Recipe):
             ) -> Optional[MultiImport]:
                 multi = super().visit_multi_import(multi, p)
 
-                # Check the 'from' part for 'from distutils.version import ...'
-                from_part = multi.from_
-                if from_part is not None:
-                    from_str = from_part.print_all() if hasattr(from_part, 'print_all') else str(from_part)
-                    if 'distutils.version' in from_str:
-                        # Check what's being imported
-                        imports_str = multi.print_all() if hasattr(multi, 'print_all') else str(multi)
-                        if 'LooseVersion' in imports_str or 'StrictVersion' in imports_str:
-                            return mark_deprecated(
-                                multi,
-                                "distutils.version is deprecated",
-                                "Migrate to packaging.version.Version (removed in Python 3.12). "
-                                "Note: packaging.version.Version is not a drop-in replacement."
-                            )
-
-                return multi
+                if multi.from_ is None or get_name_string(multi.from_) != "distutils.version":
+                    return multi
+                if not any(
+                    get_qualid_name(imp.qualid) in _DEPRECATED_CLASSES for imp in multi.names
+                ):
+                    return multi
+
+                return mark_deprecated(
+                    multi,
+                    "distutils.version is deprecated",
+                    "Migrate to packaging.version.Version (removed in Python 3.12). "
+                    "Note: packaging.version.Version is not a drop-in replacement."
+                )
 
         return Preconditions.check(uses_import("distutils"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/functools_deprecations.py

@@ -86,4 +86,4 @@ class FindFunctoolsCmpToKey(Recipe):
 
                 return method
 
-        return Preconditions.check(uses_method("*..* cmp_to_key(..)"), Visitor())
+        return Preconditions.check(uses_method("functools cmp_to_key(..)"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/html_parser_deprecations.py

@@ -103,4 +103,4 @@ class ReplaceHtmlParserUnescape(Recipe):
 
                 return method
 
-        return Preconditions.check(uses_method("*..* unescape(..)"), Visitor())
+        return Preconditions.check(uses_method("html.parser.HTMLParser unescape(..)"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/locale_getdefaultlocale_deprecation.py

@@ -89,4 +89,4 @@ class FindLocaleGetdefaultlocale(Recipe):
                     "locale.getpreferredencoding(False) instead."
                 )
 
-        return Preconditions.check(uses_method("*..* getdefaultlocale(..)"), Visitor())
+        return Preconditions.check(uses_method("locale getdefaultlocale(..)"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/os_deprecations.py

@@ -81,7 +81,7 @@ class FindOsPopen(Recipe):
 
                 return method
 
-        return Preconditions.check(uses_method("*..* popen(..)"), Visitor())
+        return Preconditions.check(uses_method("os popen(..)"), Visitor())
 
 
 @categorize(_Migrate)

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/pathlib_deprecations.py

@@ -13,11 +13,15 @@ from rewrite import ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
+from rewrite.python.method_matcher import MethodMatcher
 from rewrite.python.preconditions import uses_method
 from rewrite.python.visitor import PythonVisitor
-from rewrite.java.tree import Identifier, MethodInvocation
+from rewrite.java.tree import MethodInvocation
 from ._markers import mark_deprecated
 
+_LINK_TO = "pathlib.Path link_to(..)"
+_LINK_TO_MATCHER = MethodMatcher.create(_LINK_TO)
+
 # Define category path: Python > Migrate > Python 3.12
 _Python312 = [
     *Python,
@@ -61,7 +65,9 @@ class FindPathlibLinkTo(Recipe):
     def description(self) -> str:
         return (
             "Find usage of `Path.link_to()` which was deprecated in Python 3.10 "
-            "and removed in 3.12. Use `hardlink_to()` instead (note: argument order is reversed)."
+            "and removed in 3.12. Use `hardlink_to()` instead (note: argument order is reversed). "
+            "`link_to` is not a name reserved to `pathlib`, so this only reports calls whose "
+            "receiver resolves to a `Path`; a parse without type attribution reports nothing."
         )
 
     @property
@@ -75,9 +81,7 @@ class FindPathlibLinkTo(Recipe):
             ) -> Optional[MethodInvocation]:
                 method = super().visit_method_invocation(method, p)
 
-                if not isinstance(method.name, Identifier):
-                    return method
-                if method.name.simple_name != "link_to":
+                if not _LINK_TO_MATCHER.matches(method):
                     return method
 
                 return mark_deprecated(
@@ -86,4 +90,4 @@ class FindPathlibLinkTo(Recipe):
                     "Use hardlink_to() instead (note: argument order is reversed)."
                 )
 
-        return Preconditions.check(uses_method("*..* link_to(..)"), Visitor())
+        return Preconditions.check(uses_method(_LINK_TO), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/re_deprecations.py

@@ -118,7 +118,7 @@ class ReplaceReTemplate(Recipe):
 
         return Preconditions.check(
             Preconditions.or_(
-                uses_method("*..* template(..)"),
+                uses_method("re template(..)"),
                 uses_type("re"),
             ),
             Visitor(),

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/shutil_deprecations.py

@@ -13,11 +13,36 @@ from rewrite import ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
+from rewrite.python.method_matcher import MethodMatcher
 from rewrite.python.preconditions import uses_method
 from rewrite.python.visitor import PythonVisitor
-from rewrite.java.tree import Identifier, MethodInvocation
+from rewrite.java.tree import Identifier, Literal, MethodInvocation
+from rewrite.python.tree import NamedArgument
 from ._markers import mark_deprecated
 
+_RMTREE = "shutil rmtree(..)"
+_RMTREE_MATCHER = MethodMatcher.create(_RMTREE)
+
+
+def _supplies_onerror(method: MethodInvocation) -> bool:
+    """Whether the call passes a callback for `onerror`, by keyword or in its position.
+
+    `rmtree(path, ignore_errors, onerror)` puts `onerror` third, and an explicit `None`
+    there means the same as omitting it.
+    """
+    def is_none(expr: Any) -> bool:
+        return isinstance(expr, (Identifier, Literal)) and str(
+            getattr(expr, "simple_name", None) or getattr(expr, "value_source", None)
+        ) == "None"
+
+    for index, arg in enumerate(method.arguments):
+        if isinstance(arg, NamedArgument):
+            if isinstance(arg.name, Identifier) and arg.name.simple_name == "onerror":
+                return not is_none(arg.value)
+        elif index == 2:
+            return not is_none(arg)
+    return False
+
 # Define category path: Python > Migrate > Python 3.12
 _Python312 = [
     *Python,
@@ -75,23 +100,10 @@ class FindShutilRmtreeOnerror(Recipe):
             ) -> Optional[MethodInvocation]:
                 method = super().visit_method_invocation(method, p)
 
-                if not isinstance(method.name, Identifier):
-                    return method
-                if method.name.simple_name != "rmtree":
-                    return method
-
-                select = method.select
-                if not isinstance(select, Identifier):
-                    return method
-                if select.simple_name != "shutil":
+                if not _RMTREE_MATCHER.matches(method):
                     return method
 
-                # Check if any argument uses `onerror=` keyword
-                # We look at the string representation of arguments for keyword args
-                # Since we can't easily inspect keyword args at the AST level
-                # without type attribution, we mark all shutil.rmtree() calls
-                # as needing review if they have 3+ arguments (path, ignore_errors, onerror)
-                if len(method.arguments) >= 3:
+                if _supplies_onerror(method):
                     return mark_deprecated(
                         method,
                         "shutil.rmtree() `onerror` parameter was deprecated in Python 3.12. "
@@ -100,4 +112,4 @@ class FindShutilRmtreeOnerror(Recipe):
 
                 return method
 
-        return Preconditions.check(uses_method("*..* rmtree(..)"), Visitor())
+        return Preconditions.check(uses_method(_RMTREE), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/socket_deprecations.py

@@ -15,11 +15,15 @@ from rewrite import ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
+from rewrite.python.method_matcher import MethodMatcher
 from rewrite.python.preconditions import uses_method
 from rewrite.python.visitor import PythonVisitor
-from rewrite.java.tree import Identifier, MethodInvocation
+from rewrite.java.tree import MethodInvocation
 from ._markers import mark_deprecated
 
+_GETFQDN = "socket getfqdn(..)"
+_GETFQDN_MATCHER = MethodMatcher.create(_GETFQDN)
+
 # Define category path: Python > Migrate > Python 3.11
 _Python311 = [
     *Python,
@@ -67,15 +71,7 @@ class FindSocketGetFQDN(Recipe):
             ) -> Optional[MethodInvocation]:
                 method = super().visit_method_invocation(method, p)
 
-                if not isinstance(method.name, Identifier):
-                    return method
-                if method.name.simple_name != "getfqdn":
-                    return method
-
-                select = method.select
-                if not isinstance(select, Identifier):
-                    return method
-                if select.simple_name != "socket":
+                if not _GETFQDN_MATCHER.matches(method):
                     return method
 
                 return mark_deprecated(
@@ -84,4 +80,4 @@ class FindSocketGetFQDN(Recipe):
                     "Consider using socket.gethostname() instead."
                 )
 
-        return Preconditions.check(uses_method("*..* getfqdn(..)"), Visitor())
+        return Preconditions.check(uses_method(_GETFQDN), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/tarfile_deprecations.py

@@ -106,7 +106,7 @@ class ReplaceTarfileFilemode(Recipe):
 
         return Preconditions.check(
             Preconditions.or_(
-                uses_method("*..* filemode(..)"),
+                uses_method("tarfile filemode(..)"),
                 uses_type("tarfile"),
             ),
             Visitor(),

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/tempfile_deprecations.py

@@ -101,4 +101,4 @@ class FindTempfileMktemp(Recipe):
                     "Use tempfile.mkstemp() or NamedTemporaryFile() instead."
                 )
 
-        return Preconditions.check(uses_method("*..* mktemp(..)"), Visitor())
+        return Preconditions.check(uses_method("tempfile mktemp(..)"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/threading_deprecations.py

@@ -21,7 +21,7 @@ from rewrite import ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
-from rewrite.python.preconditions import uses_method
+from rewrite.python.preconditions import uses_import, uses_method
 from rewrite.python.visitor import PythonVisitor
 from rewrite.python.template import pattern, template, capture
 from rewrite.java.tree import Identifier, MethodInvocation
@@ -95,7 +95,7 @@ class ReplaceThreadingCurrentThread(Recipe):
                 new_name = method.name.replace(_simple_name="current_thread")
                 return method.replace(_name=new_name)
 
-        return Preconditions.check(uses_method("*..* currentThread(..)"), Visitor())
+        return Preconditions.check(uses_method("threading currentThread(..)"), Visitor())
 
 
 @categorize(_Python310)
@@ -157,7 +157,7 @@ class ReplaceThreadingActiveCount(Recipe):
                 new_name = method.name.replace(_simple_name="active_count")
                 return method.replace(_name=new_name)
 
-        return Preconditions.check(uses_method("*..* activeCount(..)"), Visitor())
+        return Preconditions.check(uses_method("threading activeCount(..)"), Visitor())
 
 
 @categorize(_Python310)
@@ -216,7 +216,10 @@ class ReplaceConditionNotifyAll(Recipe):
                 new_name = method.name.replace(_simple_name="notify_all")
                 return method.replace(_name=new_name)
 
-        return Preconditions.check(uses_method("*..* notifyAll(..)"), Visitor())
+        return Preconditions.check(
+            Preconditions.and_(uses_import("threading"), uses_method("*..* notifyAll(..)")),
+            Visitor(),
+        )
 
 
 # Pattern/template pairs for getter-to-property conversions
@@ -296,7 +299,10 @@ class ReplaceEventIsSet(Recipe):
                 new_name = method.name.replace(_simple_name="is_set")
                 return method.replace(_name=new_name)
 
-        return Preconditions.check(uses_method("*..* isSet(..)"), Visitor())
+        return Preconditions.check(
+            Preconditions.and_(uses_import("threading"), uses_method("*..* isSet(..)")),
+            Visitor(),
+        )
 
 
 @categorize(_Python310)

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/threading_is_alive_deprecation.py

@@ -13,7 +13,7 @@ from rewrite import ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
-from rewrite.python.preconditions import uses_method
+from rewrite.python.preconditions import uses_import, uses_method
 from rewrite.python.visitor import PythonVisitor
 from rewrite.java.tree import Identifier, MethodInvocation
 
@@ -84,4 +84,7 @@ class ReplaceThreadIsAlive(Recipe):
                 new_name = method.name.replace(_simple_name="is_alive")
                 return method.replace(_name=new_name)
 
-        return Preconditions.check(uses_method("*..* isAlive(..)"), Visitor())
+        return Preconditions.check(
+            Preconditions.and_(uses_import("threading"), uses_method("*..* isAlive(..)")),
+            Visitor(),
+        )

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/urllib_deprecations.py

@@ -23,6 +23,7 @@ from rewrite import ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
+from rewrite.python.method_matcher import MethodMatcher
 from rewrite.python.preconditions import uses_method
 from rewrite.python.visitor import PythonVisitor
 from rewrite.java.tree import Identifier, MethodInvocation, FieldAccess
@@ -139,6 +140,10 @@ class FindUrllibParseSplitFunctions(Recipe):
         )
 
 
+_TO_BYTES = "urllib.parse to_bytes(..)"
+_TO_BYTES_MATCHER = MethodMatcher.create(_TO_BYTES)
+
+
 @categorize(_Python314)
 class FindUrllibParseToBytes(Recipe):
     """
@@ -182,19 +187,13 @@ class FindUrllibParseToBytes(Recipe):
             ) -> Optional[MethodInvocation]:
                 method = super().visit_method_invocation(method, p)
 
-                if not isinstance(method.name, Identifier):
-                    return method
-                if method.name.simple_name != "to_bytes":
+                if not _TO_BYTES_MATCHER.matches(method):
                     return method
 
-                select = method.select
-                if isinstance(select, Identifier) and select.simple_name == "parse":
-                    return mark_deprecated(
-                        method,
-                        "urllib.parse.to_bytes() was removed in Python 3.14. "
-                        "Use str.encode() directly instead."
-                    )
-
-                return method
+                return mark_deprecated(
+                    method,
+                    "urllib.parse.to_bytes() was removed in Python 3.14. "
+                    "Use str.encode() directly instead."
+                )
 
-        return Preconditions.check(uses_method("*..* to_bytes(..)"), Visitor())
+        return Preconditions.check(uses_method(_TO_BYTES), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python/migrate/xml_deprecations.py

@@ -115,7 +115,7 @@ class ReplaceElementGetchildren(Recipe):
 
                 return result
 
-        return Preconditions.check(uses_method("*..* getchildren(..)"), Visitor())
+        return Preconditions.check(uses_method("xml.etree..* getchildren(..)"), Visitor())
 
 
 @categorize(_Python39)
@@ -185,4 +185,4 @@ class ReplaceElementGetiterator(Recipe):
                 new_name = method.name.replace(_simple_name="iter")
                 return method.replace(_name=new_name)
 
-        return Preconditions.check(uses_method("*..* getiterator(..)"), Visitor())
+        return Preconditions.check(uses_method("xml.etree..* getiterator(..)"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260904181306 → openrewrite_migrate_python-0.14.0.dev20260905202841}/src/openrewrite_migrate_python.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openrewrite-migrate-python
-Version: 0.14.0.dev20260904181306
+Version: 0.14.0.dev20260905202841
 Summary: OpenRewrite recipes for migrating Python codebases to newer Python versions.
 Author-email: "Moderne Inc." <support@moderne.io>
 License: Moderne Proprietary