openrewrite-migrate-python 0.14.0.dev20260902170552__tar.gz → 0.14.0.dev20260903170551__tar.gz

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openrewrite-migrate-python
-Version: 0.14.0.dev20260902170552
+Version: 0.14.0.dev20260903170551
 Summary: OpenRewrite recipes for migrating Python codebases to newer Python versions.
 Author-email: "Moderne Inc." <support@moderne.io>
 License: Moderne Proprietary

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/pyproject.toml

@@ -5,7 +5,7 @@ build-backend = "setuptools.build_meta"
 [project]
 name = "openrewrite-migrate-python"
 description = "OpenRewrite recipes for migrating Python codebases to newer Python versions."
-version = "0.14.0.dev20260902170552"  # Updated dynamically during release
+version = "0.14.0.dev20260903170551"  # Updated dynamically during release
 authors = [{ name = "Moderne Inc.", email = "support@moderne.io" }]
 license = { text = "Moderne Proprietary" }
 readme = "README.md"

openrewrite_migrate_python-0.14.0.dev20260903170551/src/openrewrite_migrate_python/migrate/_from_imports.py

@@ -0,0 +1,57 @@
+"""Resolving a receiver-less call to the module member it was imported from."""
+
+from typing import Dict, Optional
+
+from rewrite import Cursor
+from rewrite.java.tree import FieldAccess, Identifier, J, MethodInvocation
+from rewrite.python.import_utils import get_alias_name, get_name_string, get_qualid_name
+from rewrite.python.scope_utils import LocalBindings
+from rewrite.python.tree import CompilationUnit, MultiImport
+
+
+def _is_relative(from_: J) -> bool:
+    """Whether ``from_`` is dotted, which the LST spells as an empty leading identifier."""
+    while isinstance(from_, FieldAccess):
+        from_ = from_.target
+    return isinstance(from_, Identifier) and not from_.simple_name
+
+
+class FromImports:
+    """The members of ``module`` a file binds with ``from <module> import <member>``.
+
+    Under this form the call has no receiver, and for a symbol the typeshed in
+    use omits, no resolved declaring type either. The releases that removed
+    these APIs span many versions, so no declared version resolves them all —
+    attribution quality does not make this fallback redundant.
+    """
+
+    def __init__(self, module: str) -> None:
+        self._module = module
+        self._members: Dict[str, str] = {}
+        self._locals = LocalBindings()
+
+    def scan(self, cu: CompilationUnit) -> None:
+        """Record the file's bindings; call from ``visit_compilation_unit``.
+
+        Top-level ``from`` statements only, since a guarded import's fallback may
+        bind the name to a shim rather than the module's own member.
+        """
+        self._members = {}
+        self._locals = LocalBindings()
+        for stmt in cu.statements:
+            if not isinstance(stmt, MultiImport) or stmt.from_ is None:
+                continue
+            # `from .locale import x` binds a sibling module, which
+            # `get_name_string` renders indistinguishably from the stdlib one.
+            if _is_relative(stmt.from_) or get_name_string(stmt.from_) != self._module:
+                continue
+            for imp in stmt.names:
+                name = get_qualid_name(imp.qualid)
+                self._members.setdefault(get_alias_name(imp) or name, name)
+
+    def member_called(self, method: MethodInvocation, cursor: Cursor) -> Optional[str]:
+        """The ``module`` member a receiver-less ``method`` calls, if it calls one."""
+        if method.select is not None or not isinstance(method.name, Identifier):
+            return None
+        name = method.name.simple_name
+        return None if self._locals.is_bound(cursor, name) else self._members.get(name)

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/src/openrewrite_migrate_python/migrate/gettext_deprecations.py

@@ -18,9 +18,14 @@ from rewrite import ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
+from rewrite.python.add_import import AddImportOptions, maybe_add_import
 from rewrite.python.preconditions import uses_import
+from rewrite.python.remove_import import RemoveImportOptions, maybe_remove_import
+from rewrite.python.tree import CompilationUnit
 from rewrite.python.visitor import PythonVisitor
-from rewrite.java.tree import Identifier, MethodInvocation
+from rewrite.java.tree import Identifier, J, MethodInvocation
+
+from ._from_imports import FromImports
 
 # Define category path: Python > Migrate > Python 3.11
 _Python311 = [
@@ -105,6 +110,14 @@ class ReplaceGettextDeprecations(Recipe):
 
     def editor(self) -> TreeVisitor[Any, ExecutionContext]:
         class Visitor(PythonVisitor[ExecutionContext]):
+            def __init__(self) -> None:
+                super().__init__()
+                self._imports = FromImports("gettext")
+
+            def visit_compilation_unit(self, cu: CompilationUnit, p: ExecutionContext) -> J:
+                self._imports.scan(cu)
+                return super().visit_compilation_unit(cu, p)
+
             def visit_method_invocation(
                 self, method: MethodInvocation, p: ExecutionContext
             ) -> Optional[MethodInvocation]:
@@ -115,12 +128,21 @@ class ReplaceGettextDeprecations(Recipe):
 
                 method_name = method.name.simple_name
 
-                # Check if this is a deprecated gettext function
-                if method_name in GETTEXT_DEPRECATIONS:
+                # A receiver-less call belongs to the branch below, which moves
+                # the import as well as renaming the call.
+                if method.select is not None and method_name in GETTEXT_DEPRECATIONS:
                     if _is_gettext_method(method, method_name):
                         new_name = GETTEXT_DEPRECATIONS[method_name]
                         return _rename_method(method, new_name)
 
-                return method
+                # `from gettext import lgettext` names the function itself, so
+                # the import moves to the replacement along with the call.
+                member = self._imports.member_called(method, self.cursor)
+                new_name = GETTEXT_DEPRECATIONS.get(member) if member else None
+                if new_name is None:
+                    return method
+                maybe_add_import(self, AddImportOptions(module="gettext", name=new_name))
+                maybe_remove_import(self, RemoveImportOptions(module="gettext", name=member))
+                return _rename_method(method, new_name)
 
         return Preconditions.check(uses_import("gettext"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/src/openrewrite_migrate_python/migrate/locale_deprecations.py

@@ -14,12 +14,18 @@ from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
 from rewrite.markers import Markers
+from rewrite.python.add_import import AddImportOptions, maybe_add_import
+from rewrite.python.import_utils import get_name_string
 from rewrite.python.preconditions import uses_import
+from rewrite.python.remove_import import RemoveImportOptions, maybe_remove_import
+from rewrite.python.tree import CompilationUnit
 from rewrite.python.visitor import PythonVisitor
-from rewrite.java.tree import Identifier, MethodInvocation, Literal
+from rewrite.java.tree import Identifier, J, MethodInvocation, Literal
 from rewrite.java.support_types import JRightPadded, Space
 from rewrite.utils import random_id
 
+from ._from_imports import FromImports
+
 # Define category path: Python > Migrate > Python 3.11
 _Python311 = [
     *Python,
@@ -142,21 +148,40 @@ class ReplaceLocaleResetlocale(Recipe):
 
     def editor(self) -> TreeVisitor[Any, ExecutionContext]:
         class Visitor(PythonVisitor[ExecutionContext]):
+            def __init__(self) -> None:
+                super().__init__()
+                self._imports = FromImports("locale")
+
+            def visit_compilation_unit(self, cu: CompilationUnit, p: ExecutionContext) -> J:
+                self._imports.scan(cu)
+                return super().visit_compilation_unit(cu, p)
+
             def visit_method_invocation(
                 self, method: MethodInvocation, p: ExecutionContext
             ) -> Optional[MethodInvocation]:
                 method = super().visit_method_invocation(method, p)
 
-                if _is_locale_method(method, "resetlocale"):
-                    # Rename resetlocale -> setlocale
+                select = method.select
+                if select is not None and _is_locale_method(method, "resetlocale"):
                     method = _rename_method(method, "setlocale")
-                    # Set arguments to (locale.LC_ALL, "")
-                    method = _set_arguments(
+                    # LC_ALL is reached through the same name the call reached
+                    # the module by, which `import locale as loc` makes `loc`.
+                    return _set_arguments(
                         method,
-                        ("id", "locale.LC_ALL"),
-                        ("str", "")
+                        ("id", f"{get_name_string(select)}.LC_ALL"),
+                        ("str", ""),
                     )
-                    return method
+
+                if self._imports.member_called(method, self.cursor) == "resetlocale":
+                    # `setlocale` and `LC_ALL` are spelled unqualified, so each
+                    # needs an import of its own.
+                    for name in ("setlocale", "LC_ALL"):
+                        maybe_add_import(self, AddImportOptions(module="locale", name=name))
+                    maybe_remove_import(
+                        self, RemoveImportOptions(module="locale", name="resetlocale")
+                    )
+                    method = _rename_method(method, "setlocale")
+                    return _set_arguments(method, ("id", "LC_ALL"), ("str", ""))
 
                 return method
 

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/src/openrewrite_migrate_python/migrate/locale_getdefaultlocale_deprecation.py

@@ -13,9 +13,10 @@ from rewrite import ExecutionContext, Preconditions, Recipe, TreeVisitor
 from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
+from rewrite.python.method_matcher import MethodMatcher
 from rewrite.python.preconditions import uses_method
 from rewrite.python.visitor import PythonVisitor
-from rewrite.java.tree import Identifier, MethodInvocation
+from rewrite.java.tree import MethodInvocation
 from ._markers import mark_deprecated
 
 # Define category path: Python > Migrate > Python 3.11
@@ -25,6 +26,11 @@ _Python311 = [
     CategoryDescriptor(display_name="Python 3.11"),
 ]
 
+# One pattern covers `import locale`, `import locale as loc` and the from-import
+# form, since the owner resolves the same for each. Once the scheduled removal
+# lands this needs the `_from_imports` fallback the sibling recipes carry.
+_GETDEFAULTLOCALE = MethodMatcher.create("locale getdefaultlocale(..)")
+
 
 @categorize(_Python311)
 class FindLocaleGetdefaultlocale(Recipe):
@@ -73,15 +79,7 @@ class FindLocaleGetdefaultlocale(Recipe):
             ) -> Optional[MethodInvocation]:
                 method = super().visit_method_invocation(method, p)
 
-                if not isinstance(method.name, Identifier):
-                    return method
-                if method.name.simple_name != "getdefaultlocale":
-                    return method
-
-                select = method.select
-                if not isinstance(select, Identifier):
-                    return method
-                if select.simple_name != "locale":
+                if not _GETDEFAULTLOCALE.matches(method):
                     return method
 
                 return mark_deprecated(

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/src/openrewrite_migrate_python/migrate/platform_deprecations.py

@@ -14,15 +14,17 @@ from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
 from rewrite.markers import Markers
-from rewrite.python.preconditions import uses_method
+from rewrite.python.preconditions import uses_import
 from rewrite.python.visitor import PythonVisitor
 
 from rewrite.python.type_utils import is_of_class_type
 from rewrite.java.support_types import JLeftPadded, JRightPadded, Space
-from rewrite.java.tree import Identifier, Literal, MethodInvocation
-from rewrite.python.tree import NamedArgument
+from rewrite.java.tree import Identifier, J, MethodInvocation
+from rewrite.python.tree import CompilationUnit, NamedArgument
 from rewrite.utils import random_id
 
+from ._from_imports import FromImports
+
 # Define category path: Python > Migrate > Python 3.8
 _Python38 = [
     *Python,
@@ -31,6 +33,22 @@ _Python38 = [
 ]
 
 
+def _qualify(method: MethodInvocation, module: str) -> MethodInvocation:
+    """``method`` called through ``module`` as its receiver."""
+    select = Identifier(
+        _id=random_id(),
+        _prefix=Space.EMPTY,
+        _markers=Markers.EMPTY,
+        _annotations=[],
+        _simple_name=module,
+        _type=None,
+        _field_type=None,
+    )
+    return method.padding.replace(
+        _select=JRightPadded(select, Space.EMPTY, Markers.EMPTY)
+    )
+
+
 @categorize(_Python38)
 class ReplacePlatformPopen(Recipe):
     """
@@ -70,6 +88,14 @@ class ReplacePlatformPopen(Recipe):
 
     def editor(self) -> TreeVisitor[Any, ExecutionContext]:
         class Visitor(PythonVisitor[ExecutionContext]):
+            def __init__(self) -> None:
+                super().__init__()
+                self._imports = FromImports("platform")
+
+            def visit_compilation_unit(self, cu: CompilationUnit, p: ExecutionContext) -> J:
+                self._imports.scan(cu)
+                return super().visit_compilation_unit(cu, p)
+
             def visit_method_invocation(
                 self, method: MethodInvocation, p: ExecutionContext
             ) -> Optional[MethodInvocation]:
@@ -77,23 +103,26 @@ class ReplacePlatformPopen(Recipe):
 
                 if not isinstance(method.name, Identifier):
                     return method
-                if method.name.simple_name != "popen":
-                    return method
 
                 select = method.select
-                if not isinstance(select, Identifier):
+                if select is None:
+                    if self._imports.member_called(method, self.cursor) != "popen":
+                        return method
+                    method = _qualify(method, "subprocess")
+                elif (
+                    method.name.simple_name == "popen"
+                    and isinstance(select, Identifier)
+                    # Confirm the receiver resolves to the `platform` module (by
+                    # type, so an aliased import works and a same-named variable is
+                    # not rewritten into a destructive `subprocess.check_output`).
+                    and is_of_class_type(select.type, "platform")
+                ):
+                    new_select = select.replace(_simple_name="subprocess")
+                    old_padded_select = method.padding.select
+                    new_padded_select = old_padded_select.replace(_element=new_select)
+                    method = method.padding.replace(_select=new_padded_select)
+                else:
                     return method
-                # Confirm the receiver resolves to the `platform` module (by
-                # type, so an aliased import works and a same-named variable is
-                # not rewritten into a destructive `subprocess.check_output`).
-                if not is_of_class_type(select.type, "platform"):
-                    return method
-
-                # Replace platform with subprocess
-                new_select = select.replace(_simple_name="subprocess")
-                old_padded_select = method.padding.select
-                new_padded_select = old_padded_select.replace(_element=new_select)
-                method = method.padding.replace(_select=new_padded_select)
 
                 # Rename popen -> check_output
                 new_name = method.name.replace(_simple_name="check_output")
@@ -141,4 +170,4 @@ class ReplacePlatformPopen(Recipe):
 
                 return method
 
-        return Preconditions.check(uses_method("*..* popen(..)"), Visitor())
+        return Preconditions.check(uses_import("platform"), Visitor())

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/src/openrewrite_migrate_python/migrate/ssl_deprecations.py

@@ -15,8 +15,10 @@ from rewrite.category import CategoryDescriptor
 from rewrite.decorators import categorize
 from rewrite.marketplace import Python
 from rewrite.python.preconditions import uses_import
+from rewrite.python.tree import CompilationUnit
 from rewrite.python.visitor import PythonVisitor
-from rewrite.java.tree import Identifier, MethodInvocation
+from rewrite.java.tree import Identifier, J, MethodInvocation
+from ._from_imports import FromImports
 from ._markers import mark_deprecated
 
 # Define category path: Python > Migrate > Python 3.12
@@ -85,12 +87,21 @@ class FindSslMatchHostname(Recipe):
 
     def editor(self) -> TreeVisitor[Any, ExecutionContext]:
         class Visitor(PythonVisitor[ExecutionContext]):
+            def __init__(self) -> None:
+                super().__init__()
+                self._imports = FromImports("ssl")
+
+            def visit_compilation_unit(self, cu: CompilationUnit, p: ExecutionContext) -> J:
+                self._imports.scan(cu)
+                return super().visit_compilation_unit(cu, p)
+
             def visit_method_invocation(
                 self, method: MethodInvocation, p: ExecutionContext
             ) -> Optional[MethodInvocation]:
                 method = super().visit_method_invocation(method, p)
 
-                if _is_ssl_method(method, "match_hostname"):
+                if (_is_ssl_method(method, "match_hostname")
+                        or self._imports.member_called(method, self.cursor) == "match_hostname"):
                     return mark_deprecated(
                         method,
                         "ssl.match_hostname() is deprecated",

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/src/openrewrite_migrate_python.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: openrewrite-migrate-python
-Version: 0.14.0.dev20260902170552
+Version: 0.14.0.dev20260903170551
 Summary: OpenRewrite recipes for migrating Python codebases to newer Python versions.
 Author-email: "Moderne Inc." <support@moderne.io>
 License: Moderne Proprietary

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/src/openrewrite_migrate_python.egg-info/SOURCES.txt

@@ -22,6 +22,7 @@ src/openrewrite_migrate_python.egg-info/entry_points.txt
 src/openrewrite_migrate_python.egg-info/requires.txt
 src/openrewrite_migrate_python.egg-info/top_level.txt
 src/openrewrite_migrate_python/migrate/__init__.py
+src/openrewrite_migrate_python/migrate/_from_imports.py
 src/openrewrite_migrate_python/migrate/_import_hygiene.py
 src/openrewrite_migrate_python/migrate/_langchain_tables.py
 src/openrewrite_migrate_python/migrate/_markers.py

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/tests/test_gettext_deprecations.py

@@ -57,6 +57,22 @@ class TestReplaceGettextDeprecations:
             )
         )
 
+    def test_replaces_from_import_form(self):
+        """The call and the import both move off the removed name."""
+        spec = RecipeSpec(recipe=ReplaceGettextDeprecations())
+        spec.rewrite_run(
+            python(
+                """
+                from gettext import lgettext
+                msg = lgettext("Hello")
+                """,
+                """
+                from gettext import gettext
+                msg = gettext("Hello")
+                """,
+            )
+        )
+
     def test_no_change_when_already_correct(self):
         """Test that already-correct functions are not changed."""
         spec = RecipeSpec(recipe=ReplaceGettextDeprecations())

openrewrite_migrate_python-0.14.0.dev20260903170551/tests/test_locale_deprecations.py

@@ -0,0 +1,110 @@
+"""Tests for locale deprecation migration recipes."""
+
+from rewrite.test import RecipeSpec, python
+from openrewrite_migrate_python.migrate.locale_deprecations import (
+    ReplaceLocaleResetlocale,
+)
+
+class TestReplaceLocaleResetlocale:
+    """Tests for the ReplaceLocaleResetlocale recipe."""
+
+    def test_replaces_locale_resetlocale(self):
+        """Test that locale.resetlocale() is replaced with setlocale."""
+        spec = RecipeSpec(recipe=ReplaceLocaleResetlocale())
+        spec.rewrite_run(
+            python(
+                """
+                import locale
+                locale.resetlocale()
+                """,
+                """
+                import locale
+                locale.setlocale(locale.LC_ALL, "")
+                """,
+            )
+        )
+
+    def test_replacement_follows_the_import_form(self):
+        """`setlocale` and `LC_ALL` are spelled the way the file reaches `locale`."""
+        spec = RecipeSpec(recipe=ReplaceLocaleResetlocale())
+        spec.rewrite_run(
+            python(
+                """
+                from locale import resetlocale
+                resetlocale()
+                """,
+                """
+                from locale import LC_ALL, setlocale
+                setlocale(LC_ALL, "")
+                """,
+            )
+        )
+
+        spec.rewrite_run(
+            python(
+                """
+                import locale as loc
+                loc.resetlocale()
+                """,
+                """
+                import locale as loc
+                loc.setlocale(loc.LC_ALL, "")
+                """,
+            )
+        )
+
+    def test_no_change_when_setlocale(self):
+        """Test that locale.setlocale() is not marked."""
+        spec = RecipeSpec(recipe=ReplaceLocaleResetlocale())
+        spec.rewrite_run(
+            python(
+                """
+                import locale
+                locale.setlocale(locale.LC_ALL, "")
+                """
+            )
+        )
+
+    def test_no_change_when_locally_shadowed(self):
+        """A local `resetlocale` is not the module's, however the module is imported."""
+        spec = RecipeSpec(recipe=ReplaceLocaleResetlocale())
+        spec.rewrite_run(
+            python(
+                """
+                from locale import resetlocale
+
+                def reset():
+                    def resetlocale():
+                        pass
+                    resetlocale()
+                """
+            )
+        )
+
+    def test_no_change_on_a_relative_import(self):
+        """`from .locale import` binds a sibling module, not the stdlib one."""
+        spec = RecipeSpec(recipe=ReplaceLocaleResetlocale())
+        spec.rewrite_run(
+            python(
+                """
+                from .locale import resetlocale
+                resetlocale()
+                """
+            )
+        )
+
+    def test_no_change_when_different_module(self):
+        """Test that resetlocale on a different object is not marked."""
+        spec = RecipeSpec(recipe=ReplaceLocaleResetlocale())
+        spec.rewrite_run(
+            python(
+                """
+                class MyLocale:
+                    def resetlocale(self):
+                        pass
+
+                obj = MyLocale()
+                obj.resetlocale()
+                """
+            )
+        )

openrewrite_migrate_python-0.14.0.dev20260903170551/tests/test_locale_getdefaultlocale_deprecation.py

@@ -0,0 +1,45 @@
+"""Tests for locale.getdefaultlocale() deprecation recipe."""
+
+from rewrite.test import RecipeSpec, python
+
+from openrewrite_migrate_python.migrate.locale_getdefaultlocale_deprecation import (
+    FindLocaleGetdefaultlocale,
+)
+
+_MARKER = "/*~~(locale.getdefaultlocale() was deprecated in Python 3.11. Use locale.setlocale(), locale.getlocale(), or locale.getpreferredencoding(False) instead.)~~>*/"
+
+
+class TestFindLocaleGetdefaultlocale:
+    """Tests for FindLocaleGetdefaultlocale recipe."""
+
+    def test_finds_locale_getdefaultlocale(self):
+        spec = RecipeSpec(recipe=FindLocaleGetdefaultlocale())
+        spec.rewrite_run(
+            python(
+                "import locale\nlang, enc = locale.getdefaultlocale()",
+                f"import locale\nlang, enc = {_MARKER}locale.getdefaultlocale()",
+            )
+        )
+
+    def test_finds_from_import_and_aliased_forms(self):
+        """The import form does not decide whether the call is `locale`'s."""
+        spec = RecipeSpec(recipe=FindLocaleGetdefaultlocale())
+        spec.rewrite_run(
+            python(
+                "from locale import getdefaultlocale\nlang, enc = getdefaultlocale()",
+                f"from locale import getdefaultlocale\nlang, enc = {_MARKER}getdefaultlocale()",
+            )
+        )
+
+        spec.rewrite_run(
+            python(
+                "import locale as loc\nlang, enc = loc.getdefaultlocale()",
+                f"import locale as loc\nlang, enc = {_MARKER}loc.getdefaultlocale()",
+            )
+        )
+
+    def test_no_change_when_using_getlocale(self):
+        spec = RecipeSpec(recipe=FindLocaleGetdefaultlocale())
+        spec.rewrite_run(
+            python("import locale\nlang, enc = locale.getlocale()")
+        )

{openrewrite_migrate_python-0.14.0.dev20260902170552 → openrewrite_migrate_python-0.14.0.dev20260903170551}/tests/test_platform_deprecations.py

@@ -25,40 +25,60 @@ class TestReplacePlatformPopen:
             )
         )
 
-    def test_no_change_when_not_platform_popen(self):
+    def test_replaces_from_import_form(self):
+        """A receiver-less call bound by `from platform import popen` is rewritten."""
         spec = RecipeSpec(recipe=ReplacePlatformPopen())
         spec.rewrite_run(
             python(
                 """
-                import os
-                output = os.popen('ls').read()
+                from platform import popen
+                output = popen('ls')
+                """,
+                """
+                from platform import popen
+                output = subprocess.check_output('ls', shell=True)
+                """,
+            )
+        )
+
+    def test_no_change_on_another_platform_function(self):
+        """`popen` is the only function of the module this recipe rewrites."""
+        spec = RecipeSpec(recipe=ReplacePlatformPopen())
+        spec.rewrite_run(
+            python(
+                """
+                import platform
+                name = platform.system()
                 """
             )
         )
 
     def test_no_change_when_already_subprocess(self):
+        """Re-running over this recipe's own output leaves it alone."""
         spec = RecipeSpec(recipe=ReplacePlatformPopen())
         spec.rewrite_run(
             python(
                 """
-                import subprocess
+                import platform
                 output = subprocess.check_output('ls', shell=True)
                 """
             )
         )
 
-    def test_no_change_on_variable_named_platform(self):
-        """A local variable named `platform` that isn't the module is left untouched."""
+    def test_no_change_on_another_objects_popen(self):
+        """`popen` on something that isn't the module, in a file that imports it."""
         spec = RecipeSpec(recipe=ReplacePlatformPopen())
         spec.rewrite_run(
             python(
                 """
+                import platform
+
                 class Shell:
                     def popen(self, cmd):
                         return cmd
 
-                platform = Shell()
-                output = platform.popen('ls')
+                shell = Shell()
+                output = shell.popen('ls')
                 """
             )
         )